FailedChanges

Summary

  1. [Attributor] Remove unused verification flag We use the verify max iteration now which is more reliable.
  2. [Attributor][NFC] Expose call site traversal without QueryingAA
  3. [Attributor][FIX] Ensure h2s doesn't trigger on escaped pointers We do not yet perform h2s because we know something is free'ed but we do it because we know the pointer does not escape. Storing the pointer allows it to escape so we have to prevent that.
  4. [Attributor][FIX] Do not apply h2s for arbitrary mallocs H2S did apply to mallocs of non-constant sizes if the uses were OK. This is now forbidden through reording of the "good" and "bad" cases in the conditional.
  5. UnifiedTreeBuilder code cleaning. NFC.
  6. [Attributor][FIX] Add missing function declaration in test case
  7. Incremental.
  8. [Attributor][FIX] Avoid modifying naked/optnone functions The check for naked/optnone was insufficient for different reasons. We now check before we initialize an abstract attribute and we do it for all abstract attributes.
  9. NFC. Few cosmetic changes.
  10. [SROA] Reuse existing lifetime markers if possible Summary: If the underlying alloca did not change, we do not necessarily need new lifetime markers. This patch adds a check and reuses the old ones if possible. Reviewers: reames, ssarda, t.p.northover, hfinkel Subscribers: hiraditya, bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68900
  11. Changed clang-x86_64-debian-fast builder to use UnifiedTreeBuilder.
  12. Removed some default cmake options which doesn't seem worth being default from UnifiedTreeBuilder.addCmakeSteps.
  13. Do not set default cmake options in CmakeCommand.
Revision 374701 by jdoerfert:
[Attributor] Remove unused verification flag

We use the verify max iteration now which is more reliable.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
Revision 374700 by jdoerfert:
[Attributor][NFC] Expose call site traversal without QueryingAA
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.hllvm.src/include/llvm/Transforms/IPO/Attributor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
Revision 374699 by jdoerfert:
[Attributor][FIX] Ensure h2s doesn't trigger on escaped pointers

We do not yet perform h2s because we know something is free'ed but we do
it because we know the pointer does not escape. Storing the pointer
allows it to escape so we have to prevent that.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/heap_to_stack.llllvm.src/test/Transforms/FunctionAttrs/heap_to_stack.ll
Revision 374698 by jdoerfert:
[Attributor][FIX] Do not apply h2s for arbitrary mallocs

H2S did apply to mallocs of non-constant sizes if the uses were OK. This
is now forbidden through reording of the "good" and "bad" cases in the
conditional.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/heap_to_stack.llllvm.src/test/Transforms/FunctionAttrs/heap_to_stack.ll
Revision 374697 by gkistanova:
UnifiedTreeBuilder code cleaning. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/zorg/buildbot/builders/UnifiedTreeBuilder.pyzorg/zorg/buildbot/builders/UnifiedTreeBuilder.py
Revision 374696 by jdoerfert:
[Attributor][FIX] Add missing function declaration in test case
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/nonnull.llllvm.src/test/Transforms/FunctionAttrs/nonnull.ll
Revision 374695 by gkistanova:
Incremental.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/buildbot/osuosl/master/config/builders.pyzorg/buildbot/osuosl/master/config/builders.py
Revision 374694 by jdoerfert:
[Attributor][FIX] Avoid modifying naked/optnone functions

The check for naked/optnone was insufficient for different reasons. We
now check before we initialize an abstract attribute and we do it for
all abstract attributes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.hllvm.src/include/llvm/Transforms/IPO/Attributor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/nonnull.llllvm.src/test/Transforms/FunctionAttrs/nonnull.ll
Revision 374693 by gkistanova:
NFC. Few cosmetic changes.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/buildbot/osuosl/master/config/builders.pyzorg/buildbot/osuosl/master/config/builders.py
Revision 374692 by jdoerfert:
[SROA] Reuse existing lifetime markers if possible

Summary:
If the underlying alloca did not change, we do not necessarily need new
lifetime markers. This patch adds a check and reuses the old ones if
possible.

Reviewers: reames, ssarda, t.p.northover, hfinkel

Subscribers: hiraditya, bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68900
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/SROA.cppllvm.src/lib/Transforms/Scalar/SROA.cpp
The file was added/llvm/trunk/test/Transforms/SROA/reuse_lifetime_markers.llllvm.src/test/Transforms/SROA/reuse_lifetime_markers.ll
Revision 374691 by gkistanova:
Changed clang-x86_64-debian-fast builder to use UnifiedTreeBuilder.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/buildbot/osuosl/master/config/builders.pyzorg/buildbot/osuosl/master/config/builders.py
Revision 374690 by gkistanova:
Removed some default cmake options which doesn't seem worth being default from UnifiedTreeBuilder.addCmakeSteps.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/zorg/buildbot/builders/UnifiedTreeBuilder.pyzorg/zorg/buildbot/builders/UnifiedTreeBuilder.py
Revision 374689 by gkistanova:
Do not set default cmake options in CmakeCommand.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/zorg/buildbot/commands/CmakeCommand.pyzorg/zorg/buildbot/commands/CmakeCommand.py