FailedChanges

Summary

  1. [ThinLTO] Don't internalize during promotion Differential revision: https://reviews.llvm.org/D69107
  2. [LLVMDebugInfoPDB] - Use cantFail() instead of assert(). Currently injected-sources-native.test fails with "Expected<T> value was in success state. (Note: Expected<T> values in success mode must still be checked prior to being destroyed)" when llvm is compiled with LLVM_ENABLE_ABI_BREAKING_CHECKS in Release. The problem is that getStringForID returns Expected<StringRef> and Expected value must always be checked, even if it is in success state. Checking with assert only helps in Debug and is wrong. Differential revision: https://reviews.llvm.org/D69251
  3. [FrontendTests] Try again to make test not write an output file Setting the output stream to nulls seems to work.
  4. [builtins][test] Avoid unportable mmap call in clear_cache_test.c Within the last two weeks, the Builtins-*-sunos :: clear_cache_test.c started to FAIL on Solaris. Running it under truss shows mmap(0x00000000, 128, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 0, 0) Err#22 EINVAL _exit(1) While there are several possible reasons mmap can return EINVAL on Solaris, it turns out it's this one (from mmap(2)): MAP_ANON was specified, but the file descriptor was not -1. And indeed even the Linux mmap(2) documents this as unportable: MAP_ANONYMOUS The mapping is not backed by any file; its contents are initial‐ ized to zero. The fd argument is ignored; however, some imple‐ mentations require fd to be -1 if MAP_ANONYMOUS (or MAP_ANON) is specified, and portable applications should ensure this. The This patch follows this advise. Tested on x86_64-pc-linux-gnu, amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11. Differential Revision: https://reviews.llvm.org/D68455
  5. Revert "[FrontendTests] Don't actually run the full compiler, parsing is sufficient." This reverts commit 375488.
  6. [FrontendTests] Don't actually run the full compiler, parsing is sufficient.
  7. [clang-fuzzer] Update proto fuzzer example for r375453.
  8. [CMake] [WinMsvc] Look for includes and libs in ${MSVC_BASE}/atlmfc This is necessary if building with the DIA SDK enabled. Differential Revision: https://reviews.llvm.org/D69240
  9. [CMake] Allow overriding MSVC_DIA_SDK_DIR via CMake This eases using it in cross-msvc setups. Differential Revision: https://reviews.llvm.org/D69239
  10. gn build: Merge r375483
  11. Refactor DependencyScanningTool to its own file Summary: There's no behavior change - just moving DependencyScanningTool to its own file since this tool can be reused across both clang-scan-deps binary and an interface exposed as part of libClang APIs. Reviewers: arphaman, jkorous, Bigcheese, dexonsmith Subscribers: mgorny, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D69186
Revision 375493 by evgeny777:
[ThinLTO] Don't internalize during promotion

Differential revision: https://reviews.llvm.org/D69107
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/FunctionImport.cppllvm.src/lib/Transforms/IPO/FunctionImport.cpp
The file was added/llvm/trunk/test/ThinLTO/X86/not-internalized.llllvm.src/test/ThinLTO/X86/not-internalized.ll
The file was modified/llvm/trunk/test/ThinLTO/X86/weak_externals.llllvm.src/test/ThinLTO/X86/weak_externals.ll
Revision 375492 by grimar:
[LLVMDebugInfoPDB] - Use cantFail() instead of assert().

Currently injected-sources-native.test fails with "Expected<T>
value was in success state.
(Note: Expected<T> values in success mode must still be checked
prior to being destroyed)"
when llvm is compiled with LLVM_ENABLE_ABI_BREAKING_CHECKS in Release.

The problem is that getStringForID returns Expected<StringRef>
and Expected value must always be checked, even if it is in success state.
Checking with assert only helps in Debug and is wrong.

Differential revision: https://reviews.llvm.org/D69251
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/NativeEnumInjectedSources.cppllvm.src/lib/DebugInfo/PDB/Native/NativeEnumInjectedSources.cpp
Revision 375491 by d0k:
[FrontendTests] Try again to make test not write an output file

Setting the output stream to nulls seems to work.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Frontend/OutputStreamTest.cppclang.src/unittests/Frontend/OutputStreamTest.cpp
Revision 375490 by ro:
[builtins][test] Avoid unportable mmap call in clear_cache_test.c

Within the last two weeks, the Builtins-*-sunos :: clear_cache_test.c started to FAIL
on Solaris.  Running it under truss shows

  mmap(0x00000000, 128, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_PRIVATE|MAP_ANON, 0, 0) Err#22 EINVAL
  _exit(1)

While there are several possible reasons mmap can return EINVAL on Solaris, it turns
out it's this one (from mmap(2)):

  MAP_ANON  was  specified,  but the file descriptor was not
   -1.

And indeed even the Linux mmap(2) documents this as unportable:

  MAP_ANONYMOUS
          The mapping is not backed by any file; its contents are initial‐
          ized to zero.  The fd argument is ignored; however, some  imple‐
          mentations require fd to be -1 if MAP_ANONYMOUS (or MAP_ANON) is
          specified, and portable applications should  ensure  this.   The

This patch follows this advise.  Tested on x86_64-pc-linux-gnu, amd64-pc-solaris2.11
and sparcv9-sun-solaris2.11.

Differential Revision: https://reviews.llvm.org/D68455
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/builtins/Unit/clear_cache_test.ccompiler-rt.src/test/builtins/Unit/clear_cache_test.c
Revision 375489 by d0k:
Revert "[FrontendTests] Don't actually run the full compiler, parsing is sufficient."

This reverts commit 375488.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Frontend/OutputStreamTest.cppclang.src/unittests/Frontend/OutputStreamTest.cpp
Revision 375488 by d0k:
[FrontendTests] Don't actually run the full compiler, parsing is sufficient.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/unittests/Frontend/OutputStreamTest.cppclang.src/unittests/Frontend/OutputStreamTest.cpp
Revision 375487 by d0k:
[clang-fuzzer] Update proto fuzzer example for r375453.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/clang-fuzzer/ExampleClangProtoFuzzer.cppclang.src/tools/clang-fuzzer/ExampleClangProtoFuzzer.cpp
Revision 375486 by mstorsjo:
[CMake] [WinMsvc] Look for includes and libs in ${MSVC_BASE}/atlmfc

This is necessary if building with the DIA SDK enabled.

Differential Revision: https://reviews.llvm.org/D69240
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/platforms/WinMsvc.cmakellvm.src/cmake/platforms/WinMsvc.cmake
Revision 375485 by mstorsjo:
[CMake] Allow overriding MSVC_DIA_SDK_DIR via CMake

This eases using it in cross-msvc setups.

Differential Revision: https://reviews.llvm.org/D69239
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/config-ix.cmakellvm.src/cmake/config-ix.cmake
Revision 375484 by gnsyncbot:
gn build: Merge r375483
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang/lib/Tooling/DependencyScanning/BUILD.gnllvm.src/utils/gn/secondary/clang/lib/Tooling/DependencyScanning/BUILD.gn
Revision 375483 by kousikk:
Refactor DependencyScanningTool to its own file

Summary:
There's no behavior change - just moving DependencyScanningTool to its own file
since this tool can be reused across both clang-scan-deps binary and an interface
exposed as part of libClang APIs.

Reviewers: arphaman, jkorous, Bigcheese, dexonsmith

Subscribers: mgorny, cfe-commits

Tags: #clang

Differential Revision: https://reviews.llvm.org/D69186
Change TypePath in RepositoryPath in Workspace
The file was added/cfe/trunk/include/clang/Tooling/DependencyScanning/DependencyScanningTool.hclang.src/include/clang/Tooling/DependencyScanning/DependencyScanningTool.h
The file was modified/cfe/trunk/lib/Tooling/DependencyScanning/CMakeLists.txtclang.src/lib/Tooling/DependencyScanning/CMakeLists.txt
The file was added/cfe/trunk/lib/Tooling/DependencyScanning/DependencyScanningTool.cppclang.src/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp
The file was modified/cfe/trunk/tools/clang-scan-deps/ClangScanDeps.cppclang.src/tools/clang-scan-deps/ClangScanDeps.cpp