FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [yaml2obj] - Improve handling of the SHT_GROUP section. (details)
  2. [yaml2obj] - Make .symtab to be not mandatory section for SHT_REL[A] (details)
  3. [clangd] Add missing highlights for using decls. (details)
  4. [llvm-readobj] - Fix a comment in stack-sizes.test. NFC. (details)
  5. [obj2yaml] - Update a comment in a test case. NFC. (details)
  6. [clangd] NFC, use URI::resolve to simplify the code. (details)
  7. [ConstantFold] Push extractelement into getelementptr's operands (details)
  8. [BranchFolding] skip debug instr to avoid code change (details)
  9. Revert rG70f5aecedef9a6e347e425eb5b843bf797b95319 - "Reland (details)
  10. [LCSSA] Forget values we create LCSSA phis for (details)
  11. [clangd] Add a hidden tweak to dump symbol under the cursor. (details)
  12. Fix unused variable warning. NFCI. (details)
  13. Revert "[NFC] Replace a linked list in LiveDebugVariables pass with a (details)
  14. Fix a spelling mistake in a comment. NFC (details)
  15. Fix a spelling mistake in a comment. NFC (details)
  16. Fix some spelling mistakes in comments. NFC (details)
  17. [LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections (details)
  18. [IR] move helper function to replace undef constant (elements) with (details)
  19. [BitVector] Cast integer literals to BitWord [NFC] (details)
  20. [IR] move/change null-check to assert (details)
  21. [BitVector] Define BitWord as uintptr_t (details)
  22. [Hexagon] Handle remaining registers in getRegisterByName() (details)
  23. [InstCombine] add tests for icmp predicate canonicalization with vector (details)
  24. [bugpoint] Try to reduce passes after reducing everything. (details)
  25. [OPENMP]Fix PR43772: No warning in non-combined target regions. (details)
  26. [lldb][NFC] Make LLVMUserExpression::DoExecute return early (details)
  27. [clang] Add no_builtin attribute (details)
  28. [InstCombine] make icmp vector canonicalization safe for constant with (details)
  29. build: workaround stale caches (NFC) (details)
  30. build: make standalone builds work again (details)
  31. [X86] Pull out combineOrShiftToFunnelShift helper. NFCI. (details)
  32. Fix missing memcpy builtin on ppc64be See D68028 (details)
Commit 5b118a0471435751f39eeb92d56ecc3956053304 by grimar
[yaml2obj] - Improve handling of the SHT_GROUP section.
Currently, when we do not specify "Info" field in a YAML description for
SHT_GROUP section, yaml2obj reports an error:
"error: unknown symbol referenced: '' by YAML section '.group1'"
Also, we do not link it with a symbol table by default, though it is
what we do for AddrsigSection, HashSection, RelocationSection.
(http://www.sco.com/developers/gabi/latest/ch4.sheader.html#sh_link)
The patch fixes missings mentioned.
Differential revision: https://reviews.llvm.org/D69299
The file was modifiedllvm/test/tools/yaml2obj/elf-override-shname.yaml
The file was modifiedllvm/include/llvm/ObjectYAML/ELFYAML.h
The file was modifiedllvm/test/tools/yaml2obj/elf-comdat-broken-members.yaml
The file was modifiedllvm/lib/ObjectYAML/ELFYAML.cpp
The file was modifiedllvm/test/tools/yaml2obj/elf-comdat-broken.yaml
The file was modifiedllvm/test/tools/yaml2obj/elf-override-shoffset.yaml
The file was modifiedllvm/test/tools/yaml2obj/section-link.yaml
The file was modifiedllvm/test/tools/yaml2obj/elf-comdat-broken-info.yaml
The file was modifiedllvm/lib/ObjectYAML/ELFEmitter.cpp
The file was modifiedllvm/test/tools/yaml2obj/elf-override-shsize.yaml
The file was modifiedllvm/test/tools/yaml2obj/duplicate-section-names.test
Commit 3fe7f1dcf44ced0648fd0aef2b33056bbee37881 by grimar
[yaml2obj] - Make .symtab to be not mandatory section for SHT_REL[A]
section.
Before this change .symtab section was required for SHT_REL[A] section
declarations. yaml2obj automatically defined it in case when YAML
document did not have it.
With this change it is now possible to produce an object that has a
relocation section, but has no symbol table.
It simplifies the code and also it is inline with how we handle Link
fields for another special sections.
Differential revision: https://reviews.llvm.org/D69260
The file was modifiedllvm/test/Object/objdump-sectionheaders.test
The file was modifiedllvm/test/tools/llvm-readobj/all.test
The file was modifiedllvm/lib/ObjectYAML/ELFEmitter.cpp
The file was modifiedllvm/test/tools/obj2yaml/no-symbol-reloc.test
The file was modifiedllvm/test/tools/obj2yaml/elf-ppc64-relocations.yaml
The file was modifiedllvm/test/tools/llvm-objcopy/ELF/no-symbol-relocation.test
The file was modifiedllvm/test/tools/llvm-readobj/elf-reloc-negative-addend-no-sym.test
The file was modifiedllvm/test/Object/invalid.test
The file was modifiedllvm/test/tools/obj2yaml/relocation-unsupported-machine.yaml
Commit 94cd2f03032475e26767cf11eb81fefb00fc4dc0 by hokein.wu
[clangd] Add missing highlights for using decls.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69506
The file was modifiedclang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp
The file was modifiedclang-tools-extra/clangd/SemanticHighlighting.cpp
Commit 6c07a00aeb76faac06bcd821ee3b44df69e99a96 by grimar
[llvm-readobj] - Fix a comment in stack-sizes.test. NFC.
To address post commit review comment for D69167.
The file was modifiedllvm/test/tools/llvm-readobj/stack-sizes.test
Commit 12c9ffd108345f643df98dfa8653af1a4311ed86 by grimar
[obj2yaml] - Update a comment in a test case. NFC.
Addresses post-commit comments for D69160.
The file was modifiedllvm/test/tools/obj2yaml/invalid-section-name.yaml
Commit f821ab807debdc973066ea43ac23173ef08dc2f5 by hokein.wu
[clangd] NFC, use URI::resolve to simplify the code.
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
Commit dc63d6175aa5692db1670dc9ee7a1f304e752d87 by jay.foad
[ConstantFold] Push extractelement into getelementptr's operands
This fixes a minor oversight mentioned in the review of D69379: we
should push extractelement into the operands of getelementptr regardless
of whether that enables further folding.
The file was modifiedllvm/lib/IR/ConstantFold.cpp
Commit ec32dff0b075055b30140c543e9f2bef608adc14 by jeremy.morse
[BranchFolding] skip debug instr to avoid code change
Use the existing helper function in BranchFolding,
"countsAsInstruction", to skip over non-instructions. Otherwise debug
instructions can be identified as the last real instruction in a block,
leading to different codegen decisions when debug is enabled as
demonstrated by the test case.
Patch by: yechunliang (Chris Ye)!
Differential Revision: https://reviews.llvm.org/D66467
The file was modifiedllvm/lib/CodeGen/BranchFolding.cpp
The file was addedllvm/test/CodeGen/MIR/X86/branch-folder-with-debug.mir
Commit 2c496bb5309c972d59b11f05aee4782ddc087e71 by llvm-dev
Revert rG70f5aecedef9a6e347e425eb5b843bf797b95319 - "Reland
[AArch64][DebugInfo] Do not recompute CalleeSavedStackSize (Take 2)"
This fails on EXPENSIVE_CHECKS builds
The file was modifiedllvm/lib/CodeGen/TargetFrameLoweringImpl.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.cpp
The file was modifiedllvm/lib/Target/ARM/ARMFrameLowering.h
The file was modifiedllvm/test/DebugInfo/MIR/Mips/live-debug-values-reg-copy.mir
The file was removedllvm/test/CodeGen/AArch64/wrong-callee-save-size-after-livedebugvariables.mir
The file was modifiedllvm/lib/CodeGen/RegUsageInfoCollector.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64FrameLowering.cpp
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp
The file was modifiedllvm/include/llvm/CodeGen/TargetFrameLowering.h
The file was modifiedllvm/test/DebugInfo/MIR/X86/live-debug-values-reg-copy.mir
The file was modifiedllvm/lib/Target/AArch64/AArch64MachineFunctionInfo.h
Commit 596e4ab97a1637d2c7781aed20e3d62bcf07ef5d by florian_hahn
[LCSSA] Forget values we create LCSSA phis for
Summary: Currently we only forget the loop we added LCSSA phis for. But
SCEV expressions in other loops could also depend on the instruction we
added a PHI for and currently we do not invalidate those expressions.
This can happen when we use ScalarEvolution before converting a function
to LCSSA form. The SCEV expressions will refer to the non-LCSSA value.
If this SCEV expression is then used with the expander, we do not
preserve LCSSA form.
This patch properly forgets the values we created PHIs for. Those need
to be recomputed again. This patch fixes PR43458.
Currently SCEV::verify does not catch this mismatch and any test would
need to run multiple passes to trigger the error (e.g. -loop-reduce
-loop-unroll). I will also look into catching this kind of mismatch in
the verifier. Also, we currently forget the whole loop in LCSSA and I'll
check if we can be more surgical.
Reviewers: efriedma, sanjoy.google, reames
Reviewed By: efriedma
Subscribers: zzheng, hiraditya, javed.absar, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68194
The file was modifiedllvm/include/llvm/Transforms/Utils/LoopUtils.h
The file was modifiedllvm/lib/Transforms/Utils/LCSSA.cpp
The file was addedllvm/test/Transforms/LoopUnroll/unroll-preserve-scev-lcssa.ll
Commit 80b0cdde0ffc4ca59e99fed3dcb18412ff97568c by hokein.wu
[clangd] Add a hidden tweak to dump symbol under the cursor.
Summary: This provides a convenient way to see the SymbolID/USR of the
symbol, mainly for debugging purpose.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69517
The file was modifiedclang-tools-extra/clangd/refactor/tweaks/DumpAST.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TweakTests.cpp
Commit ec82eb2d024a3535bc9fa1dbe36764be017381b1 by llvm-dev
Fix unused variable warning. NFCI.
The file was modifiedllvm/lib/CodeGen/MachineInstr.cpp
Commit 67720e7bf7dfb28750706e3b27d16a1933af9ca0 by andrea.dibiagio
Revert "[NFC] Replace a linked list in LiveDebugVariables pass with a
DenseMap"
This reverts commit 8af5ada09319e5a021d57a1a03715b2fd022e415.
As Bjorn pointed out in D68816, the iteration over `UserVals` may not be
safe.
Reverting on behalf of Orlando.
The file was modifiedllvm/lib/CodeGen/LiveDebugVariables.cpp
Commit b1c4b4d5cbbea295ea7a9162e7cf16f0f41c935c by greg.bedwell
Fix a spelling mistake in a comment. NFC
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
Commit ed66be5c0cbe9a08313520fe506efa6f2245c3e1 by greg.bedwell
Fix a spelling mistake in a comment. NFC
(I'm currently trying to debug a strange error message I get when
pushing to github, despite the pushes being successful).
The file was modifiedllvm/lib/Target/X86/X86IndirectBranchTracking.cpp
Commit 1ba72a81cac8ac158986b83e8a87cdb97f4d1d3a by greg.bedwell
Fix some spelling mistakes in comments. NFC
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Commit 4394b5bee615a8c0d1703261204a5bd53d0d54ce by martin
[LLDB] [PECOFF] Use FindSectionByID to associate symbols to sections
The virtual container/header section caused the section list to be
offset by one, but by using FindSectionByID, the layout of the section
list shouldn't matter.
Differential Revision: https://reviews.llvm.org/D69366
The file was addedlldb/test/Shell/ObjectFile/PECOFF/symbol.yaml
The file was modifiedlldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp
Commit a1e8ad4f2fa79eabd484856a47a56c5c01259051 by spatel
[IR] move helper function to replace undef constant (elements) with
fixed constants
This is the NFC part of D69519. We had this functionality locally in
instcombine, but it can be used elsewhere, so hoisting it to Constant
class.
The file was modifiedllvm/lib/IR/Constants.cpp
The file was modifiedllvm/include/llvm/IR/Constant.h
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineShifts.cpp
Commit c6e04328814168c32764eb33736ee900b84996fe by llvm-dev
[BitVector] Cast integer literals to BitWord [NFC]
Associate the integer literals with BitWord, instead of the embedded UL
suffix.
Required for https://reviews.llvm.org/D69336.
Committed on behalf of @ekatz (Ehud Katz)
Differential Revision: https://reviews.llvm.org/D69357
The file was modifiedllvm/include/llvm/ADT/BitVector.h
Commit 09feea972d0f2c7b4f16719f3c70ac0795770330 by spatel
[IR] move/change null-check to assert
This should trigger a dereference before null-check warning, but I don't
see it when building with clang. In any case, the current and known
future users of this helper require non-null args, so I'm converting the
'if' to an assert.
The file was modifiedllvm/lib/IR/Constants.cpp
Commit ba6e2cb54446de272b817661add0483c0aec26d4 by llvm-dev
[BitVector] Define BitWord as uintptr_t
Define BitVector::BitWord as uintptr_t instead of unsigned long, as long
does not necessarily translates to a pointer size (especially on 64-bit
Visual Studio).
Committed on behalf of @ekatz (Ehud Katz)
Differential Revision: https://reviews.llvm.org/D69336
The file was modifiedllvm/include/llvm/ADT/BitVector.h
Commit 99f51960fdb5559d6720281bff9a63041452bf9a by kparzysz
[Hexagon] Handle remaining registers in getRegisterByName()
This fixes https://llvm.org/PR43829.
The file was modifiedllvm/lib/Target/Hexagon/HexagonISelLowering.cpp
The file was modifiedclang/lib/Basic/Targets/Hexagon.cpp
The file was addedllvm/test/CodeGen/Hexagon/reg-by-name.ll
Commit fe5292545f768592fa1d8881c3b8c1bca43f8dfb by spatel
[InstCombine] add tests for icmp predicate canonicalization with vector
types; NFC
Increase coverage for D69519.
The file was modifiedllvm/test/Transforms/InstCombine/icmp-vec.ll
Commit 43a46f1c09380f65bf18d39c16c5145bfe48af45 by flo
[bugpoint] Try to reduce passes after reducing everything.
In some cases, we fail to reduce the pass list earlier because of
complex pass dependencies, but we can reduce it after we simplified the
reproducer.
An example of that is PR43474, which can limit the crash to
-loop-interchange. Adding a test case would require at least 2
interacting Loop passes I think.
Reviewers: davide, reames, modocache
Reviewed By: reames
Differential Revision: https://reviews.llvm.org/D69236
The file was modifiedllvm/tools/bugpoint/CrashDebugger.cpp
Commit c09c0651a43b75044dc99e7c69acbcfaffd08aa2 by a.bataev
[OPENMP]Fix PR43772: No warning in non-combined target regions.
Need to analyze inner target regions in case of implicit mapping of the
data members when target region is created in one of the class member
functions.
The file was modifiedclang/test/OpenMP/distribute_simd_loop_messages.cpp
The file was modifiedclang/test/OpenMP/teams_distribute_codegen.cpp
The file was modifiedclang/lib/Sema/SemaOpenMP.cpp
The file was modifiedclang/test/OpenMP/teams_distribute_parallel_for_codegen.cpp
The file was modifiedclang/test/OpenMP/teams_distribute_simd_codegen.cpp
Commit 3011c7eb31c58526066841e84e7f0a6b9b733b57 by Raphael Isemann
[lldb][NFC] Make LLVMUserExpression::DoExecute return early
The giant if-else isn't conforming to LLVM code style.
The file was modifiedlldb/source/Expression/LLVMUserExpression.cpp
Commit 98f3151a7dded8838fafcb5f46e6c8358def96b8 by gchatelet
[clang] Add no_builtin attribute
Summary: This is a follow up on https://reviews.llvm.org/D61634 This
patch is simpler and only adds the no_builtin attribute.
Reviewers: tejohnson, courbet, theraven, t.p.northover, jdoerfert
Subscribers: mgrang, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D68028
This is a re-submit after it got reverted in
https://reviews.llvm.org/rGbd8791610948 since the breakage doesn't seem
to come from this patch.
The file was modifiedclang/include/clang/Basic/Attr.td
The file was modifiedclang/include/clang/AST/Decl.h
The file was modifiedclang/lib/CodeGen/CGCall.cpp
The file was modifiedclang/lib/Sema/SemaDecl.cpp
The file was modifiedclang/test/Misc/pragma-attribute-supported-attributes-list.test
The file was modifiedclang/lib/Sema/SemaDeclAttr.cpp
The file was addedclang/test/Sema/no-builtin.cpp
The file was modifiedclang/include/clang/Basic/AttrDocs.td
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was addedclang/test/CodeGen/no-builtin.cpp
Commit a22282be54b309ce7ab0e6bf8595893384971646 by spatel
[InstCombine] make icmp vector canonicalization safe for constant with
undef elements
This is a fix for: https://bugs.llvm.org/show_bug.cgi?id=43730
...and as shown there, we have existing test cases that show potential
miscompiles.
We could just bail out for vector constants that contain any undef
elements, or we can do as shown here: allow the transform, but replace
the undefs with a safe value.
For most of the tests shown, this results in a full splat constant (no
undefs) which is probably a win for further IR analysis because we
conservatively don't match undefs in most cases. Codegen can probably
recover these kinds of undef lanes via demanded elements analysis if
that's profitable.
Differential Revision: https://reviews.llvm.org/D69519
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
The file was modifiedllvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll
The file was modifiedllvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sle-to-icmp-sle.ll
The file was modifiedllvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-sge-to-icmp-sle.ll
The file was modifiedllvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll
The file was modifiedllvm/test/Transforms/InstCombine/reuse-constant-from-select-in-icmp.ll
The file was modifiedllvm/test/Transforms/InstCombine/icmp-vec.ll
The file was modifiedllvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll
Commit 55eec2ba96bd9c19ccb5d4d13cb8c88d4abcebc6 by Saleem Abdulrasool
build: workaround stale caches (NFC)
`LLVM_DEFAULT_TARGET_TRIPLE` is a cached variable, which means that it
may actually be unset.  Furthermore, in standalone builds, the variable
may be fully undefined.  Apply the regular expression over the empty
string in such a case.  This should improve the state of the green
dragon bot.
The file was modifiedlldb/tools/debugserver/source/MacOSX/CMakeLists.txt
Commit e56ba3743bcc344c51be9d919c32ec8f88ddef44 by Saleem Abdulrasool
build: make standalone builds work again
Apple's greendragon bot uses a standalone build of lldb which would fail
to build after a recent change to LLVM as it relied on LLVM setting
global flags for its build.  Attempt to repair the standalone build for
greendragon bot.
The file was modifiedlldb/CMakeLists.txt
Commit 501cf25839f37392b44441533ffd2005ebe46f98 by llvm-dev
[X86] Pull out combineOrShiftToFunnelShift helper. NFCI.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 5607ff12fad9a54728a3cda0eacaffee02e4b434 by gchatelet
Fix missing memcpy builtin on ppc64be See D68028
The file was modifiedclang/test/CodeGen/no-builtin.cpp
The file was modifiedclang/test/Sema/no-builtin.cpp