FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [ValueObjectDisplay] Generalize the description of an option. (details)
  2. Fix argument numbering confusion when diagnosing a non-viable (details)
  3. [globalisel][docs] Rewrite the IRTranslator documentation (details)
  4. [globalisel][docs] Fix warning treated as error (details)
  5. [DWARF5] Added support for deleted C++ special member functions. (details)
  6. Accept __is_same_as as a GCC-compatibility synonym for the proper trait (details)
  7. [Headers] Fix compatibility between arm_acle.h and intrin.h (details)
  8. [LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args (details)
  9. Replace std::function in PrintingPolicy with a callbacks object. (details)
  10. [LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap (details)
  11. Thread safety analysis: Peel away NoOp implicit casts in initializers (details)
  12. [lit] Small improvements in cl_arguments.py (details)
  13. [lldbsuite] Remove unused support files (details)
  14. [lldbsuite] Remove pre_kill_hook package (details)
  15. [lldbsuite] Remove the DumpFormatter (details)
  16. [lldbsuite] Remove unused test_event files (details)
  17. [MS] Fix constexpr data member pointer conversions (details)
  18. AMDGPU/GlobalISel: Legalize FDIV32 (details)
Commit d46c65592e3ac6a78c54514e4919d505c1f0c74a by ditaliano
[ValueObjectDisplay] Generalize the description of an option.
The file was modifiedlldb/source/Interpreter/OptionGroupValueObjectDisplay.cpp
Commit 52590319a225768404591e60803d0bfa84a8b5cd by richard
Fix argument numbering confusion when diagnosing a non-viable
operator().
This could lead to crashes if operator() is a variadic template, as we
could end up asking for an out-of-bounds argument.
The file was modifiedclang/lib/Sema/SemaOverload.cpp
The file was modifiedclang/test/SemaCXX/overload-member-call.cpp
Commit 6f665fc7868b4eca6fc644e0a99807fcbd831dfc by daniel_l_sanders
[globalisel][docs] Rewrite the IRTranslator documentation
Summary: I haven't refreshed the Function Calls section as I don't feel
I have sufficient knowledge of that area. It would be appreciated if
someone could review that section.
Note: I'm aware that pygments doesn't support 'mir' as used in one of
the code-block directives. This currently emits a warning and I decided
to keep it to enable finding them later. Maybe we can teach pygments to
support it.
Depends on D69456
Reviewers: volkan, aditya_nandakumar
Subscribers: rovka, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69457
The file was modifiedllvm/docs/GlobalISel/IRTranslator.rst
Commit 3260fa2cb09b78ad55e91d95a522d9dc455575f0 by daniel_l_sanders
[globalisel][docs] Fix warning treated as error
I had hoped that I could have some
```
.. code-block:: MIR
``` sections for MIR examples which causes a warning about pygments not
supporting it but we have warnings treated as errors
The file was modifiedllvm/docs/GlobalISel/IRTranslator.rst
Commit f919be336583349d883ba0dfdb3b2479a190b67c by Adrian Prantl
[DWARF5] Added support for deleted C++ special member functions.
This patch adds support for deleted C++ special member functions in
clang and llvm. Also added Defaulted member encodings for future support
for defaulted member functions.
Patch by Sourabh Singh Tomar!
Differential Revision: https://reviews.llvm.org/D69215
The file was modifiedllvm/include/llvm/BinaryFormat/Dwarf.h
The file was modifiedllvm/include/llvm/IR/DebugInfoMetadata.h
The file was addedllvm/test/DebugInfo/X86/DW_AT_deleted.ll
The file was modifiedllvm/include/llvm/IR/DebugInfoFlags.def
The file was addedclang/test/CodeGenCXX/debug-info-deleted.cpp
The file was modifiedllvm/lib/BinaryFormat/Dwarf.cpp
The file was modifiedllvm/docs/SourceLevelDebugging.rst
The file was modifiedllvm/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
Commit eb535d23418c7259cac85bdb13197263b2cee056 by richard
Accept __is_same_as as a GCC-compatibility synonym for the proper trait
name __is_same.
The file was modifiedclang/docs/LanguageExtensions.rst
The file was modifiedclang/test/SemaCXX/type-traits.cpp
The file was modifiedclang/test/Preprocessor/feature_tests.cpp
The file was modifiedclang/include/clang/Basic/TokenKinds.def
Commit 98286b569d01a461d75c9fd133cbf52c0c92e32a by efriedma
[Headers] Fix compatibility between arm_acle.h and intrin.h
Make sure they don't both define __nop.
Differential Revision: https://reviews.llvm.org/D69012
The file was modifiedclang/lib/Headers/arm_acle.h
The file was modifiedclang/test/Headers/arm-acle-header.c
Commit a69bbe02a2352271e8b14542073f177e24c499c1 by lawrence_danna
[LLDB][breakpoints] ArgInfo::count -> ArgInfo::max_positional_args
Summary: Move breakpoints from the old, bad ArgInfo::count to the new,
better ArgInfo::max_positional_args.   Soon ArgInfo::count will be no
more.
It looks like this functionality is already well tested by
`TestBreakpointCommandsFromPython.py`, so there's no need to write
additional tests for it.
Reviewers: labath, jingham, JDevlieghere
Reviewed By: labath
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D69468
The file was modifiedlldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPython.cpp
The file was modifiedlldb/include/lldb/Interpreter/ScriptInterpreter.h
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/breakpoint/breakpoint_command/TestBreakpointCommandsFromPython.py
The file was modifiedlldb/scripts/Python/python-wrapper.swig
The file was modifiedlldb/unittests/ScriptInterpreter/Python/PythonTestSuite.cpp
The file was modifiedlldb/source/Plugins/ScriptInterpreter/Python/ScriptInterpreterPythonImpl.h
Commit dbcb690fb78193e99452748c4af72eccb262e4e2 by richard
Replace std::function in PrintingPolicy with a callbacks object.
This makes PrintingPolicy significantly more lightweight and provides
groundwork for more printing customization hooks.
The file was modifiedclang/lib/AST/TypePrinter.cpp
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/lib/CodeGen/CGDebugInfo.h
The file was modifiedclang/include/clang/AST/PrettyPrinter.h
Commit 68142324290f2932df0e271747cdccc371d6dded by maskray
[LLD][ELF] Support --[no-]mmap-output-file with F_no_mmap
Summary: Add a flag `F_no_mmap` to `FileOutputBuffer` to support
`--[no-]mmap-output-file` in ELF LLD. LLD currently explicitly ignores
this flag for compatibility with GNU ld and gold.
We need this flag to speed up link time for large binaries in certain
scenarios. When we link some of our larger binaries we find that LLD
takes 50+ GB of memory, which causes memory pressure. The memory
pressure causes the VM to flush dirty pages of the output file to disk.
This is normally okay, since we should be flushing cold pages. However,
when using BtrFS with compression we need to write 128KB at a time when
we flush a page. If any page in that 128KB block is written again, then
it must be flushed a second time, and so on. Since LLD doesn't write
sequentially this causes write amplification. The same 128KB block will
end up being flushed multiple times, causing the linker to many times
more IO than necessary. We've observed 3-5x faster builds with
-no-mmap-output-file when we hit this scenario.
The bad scenario only applies to compressed filesystems, which group
together multiple pages into a single compressed block. I've tested
BtrFS, but the problem will be present for any compressed filesystem on
Linux, since it is caused by the VM.
Silently ignoring --no-mmap-output-file caused a silent regression when
we switched from gold to lld. We pass --no-mmap-output-file to fix this
edge case, but since lld silently ignored the flag we didn't realize it
wasn't being respected.
Benchmark building a 9 GB binary that exposes this edge case. I linked 3
times with --mmap-output-file and 3 times with --no-mmap-output-file and
took the average. The machine has 24 cores @ 2.4 GHz, 112 GB of RAM,
BtrFS mounted with -compress-force=zstd, and an 80% full disk.
| Mode    | Time  |
|---------|-------|
| mmap    | 894 s |
| no mmap | 126 s |
When compression is disabled, BtrFS performs just as well with and
without mmap on this benchmark.
I was unable to reproduce the regression with any binaries in
lld-speed-test.
Reviewed By: ruiu, MaskRay
Differential Revision: https://reviews.llvm.org/D69294
The file was modifiedlld/ELF/Driver.cpp
The file was modifiedllvm/lib/Support/FileOutputBuffer.cpp
The file was modifiedlld/ELF/Options.td
The file was modifiedllvm/unittests/Support/FileOutputBufferTest.cpp
The file was modifiedlld/ELF/Config.h
The file was modifiedlld/ELF/Writer.cpp
The file was modifiedlld/test/ELF/silent-ignore.test
The file was modifiedllvm/include/llvm/Support/FileOutputBuffer.h
Commit ae3159e497934ed1320d20aab8b32e3bf00a8f10 by aaronpuchert
Thread safety analysis: Peel away NoOp implicit casts in initializers
Summary: This happens when someone initializes a variable with
guaranteed copy elision and an added const qualifier. Fixes PR43826.
Reviewers: aaron.ballman, rsmith
Reviewed By: aaron.ballman
Differential Revision: https://reviews.llvm.org/D69533
The file was modifiedclang/test/SemaCXX/warn-thread-safety-analysis.cpp
The file was modifiedclang/lib/Analysis/ThreadSafety.cpp
Commit 2b0b84108320703efc7b300afbaaf1e688a6ea58 by julian.lettner
[lit] Small improvements in cl_arguments.py
*) `--max-tests` should be positive integer
*) `--max-time` should be positive integer
*) Remove unnecessary defaults for command line option parsing
The file was modifiedllvm/utils/lit/lit/main.py
The file was modifiedllvm/utils/lit/lit/cl_arguments.py
Commit 5cc2e0651fed7764f02421db1ba1719a10f17d25 by Jonas Devlieghere
[lldbsuite] Remove unused support files
To the best of my understanding these files or their content is nowhere
referenced.
The file was removedlldb/packages/Python/lldbsuite/support/sockutil.py
The file was removedlldb/packages/Python/lldbsuite/support/fs.py
Commit 8a82000e486afe472519d288f2206399ada95aca by Jonas Devlieghere
[lldbsuite] Remove pre_kill_hook package
This package was only used by dosep.py which has since been removed.
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/tests/test_darwin.py
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/tests/__init__.py
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/README.md
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/tests/test_linux.py
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/darwin.py
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/__init__.py
The file was removedlldb/packages/Python/lldbsuite/pre_kill_hook/linux.py
Commit 9f989559bad779f21fcb37fb544f9ecb96d6f567 by Jonas Devlieghere
[lldbsuite] Remove the DumpFormatter
This formatter is never used or referenced.
The file was removedlldb/packages/Python/lldbsuite/test_event/formatter/dump_formatter.py
Commit 44bac3ed5291031174ff62a2e841210ff8aedb66 by Jonas Devlieghere
[lldbsuite] Remove unused test_event files
These files don't appear to be used anywhere and the corresponding tests
are not run.
The file was removedlldb/packages/Python/lldbsuite/test_event/dotest_channels.py
The file was removedlldb/packages/Python/lldbsuite/test_event/test/resources/invalid_decorator/TestInvalidDecorator.py
The file was removedlldb/packages/Python/lldbsuite/test_event/formatter/pickled.py
The file was removedlldb/packages/Python/lldbsuite/test_event/test/src/TestCatchInvalidDecorator.py
The file was removedlldb/packages/Python/lldbsuite/test_event/test/src/event_collector.py
Commit 07ee46d613d7c1862878d7c7d1208a7b3e37459d by rnk
[MS] Fix constexpr data member pointer conversions
Constexpr data member conversions work by starting with the class that
originally introduced the field, and converting from there to the type
that the user desires. Before this change, Clang was using the
inheritance model from the final destination class type instead of the
model from the class that originally introduced the field. To fix this,
find the relevant FieldDecl and take its parent class instead of using
the member pointer type the user provided.
Indirect field decls require some special handling to find the parent
class.
Fixes PR43803
The file was modifiedclang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp
The file was modifiedclang/lib/CodeGen/MicrosoftCXXABI.cpp
Commit 2b88b344f24c07a5f4321cf65f01e03a90a73512 by Austin.Kerbow
AMDGPU/GlobalISel: Legalize FDIV32
Reviewers: arsenm
Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka,
dstuttard, tpr, t-tye, hiraditya, Petar.Avramovic, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69581
The file was modifiedllvm/include/llvm/CodeGen/GlobalISel/MachineIRBuilder.h
The file was modifiedllvm/test/CodeGen/AMDGPU/GlobalISel/legalize-fdiv.mir
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.h
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp