FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-zorg.git)

Summary

  1. [Python] Make dep.py compatible with Python 2 & 3. (details)
  2. [Python] Decode check_output result which is not a string in Python 3. (details)
  3. [Python] Pass the executable not all the remaining args (details)
  4. [Python] Add more decode('utf-8') to check_output. (details)
  5. Revert "Revert "Add six to the list of python dependencies."" (details)
  6. Add llvm-libc builders. (details)
  7. Remove the libc builders from the master for now. (details)
Commit 2f1f701bf9816893eab55c8a67ec7e172559659e by Jonas Devlieghere
[Python] Make dep.py compatible with Python 2 & 3.
The file was modifieddep/dep.py
Commit 00c16c2736e21c324d60275722cb89f3675b97aa by Jonas Devlieghere
[Python] Decode check_output result which is not a string in Python 3.
The file was modifieddep/dep.py
Commit c5faf01889988c2cb400aaf29bc759e3af67312b by Jonas Devlieghere
[Python] Pass the executable not all the remaining args
The file was modifieddep/dep.py
Commit 172fefe95bc2369b61c9e227253aebcd035e001e by Jonas Devlieghere
[Python] Add more decode('utf-8') to check_output.
The file was modifiedzorg/jenkins/build.py
The file was modifiedzorg/jenkins/monorepo_build.py
Commit 8d729f6fd0a638c65c3e64b4fd2c33f1af7af32f by Jonas Devlieghere
Revert "Revert "Add six to the list of python dependencies.""
This reverts commit 42519d0c1e217e049459543e11e20e2952a03708.
The file was modifiedzorg/jenkins/clang_build_dependencies.dep
The file was modifiedzorg/jenkins/monorepo_build.py
Commit 6d5695aea6295c0e3d97785e6ffa1a39a1288058 by sivachandra
Add llvm-libc builders.
Summary: A build factory for libc has been added. This factory makes use
of an annotated step runner.
Subscribers: MaskRay
Differential Revision: https://reviews.llvm.org/D69655
The file was addedzorg/buildbot/builders/libc/__init__.py
The file was modifiedbuildbot/osuosl/master/config/status.py
The file was modifiedbuildbot/osuosl/master/config/builders.py
The file was modifiedbuildbot/osuosl/master/master.cfg
The file was modifiedbuildbot/osuosl/master/config/slaves.py
The file was addedzorg/buildbot/builders/LibcBuilder.py
The file was addedzorg/buildbot/builders/libc/annotated_step_runner.py
Commit 12f995533f41f40c61bd41b9c880a7b2ac2ff42b by sivachandra
Remove the libc builders from the master for now.
Reviewers: gkistanova
Differential Revision: https://reviews.llvm.org/D69728
The file was modifiedbuildbot/osuosl/master/config/builders.py
The file was modifiedbuildbot/osuosl/master/config/slaves.py
The file was modifiedbuildbot/osuosl/master/config/status.py
The file was modifiedbuildbot/osuosl/master/master.cfg

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [clang-tidy] New checker performance-trivially-destructible-check (details)
  2. gn build: Merge d36a0333102 (details)
  3. [LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by (details)
  4. [libomptarget] Implement target_impl for amdgcn (details)
  5. [libTooling] Add Stencil constructor. (details)
  6. Revert "[AArch64][MachineOutliner] Return address signing for outlined (details)
  7. [InstCombine] regenerate test checks; NFC (details)
  8. llvm-config: emit the C++ standard flag into CXXFLAGS (details)
  9. Remove unnecessary unit test dependencies. (details)
  10. [Utils] Hide the default behavior change of D68819 under a flag (details)
  11. [X86] Fix -DBUILD_SHARED_LIBS=on builds after (details)
  12. Revert "[LLD][ThinLTO] Handle GUID collision in import global (details)
  13. Disable exceptions in libfuzzer's copy of libcxxabi. (details)
  14. [X86] isFNEG - use switch() instead of if-else tree. NFCI. (details)
  15. [Support] Use /proc/self/exe for GNU Hurd (details)
  16. Reland "[WebAssembly] Expand setcc of v2i64" (details)
  17. [LV] Move interleave_short_tc.ll into the X86 directory to hopefully (details)
  18. [WebAssembly] Add experimental SIMD dot product instruction (details)
  19. Add MemTagSanitizer documentation. (details)
  20. [dsymutil] Add DW_TAG_common_block to dieNeedsChildrenToBeMeaningful (details)
  21. [X86][AVX] Add support for and/or scalar bool reduction with AVX512 mask (details)
  22. Illustrate a redirector using the example of round function from math.h. (details)
  23. [MIPS GlobalISel] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off (details)
  24. [lit] Fix internal env calling env (details)
  25. [debuginfo-tests] Don't look for Python 3 if we already have it (details)
  26. Reapply [LLDB] [test] Use %clang_cl instead of build.py in a few tests (details)
Commit d36a0333102698a1398971d0717465322b1c5c2c by bikineev
[clang-tidy] New checker performance-trivially-destructible-check
Checks for types which can be made trivially-destructible by removing
out-of-line defaulted destructor declarations.
The check is motivated by the work on C++ garbage collector in Blink
(rendering engine for Chrome), which strives to minimize destructors and
improve runtime of sweeping phase.
In the entire chromium codebase the check hits over 2000 times.
Differential Revision: https://reviews.llvm.org/D69435
The file was modifiedclang-tools-extra/clang-tidy/utils/TypeTraits.h
The file was addedclang-tools-extra/test/clang-tidy/checkers/performance-trivially-destructible.cpp
The file was modifiedclang-tools-extra/clang-tidy/performance/CMakeLists.txt
The file was modifiedclang-tools-extra/clang-tidy/utils/Matchers.h
The file was modifiedclang-tools-extra/docs/clang-tidy/checks/list.rst
The file was addedclang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.cpp
The file was modifiedclang-tools-extra/docs/ReleaseNotes.rst
The file was modifiedclang-tools-extra/clang-tidy/performance/PerformanceTidyModule.cpp
The file was addedclang-tools-extra/docs/clang-tidy/checks/performance-trivially-destructible.rst
The file was addedclang-tools-extra/clang-tidy/performance/TriviallyDestructibleCheck.h
The file was modifiedclang-tools-extra/clang-tidy/utils/TypeTraits.cpp
Commit 449882b5442aa5138b5a89f56996ed990a3ead20 by llvmgnsyncbot
gn build: Merge d36a0333102
The file was modifiedllvm/utils/gn/secondary/clang-tools-extra/clang-tidy/performance/BUILD.gn
Commit 56c22931bdfafe8257e610cb9f29b9d64478f812 by bjorn.a.pettersson
[LDV][RAGreedy] Inform LiveDebugVariables about new VRegs added by
InlineSpiller
Summary: Make sure RAGreedy informs LiveDebugVariables about new VRegs
that is introduced at spill by InlineSpiller.
Consider this example
LDV: !"var" [48r;128r):0 Loc0=%2
48B   %2 = ...
...
128B  %7 = ADD %2, ...
If %2 is spilled the InlineSpiller will insert spill/reload instructions
and introduces some new vregs. So we get
48B   %4 = ...
56B   spill %4
...
120B  reload %5
128B  %3 = ADD %5, ...
In the past we did not inform LDV about this, and when reintroducing
DBG_VALUE instruction LDV still got information that "var" had the
location of the spilled register %2 for the interval [48r;128r). The
result was bad, since we mapped "var" to the spill slot even before the
spill happened:
%4 = ...
DBG_VALUE %spill.0, !"var"
spill %4 to %spill.0
...
reload %5
%3 = ADD %5, ...
This patch will inform LDV about the interval split introduced due to
spilling. So the location map in LDV will become
!"var" [48r;56r):1 [56r;120r):0 [120r;128r):2 Loc0=%2 Loc1=%4
Loc2=%5
And when inserting DBG_VALUE instructions we get
%4 = ...
DBG_VALUE %4, !"var"
spill %4 to %spill.0
DBG_VALUE %spill.0, !"var"
...
reload %5
DBG_VALUE %5, !"var"
%3 = ADD %5, ...
Fixes: https://bugs.llvm.org/show_bug.cgi?id=38899
Reviewers: jmorse, vsk, aprantl
Reviewed By: jmorse
Subscribers: dstenb, wuzish, MatzeB, qcolombet, nemanjai, hiraditya,
jsji, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69584
The file was addedllvm/test/CodeGen/PowerPC/pr38899-split-register-at-spill.mir
The file was modifiedllvm/lib/CodeGen/LiveDebugVariables.cpp
The file was modifiedllvm/lib/CodeGen/RegAllocGreedy.cpp
Commit 94c59ea8ddab9bd7dd241a56c67f98c90397b732 by jonchesterfield
[libomptarget] Implement target_impl for amdgcn
Summary:
[libomptarget] Implement target_impl for amdgcn
Smallest atomic addition for a new target. Implements enough of the
amdgcn specific code that some of the source files under nvptx/src could
be compiled, without modification, to run on amdgcn.
This foreshadows a work in progress patch to move said source out of
nvptx/src. Patch based on fork at
https://github.com/ROCm-Developer-Tools/llvm-project
Reviewers: ABataev, jdoerfert, grokos, ronlieb
Subscribers: jvesely, jfb, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D69718
The file was modifiedopenmp/libomptarget/deviceRTLs/interface.h
The file was addedopenmp/libomptarget/deviceRTLs/amdgcn/src/amdgcn_interface.h
The file was addedopenmp/libomptarget/deviceRTLs/amdgcn/src/target_impl.h
Commit 6e759daf2ea891fdd624d68690cdafdadcca11c9 by yitzhakm
[libTooling] Add Stencil constructor.
Summary: Adds a constructor that takes a vector with which to initialize
the `Parts` field and a corresponding free function that forwards to the
constructor. These definitions are needed to assist in transitioning
away from `Stencil` as a class to defining it as a type alias.
Reviewers: ilya-biryukov
Subscribers: cfe-commits, gribozavr
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69632
The file was modifiedclang/include/clang/Tooling/Transformer/Stencil.h
Commit a3f4745428814d71dec66f83ee3431abd962a3e8 by oliver.stannard
Revert "[AArch64][MachineOutliner] Return address signing for outlined
functions"
This is causing faults when an instruction which modifies SP is
outlined, causing the PAC and AUT instructions to not match.
This reverts commits 70caa1fc30c392974df3bccd9959765dae1779f6 and
55314d323738e4a8c1890b6a6e5064e7f4e0da1c.
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-regsave.mir
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-thunk.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-same-scope-diff-key.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-non-leaf.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-diff-scope-same-key.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-v8-3.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-same-scope-same-key-a.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-subtarget.ll
The file was removedllvm/test/CodeGen/AArch64/machine-outliner-retaddr-sign-same-scope-same-key-b.ll
Commit 21a518f7fb60bda07f0f3e9dce57f3a34e318610 by spatel
[InstCombine] regenerate test checks; NFC
Avoid subsequent test noise from improved CHECK-LABEL matching.
The file was modifiedllvm/test/Transforms/InstCombine/minmax-fp.ll
The file was modifiedllvm/test/Transforms/InstCombine/clamp-to-minmax.ll
The file was modifiedllvm/test/Transforms/InstCombine/minmax-fold.ll
Commit 7a25de6d2073f77ea1a0d8f4cd715bec55678941 by Saleem Abdulrasool
llvm-config: emit the C++ standard flag into CXXFLAGS
This recovers the now "missing" flag as this is controlled by CMake
rather than injected into the user defined flags list.  This is
primarily needed by LDC and other out-of-tree users which do not
correctly setup the C++ flags.
The file was modifiedllvm/tools/llvm-config/CMakeLists.txt
Commit 3a399c098782c8d251c136fafa06be97cbf5d99c by yamauchi
Remove unnecessary unit test dependencies.
Summary: This is to address comment on D69409.
Reviewers: davidxl, thakis
Subscribers: mgorny, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69568
The file was modifiedllvm/unittests/Target/X86/CMakeLists.txt
Commit e67f6477fd1ed29acbeddf8482c25d8db826912f by johannes
[Utils] Hide the default behavior change of D68819 under a flag
With D69701, the options used when running the script on a file will be
recorded and reused on a rerun. This allows us to hide new features
behind flags, starting with the "define" that was introduced in D68819.
The file was modifiedllvm/utils/UpdateTestChecks/common.py
The file was modifiedllvm/utils/update_test_checks.py
The file was modifiedllvm/utils/update_cc_test_checks.py
Commit add76dd3cbebc92f1862705d4432ba0f65db6286 by maskray
[X86] Fix -DBUILD_SHARED_LIBS=on builds after
D69568/llvmorg-10-init-8877-g3a399c09878
In -DBUILD_SHARED_LIBS=on builds, a component must specify its direct
dependencies to satisfy -Wl,-z,defs (added by
llvm/modules/HandleLLVMOptions.cmake).
Core is a direct dependency via transitive header inclusion:
  ld.lld: error: undefined symbol: llvm::LLVMContext::LLVMContext()
>>> referenced by MachineSizeOptsTest.cpp
>>>             
unittests/Target/X86/CMakeFiles/X86Tests.dir/MachineSizeOptsTest.cpp.o:(testing::internal::TestFactoryImpl<(anonymous
namespace)::MachineSizeOptsTest_Test_Test>::CreateTest())
MC is a direct dependency via transitive header inclusion:
  ld.lld: error: undefined symbol:
llvm::MCTargetOptions::MCTargetOptions()
>>> referenced by MachineSizeOptsTest.cpp
>>>             
unittests/Target/X86/CMakeFiles/X86Tests.dir/MachineSizeOptsTest.cpp.o:((anonymous
namespace)::MachineSizeOptsTest::SetUp())
The file was modifiedllvm/unittests/Target/X86/CMakeLists.txt
Commit d39d1a2f87aca3cfabe58ecfa5146879baa70096 by tejohnson
Revert "[LLD][ThinLTO] Handle GUID collision in import global
processing"
This reverts commit cc0b9647b76178bc3869bbfff80535ad86366472.
The commit is causing a failure in internal testing. Will recommit with
a fix later.
The file was modifiedllvm/lib/Transforms/Utils/FunctionImportUtils.cpp
The file was removedllvm/test/ThinLTO/X86/Inputs/guid_collision.ll
The file was removedllvm/test/ThinLTO/X86/guid_collision.ll
Commit 961d48df28ced5f9d50858b8dd931ec50b16b853 by eugenis
Disable exceptions in libfuzzer's copy of libcxxabi.
External project configuration for libcxxabi now has exceptions on by
default, but this is not needed for libfuzzer.
The file was modifiedcompiler-rt/lib/fuzzer/CMakeLists.txt
Commit ea27d82814213f292add33e8b41c42f1a81044d2 by llvm-dev
[X86] isFNEG - use switch() instead of if-else tree. NFCI.
In a future patch this will avoid some checks which don't need to be
done for some opcodes.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit f42671239ffd414c3056be9a04d8678860800148 by Kristina Brooks
[Support] Use /proc/self/exe for GNU Hurd
Use `/proc/self/exe` to get the current executable path on GNU Hurd.
Patch by sthibaul (Samuel Thibault)
Differential Revision: https://reviews.llvm.org/D69683
The file was modifiedllvm/lib/Support/Unix/Path.inc
Commit ecb7daf68f20baa5af72d7c4247ea4c2f5b788bf by tlively
Reland "[WebAssembly] Expand setcc of v2i64"
This reverts commit e5cae5692b5899631b5bfe5c23234deb5efda10c, which
reverted 11850a6305c5778b180243eb06aefe86762dd4ce. The original revert
was done because of breakage that was actually in a separate commit,
2ab1b8c1ec452fb743f6cc5051e75a01039cabfe, which was also reverted and
has since been fixed and relanded.
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyISelLowering.h
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-comparisons.ll
Commit 4592f70758531d6efe4e43d8122a8944f469d933 by craig.topper
[LV] Move interleave_short_tc.ll into the X86 directory to hopefully
make fix non-X86 bots.
The file was addedllvm/test/Transforms/LoopVectorize/X86/interleave_short_tc.ll
The file was removedllvm/test/Transforms/LoopVectorize/interleave_short_tc.ll
Commit 935c84c3c27de4544917216fc2b0557314802202 by tlively
[WebAssembly] Add experimental SIMD dot product instruction
Summary: This instruction is not merged to the spec proposal, but we
need it to be implemented in the toolchain to experiment with it. It is
available only on an opt-in basis through a clang builtin.
Defined in https://github.com/WebAssembly/simd/pull/127.
Depends on D69696.
Reviewers: aheejin
Subscribers: dschuff, sbc100, jgravelle-google, hiraditya, sunfish,
cfe-commits, llvm-commits
Tags: #clang, #llvm
Differential Revision: https://reviews.llvm.org/D69697
The file was modifiedclang/test/CodeGen/builtins-wasm.c
The file was modifiedllvm/test/CodeGen/WebAssembly/simd-intrinsics.ll
The file was modifiedllvm/lib/Target/WebAssembly/WebAssemblyInstrSIMD.td
The file was modifiedclang/lib/CodeGen/CGBuiltin.cpp
The file was modifiedclang/include/clang/Basic/BuiltinsWebAssembly.def
The file was modifiedllvm/test/MC/WebAssembly/simd-encodings.s
The file was modifiedllvm/include/llvm/IR/IntrinsicsWebAssembly.td
Commit 27c9abae656234813931e2717d60c69d988ecedc by eugenis
Add MemTagSanitizer documentation.
Summary: A lot of this is work in progress...
Reviewers: kcc, pcc
Subscribers: cryptoad, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69289
The file was addedllvm/docs/MemTagSanitizer.rst
The file was modifiedllvm/docs/Reference.rst
Commit 96bbf478b6718b13b19ac52fd790e64d4ed56fe9 by Jonas Devlieghere
[dsymutil] Add DW_TAG_common_block to dieNeedsChildrenToBeMeaningful
Ensure we walk the children of common blocks when deciding what DIEs to
keep. Otherwise we might incorrectly discard them leading to missing
variables in the linked debug info.
This also sorts the list of DW_TAGs alphabetically.
The file was modifiedllvm/tools/dsymutil/DwarfLinker.cpp
Commit 9b0dfdf5e1939b4129df75cc8e8d57fcf451b786 by llvm-dev
[X86][AVX] Add support for and/or scalar bool reduction with AVX512 mask
registers
combineBitcastvxi1 only handles bitcast->MOVMSK combines, with mask
registers we use BITCAST directly.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/movmsk-cmp.ll
Commit 9364107cf348c7d4a2d05b8906bda6ba384ce6f6 by sivachandra
Illustrate a redirector using the example of round function from math.h.
Setup demonstrated in this patch is only for ELF-ish platforms.
Also note:
1. Use of redirectors is a temporary scheme. They will be removed once
  LLVM-libc has implementations for the redirected functions. 2.
Redirectors are optional. One can choose to not include them in the
  LLVM-libc build for their platform. 3. Even with redirectors used, we
want to link to the system libc
  dynamically.
Reviewers: dlj, hfinkel, jakehehrlich, phosek, stanshebs, theraven,
alexshap
Subscribers: mgorny, libc-commits
Tags: #libc-project
Differential Revision: https://reviews.llvm.org/D69020
The file was addedlibc/src/math/round/round_redirector.cpp
The file was modifiedlibc/src/CMakeLists.txt
The file was addedlibc/src/math/round/CMakeLists.txt
The file was addedlibc/src/math/CMakeLists.txt
The file was addedlibc/src/math/round/round.h
The file was modifiedlibc/docs/build_system.rst
The file was modifiedlibc/cmake/modules/LLVMLibCRules.cmake
The file was addedlibc/src/math/round/round.cpp
The file was addedlibc/docs/redirectors.rst
The file was addedlibc/docs/redirectors_schematic.svg
The file was modifiedlibc/lib/CMakeLists.txt
Commit 45ee0d6de6f82833de1320de35366669b2b1cdf2 by maskray
[MIPS GlobalISel] Fix -Wunused-variable in -DLLVM_ENABLE_ASSERTIONS=off
builds after D69663
The file was modifiedllvm/lib/Target/Mips/MipsInstructionSelector.cpp
Commit cb2c4bb0e0da675bb0ab3a3fce4cbb014d83f675 by jdenny.ornl
[lit] Fix internal env calling env
Without this patch, when using lit's internal shell, if `env` on a lit
RUN line calls `env`, lit accidentally searches for the latter as an
external executable.  What's worse is that works fine when a developer
is testing on a platform where `env` is available and behaves as
expected, but it then breaks on other platforms.
`env` calling `env` can make sense if one such `env` is within a lit
substitution, as in D65156 and D65121.  This patch ensures that lit
executes both as internal commands.
Reviewed By: probinson, mgorny, rnk
Differential Revision: https://reviews.llvm.org/D65697
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-args-nested-none.txt
The file was addedllvm/utils/lit/tests/Inputs/shtest-env/env-calls-env.txt
The file was modifiedllvm/utils/lit/lit/TestRunner.py
The file was modifiedllvm/utils/lit/tests/shtest-env.py
Commit 309f9a1c52977cbd011b29909f7aa45c124b005f by rnk
[debuginfo-tests] Don't look for Python 3 if we already have it
LLDB already requires Python 3 on Windows, so I already configure it
that way. For some reason CMake fails to find the one that Visual Studio
automatically installs at this standard location:
C:/Program Files (x86)/Microsoft Visual
Studio/Shared/Python37_64/python.exe
CMake prefers the python on path, which happens to be python 2.7.
Reviewers: aprantl, jmorse
Differential Revision: https://reviews.llvm.org/D69684
The file was modifieddebuginfo-tests/CMakeLists.txt
Commit 1739c7c10c42748c278b0ea194e32bbfdd04fb98 by martin
Reapply [LLDB] [test] Use %clang_cl instead of build.py in a few tests
This allows explicitly specifying the intended target architecture, for
tests that aren't supposed to be executed, and that don't require MSVC
headers or libraries to be available.
(These tests already implicitly assumed to be built for x86; one didn't
specify anything, assuming x86_64, while the other specified
--arch=32, which only picks the 32 bit variant of the default target
architecture).
Join two comment lines in disassembly.cpp, to keep row numbers checked
in the test unchanged.
This fixes running check-lldb on arm linux.
Previously when this was applied (in 95980409e6), it broke macos
buildbots, as they added "-isysroot <path>" to all %clang*
substitutions, and clang-cl didn't support that.
Reapplying it without further changes to this patch, after D69619
(9c73925226), because now, such extra parameters are added to
%clang_host*, but not to plain %clang_cl.
Differential Revision: https://reviews.llvm.org/D69031
The file was modifiedlldb/test/Shell/SymbolFile/NativePDB/disassembly.cpp
The file was modifiedlldb/test/Shell/SymbolFile/NativePDB/function-types-calling-conv.cpp