FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [OpenCL] Fix address space for const method call from nonconst (PR43145) (details)
  2. [InstSimplify] add more tests for fcmp+select; NFC (details)
  3. [InstSimplify] use FMF to improve fcmp+select fold (details)
  4. [ARM] Add vrev32 NEON fp16 patterns (details)
  5. [ARM] More MVE shuffle tests for sequences that can be converted to (details)
  6. Revert "[LV] Apply sink-after & interleave-groups as VPlan (details)
  7. gn build: add deps, see discussion on D69130 (details)
  8. gn build: run "gn format" (details)
  9. gn build: (manually) merge 51b4b17eb (details)
  10. [SystemZ] Fix typo (details)
  11. Fix compilation warning. NFC. (details)
  12. [IR] adjust assert when replacing undef elements in vector constant (details)
  13. [ARM] Use isFMAFasterThanFMulAndFAdd for MVE (details)
  14. [OpenCL] Fix FileCheck pattern (details)
  15. [X86] Regenerate known-signbits-vector.ll tests. (details)
  16. SanitizerMask::bitPosToMask - fix operator precedence warnings. NFCI. (details)
  17. [MachineVerifier]  Improve verification of live-in lists. (details)
  18. [SystemZ]  Use LivePhysRegs instead of isCCLiveOut() in (details)
  19. [test] Use system locale for mri-utf8.test (details)
  20. [Diagnostics] Improve some error messages related to bad use of (details)
  21. AliasSetTracker - fix uninitialized variable warnings. NFCI. (details)
  22. [X86] Convert ShrinkMode to scoped enum class. NFCI. (details)
  23. [SLP]Fix PR43799: Crash on different sizes of GEP indices. (details)
  24. Fix buildbots troubled by b7b170c. (details)
  25. [Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC (details)
  26. [FPEnv][SelectionDAG] Refactor strict FP node construction (details)
  27. ELF: Discard .ARM.exidx sections for empty functions instead of (details)
  28. Recommit "[CodeView] Add option to disable inline line tables." (details)
  29. Lower generic MASSV entries to PowerPC subtarget-specific entries (details)
  30. Fix static analysis warnings in ARM calling convention lowering (details)
  31. gn build: Merge 40d0d4e2335 (details)
  32. MCDwarfFile::DirIndex - fix uninitialized variable warning. NFCI. (details)
  33. createMCObjectStreamer - fix uninitialized variable warning. NFCI. (details)
  34. VirtualFileSystem - fix uninitialized variable warnings. NFCI. (details)
  35. [X86] Fix uninitialized variable warnings. NFCI. (details)
Commit 82888b78d47ed132aee4993e00669ce7cbd963e0 by sven.vanhaastregt
[OpenCL] Fix address space for const method call from nonconst (PR43145)
Patch by Anastasia Stulova and Sven van Haastregt.
Differential Revision: https://reviews.llvm.org/D68781
The file was modifiedclang/test/CodeGenOpenCLCXX/addrspace-of-this.cl
The file was modifiedclang/lib/Sema/SemaOverload.cpp
Commit ad87f244b4228699806e757fedb39f8996c595f9 by spatel
[InstSimplify] add more tests for fcmp+select; NFC
The easy code fix won't catch non-canonical mismatched constant
patterns, so adding extra coverage for those in case we decide that's
important (but seems unlikely).
The file was modifiedllvm/test/Transforms/InstSimplify/fcmp-select.ll
Commit 659bd73d13686948c2b4dbee02df2f82542849dd by spatel
[InstSimplify] use FMF to improve fcmp+select fold
This is part of a series of patches needed to solve PR39535:
https://bugs.llvm.org/show_bug.cgi?id=39535
The file was modifiedllvm/lib/Analysis/InstructionSimplify.cpp
The file was modifiedllvm/test/Transforms/InstSimplify/fcmp-select.ll
Commit 6bae5d16a28662fee78595e827343ce1c575b1de by david.green
[ARM] Add vrev32 NEON fp16 patterns
Fill in the gaps for vrev32.16 f16 patterns, extending the existing i16
patterns.
Differential Revision: https://reviews.llvm.org/D69508
The file was modifiedllvm/test/CodeGen/ARM/vrev.ll
The file was modifiedllvm/lib/Target/ARM/ARMInstrNEON.td
Commit 1c616a9266bd829ea8915617ff83244df45a31c8 by david.green
[ARM] More MVE shuffle tests for sequences that can be converted to
VMOVS. NFC.
The file was addedllvm/test/CodeGen/Thumb2/mve-shufflemov.ll
Commit d3ec06d219788801380af1948c7f7ef9d3c6100b by benny.kra
Revert "[LV] Apply sink-after & interleave-groups as VPlan
transformations (NFC)"
This reverts commit 2be17087f8c38934b7fc9208ae6cf4e9b4d44f4b. Fails
ASAN.
The file was modifiedllvm/unittests/Transforms/Vectorize/VPlanTest.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
Commit a3915ca9f908177c53073549e1b9b19e172a45ec by nicolasweber
gn build: add deps, see discussion on D69130
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/AArch64/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/RISCV/BUILD.gn
Commit 9cd13deb293a00da797f7a97e31cdade2d115078 by nicolasweber
gn build: run "gn format"
The file was modifiedllvm/utils/gn/secondary/llvm/unittests/Transforms/Utils/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn
Commit 4168a2e9de35f84abb90fecd03f06a8e131c50fc by nicolasweber
gn build: (manually) merge 51b4b17eb
Also reverts r353980 since that duplicated the GenAsmMatcher target for
AArch64. Instead use visiblity.
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/RISCV/AsmParser/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/RISCV/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/AArch64/AsmParser/BUILD.gn
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/AArch64/BUILD.gn
Commit d4a7855b68d4d53f121209333d5f2796731ab1f5 by ulrich.weigand
[SystemZ] Fix typo
Typo in comment.  NFC.
The file was modifiedllvm/lib/Target/SystemZ/SystemZISelLowering.h
Commit d142ec6fef9a053c9fd9edb5a388203cdb121e65 by michael.hliao
Fix compilation warning. NFC.
The file was modifiedclang/lib/Driver/ToolChains/Darwin.cpp
Commit b556ce3992709e1f6302ca1d4c296f57e83cd6a7 by spatel
[IR] adjust assert when replacing undef elements in vector constant
As noted in follow-up to: rGa1e8ad4f2fa7
It's not safe to assume that an element of the constant is always
non-null. It's definitely not an expected case for the current
instcombine user, but that may not hold if this function is eventually
called from arbitrary places.
The file was modifiedllvm/lib/IR/Constants.cpp
Commit 91b0cad8132997060182146b2734065bc807e9fa by david.green
[ARM] Use isFMAFasterThanFMulAndFAdd for MVE
The Arm backend will usually return false for
isFMAFasterThanFMulAndFAdd, where both the fused VFMA.f32 and a
non-fused VMLA.f32 are usually available for scalar code. For MVE we
don't have the non-fused version though. It makes more sense for
isFMAFasterThanFMulAndFAdd to return true, allowing us to simplify some
of the existing ISel patterns.
The tests here are that non of the existing tests failed, and so we are
still selecting VFMA and VFMS. The one test that changed shows we can
now select from fast math flags, as opposed to just relying on the
isFMADLegalForFAddFSub option.
Differential Revision: https://reviews.llvm.org/D69115
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.cpp
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/fast-fp-loops.ll
The file was modifiedllvm/lib/Target/ARM/ARMISelLowering.h
Commit 6c5827975cf921563315de54ac7c6053d3995f40 by sven.vanhaastregt
[OpenCL] Fix FileCheck pattern
For this test, FileCheck is not run with the CHECK prefix; it seems
COMMON was intended here.
The file was modifiedclang/test/CodeGenOpenCLCXX/addrspace-of-this.cl
Commit 03cde3a7ccd2025baa497cbcf6e825862429f1bd by llvm-dev
[X86] Regenerate known-signbits-vector.ll tests.
Use X86 instead of X32 and add a common CHECK prefix
The file was modifiedllvm/test/CodeGen/X86/known-signbits-vector.ll
Commit a0324e911374441151903ed0d828e0fc1994c167 by llvm-dev
SanitizerMask::bitPosToMask - fix operator precedence warnings. NFCI.
Fix static analyzer operator precedence warnings with suitable
bracketing. Pull out the mask generation code so clang-format doesn't
make such a mess of it.
The file was modifiedclang/include/clang/Basic/Sanitizers.h
Commit b7b170c9b46ab4c0a10ecf1d9d5832e70ca992d5 by paulsson
[MachineVerifier]  Improve verification of live-in lists.
MachineVerifier::visitMachineFunctionAfter() is extended to check the
live-through case for live-in lists. This is only done for registers
without aliases and that are neither allocatable or reserved, such as
the SystemZ::CC register.
The MachineVerifier earlier only catched the case of a live-in use
without an entry in the live-in list (as "using an undefined physical
register").
A comment in LivePhysRegs.h has been added stating a guarantee that
addLiveOuts() can be trusted for a full register both before and after
register allocation.
Review: Quentin Colombet https://reviews.llvm.org/D68267
The file was addedllvm/test/MachineVerifier/live-ins-03.mir
The file was modifiedllvm/include/llvm/CodeGen/LivePhysRegs.h
The file was addedllvm/test/MachineVerifier/live-ins-02.mir
The file was modifiedllvm/lib/CodeGen/MachineVerifier.cpp
The file was addedllvm/test/MachineVerifier/live-ins-01.mir
Commit bf6744dfb244dbd2a4abe635f57e45218292743f by paulsson
[SystemZ]  Use LivePhysRegs instead of isCCLiveOut() in
SystemZElimCompare.cpp
Review: Ulrich Weigand https://reviews.llvm.org/D68267
The file was modifiedllvm/lib/Target/SystemZ/SystemZElimCompare.cpp
Commit 0bab0538d8cc0de242ed2936a4766930cfc934d2 by thomasp
[test] Use system locale for mri-utf8.test
Summary: llvm-ar's mri-utf8.test test relies on the en_US.UTF-8 locale
to be installed for its last RUN line to work. If not installed, the
unicode string gets encoded (interpreted) as ascii which fails since the
most significant byte is non zero. This commit changes the test to only
rely on the system being able to encode the pound sign in its default
encoding (e.g. UTF-16 for Microsoft Windows) by always opening the file
via input/output redirection. This avoids forcing a given locale to be
present and supported. A Byte Order Mark is also added to help
recognizing the encoding of the file and its endianness. Finally the
XFAIL on system-darwin is removed since the test actually passes fine on
Mac OS X and XFAIL was only added because it failed before.
Reviewers: gbreynoo, MaskRay, rupprecht, JamesNagurne, jfb
Subscribers: dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D68472
The file was addedllvm/test/tools/llvm-ar/mri-nonascii.test
The file was removedllvm/test/tools/llvm-ar/mri-utf8.test
Commit 55507110b988c27cfb9ff4c2231fa38171692545 by Dávid Bolvanský
[Diagnostics] Improve some error messages related to bad use of
dynamic_cast
The file was modifiedclang/include/clang/Basic/DiagnosticSemaKinds.td
The file was modifiedclang/lib/Sema/SemaCast.cpp
The file was modifiedclang/test/SemaCXX/dynamic-cast.cpp
The file was modifiedclang/test/SemaTemplate/instantiate-cast.cpp
Commit 1abb2c1a39fb20e12210472fda42a0c942f83be8 by llvm-dev
AliasSetTracker - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/include/llvm/Analysis/AliasSetTracker.h
Commit 9ad9d1531b96242bedce3e7f101689bc46322fd2 by llvm-dev
[X86] Convert ShrinkMode to scoped enum class. NFCI.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit b80c41cd3c095c8c4fa739130b560b15bda4bbd0 by a.bataev
[SLP]Fix PR43799: Crash on different sizes of GEP indices.
Summary: If the GEP instructions are going to be vectorized, the indices
in those GEP instructions must be of the same type. Otherwise, the
compiler may crash when trying to build the vector constant.
Reviewers: RKSimon, spatel
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69627
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/crash_gep.ll
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
Commit b14ff0caecbdbb8312e5671047b9b1dff32da1ca by paulsson
Fix buildbots troubled by b7b170c.
Add '# REQUIRES: systemz-registered-target' in the new tests.
The file was modifiedllvm/test/MachineVerifier/live-ins-02.mir
The file was modifiedllvm/test/MachineVerifier/live-ins-01.mir
The file was modifiedllvm/test/MachineVerifier/live-ins-03.mir
Commit 9ba16615fa07c586965b1fa2dc6e88f13fe8031d by ibiryukov
[Sema] Make helper in TreeTransform.h 'inline' instead of 'static'. NFC
Summary: There seems to be no evidence that having internal linkage for
the function was intentional. Since 'static' functions are normally used
only in .cpp files, using 'inline' in the header file is more
appropriate.
Reviewers: Anastasia
Reviewed By: Anastasia
Subscribers: merge_guards_bot, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69242
The file was modifiedclang/lib/Sema/TreeTransform.h
Commit 664f84e246478db82be2871f36fd1a523d9f2731 by ulrich.weigand
[FPEnv][SelectionDAG] Refactor strict FP node construction
Small refactoring in visitConstrainedFPIntrinsic that should make it
easier to create DAG nodes requiring extra arguments.  That is the case
currently only for STRICT_FP_ROUND, but may be the case for additional
nodes (in particular compares) in the future.
Extracted from the patch for D69281.
NFC.
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
Commit 2c6fae179e6984c7330ff8a284d7a10ce142eef9 by peter
ELF: Discard .ARM.exidx sections for empty functions instead of
misordering them.
The logic added in r372781 caused ARMExidxSyntheticSection::addSection()
to return false for exidx sections without a link order dep that passed
isValidExidxSectionDep(). This included exidx sections for empty
functions. As a result, such exidx sections would end up treated like
ordinary sections and would end up being laid out before the
ARMExidxSyntheticSection, most likely in the wrong order relative to the
exidx entries in the ARMExidxSyntheticSection, breaking the orderedness
invariant relied upon by unwinders. Fix this by simply discarding such
sections.
Differential Revision: https://reviews.llvm.org/D69744
The file was modifiedlld/ELF/SyntheticSections.cpp
The file was addedlld/test/ELF/arm-exidx-empty-fn.s
Commit ab76cfdd200d35177df2042a1c0c7e86868d01bc by akhuang
Recommit "[CodeView] Add option to disable inline line tables."
This reverts commit 004ed2b0d1b86d424643ffc88fce20ad8bab6804. Original
commit hash 6d03890384517919a3ba7fe4c35535425f278f89
Summary: This adds a clang option to disable inline line tables. When it
is used, the inliner uses the call site as the location of the inlined
function instead of marking it as an inline location with the function
location.
https://reviews.llvm.org/D67723
The file was modifiedclang/lib/CodeGen/CodeGenFunction.cpp
The file was addedclang/test/CodeGen/debug-info-no-inline-line-tables.c
The file was addedllvm/test/Transforms/Inline/no-inline-line-tables.ll
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedllvm/include/llvm/IR/Attributes.td
The file was modifiedclang/include/clang/Basic/CodeGenOptions.def
The file was modifiedllvm/docs/LangRef.rst
The file was modifiedllvm/lib/Transforms/Utils/InlineFunction.cpp
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp
Commit 40d0d4e2335d14a3a70a565304fd7e92c25f178b by Jinsong Ji
Lower generic MASSV entries to PowerPC subtarget-specific entries
This patch (second of two patches) lowers the generic PowerPC vector
entries to PowerPC subtarget-specific entries. For instance, the PowerPC
generic entry 'cbrtd2_massv' is lowered to
'cbrtd2_P9' or Power9 subtarget.
The first patch enables the vectorizer to recognize the IBM MASS vector
library routines. This patch specifically adds support for recognizing
the '-vector-library=MASSV' option, and defines mappings from IEEE
standard scalar math functions to generic PowerPC MASS vector
counterparts. For instance, the generic PowerPC MASS vector entry for
double-precision
'cbrt' function is '__cbrtd2_massv'
The overall support for MASS vector library is presented as such in two
patches for ease of review.
Patch by pjeeva01 (Jeeva P.) Differential Revision:
https://reviews.llvm.org/D59883
The file was modifiedllvm/lib/Target/PowerPC/CMakeLists.txt
The file was addedllvm/test/CodeGen/PowerPC/lower-massv-attr.ll
The file was modifiedllvm/include/llvm/Analysis/VecFuncs.def
The file was addedllvm/test/CodeGen/PowerPC/lower-massv.ll
The file was addedllvm/lib/Target/PowerPC/PPCLowerMASSVEntries.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPCTargetMachine.cpp
The file was modifiedllvm/lib/Target/PowerPC/PPC.h
Commit 73c3137a82c96789f4a2b8ec9427d23fa73498d8 by oliver.stannard
Fix static analysis warnings in ARM calling convention lowering
Fixes https://bugs.llvm.org/show_bug.cgi?id=43891
The file was modifiedllvm/lib/Target/ARM/ARMCallingConv.cpp
Commit 667223c3ed609794495ea30aaea6becd330f9459 by llvmgnsyncbot
gn build: Merge 40d0d4e2335
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Target/PowerPC/BUILD.gn
Commit 692b42fbb0530b41d9575c12e13076d160ab12a5 by llvm-dev
MCDwarfFile::DirIndex - fix uninitialized variable warning. NFCI.
The file was modifiedllvm/include/llvm/MC/MCDwarf.h
Commit 67286c87854adaa5d2826069ce685012e41ce05c by llvm-dev
createMCObjectStreamer - fix uninitialized variable warning. NFCI.
The file was modifiedllvm/include/llvm/Support/TargetRegistry.h
Commit e1000f1d674186c095eac2f252d45ff5b9306db7 by llvm-dev
VirtualFileSystem - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/lib/Support/VirtualFileSystem.cpp
Commit a8653da4320c5e37fccc54d396f2286a0dce7efe by llvm-dev
[X86] Fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/lib/Target/X86/X86FlagsCopyLowering.cpp
The file was modifiedllvm/lib/Target/X86/X86WinAllocaExpander.cpp
The file was modifiedllvm/lib/Target/X86/X86WinEHState.cpp
The file was modifiedllvm/lib/Target/X86/X86FixupSetCC.cpp
The file was modifiedllvm/lib/Target/X86/X86IndirectBranchTracking.cpp
The file was modifiedllvm/lib/Target/X86/X86SpeculativeLoadHardening.cpp
The file was modifiedllvm/lib/Target/X86/X86AvoidStoreForwardingBlocks.cpp
The file was modifiedllvm/lib/Target/X86/X86OptimizeLEAs.cpp
The file was modifiedllvm/lib/Target/X86/X86FixupLEAs.cpp
The file was modifiedllvm/lib/Target/X86/X86RetpolineThunks.cpp