FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. X86FoldTablesEmitter - fix static analyzer potential invalid iterator (details)
  2. [X86] Fix uninitialized variable warnings. NFCI. (details)
  3. [Support] fix mingw-w64 build (details)
  4. [x86] avoid crashing when splitting AVX stores with non-simple type (details)
  5. [clangd] Improve the output of rename tests where there are failures. (details)
  6. lldb: Skip reproducer+expression evaluation test on linux (details)
  7. lldb/docs: update the lldb-x86_64-debian bot url (details)
  8. [NFC][APInt] Fix typos in comments. (details)
  9. [clang-tidy] Update TransformerClangTidyCheck to use new Transformer (details)
  10. DWARFDebugLoclists: Move to a incremental parsing model (details)
  11. [libTooling] Simplify type structure of `Stencil`s. (details)
  12. [libomptarget] Revert all improvements to support (details)
  13. [libTooling] Small changes in Transformer API. (details)
  14. [CommandLine] Add inline ArgName printing (details)
  15. [libTooling] Fix breakage from change #84922 (details)
  16. Revert "build: explicitly set the linker language for unwind" (details)
  17. [libcxx] Make generate_feature_test_macro_components script compatible (details)
  18. BranchProbabilityInfo - fix uninitialized variable warning. NFCI. (details)
  19. LoopAccessAnalysis - fix uninitialized variable warnings. NFCI. (details)
  20. CodeGenInstruction - fix uninitialized variable warnings. NFCI. (details)
  21. [CostModel][X86] Add add/fadd reduction tests for SLM (details)
  22. [clang-format] Assert that filenames are not empty (details)
  23. [clang-format] [RELAND] Remove the dependency on frontend (details)
Commit cfc385d95445ea52ac68d55f2c13ac8d19f79855 by llvm-dev
X86FoldTablesEmitter - fix static analyzer potential invalid iterator
warning. NFCI.
The file was modifiedllvm/utils/TableGen/X86FoldTablesEmitter.cpp
Commit eabd405e665e24e00dc71c90baa196c38cd15f12 by llvm-dev
[X86] Fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/lib/Target/X86/X86EvexToVex.cpp
The file was modifiedllvm/lib/Target/X86/X86DomainReassignment.cpp
The file was modifiedllvm/lib/Target/X86/X86CallFrameOptimization.cpp
The file was modifiedllvm/lib/Target/X86/X86CmovConversion.cpp
The file was modifiedllvm/lib/Target/X86/X86FloatingPoint.cpp
The file was modifiedllvm/lib/Target/X86/X86ExpandPseudo.cpp
The file was modifiedllvm/lib/Target/X86/X86FixupBWInsts.cpp
Commit 3e54404c71564d9c684742439f178f07f1e45a70 by ibiryukov
[Support] fix mingw-w64 build
Older versions of Mingw-w64 do not define _beginthreadex_proc_type, so
we replace it with `unsigned (__stdcall *ThreadFunc)(void *)`.
Fixes https://github.com/clangd/clangd/issues/188
Patch by lh123!
Differential Revision: https://reviews.llvm.org/D69879
The file was modifiedllvm/lib/Support/Windows/Threading.inc
Commit 8e34dd941cb304c785ef623633ad663b59cfced0 by spatel
[x86] avoid crashing when splitting AVX stores with non-simple type
(PR43916)
The store splitting transform was assuming a simple type (MVT), but
that's not necessarily the case as shown in the test.
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/X86/avx-load-store.ll
Commit b0eed2a5cfe13a7cd13e2446b7dfe2d7b588d416 by hokein.wu
[clangd] Improve the output of rename tests where there are failures.
Summary: Previously, we match ranges, which is hard to spot the
difference. Now, we diff the code after rename against the expected
result, it produces much nicer output.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69890
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp
Commit 58401612cdc8d2c8e0e8c4103423b5da781199be by pavel
lldb: Skip reproducer+expression evaluation test on linux
It's flaky.
The file was modifiedlldb/test/Shell/Reproducer/Functionalities/TestExpressionEvaluation.test
Commit bcae3b04e8740e1a82567471df410a2fd8b72c3f by pavel
lldb/docs: update the lldb-x86_64-debian bot url
It is on the "stable" master now.
The file was modifiedlldb/docs/resources/bots.rst
Commit 4601df7d6ac5919b33366078c643ab21f9f229cf by Milos.Stojanovic
[NFC][APInt] Fix typos in comments.
Testing git commit access.
The file was modifiedllvm/include/llvm/ADT/APInt.h
The file was modifiedllvm/lib/Support/APInt.cpp
Commit bde32933027a096b6cfe14b0e9385ac1005fc28a by yitzhakm
[clang-tidy] Update TransformerClangTidyCheck to use new Transformer
bindings.
Summary: Updates the relevant source files to use bindings in
`clang::transformer` rather than `clang::tooling`.
Reviewers: gribozavr
Subscribers: xazax.hun, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69804
The file was modifiedclang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.h
The file was modifiedclang-tools-extra/clang-tidy/utils/TransformerClangTidyCheck.cpp
The file was modifiedclang-tools-extra/unittests/clang-tidy/TransformerClangTidyCheckTest.cpp
Commit e1f8c8a16f441aed3aaa6262f932854b74e4f97c by pavel
DWARFDebugLoclists: Move to a incremental parsing model
Summary: This patch stems from the discussion D68270 (including some
offline talks). The idea is to provide an "incremental" api for parsing
location lists, which will avoid caching or materializing parsed data.
An additional goal is to provide a high level location list api, which
abstracts the differences between different encoding schemes, and can be
used by users which don't care about those (such as LLDB).
This patch implements the first part. It implements a call-back based
"visitLocationList" api. This function parses a single location list,
calling a user-specified callback for each entry. This is going to be
the base api, which other location list functions (right now, just the
dumping code) are going to be based on.
Future patches will do something similar for the v4 location lists, and
add a mechanism to translate raw entries into concrete address ranges.
Reviewers: dblaikie, probinson, JDevlieghere, aprantl, SouraVX
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69672
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFContext.h
The file was modifiedllvm/test/DebugInfo/X86/dwarfdump-debug-loclists.test
The file was modifiedllvm/test/DebugInfo/X86/stack-value-piece.ll
The file was modifiedllvm/include/llvm/DebugInfo/DWARF/DWARFDebugLoc.h
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was modifiedllvm/test/DebugInfo/X86/fission-ranges.ll
The file was modifiedllvm/test/CodeGen/X86/debug-loclists.ll
The file was modifiedllvm/test/DebugInfo/X86/dwarfdump-debug-loclists-error-cases2.s
The file was modifiedllvm/test/tools/llvm-dwarfdump/X86/debug_loclists_startx_length.s
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDebugLoc.cpp
The file was modifiedllvm/lib/DebugInfo/DWARF/DWARFDie.cpp
Commit ce2b5cb6decb5cce32adde0d23bdea521da0908b by yitzhakm
[libTooling] Simplify type structure of `Stencil`s.
Summary: Currently, stencils are defined as a sequence of
`StencilParts`. This differentiation adds an unneeded layer of
complexity to the definition of Stencils. This change significantly
simplifies the type structure: a stencil is now conceptually any object
implementing `StencilInterface` and `Stencil` is just a thin wrapper for
pointers to this interface.
To account for the sequencing that was supported by the old `Stencil`
type, we introduce a sequencing class that implements
`StencilInterface`. That is, sequences are just another kind of Stencil
and no longer have any special status.
Corresponding to this change in the type structure, we change the way
`cat` is used (and defined). `cat` bundles multiple features: it builds
a stencil from a sequence of subcomponents and admits multiple different
types for its arguments, while coercing them into the right type.
Previously, `cat` was also used to coerce a single `StencilPart` into a
`Stencil`. With that distinction gone, many uses of `cat` (e.g. in the
tests) are unnecessary and have, therefore, been removed.
Reviewers: gribozavr
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69613
The file was modifiedclang/lib/Tooling/Transformer/Stencil.cpp
The file was modifiedclang/unittests/Tooling/StencilTest.cpp
The file was modifiedclang/include/clang/Tooling/Transformer/Stencil.h
Commit 7cea0cea77d15b70d54083ec7c17ae5d49b3f53f by jonathanchesterfield
[libomptarget] Revert all improvements to support
Summary:
[libomptarget] Revert all improvements to support
The change to unity build for nvcc has broken the build for some
developers. This patch reverts to a known-working state.
There has been some confusion over exactly how the build broke. I think
we have reached a common understanding that the disappearing symbols are
from the bitcode library built by clang. The static archive built by
nvcc may show the same problem. Some of the confusion arose from
building the deviceRTL twice and using one or the other library based on
various environmental factors.
I'm pretty sure the problem is clang expanding `__forceinline__` into
both `__inline__` and `attribute(("always_inline"))`. The `__inline__`
attribute resolves to linkonce_odr which is not safe for exporting
symbols from translation units.
"always_inline" is the desired semantic for small functions defined in
one translation unit that are intended to be inlined at link time.
"inline" is not.
This therefore reintroduces the dependency hazard of supporti.h and some
code duplication, and blocks progress separating deviceRTL into reusable
components.
See also D69857, D69859 for attempts at a fix instead of a revert.
Reviewers: ABataev, jdoerfert, grokos, ikitayama, tianshilei1992
Reviewed By: ABataev
Subscribers: mgorny, jfb, openmp-commits
Tags: #openmp
Differential Revision: https://reviews.llvm.org/D69885
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/data_sharing.cu
The file was removedopenmp/libomptarget/deviceRTLs/nvptx/src/support.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/omptarget-nvptx.h
The file was addedopenmp/libomptarget/deviceRTLs/nvptx/src/supporti.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/debug.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/target_impl.h
The file was removedopenmp/libomptarget/deviceRTLs/nvptx/unity.cu
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/support.h
The file was modifiedopenmp/libomptarget/deviceRTLs/nvptx/src/libcall.cu
Commit 9f97480cddd77bd2d169131a290cc996fc78df0f by yitzhakm
[libTooling] Small changes in Transformer API.
Summary:
* Rename `transformer::change` to `transformer::changeTo`, make `change`
forward
to `changeTo` and mark it deprecated.
* Mark `transformer::text` and `transformer::selection` deprecated and
migrate
references to them in tests.
Reviewers: ilya-biryukov
Subscribers: gribozavr, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69896
The file was modifiedclang/include/clang/Tooling/Transformer/RewriteRule.h
The file was modifiedclang/include/clang/Tooling/Transformer/Stencil.h
The file was modifiedclang/unittests/Tooling/TransformerTest.cpp
Commit 405e83689fb42f8ae673d9a26bd21366c4a055be by hintonda
[CommandLine] Add inline ArgName printing
Summary: This patch adds PrintArgInline (after PrintArg) that strips the
leading spaces from an argument before printing them, for usage inline.
Related bug: PR42943 <https://bugs.llvm.org/show_bug.cgi?id=42943>
Patch by Daan Sprenkels!
Reviewers: jhenderson, chandlerc, hintonda
Reviewed By: jhenderson
Subscribers: hiraditya, kristina, llvm-commits, dsprenkels
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69501
The file was modifiedllvm/lib/Support/CommandLine.cpp
The file was modifiedllvm/unittests/Support/CommandLineTest.cpp
Commit 6c683aa8d7d9dcda30b2a9eb42b43cbce5c645b8 by yitzhakm
[libTooling] Fix breakage from change #84922
The file was modifiedclang/lib/Tooling/Transformer/RewriteRule.cpp
The file was modifiedclang/unittests/Tooling/TransformerTest.cpp
Commit 049f94af487fc8be704f8740e2d2946ac5c6efc9 by Saleem Abdulrasool
Revert "build: explicitly set the linker language for unwind"
This reverts commit 6db7a5cd7c800a588e94ce5c1ef24ae4d60ecdd3. This
adversely impacted the NetBSD libc++ bot for some reason, reverting
while investigating.
The file was modifiedlibunwind/src/CMakeLists.txt
Commit fd02a4685522bf2ded1d8fb8831a1530c5da6be7 by Louis Dionne
[libcxx] Make generate_feature_test_macro_components script compatible
with Python 3.
The script is still compatible with Python 2 as well. Thanks to Marek
Kurdej for the patch.
Differential Revision: https://reviews.llvm.org/D69884
The file was modifiedlibcxx/utils/generate_feature_test_macro_components.py
Commit c447e5d90e8624e69620c1876917601d905e7e35 by llvm-dev
BranchProbabilityInfo - fix uninitialized variable warning. NFCI.
The file was modifiedllvm/include/llvm/Analysis/BranchProbabilityInfo.h
Commit 216dab915285c5b9e2c56be9b6541f35ccb96303 by llvm-dev
LoopAccessAnalysis - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/include/llvm/Analysis/LoopAccessAnalysis.h
Commit cca01c0347e85f184f06676a421bb8456e7cfa36 by llvm-dev
CodeGenInstruction - fix uninitialized variable warnings. NFCI.
The file was modifiedllvm/utils/TableGen/CodeGenInstruction.h
Commit 1b986b41ac40c9df82cc98ea4238d463e217bb25 by llvm-dev
[CostModel][X86] Add add/fadd reduction tests for SLM
The file was modifiedllvm/test/Analysis/CostModel/X86/reduction.ll
The file was modifiedllvm/test/Analysis/CostModel/X86/reduce-add.ll
Commit 7681435de148cf7a1c7db1b0daba0497630989d2 by paulhoad
[clang-format] Assert that filenames are not empty
Summary: Adds asserts to catch empty filenames, which otherwise will
cause a crash in SourceManager. The clang-format tool now outputs an
error if an empty filename is used. Fixes bug: 34667
Reviewers: krasimir, djasper, MyDeveloperDay
Reviewed By: MyDeveloperDay
Subscribers: cfe-commits
Patch by: @jr
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D56345
The file was modifiedclang/tools/clang-format/ClangFormat.cpp
Commit 3ddac7e563633632d4a3e673f3224ee66e1a717e by paulhoad
[clang-format] [RELAND] Remove the dependency on frontend
Summary: relanding {D68969} after it failed UBSAN build caused by the
passing of an invalid SMLoc() (nullptr)
Reviewers: thakis, vlad.tsyrklevich, klimek, mitchell-stellar
Reviewed By: thakis
Subscribers: merge_guards_bot, mgorny, cfe-commits
Tags: #clang-format, #clang
Differential Revision: https://reviews.llvm.org/D69854
The file was modifiedclang/tools/clang-format/ClangFormat.cpp
The file was modifiedclang/tools/clang-format/CMakeLists.txt