FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. [X86] Remove unused variable. NFC (details)
  2. [llvm-readobj] - Simplify elf-hash-symbols.test. NFCI. (details)
  3. [Syntax] Silence "unused function" warning in no-assert builds. NFC (details)
  4. [AMDGPU] Fix bug introduced in 47a5c36b37f0 (details)
  5. [clangd] Set RetainCommentsFromSystemHeaders to true (details)
  6. [clang-format] Make '.clang-format' variants finding a loop (NFC) (details)
  7. [clangd] Add unit tests for comments in system headers (details)
  8. Revert a5c8ec4 "[CGDebugInfo] Emit subprograms for decls when (details)
  9. [clang-rename] Respect the traversal scope when traversing the entire (details)
  10. [lldb-server] Add setting to force 'g' packet use (details)
  11. [clangd] NFC, hide the internal-only utility function lex. (details)
  12. Revert f0c2a5a "[LV] Generalize conditions for sinking instrs for first (details)
  13. [mips] Implement Octeon+ `saa` and `saad` instructions (details)
  14. [mips] Support `octeon+` CPU in the `.set arch=` directive (details)
  15. [mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section (details)
  16. [mips] Add `octeon+` to the list of CPUs accepted by the driver (details)
  17. [mips] Set macros for Octeon+ CPU (details)
  18. [NFC][CVP] Add some tests for `sub` with preexisting no-wrap flags (details)
Commit 17eb12fa6d99b2e963d4dff15c3790a5fda8549e by craig.topper
[X86] Remove unused variable. NFC
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit c44a9b538d8cd468dd978c0d1fe447d2df69566a by grimar
[llvm-readobj] - Simplify elf-hash-symbols.test. NFCI.
It converts binary contents of .hash and .gnu.hash that were generated
by a linker to YAML descriptions. I've also dropped Shift2 and
BloomFilter values because they are not needed here.
Differential revision: https://reviews.llvm.org/D69881
The file was modifiedllvm/test/tools/llvm-readobj/elf-hash-symbols.test
Commit 96065cf79ff76d5fd4fdaeb2fb2650074b3e0e51 by ibiryukov
[Syntax] Silence "unused function" warning in no-assert builds. NFC
A helper `isImpicitExpr` is only used inside assert.
The file was modifiedclang/lib/Tooling/Syntax/BuildTree.cpp
Commit 6e8251046b96ae9b1ab8fc0f864266222856b5c5 by dfukalov
[AMDGPU] Fix bug introduced in 47a5c36b37f0
Summary: [AMDGPU] Fix bug introduced in 47a5c36b37f0
Reviewers: foad, arsenm
Reviewed By: arsenm
Subscribers: arsenm, kzhuravl, jvesely, wdng, nhaehnle, yaxunl,
dstuttard, tpr, t-tye, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69915
The file was modifiedllvm/test/Analysis/CostModel/AMDGPU/shufflevector.ll
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp
Commit 0019684900491f517f3b08b4fa92740b69a8cc0f by ibiryukov
[clangd] Set RetainCommentsFromSystemHeaders to true
clangd should retain comments from system headers.
fixes https://github.com/clangd/clangd/issues/96
Patch by lh123!
Differential revision: https://reviews.llvm.org/D69928
The file was modifiedclang-tools-extra/clangd/Compiler.cpp
The file was modifiedclang-tools-extra/clangd/index/IndexAction.cpp
Commit 86825dbe3306d296094432feb4a7af7d385d6b1d by anders
[clang-format] Make '.clang-format' variants finding a loop (NFC)
This simplifies logic making it trivial to add searching for other files
later.
Differential revision: https://reviews.llvm.org/D68568
The file was modifiedclang/lib/Format/Format.cpp
Commit dec8d8d3f205268712a928d106ff2e6f799f7a9b by ibiryukov
[clangd] Add unit tests for comments in system headers
The file was modifiedclang-tools-extra/clangd/unittests/CodeCompleteTests.cpp
Commit 5b9a072c39c0c34a290abd19e4aca8208a9afae6 by hans
Revert a5c8ec4 "[CGDebugInfo] Emit subprograms for decls when
AT_tail_call is understood"
This caused Chromium builds to fail with "inlinable function call in a
function with debug info must have a !dbg location" errors. See
https://bugs.chromium.org/p/chromium/issues/detail?id=1022296#c1 for a
reproducer.
> Currently, clang emits subprograms for declared functions when the
> target debugger or DWARF standard is known to support entry values
> (DW_OP_entry_value & the GNU equivalent).
>
> Treat DW_AT_tail_call the same way to allow debuggers to follow
cross-TU
> tail calls.
>
> Pre-patch debug session with a cross-TU tail call:
>
> ```
>   * frame #0: 0x0000000100000fa4 main`target at b.c:4:3 [opt]
>     frame #1: 0x0000000100000f99 main`main at a.c:8:10 [opt]
> ```
>
> Post-patch (note that the tail-calling frame, "helper", is visible):
>
> ```
>   * frame #0: 0x0000000100000fa4 main`target at b.c:4:3 [opt]
>     frame #1: 0x0000000100000f80 main`helper [opt] [artificial]
>     frame #2: 0x0000000100000f99 main`main at a.c:8:10 [opt]
> ```
>
> rdar://46577651
>
> Differential Revision: https://reviews.llvm.org/D69743
The file was modifiedllvm/test/DebugInfo/X86/dwarf-callsite-related-attrs.ll
The file was modifiedclang/lib/CodeGen/CGDebugInfo.cpp
The file was modifiedclang/test/CodeGenCXX/dbg-info-all-calls-described.cpp
The file was modifiedclang/test/CodeGen/debug-info-extern-call.c
Commit 118f7836a65e864ef3c7e015d58ca370fee65e89 by hokein.wu
[clang-rename] Respect the traversal scope when traversing the entire
AST.
Summary: This should be NFC to clang-rename, by default the traversal
scope is TUDecl. Traversing the TUDecl in clangd is a performance cliff,
we should avoid it.
Reviewers: ilya-biryukov
Subscribers: kadircet, usaxena95, cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D69892
The file was modifiedclang/lib/Tooling/Refactoring/Rename/USRFindingAction.cpp
Commit b1b70f6761266c3eecaf8bd71529eaf51994207b by pavel
[lldb-server] Add setting to force 'g' packet use
Following up on https://reviews.llvm.org/D62221, this change introduces
the settings plugin.process.gdb-remote.use-g-packet-for-reading.  When
they are on, 'g' packets are used for reading registers.
Using 'g' packets can improve performance by reducing the number of
packets exchanged between client and server when a large number of
registers needs to be fetched.
Differential revision: https://reviews.llvm.org/D62931
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ProcessGDBRemoteProperties.td
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/TestGDBRemoteClient.py
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.h
The file was modifiedlldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.h
Commit c5e4cf40ac459aae996180089a9831959ceb3d05 by hokein.wu
[clangd] NFC, hide the internal-only utility function lex.
To avoid any potential ODR violations.
The file was modifiedclang-tools-extra/clangd/SourceCode.cpp
Commit eaff3004019f97c64c88ab76da6b25106b659b30 by hans
Revert f0c2a5a "[LV] Generalize conditions for sinking instrs for first
order recurrences."
It broke Chromium, causing "Instruction does not dominate all uses!"
errors. See
https://bugs.chromium.org/p/chromium/issues/detail?id=1022297#c1 for a
reproducer.
> If the recurrence PHI node has a single user, we can sink any
> instruction without side effects, given that all users are dominated
by
> the instruction computing the incoming value of the next iteration
> ('Previous'). We can sink instructions that may cause traps, because
> that only causes the trap to occur later, but not on any new paths.
>
> With the relaxed check, we also have to make sure that we do not have
a
> direct cycle (meaning PHI user == 'Previous), which indicates a
> reduction relation, which potentially gets missed by
> ReductionDescriptor.
>
> As follow-ups, we can also sink stores, iff they do not alias with
> other instructions we move them across and we could also support
sinking
> chains of instructions and multiple users of the PHI.
>
> Fixes PR43398.
>
> Reviewers: hsaito, dcaballe, Ayal, rengolin
>
> Reviewed By: Ayal
>
> Differential Revision: https://reviews.llvm.org/D69228
The file was removedllvm/test/Transforms/LoopVectorize/first-order-recurrence-complex.ll
The file was modifiedllvm/lib/Analysis/IVDescriptors.cpp
Commit 7bed381eae12277d6e0ef7e8a56491d11589ee7f by simon
[mips] Implement Octeon+ `saa` and `saad` instructions
`saa` and `saad` are 32-bit and 64-bit store atomic add instructions.
   memory[base] = memory[base] + rt
These instructions are available for "Octeon+" CPU. The patch adds
support for both instructions to MIPS assembler and diassembler and
introduces new CPU type - "octeon+".
Next patches will implement `.set arch=octeon+` directive and
`AFL_EXT_OCTEONP` ISA extension flag support.
Differential Revision: https://reviews.llvm.org/D69849
The file was modifiedllvm/lib/Target/Mips/Disassembler/MipsDisassembler.cpp
The file was modifiedllvm/lib/Target/Mips/MipsScheduleGeneric.td
The file was addedllvm/test/MC/Mips/macro-saad.s
The file was addedllvm/test/MC/Disassembler/Mips/octeonp/valid-el.txt
The file was modifiedllvm/lib/Target/Mips/MipsScheduleP5600.td
The file was modifiedllvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
The file was modifiedllvm/lib/Target/Mips/MipsSubtarget.h
The file was modifiedllvm/lib/Target/Mips/MipsSubtarget.cpp
The file was modifiedllvm/test/MC/Mips/elf_eflags.s
The file was modifiedllvm/test/MC/Mips/elf_header.s
The file was modifiedllvm/lib/Target/Mips/Mips.td
The file was addedllvm/test/MC/Disassembler/Mips/octeonp/valid.txt
The file was addedllvm/test/MC/Mips/cnmipsp/invalid.s
The file was modifiedllvm/lib/Target/Mips/Mips64InstrInfo.td
The file was modifiedllvm/lib/Target/Mips/MipsInstrFormats.td
The file was addedllvm/test/MC/Mips/cnmipsp/valid.s
The file was modifiedllvm/lib/Target/Mips/MipsInstrInfo.td
The file was addedllvm/test/MC/Mips/macro-saa.s
Commit 3718102d40d60ba415ac2b2b1108e411838838a5 by simon
[mips] Support `octeon+` CPU in the `.set arch=` directive
Differential Revision: https://reviews.llvm.org/D69850
The file was modifiedllvm/test/MC/Mips/set-arch.s
The file was modifiedllvm/lib/Target/Mips/AsmParser/MipsAsmParser.cpp
Commit bf996f761b99108c71efc84688597b7c3c63139e by simon
[mips] Write `AFL_EXT_OCTEONP` flag to the `.MIPS.abiflags` section
Differential Revision: https://reviews.llvm.org/D69851
The file was modifiedllvm/lib/Target/Mips/MCTargetDesc/MipsABIFlagsSection.h
The file was modifiedllvm/test/MC/Mips/mips_abi_flags_xx.s
Commit 3552d3e0f7c943c3547c0227ddd80fd4d0732a7e by simon
[mips] Add `octeon+` to the list of CPUs accepted by the driver
The file was modifiedclang/test/Driver/mips-abi.c
The file was modifiedclang/test/Misc/target-invalid-cpu-note.c
The file was modifiedclang/lib/Basic/Targets/Mips.cpp
The file was modifiedclang/lib/Basic/Targets/Mips.h
The file was modifiedclang/test/Driver/mips-as.c
The file was modifiedclang/lib/Driver/ToolChains/Gnu.cpp
Commit a751f557d824c569a96051ea5feef1ff32bb4723 by simon
[mips] Set macros for Octeon+ CPU
The file was modifiedclang/test/Preprocessor/init.c
The file was modifiedclang/lib/Basic/Targets/Mips.cpp
Commit 55b445150da9101fda07a4c28ee6a4e4bc9fc89a by lebedev.ri
[NFC][CVP] Add some tests for `sub` with preexisting no-wrap flags
We can use those to further limit the ranges in LVI.
The file was modifiedllvm/test/Transforms/CorrelatedValuePropagation/icmp.ll