FailedChanges

Changes from Git (git http://labmaster3.local/git/llvm-zorg.git)

Summary

  1. Remove LLVM from depset for the libc++ builders. (details)
Commit f296f7da2dd516d86d12a53c98642e7714015ee7 by eric
Remove LLVM from depset for the libc++ builders.
This prevents every LLVM commit from triggering the libc++ buildbots,
which is a waste of resources because the only parts of LLVM that libc++
depends on are the CMake files and LIT harness.
These file change infrequently enough that it seems OK to occasionally
fail to trigger a build when they change.
The file was modifiedzorg/buildbot/builders/LibcxxAndAbiBuilder.py

Changes from Git (git http://labmaster3.local/git/llvm-project.git)

Summary

  1. Keep symbols passed by -init and -fini (details)
  2. [RAGreedy] Enable -consider-local-interval-cost for AArch64 (details)
  3. Revert d91ed80 "[codeview] Reference types in type parent scopes" (details)
  4. [cmake] Enable thin lto cache when building with lld-link (details)
  5. [lldb][NFC] Refactor some IsClangType checks in ClangASTContext (details)
  6. [lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL (details)
  7. Reland: [TII] Use optional destination and source pair as a return (details)
  8. Revert "[compiler-rt] Fix tests after 03b84e4f6d0" (details)
  9. Revert "[clang] Report sanitizer blacklist as a dependency in cc1" (details)
  10. test commit (details)
  11. test commit (details)
  12. Revert "Revert "[clang] Report sanitizer blacklist as a dependency in (details)
  13. Revert "Revert "Revert "[clang] Report sanitizer blacklist as a (details)
  14. Revert "test commit" (details)
  15. Revert "test commit" (details)
  16. [clang-format] update comments in clang-format.py for python3 (details)
  17. BinaryStream - fix static analyzer warnings. NFCI.  - uninitialized (details)
  18. [LV] Apply sink-after & interleave-groups as VPlan transformations (details)
  19. [AMDGPU][MC] Corrected src0 for v_movrelsd_b32 and v_movrelsd_2_b32 (details)
Commit f95273f75aaa5db5493aea7902416ce3d5a09043 by ruiu
Keep symbols passed by -init and -fini
Previously, symbols passed by -init and -fini look as if they are not
referenced by anyone, and the LTO might eliminate them. This patch fixes
the issue.
Fixes a bug reported in https://bugs.llvm.org/show_bug.cgi?id=43927
Differential Revision: https://reviews.llvm.org/D69985
The file was modifiedlld/ELF/Driver.cpp
The file was addedlld/test/ELF/lto/init-fini.ll
Commit f649f24d388c745d20fab5573d27b822b92818ed by Sanne.Wouda
[RAGreedy] Enable -consider-local-interval-cost for AArch64
Summary: The greedy register allocator occasionally decides to insert a
large number of unnecessary copies, see below for an example.  The
-consider-local-interval-cost option (which X86 already enables by
default) fixes this.  We enable this option for AArch64 only after
receiving feedback that this change is not beneficial for PowerPC.
We evaluated the impact of this change on compile time, code size and
performance benchmarks.
This option has a small impact on compile time, measured on CTMark. A
0.1% geomean regression on -O1 and -O2, and 0.2% geomean for -O3, with
at most 0.5% on individual benchmarks.
The effect on both code size and performance on AArch64 for the LLVM
test suite is nil on the geomean with individual outliers (ignoring
short exec_times) between:
                 best     worst
size..text     -3.3%    +0.0%
exec_time      -5.8%    +2.3%
On SPEC CPU® 2017 (compiled for AArch64) there is a minor reduction
(-0.2% at most) in code size on some benchmarks, with a tiny movement
(-0.01%) on the geomean.  Neither intrate nor fprate show any change in
performance.
This patch makes the following changes.
- For the AArch64 target, enableAdvancedRASplitCost() now returns true.
- Ensures that -consider-local-interval-cost=false can disable the new
behaviour if necessary.
This matrix multiply example:
   $ cat test.c
  long A[8][8];
  long B[8][8];
  long C[8][8];
   void run_test() {
    for (int k = 0; k < 8; k++) {
      for (int i = 0; i < 8; i++) {
for (int j = 0; j < 8; j++) {
   C[i][j] += A[i][k] * B[k][j];
}
      }
    }
  }
results in the following generated code on AArch64:
  $ clang --target=aarch64-arm-none-eabi -O3 -S test.c -o -
[...]
                                       // %for.cond1.preheader
                                       // =>This Inner Loop Header:
Depth=1
       add     x14, x11, x9
       str     q0, [sp, #16]           // 16-byte Folded Spill
       ldr     q0, [x14]
       mov     v2.16b, v15.16b
       mov     v15.16b, v14.16b
       mov     v14.16b, v13.16b
       mov     v13.16b, v12.16b
       mov     v12.16b, v11.16b
       mov     v11.16b, v10.16b
       mov     v10.16b, v9.16b
       mov     v9.16b, v8.16b
       mov     v8.16b, v31.16b
       mov     v31.16b, v30.16b
       mov     v30.16b, v29.16b
       mov     v29.16b, v28.16b
       mov     v28.16b, v27.16b
       mov     v27.16b, v26.16b
       mov     v26.16b, v25.16b
       mov     v25.16b, v24.16b
       mov     v24.16b, v23.16b
       mov     v23.16b, v22.16b
       mov     v22.16b, v21.16b
       mov     v21.16b, v20.16b
       mov     v20.16b, v19.16b
       mov     v19.16b, v18.16b
       mov     v18.16b, v17.16b
       mov     v17.16b, v16.16b
       mov     v16.16b, v7.16b
       mov     v7.16b, v6.16b
       mov     v6.16b, v5.16b
       mov     v5.16b, v4.16b
       mov     v4.16b, v3.16b
       mov     v3.16b, v1.16b
       mov     x12, v0.d[1]
       fmov    x15, d0
       ldp     q1, q0, [x14, #16]
       ldur    x1, [x10, #-256]
       ldur    x2, [x10, #-192]
       add     x9, x9, #64             // =64
       mov     x13, v1.d[1]
       fmov    x16, d1
       ldr     q1, [x14, #48]
       mul     x3, x15, x1
       mov     x14, v0.d[1]
       fmov    x17, d0
       mov     x18, v1.d[1]
       fmov    x0, d1
       mov     v1.16b, v3.16b
       mov     v3.16b, v4.16b
       mov     v4.16b, v5.16b
       mov     v5.16b, v6.16b
       mov     v6.16b, v7.16b
       mov     v7.16b, v16.16b
       mov     v16.16b, v17.16b
       mov     v17.16b, v18.16b
       mov     v18.16b, v19.16b
       mov     v19.16b, v20.16b
       mov     v20.16b, v21.16b
       mov     v21.16b, v22.16b
       mov     v22.16b, v23.16b
       mov     v23.16b, v24.16b
       mov     v24.16b, v25.16b
       mov     v25.16b, v26.16b
       mov     v26.16b, v27.16b
       mov     v27.16b, v28.16b
       mov     v28.16b, v29.16b
       mov     v29.16b, v30.16b
       mov     v30.16b, v31.16b
       mov     v31.16b, v8.16b
       mov     v8.16b, v9.16b
       mov     v9.16b, v10.16b
       mov     v10.16b, v11.16b
       mov     v11.16b, v12.16b
       mov     v12.16b, v13.16b
       mov     v13.16b, v14.16b
       mov     v14.16b, v15.16b
       mov     v15.16b, v2.16b
       ldr     q2, [sp]                // 16-byte Folded Reload
       fmov    d0, x3
       mul     x3, x12, x1
[...]
With -consider-local-interval-cost the same section of code results in
the following:
  $ clang --target=aarch64-arm-none-eabi -mllvm
-consider-local-interval-cost -O3 -S test.c -o -
[...]
.LBB0_1:                              // %for.cond1.preheader
                                       // =>This Inner Loop Header:
Depth=1
       add     x14, x11, x9
       ldp     q0, q1, [x14]
       ldur    x1, [x10, #-256]
       ldur    x2, [x10, #-192]
       add     x9, x9, #64             // =64
       mov     x12, v0.d[1]
       fmov    x15, d0
       mov     x13, v1.d[1]
       fmov    x16, d1
       ldp     q0, q1, [x14, #32]
       mul     x3, x15, x1
       cmp     x9, #512                // =512
       mov     x14, v0.d[1]
       fmov    x17, d0
       fmov    d0, x3
       mul     x3, x12, x1
[...]
Reviewers: SjoerdMeijer, samparker, dmgreen, qcolombet
Reviewed By: dmgreen
Subscribers: ZhangKang, jsji, wuzish, ppc-slack, lkail, steven.zhang,
MatzeB, qcolombet, kristof.beyls, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69437
The file was modifiedllvm/lib/CodeGen/RegAllocGreedy.cpp
The file was modifiedllvm/test/CodeGen/AArch64/ragreedy-local-interval-cost.ll
The file was modifiedllvm/lib/Target/AArch64/AArch64Subtarget.h
Commit ff3b513495c04d87799b3c5a98ddcdb6996af4f3 by hans
Revert d91ed80 "[codeview] Reference types in type parent scopes"
This triggered asserts in the Chromium build, see
https://crbug.com/1022729 for details and reproducer.
> Without this change, when a nested tag type of any kind (enum, class,
> struct, union) is used as a variable type, it is emitted without
> emitting the parent type. In CodeView, parent types point to their
inner
> types, and inner types do not point back to their parents. We already
> walk over all of the parent scopes to build the fully qualified name.
> This change simply requests their type indices as we go along to
enusre
> they are all emitted.
>
> Fixes PR43905
>
> Reviewers: akhuang, amccarth
>
> Differential Revision: https://reviews.llvm.org/D69924
The file was modifiedllvm/test/DebugInfo/COFF/global-constants.ll
The file was removedllvm/test/DebugInfo/COFF/parent-type-scopes.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
The file was modifiedllvm/lib/CodeGen/AsmPrinter/CodeViewDebug.h
Commit 0a8bd77e7741b36248c4af73d05f659fb8e4d8a6 by russell.gallop
[cmake] Enable thin lto cache when building with lld-link
This was enabled for other platforms. Added option for Windows/lld-link.
Differential Revision: https://reviews.llvm.org/D69941
The file was modifiedllvm/cmake/modules/HandleLLVMOptions.cmake
Commit 79b3cce7f143ebcbc57a3c4599cbd7a1541a742b by Raphael Isemann
[lldb][NFC] Refactor some IsClangType checks in ClangASTContext
Summary: All type in these functions need be valid and Clang types, so
we might as well replace these checks with IsClangType.
Also lets IsClangType explicitly check for validity instead of assuming
that the TypeSystem is a nullptr.
Subscribers: abidh, JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70001
The file was modifiedlldb/source/Symbol/ClangASTContext.cpp
The file was modifiedlldb/source/Symbol/ClangUtil.cpp
Commit 5a1bac4d1daee2bcbf13365a8254a26d242d8c46 by Raphael Isemann
[lldb] Make Target* a Target& in CommandObjectExpression::DoExecute REPL
logic
Subscribers: JDevlieghere, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70002
The file was modifiedlldb/source/Commands/CommandObjectExpression.cpp
Commit 8d2ccd1ac32ca5c96fc17e265fec5e1fc94a0520 by djordje.todorovic
Reland: [TII] Use optional destination and source pair as a return
value; NFC
Refactor usage of isCopyInstrImpl, isCopyInstr and isAddImmediate
methods to return optional machine operand pair of destination and
source registers.
Patch by Nikola Prica
Differential Revision: https://reviews.llvm.org/D69622
The file was modifiedllvm/lib/Target/ARM/ARMBaseInstrInfo.h
The file was modifiedllvm/lib/CodeGen/TargetInstrInfo.cpp
The file was modifiedllvm/lib/Target/ARM/ARMBaseInstrInfo.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.cpp
The file was modifiedllvm/lib/CodeGen/LiveDebugValues.cpp
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.h
The file was modifiedllvm/include/llvm/CodeGen/TargetInstrInfo.h
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrInfo.h
The file was modifiedllvm/lib/Target/Mips/Mips16InstrInfo.cpp
The file was modifiedllvm/lib/Target/Mips/Mips16InstrInfo.h
The file was modifiedllvm/lib/Target/X86/X86InstrInfo.cpp
The file was modifiedllvm/lib/Target/Mips/MipsSEInstrInfo.h
The file was modifiedllvm/lib/Target/Mips/MipsSEInstrInfo.cpp
Commit d6be9273c6035c07b25dd1494f76cd61d523b878 by jeremy.morse
Revert "[compiler-rt] Fix tests after 03b84e4f6d0"
This reverts commit bdeb2724f0aa9c518f94d998d24d8620a1e88727.
(Reverting 03b84e4f6d0, so this must come out as well)
The file was modifiedcompiler-rt/test/asan/TestCases/default_blacklist.cpp
The file was modifiedcompiler-rt/test/msan/default_blacklist.cpp
Commit 6b45e1bc11e91ea7b57a6ab1c19461a86dba33f8 by jeremy.morse
Revert "[clang] Report sanitizer blacklist as a dependency in cc1"
This reverts commit 03b84e4f6d0e1c04f22d69cc445f36e1f713beb4.
This breaks dfsan tests with a linking failure, in for example this
build:
  http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/24312
Reverting this patch locally makes those tests succeed.
The file was modifiedclang/test/Frontend/dependency-gen.c
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Driver/SanitizerArgs.cpp
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedclang/include/clang/Driver/SanitizerArgs.h
The file was modifiedclang/test/Driver/fsanitize-blacklist.c
Commit b0a03f29d9a2d316d6be99e6a4825114f240c0b2 by abelkocsis
test commit
The file was modifiedclang/README.txt
Commit 3ffce13f8c7ecb21c5729aa358f1f9fc008bbea2 by abelkocsis
test commit
The file was modifiedclang/README.txt
Commit 3182027282c59c51d5080d83365917fccd695854 by abelkocsis
Revert "Revert "[clang] Report sanitizer blacklist as a dependency in
cc1""
This reverts commit 6b45e1bc11e91ea7b57a6ab1c19461a86dba33f8.
The file was modifiedclang/test/Frontend/dependency-gen.c
The file was modifiedclang/test/Driver/fsanitize-blacklist.c
The file was modifiedclang/include/clang/Driver/SanitizerArgs.h
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Driver/SanitizerArgs.cpp
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
Commit 9b8413ac6e56e7a6e0ba884773d13bcf9414bd43 by abelkocsis
Revert "Revert "Revert "[clang] Report sanitizer blacklist as a
dependency in cc1"""
This reverts commit 3182027282c59c51d5080d83365917fccd695854.
The file was modifiedclang/include/clang/Driver/Options.td
The file was modifiedclang/lib/Frontend/CompilerInvocation.cpp
The file was modifiedclang/lib/Driver/SanitizerArgs.cpp
The file was modifiedclang/include/clang/Driver/SanitizerArgs.h
The file was modifiedclang/test/Frontend/dependency-gen.c
The file was modifiedclang/test/Driver/fsanitize-blacklist.c
Commit 9fcf2a38c202efcf7d221173a2b3a484d66c67e8 by abelkocsis
Revert "test commit"
This reverts commit 3ffce13f8c7ecb21c5729aa358f1f9fc008bbea2.
The file was modifiedclang/README.txt
Commit c0a77329d46f3577357645e0aa316174798e54cc by abelkocsis
Revert "test commit"
This reverts commit b0a03f29d9a2d316d6be99e6a4825114f240c0b2.
The file was modifiedclang/README.txt
Commit 6bf9e88ae4a45ee43eef3c7978040d33cead59ce by paulhoad
[clang-format] update comments in clang-format.py for python3
compatibility
Summary: D23319 introduced python3 compatibility to clang-format.py,
this is however not reflected by the documentation in the comments at
the beginning of the file, which show how to use the script with python2
in .vimrc. While the actual mapping a user might want to use may well
differ from my suggestion, I think it's nice to show the python2 and
python3 version, such that a user can pick from the suggestions instead
of googeling the python3 replacement for `:pyf` which they might not be
familiar with.
EDIT: picking reviewers according to
https://llvm.org/docs/Phabricator.html#finding-potential-reviewers
Reviewers: klimek, MyDeveloperDay
Reviewed By: MyDeveloperDay
Subscribers: ilya-biryukov, cfe-commits, llvm-commits, ychen
Patch By: pseyfert
Tags: #clang-tools-extra, #llvm, #clang
Differential Revision: https://reviews.llvm.org/D38446
The file was modifiedclang/tools/clang-format/clang-format.py
Commit ef459dedcafbdfda630c884f788a6b53ee9ee30c by llvm-dev
BinaryStream - fix static analyzer warnings. NFCI.  - uninitialized
variables  - documention warnings  - shadow variable names
The file was modifiedllvm/include/llvm/Support/BinaryStreamReader.h
The file was modifiedllvm/include/llvm/Support/BinaryStreamRef.h
The file was modifiedllvm/include/llvm/Support/BinaryStreamArray.h
The file was modifiedllvm/lib/Support/BinaryStreamReader.cpp
Commit 11ed1c0239fd51fd2f064311dc7725277ed0a994 by gil.rapaport
[LV] Apply sink-after & interleave-groups as VPlan transformations
(NFCI)
This recommits 100e797adb433724a17c9b42b6533cd634cb796b (reverted in
009e032634b3bd7fc32071ac2344b12142286477 for failing an assert). While
the root cause was independently reverted in
eaff3004019f97c64c88ab76da6b25106b659b30, this commit includes a LIT to
make sure IVDescriptor's SinkAfter logic does not try to sink branch
instructions.
The file was modifiedllvm/include/llvm/Analysis/VectorUtils.h
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorize.cpp
The file was modifiedllvm/unittests/Transforms/Vectorize/VPlanTest.cpp
The file was modifiedllvm/lib/Transforms/Vectorize/VPRecipeBuilder.h
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.h
The file was modifiedllvm/lib/Transforms/Vectorize/LoopVectorizationPlanner.h
The file was modifiedllvm/lib/Transforms/Vectorize/VPlan.cpp
The file was modifiedllvm/test/Transforms/LoopVectorize/first-order-recurrence.ll
Commit e25bc5e0247141cb31093a370e22fe3249bdbb05 by dmitry.preobrazhensky
[AMDGPU][MC] Corrected src0 for v_movrelsd_b32 and v_movrelsd_2_b32
See https://bugs.llvm.org/show_bug.cgi?id=40903
Reviewers: arsenm, rampitec
Differential Revision: https://reviews.llvm.org/D69888
The file was modifiedllvm/lib/Target/AMDGPU/VOP1Instructions.td
The file was modifiedllvm/test/MC/AMDGPU/gfx10_asm_all.s
The file was modifiedllvm/test/MC/AMDGPU/vop1.s