SuccessChanges

Summary

  1. [CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header (details)
  2. [LLDB] Fix compilation for MinGW, remove redundant class name on inline (details)
  3. [LLDB] Check for the GCC/MinGW compatible arch defines for windows, in (details)
  4. [LLDB] Use LLVM_FALLTHROUGH instead of a custom comment (details)
  5. [LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style (details)
  6. [LLDB] Cast -1 (as invalid socket) to the socket type before comparing (details)
Commit 1bfdab52a76bf667aa345b5026f1d524ed6d4ac8 by martin
[CodeView] Add pragma push/pop_macro for ARM64_FPSR to enum header
This fixes (one aspect of) compilation of LLDB with MSVC for ARM64.
LLDB source files include intrin.h, and the MSVC intrin.h transitively
includes arm64intr.h, which has an ARM64_FPSR define, which clashes with
the enum declaration.
Differential Revision: https://reviews.llvm.org/D67864
llvm-svn: 372481
The file was modifiedllvm/include/llvm/DebugInfo/CodeView/CodeViewRegisters.def
Commit f4deacf995c73045a2172f35cbaf289fa97e7abc by martin
[LLDB] Fix compilation for MinGW, remove redundant class name on inline
member
This fixes build errors like these:
NativeRegisterContextWindows.h:22:33: error: extra qualification on
member 'NativeRegisterContextWindows'
NativeRegisterContextWindows::NativeRegisterContextWindows(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^
Differential Revision: https://reviews.llvm.org/D67856
llvm-svn: 372482
The file was modifiedlldb/source/Plugins/Process/Windows/Common/NativeRegisterContextWindows.h
Commit 2e25c44dc3fa97defe03e4b5d813344577d6b5fb by martin
[LLDB] Check for the GCC/MinGW compatible arch defines for windows, in
addition to MSVC defines
This matches how it is done in all other similar ifdefs throughout lldb.
Differential Revision: https://reviews.llvm.org/D67858
llvm-svn: 372483
The file was modifiedlldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp
The file was modifiedlldb/source/Plugins/Process/Windows/Common/TargetThreadWindows.cpp
Commit 5c38730dbd002a9f669bf3fb3c0a8b19e84bdd97 by martin
[LLDB] Use LLVM_FALLTHROUGH instead of a custom comment
This fixes a warning when built with Clang in MinGW mode.
Differential Revision: https://reviews.llvm.org/D67860
llvm-svn: 372484
The file was modifiedlldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
Commit ed78dc8e4371b573e3daca3ee6d39231df218918 by martin
[LLDB] Use SetErrorStringWithFormatv for cases that use LLVM style
format strings
SetErrorStringWithFormat only supports normal printf style format
strings.
Differential Revision: https://reviews.llvm.org/D67862
llvm-svn: 372485
The file was modifiedlldb/source/Plugins/Process/Windows/Common/NativeProcessWindows.cpp
The file was modifiedlldb/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
Commit 5534a6750087ef4290c58238337b0dad29397f46 by martin
[LLDB] Cast -1 (as invalid socket) to the socket type before comparing
This silences warnings about comparison of integers between unsigned
long long (which is what the Windows SOCKET type is) and signed int when
building in MinGW mode.
Differential Revision: https://reviews.llvm.org/D67863
llvm-svn: 372486
The file was modifiedlldb/tools/lldb-vscode/lldb-vscode.cpp
The file was modifiedlldb/source/Host/common/Socket.cpp