FailedChanges

Summary

  1. [NFC] Fix name and clarifying comment for factored-out function
  2. [InstCombine] add tests for unsigned saturated add; NFC We're missing IR canonicalizations for this op as shown in D51929.
  3. [NFC] Factor out a function for future reuse
  4. Revert [NFC] Better encapsulation of llvm::Optional Storage I'm getting the feealing that current Optional implementation is full of UB :-/
  5. Revert "[AST] Factor out the logic of the various Expr::Ignore*" This breaks some clang-tidy checks. For some reason they were not included in check-clang ?
  6. [AST] Factor out the logic of the various Expr::Ignore* Now that the implementation of all of the Expr::Ignore* is in Expr.cpp we can try to remove some duplication. Do this by separating the logic of the Expr::Ignore* from the iterative loop. This is NFC, except for one change: IgnoreParenImpCasts now skips, among other things, everything that IgnoreImpCasts skips. This means FullExpr are now skipped by IgnoreParenImpCasts. This was likely an oversight when FullExpr was added to the nodes skipped by IgnoreImpCasts. Differential Revision: https://reviews.llvm.org/D57267 Reviewed By: aaron.ballman (with comments from void and rnk)
  7. [NFC] Better encapsulation of llvm::Optional Storage
  8. [compiler-rt] Build custom libcxx with libcxxabi This changes add_custom_libcxx to also build libcxxabi and merges the two into a static and hermetic library. There are multiple advantages: 1) The resulting libFuzzer doesn't expose C++ internals and looks like a plain C library. 2) We don't have to manually link in libstdc++ to provide cxxabi. 3) The sanitizer tests cannot interfere with an installed version of libc++.so in LD_LIBRARY_PATH. Differential Revision: https://reviews.llvm.org/D58013
Revision 354220 by mkazantsev:
[NFC] Fix name and clarifying comment for factored-out function
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp (diff)llvm.src/lib/Transforms/Scalar/LoopSimplifyCFG.cpp
Revision 354219 by spatel:
[InstCombine] add tests for unsigned saturated add; NFC

We're missing IR canonicalizations for this op as shown in D51929.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/saturating-add-sub.ll (diff)llvm.src/test/Transforms/InstCombine/saturating-add-sub.ll
Revision 354218 by mkazantsev:
[NFC] Factor out a function for future reuse
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp (diff)llvm.src/lib/Transforms/Scalar/LoopSimplifyCFG.cpp
Revision 354217 by serge_sans_paille:
Revert  [NFC] Better encapsulation of llvm::Optional Storage

I'm getting the feealing that current Optional implementation is full of UB :-/
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Optional.h (diff)llvm.src/include/llvm/ADT/Optional.h
Revision 354216 by brunoricci:
Revert "[AST] Factor out the logic of the various Expr::Ignore*"

This breaks some clang-tidy checks. For some reason they were
not included in check-clang ?
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/Expr.h (diff)clang.src/include/clang/AST/Expr.h
The file was modified/cfe/trunk/lib/AST/Expr.cpp (diff)clang.src/lib/AST/Expr.cpp
Revision 354215 by brunoricci:
[AST] Factor out the logic of the various Expr::Ignore*

Now that the implementation of all of the Expr::Ignore* is in Expr.cpp
we can try to remove some duplication. Do this by separating the logic of
the Expr::Ignore* from the iterative loop.

This is NFC, except for one change: IgnoreParenImpCasts now skips, among
other things, everything that IgnoreImpCasts skips. This means FullExpr
are now skipped by IgnoreParenImpCasts. This was likely an oversight when
FullExpr was added to the nodes skipped by IgnoreImpCasts.

Differential Revision: https://reviews.llvm.org/D57267

Reviewed By: aaron.ballman (with comments from void and rnk)
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/AST/Expr.h (diff)clang.src/include/clang/AST/Expr.h
The file was modified/cfe/trunk/lib/AST/Expr.cpp (diff)clang.src/lib/AST/Expr.cpp
Revision 354214 by serge_sans_paille:
[NFC] Better encapsulation of llvm::Optional Storage
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/Optional.h (diff)llvm.src/include/llvm/ADT/Optional.h
Revision 354212 by hahnfeld:
[compiler-rt] Build custom libcxx with libcxxabi

This changes add_custom_libcxx to also build libcxxabi and merges
the two into a static and hermetic library.
There are multiple advantages:
1) The resulting libFuzzer doesn't expose C++ internals and looks
   like a plain C library.
2) We don't have to manually link in libstdc++ to provide cxxabi.
3) The sanitizer tests cannot interfere with an installed version
   of libc++.so in LD_LIBRARY_PATH.

Differential Revision: https://reviews.llvm.org/D58013
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/CMakeLists.txt (diff)compiler-rt.src/CMakeLists.txt
The file was modified/compiler-rt/trunk/cmake/Modules/AddCompilerRT.cmake (diff)compiler-rt.src/cmake/Modules/AddCompilerRT.cmake
The file was added/compiler-rt/trunk/cmake/Modules/CustomLibcxxcompiler-rt.src/cmake/Modules/CustomLibcxx
The file was added/compiler-rt/trunk/cmake/Modules/CustomLibcxx/CMakeLists.txtcompiler-rt.src/cmake/Modules/CustomLibcxx/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/fuzzer/CMakeLists.txt (diff)compiler-rt.src/lib/fuzzer/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/fuzzer/tests/CMakeLists.txt (diff)compiler-rt.src/lib/fuzzer/tests/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/msan/tests/CMakeLists.txt (diff)compiler-rt.src/lib/msan/tests/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/tsan/CMakeLists.txt (diff)compiler-rt.src/lib/tsan/CMakeLists.txt
The file was modified/compiler-rt/trunk/test/fuzzer/lit.cfg (diff)compiler-rt.src/test/fuzzer/lit.cfg
The file was modified/compiler-rt/trunk/test/msan/CMakeLists.txt (diff)compiler-rt.src/test/msan/CMakeLists.txt
The file was modified/compiler-rt/trunk/test/tsan/CMakeLists.txt (diff)compiler-rt.src/test/tsan/CMakeLists.txt
The file was added/compiler-rt/trunk/test/tsan/Linux/check_memcpy.ccompiler-rt.src/test/tsan/Linux/check_memcpy.c
The file was removed/compiler-rt/trunk/test/tsan/Linux/check_memcpy.cccompiler-rt.src/test/tsan/Linux/check_memcpy.cc
The file was modified/compiler-rt/trunk/test/tsan/lit.cfg (diff)compiler-rt.src/test/tsan/lit.cfg
The file was modified/compiler-rt/trunk/test/tsan/static_init6.cc (diff)compiler-rt.src/test/tsan/static_init6.cc
The file was modified/libcxx/trunk/CMakeLists.txt (diff)libcxx.src/CMakeLists.txt
The file was modified/libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmake (diff)libcxx.src/cmake/Modules/HandleLibCXXABI.cmake
The file was modified/libcxxabi/trunk/CMakeLists.txt (diff)N/A