FailedChanges

Summary

  1. [ubsan] nullability-assign: Check assignments into C++ structs Fix the nullability-assign check so that it can handle assignments into C++ structs. Previously, such assignments were not instrumented. Testing: check-clang, check-ubsan, enabling the existing test in ObjC++ mode, and building some Apple frameworks with -fsanitize=nullability.
  2. [unittests/DeLICM] Add test for Written vs Written. The interpretation of multiple known ValInsts for the same element and timepoint is that these are alterntivate names for the same values, for instance a PHINode and the incoming value when knowning it was the last executed block. That means that known values do not conflict if there at least (but necessarily all) one common ValInst. This prinviple also applies to Written values. Add a test for this principle.
  3. [unittests/DeLICM] Add test for Occipied vs Occupied. The interpretation of multiple known ValInsts for the same element and timepoint is that these are alterntivate names for the same values, for instance a PHINode and the incoming value when knowning it was the last executed block. That means that known values do not conflict if there at least (but necessarily all) one common ValInst. Add a case to test this principle.
  4. Merging r292034: (PR32315) Tweaked to not remove the non-const variants as to not change the ABI. ------------------------------------------------------------------------ r292034 | majnemer | 2017-01-14 13:54:58 -0800 (Sat, 14 Jan 2017) | 7 lines Adding const overloads of operator* and operator-> for DenseSet iterators This fixes some problems when building ClangDiagnostics.cpp on Visual Studio 2017 RC. As far as I understand, there was a change in the implementation of the constructor for std::vector with two iterator parameters, which in our case causes an attempt to dereference const Iterator objects. Since there was no overload for a const Iterator, the compile would fail. Patch by Hugo Puhlmann! Differential Revision: https://reviews.llvm.org/D28726 ------------------------------------------------------------------------
  5. Mark two tests (dead-strip.c, initialization-bug.cc) as unsupported on iOS.
  6. [LibCallsShrinkWrap] Remove an unnecessary class member variable.
  7. Do flag compatibility check in checkOptions. NFC.
  8. Factor out code to parse -build-id. NFC.
  9. [LibCallsShrinkWrap] More descriptive assertion messages. Fix a typo while I'm here.
  10. [LibCallsShrinkWrap] Remove some temporary cl::opt(s). The pass has been on and working for a while.
Revision 301482 by Vedant Kumar:
[ubsan] nullability-assign: Check assignments into C++ structs

Fix the nullability-assign check so that it can handle assignments into
C++ structs. Previously, such assignments were not instrumented.

Testing: check-clang, check-ubsan, enabling the existing test in ObjC++
mode, and building some Apple frameworks with -fsanitize=nullability.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGExpr.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGExpr.cpp
The file was added/cfe/trunk/test/CodeGenCXX/ubsan-nullability-assign.cppllvm-revision.src/cfe/trunk/test/CodeGenCXX/ubsan-nullability-assign.cpp
The file was modified/cfe/trunk/test/CodeGenObjC/ubsan-nullability.m (diff)llvm-revision.src/cfe/trunk/test/CodeGenObjC/ubsan-nullability.m
Revision 301481 by meinersbur:
[unittests/DeLICM] Add test for Written vs Written.

The interpretation of multiple known ValInsts for the same element and
timepoint is that these are alterntivate names for the same values,
for instance a PHINode and the incoming value when knowning it was
the last executed block. That means that known values do not conflict
if there at least (but necessarily all) one common ValInst.

This prinviple also applies to Written values. Add a test for this
principle.
Change TypePath in RepositoryPath in Workspace
The file was modified/polly/trunk/unittests/DeLICM/DeLICMTest.cpp (diff)llvm-revision.src/polly/trunk/unittests/DeLICM/DeLICMTest.cpp
Revision 301480 by meinersbur:
[unittests/DeLICM] Add test for Occipied vs Occupied.

The interpretation of multiple known ValInsts for the same element and
timepoint is that these are alterntivate names for the same values,
for instance a PHINode and the incoming value when knowning it was
the last executed block. That means that known values do not conflict
if there at least (but necessarily all) one common ValInst.

Add a case to test this principle.
Change TypePath in RepositoryPath in Workspace
The file was modified/polly/trunk/unittests/DeLICM/DeLICMTest.cpp (diff)llvm-revision.src/polly/trunk/unittests/DeLICM/DeLICMTest.cpp
Revision 301479 by hans:
Merging r292034: (PR32315)

Tweaked to not remove the non-const variants as to not change the ABI.

------------------------------------------------------------------------
r292034 | majnemer | 2017-01-14 13:54:58 -0800 (Sat, 14 Jan 2017) | 7 lines

Adding const overloads of operator* and operator-> for DenseSet iterators

This fixes some problems when building ClangDiagnostics.cpp on Visual Studio 2017 RC. As far as I understand, there was a change in the implementation of the constructor for std::vector with two iterator parameters, which in our case causes an attempt to dereference const Iterator objects. Since there was no overload for a const Iterator, the compile would fail.

Patch by Hugo Puhlmann!

Differential Revision: https://reviews.llvm.org/D28726
------------------------------------------------------------------------
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/branches/release_40 (diff)llvm-revision.src/llvm/branches/release_40
The file was modified/llvm/branches/release_40/include/llvm/ADT/DenseSet.h (diff)llvm-revision.src/llvm/branches/release_40/include/llvm/ADT/DenseSet.h
Revision 301478 by kuba.brecka:
Mark two tests (dead-strip.c, initialization-bug.cc) as unsupported on iOS.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/asan/TestCases/Darwin/dead-strip.c (diff)llvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Darwin/dead-strip.c
The file was modified/compiler-rt/trunk/test/asan/TestCases/initialization-bug.cc (diff)llvm-revision.src/compiler-rt/trunk/test/asan/TestCases/initialization-bug.cc
Revision 301477 by davide:
[LibCallsShrinkWrap] Remove an unnecessary class member variable.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp
Revision 301476 by ruiu:
Do flag compatibility check in checkOptions. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/Driver.cpp (diff)llvm-revision.src/lld/trunk/ELF/Driver.cpp
Revision 301475 by ruiu:
Factor out code to parse -build-id. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/Driver.cpp (diff)llvm-revision.src/lld/trunk/ELF/Driver.cpp
Revision 301474 by davide:
[LibCallsShrinkWrap] More descriptive assertion messages.

Fix a typo while I'm here.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp
Revision 301473 by davide:
[LibCallsShrinkWrap] Remove some temporary cl::opt(s).

The pass has been on and working for a while.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/LibCallsShrinkWrap.cpp