FailedChanges

Summary

  1. Fix comment. NFC
  2. [MC] Fix some Clang-tidy modernize-use-using warnings; other minor fixes (NFC).
  3. Create an OutputSection for each non-empty OutputSectionCommand. We were already pretty close, the one exception was when a name was reused in another SECTIONS directive: SECTIONS { .text : { *(.text) } .data : { *(.data) } } SECTIONS { .data : { *(other) } } In this case we would create a single .data and magically output "other" while looking at the first OutputSectionCommand. We now create two .data sections. This matches what gold does. If we really want to create a single one, we should change the parser so that the above is parsed as if the user had written SECTIONS { .text : { *(.text) } .data : { *(.data) *(other)} } That is, there should be only one OutputSectionCommand for .data and it would have two InputSectionDescriptions. By itself this patch makes the code a bit more complicated, but is an important step in allowing assignAddresses to operate just on the linker script.
  4. Update lldb to match clang r301442. This code really doesn't make any sense: there is only ever one InputKind here. Plus, this is an incomplete and out-of-date copy-paste of some Clang code. This really ought to be revisited, but this change should get the bots green again.
Revision 301486 by George Burgess IV:
Fix comment. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaExpr.cpp (diff)llvm-revision.src/cfe/trunk/lib/Sema/SemaExpr.cpp
Revision 301485 by eugenezelenko:
[MC] Fix some Clang-tidy modernize-use-using warnings; other minor fixes (NFC).
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/MC/ConstantPools.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/ConstantPools.h
The file was modified/llvm/trunk/include/llvm/MC/LaneBitmask.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/LaneBitmask.h
The file was modified/llvm/trunk/include/llvm/MC/MCAssembler.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCAssembler.h
The file was modified/llvm/trunk/include/llvm/MC/MCContext.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCContext.h
The file was modified/llvm/trunk/include/llvm/MC/MCDwarf.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCDwarf.h
The file was modified/llvm/trunk/include/llvm/MC/MCExpr.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCExpr.h
The file was modified/llvm/trunk/include/llvm/MC/MCFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCFragment.h
The file was modified/llvm/trunk/include/llvm/MC/MCInst.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCInst.h
The file was modified/llvm/trunk/include/llvm/MC/MCLinkerOptimizationHint.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCLinkerOptimizationHint.h
The file was modified/llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h
The file was modified/llvm/trunk/include/llvm/MC/MCParser/MCTargetAsmParser.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCParser/MCTargetAsmParser.h
The file was modified/llvm/trunk/include/llvm/MC/MCRegisterInfo.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCRegisterInfo.h
The file was modified/llvm/trunk/include/llvm/MC/MCSection.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCSection.h
The file was modified/llvm/trunk/include/llvm/MC/MCStreamer.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCStreamer.h
The file was modified/llvm/trunk/include/llvm/MC/MCSubtargetInfo.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCSubtargetInfo.h
The file was modified/llvm/trunk/include/llvm/MC/MCSymbol.h (diff)llvm-revision.src/llvm/trunk/include/llvm/MC/MCSymbol.h
The file was modified/llvm/trunk/lib/MC/ELFObjectWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/MC/ELFObjectWriter.cpp
The file was modified/llvm/trunk/lib/MC/StringTableBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/MC/StringTableBuilder.cpp
The file was modified/llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/MC/WinCOFFObjectWriter.cpp
Revision 301484 by rafael:
Create an OutputSection for each non-empty OutputSectionCommand.

We were already pretty close, the one exception was when a name was
reused in another SECTIONS directive:

SECTIONS {
  .text : { *(.text) }
  .data : { *(.data) }
}
SECTIONS {
  .data : { *(other) }
}

In this case we would create a single .data and magically output
"other" while looking at the first OutputSectionCommand.

We now create two .data sections. This matches what gold does. If we
really want to create a single one, we should change the parser so that
the above is parsed as if the user had written

SECTIONS {
  .text : { *(.text) }
  .data : { *(.data) *(other)}
}

That is, there should be only one OutputSectionCommand for .data and
it would have two InputSectionDescriptions.

By itself this patch makes the code a bit more complicated, but is an
important step in allowing assignAddresses to operate just on the
linker script.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/LinkerScript.cpp (diff)llvm-revision.src/lld/trunk/ELF/LinkerScript.cpp
The file was modified/lld/trunk/ELF/OutputSections.cpp (diff)llvm-revision.src/lld/trunk/ELF/OutputSections.cpp
The file was modified/lld/trunk/ELF/OutputSections.h (diff)llvm-revision.src/lld/trunk/ELF/OutputSections.h
The file was modified/lld/trunk/test/ELF/linkerscript/sections.s (diff)llvm-revision.src/lld/trunk/test/ELF/linkerscript/sections.s
Revision 301483 by rsmith:
Update lldb to match clang r301442.

This code really doesn't make any sense: there is only ever one InputKind here.
Plus, this is an incomplete and out-of-date copy-paste of some Clang code. This
really ought to be revisited, but this change should get the bots green again.
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/source/Symbol/ClangASTContext.cpp (diff)llvm-revision.src/lldb/trunk/source/Symbol/ClangASTContext.cpp