FailedChanges

Summary

  1. Specify something that's true in practice
  2. Add references to past LLVM in HPC workshops They'll be another one this year. More information coming...
  3. [ubsan] Make the cast overflow message less redundant
  4. [asan] Fix dead stripping of globals on Linux (compiler-rt). Third attempt. See the description of the corresponding commit in LLVM for more details.
  5. [asan] Fix dead stripping of globals on Linux. Use a combination of !associated, comdat, @llvm.compiler.used and custom sections to allow dead stripping of globals and their asan metadata. Sometimes. Currently this works on LLD, which supports SHF_LINK_ORDER with sh_link pointing to the associated section. This also works on BFD, which seems to treat comdats as all-or-nothing with respect to linker GC. There is a weird quirk where the "first" global in each link is never GC-ed because of the section symbols. At this moment it does not work on Gold (as in the globals are never stripped). This is a second re-land of r298158. This time, this feature is limited to -fdata-sections builds.
  6. [asan] Put ctor/dtor in comdat. When possible, put ASan ctor/dtor in comdat. The only reason not to is global registration, which can be TU-specific. This is not the case when there are no instrumented globals. This is also limited to ELF targets, because MachO does not have comdat, and COFF linkers may GC comdat constructors. The benefit of this is a lot less __asan_init() calls: one per DSO instead of one per TU. It's also necessary for the upcoming gc-sections-for-globals change on Linux, where multiple references to section start symbols trigger quadratic behaviour in gold linker. This is a second re-land of r298756. This time with a flag to disable the whole thing to avoid a bug in the gold linker: https://sourceware.org/bugzilla/show_bug.cgi?id=19002
  7. libclang: remove unused variable.
  8. [scudo] Move thread local variables into their own files Summary: This change introduces scudo_tls.h & scudo_tls_linux.cpp, where we move the thread local variables used by the allocator, namely the cache, quarantine cache & prng. `ScudoThreadContext` will hold those. This patch doesn't introduce any new platform support yet, this will be the object of a later patch. This also changes the PRNG so that the structure can be POD. Reviewers: kcc, dvyukov, alekseyshl Reviewed By: dvyukov, alekseyshl Subscribers: llvm-commits, mgorny Differential Revision: https://reviews.llvm.org/D32440
  9. [X86][SSE] Add tests for broadcast from larger vector loads
Revision 301591 by sanjoy:
Specify something that's true in practice
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/StackMaps.rst (diff)llvm-revision.src/llvm/trunk/docs/StackMaps.rst
Revision 301590 by hfinkel:
Add references to past LLVM in HPC workshops

They'll be another one this year. More information coming...
Change TypePath in RepositoryPath in Workspace
The file was modified/www/trunk/devmtg/index.html (diff)llvm-revision.src/www/trunk/devmtg/index.html
Revision 301589 by Vedant Kumar:
[ubsan] Make the cast overflow message less redundant
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc (diff)llvm-revision.src/compiler-rt/trunk/lib/ubsan/ubsan_handlers.cc
The file was modified/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp (diff)llvm-revision.src/compiler-rt/trunk/test/ubsan/TestCases/Float/cast-overflow.cpp
The file was modified/compiler-rt/trunk/test/ubsan/TestCases/Misc/log-path_test.cc (diff)llvm-revision.src/compiler-rt/trunk/test/ubsan/TestCases/Misc/log-path_test.cc
Revision 301588 by eugenis:
[asan] Fix dead stripping of globals on Linux (compiler-rt).

Third attempt. See the description of the corresponding commit in
LLVM for more details.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/asan/asan_globals.cc (diff)llvm-revision.src/compiler-rt/trunk/lib/asan/asan_globals.cc
The file was modified/compiler-rt/trunk/lib/asan/asan_interface.inc (diff)llvm-revision.src/compiler-rt/trunk/lib/asan/asan_interface.inc
The file was modified/compiler-rt/trunk/lib/asan/asan_interface_internal.h (diff)llvm-revision.src/compiler-rt/trunk/lib/asan/asan_interface_internal.h
The file was modified/compiler-rt/trunk/test/asan/CMakeLists.txt (diff)llvm-revision.src/compiler-rt/trunk/test/asan/CMakeLists.txt
The file was added/compiler-rt/trunk/test/asan/TestCases/Linux/global-overflow-bfd.ccllvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Linux/global-overflow-bfd.cc
The file was added/compiler-rt/trunk/test/asan/TestCases/Linux/global-overflow-lld.ccllvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Linux/global-overflow-lld.cc
The file was added/compiler-rt/trunk/test/asan/TestCases/Linux/globals-gc-sections-lld.ccllvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Linux/globals-gc-sections-lld.cc
The file was removed/compiler-rt/trunk/test/asan/TestCases/Linux/globals-gc-sections.ccllvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Linux/globals-gc-sections.cc
Revision 301587 by eugenis:
[asan] Fix dead stripping of globals on Linux.

Use a combination of !associated, comdat, @llvm.compiler.used and
custom sections to allow dead stripping of globals and their asan
metadata. Sometimes.

Currently this works on LLD, which supports SHF_LINK_ORDER with
sh_link pointing to the associated section.

This also works on BFD, which seems to treat comdats as
all-or-nothing with respect to linker GC. There is a weird quirk
where the "first" global in each link is never GC-ed because of the
section symbols.

At this moment it does not work on Gold (as in the globals are never
stripped).

This is a second re-land of r298158. This time, this feature is
limited to -fdata-sections builds.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/ModuleUtils.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Utils/ModuleUtils.h
The file was modified/llvm/trunk/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/IPO/ThinLTOBitcodeWriter.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/ModuleUtils.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/ModuleUtils.cpp
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata.ll
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata_darwin.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata_darwin.ll
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata_windows.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/global_metadata_windows.ll
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/instrument_global.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/instrument_global.ll
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/no-globals.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/no-globals.ll
Revision 301586 by eugenis:
[asan] Put ctor/dtor in comdat.

When possible, put ASan ctor/dtor in comdat.

The only reason not to is global registration, which can be
TU-specific. This is not the case when there are no instrumented
globals. This is also limited to ELF targets, because MachO does
not have comdat, and COFF linkers may GC comdat constructors.

The benefit of this is a lot less __asan_init() calls: one per DSO
instead of one per TU. It's also necessary for the upcoming
gc-sections-for-globals change on Linux, where multiple references to
section start symbols trigger quadratic behaviour in gold linker.

This is a second re-land of r298756. This time with a flag to disable
the whole thing to avoid a bug in the gold linker:
  https://sourceware.org/bugzilla/show_bug.cgi?id=19002
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
The file was modified/llvm/trunk/test/Instrumentation/AddressSanitizer/instrument_global.ll (diff)llvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/instrument_global.ll
The file was added/llvm/trunk/test/Instrumentation/AddressSanitizer/no-globals.llllvm-revision.src/llvm/trunk/test/Instrumentation/AddressSanitizer/no-globals.ll
Revision 301585 by Tim Northover:
libclang: remove unused variable.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/tools/libclang/CXCursor.cpp (diff)llvm-revision.src/cfe/trunk/tools/libclang/CXCursor.cpp
Revision 301584 by cryptoad:
[scudo] Move thread local variables into their own files

Summary:
This change introduces scudo_tls.h & scudo_tls_linux.cpp, where we move the
thread local variables used by the allocator, namely the cache, quarantine
cache & prng. `ScudoThreadContext` will hold those. This patch doesn't
introduce any new platform support yet, this will be the object of a later
patch. This also changes the PRNG so that the structure can be POD.

Reviewers: kcc, dvyukov, alekseyshl

Reviewed By: dvyukov, alekseyshl

Subscribers: llvm-commits, mgorny

Differential Revision: https://reviews.llvm.org/D32440
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/scudo/CMakeLists.txt (diff)llvm-revision.src/compiler-rt/trunk/lib/scudo/CMakeLists.txt
The file was modified/compiler-rt/trunk/lib/scudo/scudo_allocator.cpp (diff)llvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_allocator.cpp
The file was modified/compiler-rt/trunk/lib/scudo/scudo_allocator.h (diff)llvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_allocator.h
The file was added/compiler-rt/trunk/lib/scudo/scudo_tls.hllvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_tls.h
The file was added/compiler-rt/trunk/lib/scudo/scudo_tls_linux.cppllvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_tls_linux.cpp
The file was added/compiler-rt/trunk/lib/scudo/scudo_tls_linux.hllvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_tls_linux.h
The file was modified/compiler-rt/trunk/lib/scudo/scudo_utils.cpp (diff)llvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_utils.cpp
The file was modified/compiler-rt/trunk/lib/scudo/scudo_utils.h (diff)llvm-revision.src/compiler-rt/trunk/lib/scudo/scudo_utils.h
Revision 301583 by rksimon:
[X86][SSE] Add tests for broadcast from larger vector loads
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/widened-broadcast.ll (diff)llvm-revision.src/llvm/trunk/test/CodeGen/X86/widened-broadcast.ll