FailedChanges

Summary

  1. [InstCombine] add tests to show potentially bogus application of DeMorgan (NFC)
  2. Remove set but unused variable in BitcodeReader.cpp. NFC.
  3. Revert r301697 "[IR] Make add/remove Attributes use AttrBuilder instead of AttributeList" This broke the Clang build. (Clang-side patch missing?) Original commit message: > [IR] Make add/remove Attributes use AttrBuilder instead of > AttributeList > > This change cleans up call sites and avoids creating temporary > AttributeList objects. > > NFC
  4. InferAddressSpaces: Search constant expressions for addrspacecasts These are pretty common when using local memory, and the 64-bit generic addressing is much more expensive to compute.
  5. Eliminate .debug_gnu_pub{names,types} if -gdb-index is given. This patch is to ignore .debug_gnu_pub{names,types} sections if the -gdb-index option was given. Differential Revision: https://reviews.llvm.org/D32662
  6. Revert r301678: Remove LinkerScript::flush. This reverts commit r301678 since that change significantly slowed down the linker. Before this patch, LLD could link clang in 8 seconds, but with this patch it took 40 seconds.
  7. Added new slave for builder clang-lld-x86_64-2stage.
  8. Adapt to LLVM API change (DINamespace no longer takes line/file info). rdar://problem/17484998 https://reviews.llvm.org/D32648
  9. Remove line and file from DINamespace. Fixes the issue highlighted in http://lists.llvm.org/pipermail/cfe-dev/2014-June/037500.html. The DW_AT_decl_file and DW_AT_decl_line attributes on namespaces can prevent LLVM from uniquing types that are in the same namespace. They also don't carry any meaningful information. rdar://problem/17484998 Differential Revision: https://reviews.llvm.org/D32648
  10. InferAddressSpaces: Avoid looking up deleted values While looking at pure addressing expressions, it's possible for the value to appear later in Postorder. I haven't been able to come up with a testcase where this exhibits an actual issue, but if you insert a dump before the value map lookup, a few testcases crash.
  11. InferAddressSpaces: Infer from just addrspacecasts Eliminates some more cases where some subset of the addressing computation remains flat. Some cases with addrspacecasts in nested constant expressions are still left behind however.
  12. [SCEV] Use early exit in createAddRecFromPHI. NFC.
  13. LoopRotate: Fix use after scope bug
  14. [ODRHash] Add testcase with different paramter names. NFC
  15. [RDF] Correctly calculate lane masks for defs
  16. Properly handle PHIs with subregisters in UnreachableBlockElim When a PHI operand has a subregister, create a COPY instead of simply replacing the PHI output with the input it. Differential Revision: https://reviews.llvm.org/D32650
  17. [Hexagon] Do not move a block if it is on a fall-through path
  18. [IR] Make add/remove Attributes use AttrBuilder instead of AttributeList This change cleans up call sites and avoids creating temporary AttributeList objects. NFC
  19. [ConstantRange] Use APInt::isNullValue rather than APInt::isMinValue where it would make more sense to thing of 0 as 0 rather than the minimum unsigned value. NFC
  20. [APInt] Add an isNullValue method to check for all bits being zero. Use it in a couple internal methods where it makes more sense than isMinValue or !getBoolValue. NFC I used Null rather than Zero to match the getNullValue method name. There are some other places outside APInt where isNullValue would be more readable than isMinValue even though they do the same thing. I'll update those in future patches.
  21. [ConstantRange] Use const references to prevent a couple APInt copies. NFC
Revision 301714 by spatel:
[InstCombine] add tests to show potentially bogus application of DeMorgan (NFC)
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/InstCombine/and-or.ll (diff)llvm-revision.src/llvm/trunk/test/Transforms/InstCombine/and-or.ll
Revision 301713 by hans:
Remove set but unused variable in BitcodeReader.cpp. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Reader/BitcodeReader.cpp
Revision 301712 by hans:
Revert r301697 "[IR] Make add/remove Attributes use AttrBuilder instead of AttributeList"

This broke the Clang build. (Clang-side patch missing?)

Original commit message:

> [IR] Make add/remove Attributes use AttrBuilder instead of
> AttributeList
>
> This change cleans up call sites and avoids creating temporary
> AttributeList objects.
>
> NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/CommandFlags.h (diff)llvm-revision.src/llvm/trunk/include/llvm/CodeGen/CommandFlags.h
The file was modified/llvm/trunk/include/llvm/IR/Attributes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Attributes.h
The file was modified/llvm/trunk/include/llvm/IR/Function.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Function.h
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp
The file was modified/llvm/trunk/lib/IR/Attributes.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Attributes.cpp
The file was modified/llvm/trunk/lib/IR/Function.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Function.cpp
The file was modified/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
The file was modified/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
The file was modified/llvm/trunk/unittests/IR/AttributesTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/AttributesTest.cpp
Revision 301711 by arsenm:
InferAddressSpaces: Search constant expressions for addrspacecasts

These are pretty common when using local memory, and the 64-bit generic
addressing is much more expensive to compute.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp
The file was modified/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-getelementptr.ll (diff)llvm-revision.src/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-getelementptr.ll
The file was modified/llvm/trunk/test/Transforms/InferAddressSpaces/NVPTX/bug31948.ll (diff)llvm-revision.src/llvm/trunk/test/Transforms/InferAddressSpaces/NVPTX/bug31948.ll
Revision 301710 by ruiu:
Eliminate .debug_gnu_pub{names,types} if -gdb-index is given.

This patch is to ignore .debug_gnu_pub{names,types} sections if the
-gdb-index option was given.

Differential Revision: https://reviews.llvm.org/D32662
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/InputFiles.cpp (diff)llvm-revision.src/lld/trunk/ELF/InputFiles.cpp
The file was added/lld/trunk/test/ELF/debug-gnu-pubnames.sllvm-revision.src/lld/trunk/test/ELF/debug-gnu-pubnames.s
Revision 301709 by ruiu:
Revert r301678: Remove LinkerScript::flush.

This reverts commit r301678 since that change significantly slowed
down the linker. Before this patch, LLD could link clang in 8 seconds,
but with this patch it took 40 seconds.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/LinkerScript.cpp (diff)llvm-revision.src/lld/trunk/ELF/LinkerScript.cpp
The file was modified/lld/trunk/ELF/LinkerScript.h (diff)llvm-revision.src/lld/trunk/ELF/LinkerScript.h
The file was modified/lld/trunk/ELF/Writer.cpp (diff)llvm-revision.src/lld/trunk/ELF/Writer.cpp
Revision 301708 by gkistanova:
Added new slave for builder clang-lld-x86_64-2stage.
Change TypePath in RepositoryPath in Workspace
The file was modified/zorg/trunk/buildbot/osuosl/master/config/builders.py (diff)llvm-revision.src/zorg/trunk/buildbot/osuosl/master/config/builders.py
The file was modified/zorg/trunk/buildbot/osuosl/master/config/slaves.py (diff)llvm-revision.src/zorg/trunk/buildbot/osuosl/master/config/slaves.py
Revision 301707 by Adrian Prantl:
Adapt to LLVM API change (DINamespace no longer takes line/file info).

rdar://problem/17484998
https://reviews.llvm.org/D32648
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGDebugInfo.cpp
The file was modified/cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp (diff)llvm-revision.src/cfe/trunk/test/CodeGenCXX/debug-info-namespace.cpp
The file was modified/cfe/trunk/test/Modules/ExtDebugInfo.cpp (diff)llvm-revision.src/cfe/trunk/test/Modules/ExtDebugInfo.cpp
Revision 301706 by Adrian Prantl:
Remove line and file from DINamespace.

Fixes the issue highlighted in
http://lists.llvm.org/pipermail/cfe-dev/2014-June/037500.html.

The DW_AT_decl_file and DW_AT_decl_line attributes on namespaces can
prevent LLVM from uniquing types that are in the same namespace. They
also don't carry any meaningful information.

rdar://problem/17484998
Differential Revision: https://reviews.llvm.org/D32648
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/DIBuilder.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/DIBuilder.h
The file was modified/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h
The file was modified/llvm/trunk/lib/AsmParser/LLParser.cpp (diff)llvm-revision.src/llvm/trunk/lib/AsmParser/LLParser.cpp
The file was modified/llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Reader/MetadataLoader.cpp
The file was modified/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Writer/BitcodeWriter.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.h
The file was modified/llvm/trunk/lib/IR/AsmWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/AsmWriter.cpp
The file was modified/llvm/trunk/lib/IR/DIBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/DIBuilder.cpp
The file was modified/llvm/trunk/lib/IR/DebugInfoMetadata.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/DebugInfoMetadata.cpp
The file was modified/llvm/trunk/lib/IR/LLVMContextImpl.h (diff)llvm-revision.src/llvm/trunk/lib/IR/LLVMContextImpl.h
The file was modified/llvm/trunk/test/Assembler/dinamespace.ll (diff)llvm-revision.src/llvm/trunk/test/Assembler/dinamespace.ll
The file was modified/llvm/trunk/test/Bitcode/DINamespace.ll (diff)llvm-revision.src/llvm/trunk/test/Bitcode/DINamespace.ll
The file was modified/llvm/trunk/test/CodeGen/X86/stack-protector-dbginfo.ll (diff)llvm-revision.src/llvm/trunk/test/CodeGen/X86/stack-protector-dbginfo.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/cpp-mangling.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/COFF/cpp-mangling.ll
The file was modified/llvm/trunk/test/DebugInfo/COFF/scopes.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/COFF/scopes.ll
The file was modified/llvm/trunk/test/DebugInfo/Generic/dwarf-public-names.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/Generic/dwarf-public-names.ll
The file was modified/llvm/trunk/test/DebugInfo/Generic/namespace.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/Generic/namespace.ll
The file was modified/llvm/trunk/test/DebugInfo/Generic/namespace_function_definition.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/Generic/namespace_function_definition.ll
The file was modified/llvm/trunk/test/DebugInfo/Generic/namespace_inline_function_definition.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/Generic/namespace_inline_function_definition.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/dwarf-linkage-names.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/dwarf-linkage-names.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/dwarf-public-names.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/generate-odr-hash.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/gnu-public-names-tu.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/gnu-public-names-tu.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/gnu-public-names.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/gnu-public-names.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/inline-namespace.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/inline-namespace.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/lexical-block-file-inline.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/lexical-block-file-inline.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/multiple-at-const-val.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/multiple-at-const-val.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/parameters.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/parameters.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/pr19307.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/pr19307.ll
The file was modified/llvm/trunk/test/DebugInfo/X86/union-template.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/union-template.ll
The file was modified/llvm/trunk/test/Linker/2011-08-18-unique-class-type.ll (diff)llvm-revision.src/llvm/trunk/test/Linker/2011-08-18-unique-class-type.ll
The file was modified/llvm/trunk/test/Linker/2011-08-18-unique-class-type2.ll (diff)llvm-revision.src/llvm/trunk/test/Linker/2011-08-18-unique-class-type2.ll
The file was modified/llvm/trunk/test/Linker/pr26037.ll (diff)llvm-revision.src/llvm/trunk/test/Linker/pr26037.ll
The file was modified/llvm/trunk/test/ThinLTO/X86/debuginfo-cu-import.ll (diff)llvm-revision.src/llvm/trunk/test/ThinLTO/X86/debuginfo-cu-import.ll
The file was modified/llvm/trunk/unittests/IR/MetadataTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/MetadataTest.cpp
Revision 301705 by arsenm:
InferAddressSpaces: Avoid looking up deleted values

While looking at pure addressing expressions, it's possible
for the value to appear later in Postorder.

I haven't been able to come up with a testcase where this
exhibits an actual issue, but if you insert a dump before
the value map lookup, a few testcases crash.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp
Revision 301704 by arsenm:
InferAddressSpaces: Infer from just addrspacecasts

Eliminates some more cases where some subset of the addressing
computation remains flat. Some cases with addrspacecasts
in nested constant expressions are still left behind however.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp
The file was added/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-addrspacecast.llllvm-revision.src/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-addrspacecast.ll
The file was modified/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-getelementptr.ll (diff)llvm-revision.src/llvm/trunk/test/Transforms/InferAddressSpaces/AMDGPU/infer-getelementptr.ll
Revision 301703 by Michael Zolotukhin:
[SCEV] Use early exit in createAddRecFromPHI. NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ScalarEvolution.cpp (diff)llvm-revision.src/llvm/trunk/lib/Analysis/ScalarEvolution.cpp
Revision 301702 by dannyb:
LoopRotate: Fix use after scope bug
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopRotation.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopRotation.cpp
Revision 301701 by rtrieu:
[ODRHash] Add testcase with different paramter names.  NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/Modules/odr_hash.cpp (diff)llvm-revision.src/cfe/trunk/test/Modules/odr_hash.cpp
Revision 301700 by kparzysz:
[RDF] Correctly calculate lane masks for defs
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Hexagon/RDFLiveness.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/Hexagon/RDFLiveness.cpp
The file was added/llvm/trunk/test/CodeGen/Hexagon/rdf-def-mask.llllvm-revision.src/llvm/trunk/test/CodeGen/Hexagon/rdf-def-mask.ll
Revision 301699 by kparzysz:
Properly handle PHIs with subregisters in UnreachableBlockElim

When a PHI operand has a subregister, create a COPY instead of simply
replacing the PHI output with the input it.

Differential Revision: https://reviews.llvm.org/D32650
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/CodeGen/UnreachableBlockElim.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/UnreachableBlockElim.cpp
The file was added/llvm/trunk/test/CodeGen/Hexagon/unreachable-mbb-phi-subreg.mirllvm-revision.src/llvm/trunk/test/CodeGen/Hexagon/unreachable-mbb-phi-subreg.mir
Revision 301698 by kparzysz:
[Hexagon] Do not move a block if it is on a fall-through path
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/Hexagon/HexagonCFGOptimizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/Hexagon/HexagonCFGOptimizer.cpp
The file was added/llvm/trunk/test/CodeGen/Hexagon/cfgopt-fall-through.llllvm-revision.src/llvm/trunk/test/CodeGen/Hexagon/cfgopt-fall-through.ll
Revision 301697 by rnk:
[IR] Make add/remove Attributes use AttrBuilder instead of AttributeList

This change cleans up call sites and avoids creating temporary
AttributeList objects.

NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/CommandFlags.h (diff)llvm-revision.src/llvm/trunk/include/llvm/CodeGen/CommandFlags.h
The file was modified/llvm/trunk/include/llvm/IR/Attributes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Attributes.h
The file was modified/llvm/trunk/include/llvm/IR/Function.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Function.h
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp
The file was modified/llvm/trunk/lib/IR/Attributes.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Attributes.cpp
The file was modified/llvm/trunk/lib/IR/Function.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Function.cpp
The file was modified/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/Mips/Mips16HardFloat.cpp
The file was modified/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/MemorySanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
The file was modified/llvm/trunk/unittests/IR/AttributesTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/AttributesTest.cpp
Revision 301696 by ctopper:
[ConstantRange] Use APInt::isNullValue rather than APInt::isMinValue where it would make more sense to thing of 0 as 0 rather than the minimum unsigned value. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/IR/ConstantRange.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/ConstantRange.cpp
Revision 301695 by ctopper:
[APInt] Add an isNullValue method to check for all bits being zero. Use it in a couple internal methods where it makes more sense than isMinValue or !getBoolValue. NFC

I used Null rather than Zero to match the getNullValue method name.

There are some other places outside APInt where isNullValue would be more readable than isMinValue even though they do the same thing. I'll update those in future patches.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/APInt.h (diff)llvm-revision.src/llvm/trunk/include/llvm/ADT/APInt.h
Revision 301694 by ctopper:
[ConstantRange] Use const references to prevent a couple APInt copies. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/IR/ConstantRange.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/ConstantRange.cpp