FailedChanges

Summary

  1. [LoopUnswitch] Don't remove instructions with side effects. This fixes PR32818. Differential Revision: https://reviews.llvm.org/D32664
  2. ObjCBoxedExpr can't be evaluated by the constant expression evaluator. A boxed expression evaluates its subexpr and then calls an objc method to transform it into another value with pointer type. The objc method can never be constexpr and therefore this expression can never be evaluated. Fixes a miscompile boxing expressions with side-effects. Also make ObjCBoxedExpr handling a normal part of the expression evaluator instead of being the only case besides full-expression where we check for integer overflow.
  3. [llvm-readobj] Fix incorrect printing of CV column info.
  4. Fuzzer: Mark test/cxxstring.test UNSUPPORTED: windows This has been mysteriously failing since r301593, which cleaned up the types of things like size_t and SIZE_MAX for freestanding targets. Reid and Kostya suggested marking it as UNSUPPORTED on windows, given that no one has been able to reproduce locally.
  5. [llvm-readobj] Use LLVMDebugInfoCodeView to parse line tables. The llvm-readobj parsing code currently exists in our CodeView library, so we use that to parse instead of re-writing the logic in the tool.
  6. Win snapshot: r301646.
  7. [Support] Provide unsafe random access for VarStreamArray.
  8. Replace PrettyPrinter class in MapFile.cpp with a few non-member functions. Since the output format has been simplified, the class to print out a map file doesn't seem to be needed anymore. We can replace it with a few non-member functions.
Revision 301722 by davide:
[LoopUnswitch] Don't remove instructions with side effects.

This fixes PR32818.

Differential Revision:  https://reviews.llvm.org/D32664
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
The file was added/llvm/trunk/test/Transforms/LoopUnswitch/pr32818.llllvm-revision.src/llvm/trunk/test/Transforms/LoopUnswitch/pr32818.ll
Revision 301721 by nicholas:
ObjCBoxedExpr can't be evaluated by the constant expression evaluator.

A boxed expression evaluates its subexpr and then calls an objc method to transform it into another value with pointer type. The objc method can never be constexpr and therefore this expression can never be evaluated. Fixes a miscompile boxing expressions with side-effects.

Also make ObjCBoxedExpr handling a normal part of the expression evaluator instead of being the only case besides full-expression where we check for integer overflow.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ExprConstant.cpp (diff)llvm-revision.src/cfe/trunk/lib/AST/ExprConstant.cpp
The file was modified/cfe/trunk/lib/Sema/SemaChecking.cpp (diff)llvm-revision.src/cfe/trunk/lib/Sema/SemaChecking.cpp
The file was modified/cfe/trunk/lib/Sema/SemaExprObjC.cpp (diff)llvm-revision.src/cfe/trunk/lib/Sema/SemaExprObjC.cpp
The file was added/cfe/trunk/test/CodeGenObjCXX/boxing.mmllvm-revision.src/cfe/trunk/test/CodeGenObjCXX/boxing.mm
Revision 301720 by zturner:
[llvm-readobj] Fix incorrect printing of CV column info.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
Revision 301719 by Duncan P. N. Exon Smith:
Fuzzer: Mark test/cxxstring.test UNSUPPORTED: windows

This has been mysteriously failing since r301593, which cleaned up the
types of things like size_t and SIZE_MAX for freestanding targets.  Reid
and Kostya suggested marking it as UNSUPPORTED on windows, given that no
one has been able to reproduce locally.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Fuzzer/test/cxxstring.test (diff)llvm-revision.src/llvm/trunk/lib/Fuzzer/test/cxxstring.test
Revision 301718 by zturner:
[llvm-readobj] Use LLVMDebugInfoCodeView to parse line tables.

The llvm-readobj parsing code currently exists in our CodeView
library, so we use that to parse instead of re-writing the logic
in the tool.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/ModuleDebugStream.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
Revision 301717 by hans:
Win snapshot: r301646.
Change TypePath in RepositoryPath in Workspace
The file was modified/www/trunk/builds/index.html (diff)llvm-revision.src/www/trunk/builds/index.html
Revision 301716 by zturner:
[Support] Provide unsafe random access for VarStreamArray.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Support/BinaryStreamArray.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/BinaryStreamArray.h
Revision 301715 by ruiu:
Replace PrettyPrinter class in MapFile.cpp with a few non-member functions.

Since the output format has been simplified, the class to print
out a map file doesn't seem to be needed anymore. We can replace
it with a few non-member functions.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/ELF/MapFile.cpp (diff)llvm-revision.src/lld/trunk/ELF/MapFile.cpp