FailedChanges

Summary

  1. X86: initialize a few subtarget variables. Otherwise an indeterminate value gets read, causing a bunch of UBSan failures.
  2. Add a blank line as a test-commit. Per http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
  3. Use a 2 bit pointer in ValueHandleBase::PrevPair; NFC This was an omission in r301813. I had made the supporting changes to make this happen, but I forgot to actually update the PrevPair declaration.
  4. Take indirect branch into account as well when folding. We may not be able to rewrite indirect branch target, but we also want to take it into account when folding, i.e. if it and all its successor's predecessors go to the same destination, we can fold, i.e. no need to thread.
  5. Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC
  6. Use WeakVH instead of WeakTrackingVH in AliasSetTracker's UnkownInsts In cases where an instruction (a call site, say) is RAUW'ed with some other value (this is possible via the `returned` attribute, for instance), we want the slot in UnknownInsts to point to the original Instruction we wanted to track, not the value it got replaced by. Fixes PR32587. This relands r301426.
  7. Add a new WeakVH value handle; NFC This relands r301425.
  8. Rename WeakVH to WeakTrackingVH; NFC This relands r301424.
Revision 301819 by Tim Northover:
X86: initialize a few subtarget variables.

Otherwise an indeterminate value gets read, causing a bunch of UBSan failures.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Subtarget.cpp
Revision 301818 by saugustine:
Add a blank line as a test-commit.

Per http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/builtins/assembly.h (diff)llvm-revision.src/compiler-rt/trunk/lib/builtins/assembly.h
Revision 301817 by sanjoy:
Use a 2 bit pointer in ValueHandleBase::PrevPair; NFC

This was an omission in r301813.  I had made the supporting changes to
make this happen, but I forgot to actually update the PrevPair
declaration.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/ValueHandle.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ValueHandle.h
Revision 301816 by trentxintong:
Take indirect branch into account as well when folding.

We may not be able to rewrite indirect branch target, but we also want to take it into
account when folding, i.e. if it and all its successor's predecessors go to the same
destination, we can fold, i.e. no need to thread.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/JumpThreading.cpp
The file was modified/llvm/trunk/test/Transforms/JumpThreading/fold-not-thread.ll (diff)llvm-revision.src/llvm/trunk/test/Transforms/JumpThreading/fold-not-thread.ll
Revision 301815 by sanjoy:
Adapt to LLVM's rename of WeakVH to WeakTrackingVH; NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGDeclCXX.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGDeclCXX.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGObjCMac.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGObjCMac.cpp
The file was modified/cfe/trunk/lib/CodeGen/CodeGenFunction.h (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CodeGenFunction.h
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CodeGenModule.cpp
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.h (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CodeGenModule.h
Revision 301814 by sanjoy:
Use WeakVH instead of WeakTrackingVH in AliasSetTracker's UnkownInsts

In cases where an instruction (a call site, say) is RAUW'ed with some
other value (this is possible via the `returned` attribute, for
instance), we want the slot in UnknownInsts to point to the original
Instruction we wanted to track, not the value it got replaced by.

Fixes PR32587.

This relands r301426.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/AliasSetTracker.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/AliasSetTracker.h
The file was added/llvm/trunk/test/Analysis/AliasSet/unknown-inst-tracking.llllvm-revision.src/llvm/trunk/test/Analysis/AliasSet/unknown-inst-tracking.ll
Revision 301813 by sanjoy:
Add a new WeakVH value handle; NFC

This relands r301425.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/ValueHandle.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ValueHandle.h
The file was modified/llvm/trunk/lib/IR/Value.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Value.cpp
The file was modified/llvm/trunk/unittests/IR/ValueHandleTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/ValueHandleTest.cpp
Revision 301812 by sanjoy:
Rename WeakVH to WeakTrackingVH; NFC

This relands r301424.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Analysis/AliasSetTracker.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/AliasSetTracker.h
The file was modified/llvm/trunk/include/llvm/Analysis/AssumptionCache.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/AssumptionCache.h
The file was modified/llvm/trunk/include/llvm/Analysis/CGSCCPassManager.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/CGSCCPassManager.h
The file was modified/llvm/trunk/include/llvm/Analysis/CallGraph.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/CallGraph.h
The file was modified/llvm/trunk/include/llvm/Analysis/IVUsers.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/IVUsers.h
The file was modified/llvm/trunk/include/llvm/Analysis/MemoryBuiltins.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/MemoryBuiltins.h
The file was modified/llvm/trunk/include/llvm/Analysis/ScalarEvolutionExpander.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Analysis/ScalarEvolutionExpander.h
The file was modified/llvm/trunk/include/llvm/IR/ValueHandle.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/ValueHandle.h
The file was modified/llvm/trunk/include/llvm/Transforms/Scalar/NaryReassociate.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Scalar/NaryReassociate.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/Cloning.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Utils/Cloning.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/SimplifyIndVar.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Utils/SimplifyIndVar.h
The file was modified/llvm/trunk/include/llvm/Transforms/Utils/ValueMapper.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Utils/ValueMapper.h
The file was modified/llvm/trunk/include/llvm/Transforms/Vectorize/SLPVectorizer.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Transforms/Vectorize/SLPVectorizer.h
The file was modified/llvm/trunk/lib/Analysis/AssumptionCache.cpp (diff)llvm-revision.src/llvm/trunk/lib/Analysis/AssumptionCache.cpp
The file was modified/llvm/trunk/lib/Analysis/CallGraphSCCPass.cpp (diff)llvm-revision.src/llvm/trunk/lib/Analysis/CallGraphSCCPass.cpp
The file was modified/llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp (diff)llvm-revision.src/llvm/trunk/lib/Analysis/ScalarEvolutionExpander.cpp
The file was modified/llvm/trunk/lib/Bitcode/Reader/ValueList.cpp (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Reader/ValueList.cpp
The file was modified/llvm/trunk/lib/Bitcode/Reader/ValueList.h (diff)llvm-revision.src/llvm/trunk/lib/Bitcode/Reader/ValueList.h
The file was modified/llvm/trunk/lib/CodeGen/CodeGenPrepare.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/CodeGenPrepare.cpp
The file was modified/llvm/trunk/lib/IR/Value.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Value.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AMDGPU/SIAnnotateControlFlow.cpp
The file was modified/llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/XCore/XCoreLowerThreadLocal.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/IPO/GlobalOpt.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/IPO/MergeFunctions.cpp
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/InstCombine/InstructionCombining.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/IndVarSimplify.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/InferAddressSpaces.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopSimplifyCFG.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopStrengthReduce.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/LoopUnswitch.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/NaryReassociate.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/Reassociate.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/BasicBlockUtils.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/Local.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/Local.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/LoopUnroll.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyIndVar.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/SimplifyIndVar.cpp
The file was modified/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Vectorize/SLPVectorizer.cpp
The file was modified/llvm/trunk/unittests/IR/ValueHandleTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/ValueHandleTest.cpp