FailedChanges

Summary

  1. Improve handling of arrays of unknown bound in constant expressions. Do not spuriously reject constexpr functions that access elements of an array of unknown bound; this may later become valid once the bound is known. Permit array-to-pointer decay on such arrays, but disallow pointer arithmetic (since we do not know whether it will have defined behavior). The standard is not clear on how this should work, but this seems to be a decent answer. Patch by Robert Haberlach!
  2. Change an unusual directory permission back to a sane value after test. Leaving a directory with a permission 0o100 is inconvenient. For example, macOS's rm can't remove such directory.
  3. Cleanup previous test commit.
Revision 301822 by rsmith:
Improve handling of arrays of unknown bound in constant expressions.

Do not spuriously reject constexpr functions that access elements of an array
of unknown bound; this may later become valid once the bound is known. Permit
array-to-pointer decay on such arrays, but disallow pointer arithmetic (since
we do not know whether it will have defined behavior).

The standard is not clear on how this should work, but this seems to be a
decent answer.

Patch by Robert Haberlach!
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td (diff)llvm-revision.src/cfe/trunk/include/clang/Basic/DiagnosticASTKinds.td
The file was modified/cfe/trunk/lib/AST/ExprConstant.cpp (diff)llvm-revision.src/cfe/trunk/lib/AST/ExprConstant.cpp
The file was added/cfe/trunk/test/SemaCXX/constexpr-array-unknown-bound.cppllvm-revision.src/cfe/trunk/test/SemaCXX/constexpr-array-unknown-bound.cpp
Revision 301821 by ruiu:
Change an unusual directory permission back to a sane value after test.

Leaving a directory with a permission 0o100 is inconvenient.
For example, macOS's rm can't remove such directory.
Change TypePath in RepositoryPath in Workspace
The file was modified/lld/trunk/test/ELF/driver-access.test (diff)llvm-revision.src/lld/trunk/test/ELF/driver-access.test
Revision 301820 by saugustine:
Cleanup previous test commit.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/lib/builtins/assembly.h (diff)llvm-revision.src/compiler-rt/trunk/lib/builtins/assembly.h