FailedChanges

Summary

  1. ObjectFileELF: Fix symbol lookup in bss section Summary: If we have symbol information in a separate file, we need to be very careful about presenting a unified section view of module to the rest of the debugger. ObjectFileELF had code to handle that, but it was being overly cautious -- the section->GetFileSize()!=0 meant that the unification would fail for sections which do not occupy any space in the object file (e.g., .bss). In my case, that manifested itself as not being able to display the values of .bss variables properly as the section associated with the variable did not have it's load address set (because it was not present in the unified section list). I test this by making sure the unified section list and the variables refer to the same section. Reviewers: eugene, zturner Subscribers: tberghammer, lldb-commits, mgorny Differential Revision: https://reviews.llvm.org/D32434
  2. Revert r301735 (and subsequent r301786). It leads to clang crashing, e.g. on this short code fragment (added to test/SemaCXX/warn-thread-safety-parsing.cpp): class SomeClass { public: void foo() { auto l = [this] { auto l = [] EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; }; } Mutex mu_; };
  3. [X86][SSE] Add test for PR30264 (combining multiple constants inputs in a shuffle)
  4. [clang-move] Find template class forward declarations more precisely. Reviewers: ioeric Reviewed By: ioeric Subscribers: cfe-commits Differential Revision: https://reviews.llvm.org/D32741
  5. [analyzer] Detect bad free of function pointers Differential Revision: https://reviews.llvm.org/D31650
Revision 301917 by labath:
ObjectFileELF: Fix symbol lookup in bss section

Summary:
If we have symbol information in a separate file, we need to be very
careful about presenting a unified section view of module to the rest of
the debugger. ObjectFileELF had code to handle that, but it was being
overly cautious -- the section->GetFileSize()!=0 meant that the
unification would fail for sections which do not occupy any space in the
object file (e.g., .bss). In my case, that manifested itself as not
being able to display the values of .bss variables properly as the
section associated with the variable did not have it's load address set
(because it was not present in the unified section list).

I test this by making sure the unified section list and the variables
refer to the same section.

Reviewers: eugene, zturner

Subscribers: tberghammer, lldb-commits, mgorny

Differential Revision: https://reviews.llvm.org/D32434
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp (diff)llvm-revision.src/lldb/trunk/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp
The file was modified/lldb/trunk/unittests/ObjectFile/ELF/CMakeLists.txt (diff)llvm-revision.src/lldb/trunk/unittests/ObjectFile/ELF/CMakeLists.txt
The file was added/lldb/trunk/unittests/ObjectFile/ELF/Inputsllvm-revision.src/lldb/trunk/unittests/ObjectFile/ELF/Inputs
The file was added/lldb/trunk/unittests/ObjectFile/ELF/Inputs/sections-resolve-consistently.yamlllvm-revision.src/lldb/trunk/unittests/ObjectFile/ELF/Inputs/sections-resolve-consistently.yaml
The file was added/lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cppllvm-revision.src/lldb/trunk/unittests/ObjectFile/ELF/TestObjectFileELF.cpp
Revision 301916 by djasper:
Revert r301735 (and subsequent r301786).

It leads to clang crashing, e.g. on this short code fragment (added to
test/SemaCXX/warn-thread-safety-parsing.cpp):

  class SomeClass {
  public:
    void foo() {
      auto l = [this] { auto l = [] EXCLUSIVE_LOCKS_REQUIRED(mu_) {}; };
    }
    Mutex mu_;
  };
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaExprCXX.cpp (diff)llvm-revision.src/cfe/trunk/lib/Sema/SemaExprCXX.cpp
The file was modified/cfe/trunk/test/SemaCXX/cxx1z-lambda-star-this.cpp (diff)llvm-revision.src/cfe/trunk/test/SemaCXX/cxx1z-lambda-star-this.cpp
Revision 301915 by rksimon:
[X86][SSE] Add test for PR30264 (combining multiple constants inputs in a shuffle)
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/CodeGen/X86/vector-shuffle-combining.ll (diff)llvm-revision.src/llvm/trunk/test/CodeGen/X86/vector-shuffle-combining.ll
Revision 301914 by hokein:
[clang-move] Find template class forward declarations more precisely.

Reviewers: ioeric

Reviewed By: ioeric

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D32741
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-move/ClangMove.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/clang-move/ClangMove.cpp
The file was modified/clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/unittests/clang-move/ClangMoveTests.cpp
Revision 301913 by danielmarjamaki:
[analyzer] Detect bad free of function pointers

Differential Revision: https://reviews.llvm.org/D31650
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp (diff)llvm-revision.src/cfe/trunk/lib/StaticAnalyzer/Checkers/MallocChecker.cpp
The file was modified/cfe/trunk/test/Analysis/malloc.c (diff)llvm-revision.src/cfe/trunk/test/Analysis/malloc.c