FailedChanges

Summary

  1. Fixed a bug where we did not properly use the complete versions of Objective-C classes. Also added a test case, thanks to Greg Clayton. <rdar://problem/18913551>
  2. [modules] Round-trip -Werror flag through explicit module build. The intent for an explicit module build is that the diagnostics produced within the module are those that were configured when the module was built, not those that are enabled within a user of the module. This includes diagnostics that don't actually show up until the module is used (for instance, diagnostics produced during template instantiation and weird cases like -Wpadded). We serialized and restored the diagnostic state for individual warning groups, but previously did not track the state for flags like -Werror and -Weverything, which are implemented as separate bits rather than as part of the diagnostics mapping information.
  3. Revert r295861, "[ModuleSummaryAnalysis] Don't crash when referencing unnamed globals." We should always expect values to be named before running the module summary analysis (see NameAnonGlobals pass), so it's fine if we crash in that case.
Revision 301993 by Sean Callanan:
Fixed a bug where we did not properly use the complete versions of Objective-C classes.
Also added a test case, thanks to Greg Clayton.

<rdar://problem/18913551>
Change TypePath in RepositoryPath in Workspace
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definitionllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefilellvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Testllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Foo.hllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Foo.h
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Test.hllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Test.h
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Test.mllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Test/Test.m
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestConflictingDefinition.pyllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestConflictingDefinition.py
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExtllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/Foo.hllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/Foo.h
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/TestExt.hllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/TestExt.h
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/TestExt.mllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/TestExt/TestExt.m
The file was added/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/main.mllvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/main.m
The file was modified/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp (diff)llvm-revision.src/lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangASTSource.cpp
Revision 301992 by rsmith:
[modules] Round-trip -Werror flag through explicit module build.

The intent for an explicit module build is that the diagnostics produced within
the module are those that were configured when the module was built, not those
that are enabled within a user of the module. This includes diagnostics that
don't actually show up until the module is used (for instance, diagnostics
produced during template instantiation and weird cases like -Wpadded).

We serialized and restored the diagnostic state for individual warning groups,
but previously did not track the state for flags like -Werror and -Weverything,
which are implemented as separate bits rather than as part of the diagnostics
mapping information.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/Diagnostic.h (diff)llvm-revision.src/cfe/trunk/include/clang/Basic/Diagnostic.h
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticIDs.h (diff)llvm-revision.src/cfe/trunk/include/clang/Basic/DiagnosticIDs.h
The file was modified/cfe/trunk/lib/Basic/Diagnostic.cpp (diff)llvm-revision.src/cfe/trunk/lib/Basic/Diagnostic.cpp
The file was modified/cfe/trunk/lib/Basic/DiagnosticIDs.cpp (diff)llvm-revision.src/cfe/trunk/lib/Basic/DiagnosticIDs.cpp
The file was modified/cfe/trunk/lib/Serialization/ASTReader.cpp (diff)llvm-revision.src/cfe/trunk/lib/Serialization/ASTReader.cpp
The file was modified/cfe/trunk/lib/Serialization/ASTWriter.cpp (diff)llvm-revision.src/cfe/trunk/lib/Serialization/ASTWriter.cpp
The file was modified/cfe/trunk/test/Index/keep-going.cpp (diff)llvm-revision.src/cfe/trunk/test/Index/keep-going.cpp
The file was modified/cfe/trunk/test/Modules/diag-flags.cpp (diff)llvm-revision.src/cfe/trunk/test/Modules/diag-flags.cpp
The file was modified/cfe/trunk/tools/libclang/CIndex.cpp (diff)llvm-revision.src/cfe/trunk/tools/libclang/CIndex.cpp
The file was modified/cfe/trunk/unittests/Basic/DiagnosticTest.cpp (diff)llvm-revision.src/cfe/trunk/unittests/Basic/DiagnosticTest.cpp
Revision 301991 by pcc:
Revert r295861, "[ModuleSummaryAnalysis] Don't crash when referencing unnamed globals."

We should always expect values to be named before running the module summary
analysis (see NameAnonGlobals pass), so it's fine if we crash in that case.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Analysis/ModuleSummaryAnalysis.cpp (diff)llvm-revision.src/llvm/trunk/lib/Analysis/ModuleSummaryAnalysis.cpp
The file was removed/llvm/trunk/test/Transforms/FunctionImport/unnamed-globals.llllvm-revision.src/llvm/trunk/test/Transforms/FunctionImport/unnamed-globals.ll