FailedChanges

Summary

  1. [ELF] - Added testcase gdb-index-ranges.s (https://reviews.llvm.org/D32750) Before rL301170 was landed, LLD did not produce correct entries in .gdb_index address area. Issue was fixed on LLVM DWARF parsers side and was relative to how .debug_ranges section was scanned. It was main problem of PR32319. It makes sense to have testcase on LLD size too. This checks that we generate proper values now, because we do not have any tests for .gdb_index which works with .debug_ranges atm. Differential revision: https://reviews.llvm.org/D32750
  2. [ScopInfo] Remove code not needed anymore after r302004
  3. [ScopInfo] Do not add array name into memory reference ids Before this change a memory reference identifier had the form: <STMT>_<ACCESSTYPE><ID>_<MEMREF>, e.g., Stmt_bb9_Write0_MemRef_tmp11 After this change, we use the format: <STMT>_<ACCESSTYPE><ID>, e.g., Stmt_bb9_Write0 The name of the array that is accessed through a memory reference is not necessary to uniquely identify a memory reference, but was only added to provide additional information for debugging. We drop this information now for the following two reasons: 1) This shortens the names and consequently improves readability 2) This removes a second location where we decide on the name of a scop array, leaving us only with the location where the actual scop array is created. Having after 2) only a single location to name scop arrays will allow us to change the naming convention of scop arrays more easily, which we will do in a future commit to reduce compilation time.
  4. Silences gcc's -Wnarrowing. I think this is a false positive in GCC's warning, but nonetheless, we should try to be warning-free. Smaller reproducer (reproduces with GCC 6.3): https://godbolt.org/g/cJuO2z
  5. Revert r301986 (and subsequent r301987). The patch is failing to add StringTableStreamBuilder.h, but that isn't even discovered because the corresponding StringTableStreamBuilder.cpp isn't added to any CMakeLists.txt file and thus never built. I think this patch is just incomplete.
Revision 302006 by grimar:
[ELF] - Added testcase gdb-index-ranges.s (https://reviews.llvm.org/D32750)

Before rL301170 was landed, LLD did not produce correct entries in .gdb_index address area.
Issue was fixed on LLVM DWARF parsers side and was relative to how .debug_ranges
section was scanned. It was main problem of PR32319.

It makes sense to have testcase on LLD size too. This checks that we generate proper values
now, because we do not have any tests for .gdb_index which works with .debug_ranges atm.

Differential revision: https://reviews.llvm.org/D32750
Change TypePath in RepositoryPath in Workspace
The file was added/lld/trunk/test/ELF/gdb-index-ranges.sllvm-revision.src/lld/trunk/test/ELF/gdb-index-ranges.s
Revision 302005 by grosser:
[ScopInfo] Remove code not needed anymore after r302004
Change TypePath in RepositoryPath in Workspace
The file was modified/polly/trunk/include/polly/ScopInfo.h (diff)llvm-revision.src/polly/trunk/include/polly/ScopInfo.h
The file was modified/polly/trunk/lib/Analysis/ScopBuilder.cpp (diff)llvm-revision.src/polly/trunk/lib/Analysis/ScopBuilder.cpp
The file was modified/polly/trunk/lib/Analysis/ScopInfo.cpp (diff)llvm-revision.src/polly/trunk/lib/Analysis/ScopInfo.cpp
Revision 302004 by grosser:
[ScopInfo] Do not add array name into memory reference ids

Before this change a memory reference identifier had the form:

  <STMT>_<ACCESSTYPE><ID>_<MEMREF>, e.g., Stmt_bb9_Write0_MemRef_tmp11

After this change, we use the format:

  <STMT>_<ACCESSTYPE><ID>, e.g., Stmt_bb9_Write0

The name of the array that is accessed through a memory reference is not
necessary to uniquely identify a memory reference, but was only added to
provide additional information for debugging. We drop this information now
for the following two reasons:

  1) This shortens the names and consequently improves readability
  2) This removes a second location where we decide on the name of a scop array,
     leaving us only with the location where the actual scop array is created.

Having after 2) only a single location to name scop arrays will allow us to
change the naming convention of scop arrays more easily, which we will do
in a future commit to reduce compilation time.
Change TypePath in RepositoryPath in Workspace
The file was modified/polly/trunk/lib/Analysis/ScopInfo.cpp (diff)llvm-revision.src/polly/trunk/lib/Analysis/ScopInfo.cpp
The file was modified/polly/trunk/test/DependenceInfo/computeout.ll (diff)llvm-revision.src/polly/trunk/test/DependenceInfo/computeout.ll
The file was modified/polly/trunk/test/DependenceInfo/different_schedule_dimensions.ll (diff)llvm-revision.src/polly/trunk/test/DependenceInfo/different_schedule_dimensions.ll
The file was modified/polly/trunk/test/DependenceInfo/do_pluto_matmult.ll (diff)llvm-revision.src/polly/trunk/test/DependenceInfo/do_pluto_matmult.ll
The file was modified/polly/trunk/test/DependenceInfo/fine_grain_dep_0.ll (diff)llvm-revision.src/polly/trunk/test/DependenceInfo/fine_grain_dep_0.ll
The file was modified/polly/trunk/test/DependenceInfo/sequential_loops.ll (diff)llvm-revision.src/polly/trunk/test/DependenceInfo/sequential_loops.ll
Revision 302003 by djasper:
Silences gcc's -Wnarrowing.

I think this is a false positive in GCC's warning, but nonetheless, we
should try to be warning-free. Smaller reproducer (reproduces with GCC
6.3):
https://godbolt.org/g/cJuO2z
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Serialization/ASTWriter.cpp (diff)llvm-revision.src/cfe/trunk/lib/Serialization/ASTWriter.cpp
Revision 302002 by djasper:
Revert r301986 (and subsequent r301987).

The patch is failing to add StringTableStreamBuilder.h, but that isn't
even discovered because the corresponding StringTableStreamBuilder.cpp
isn't added to any CMakeLists.txt file and thus never built. I think
this patch is just incomplete.
Change TypePath in RepositoryPath in Workspace
The file was removed/llvm/trunk/include/llvm/DebugInfo/CodeView/StringTable.hllvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/StringTable.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFile.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFile.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTable.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTable.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/RawTypes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/RawTypes.h
The file was modified/llvm/trunk/include/llvm/Support/BinaryStreamReader.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/BinaryStreamReader.h
The file was modified/llvm/trunk/include/llvm/Support/BinaryStreamWriter.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/BinaryStreamWriter.h
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/CMakeLists.txt (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/CMakeLists.txt
The file was removed/llvm/trunk/lib/DebugInfo/CodeView/StringTable.cppllvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/StringTable.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/DbiStream.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/DbiStream.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFile.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFile.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTable.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTable.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp
The file was removed/llvm/trunk/lib/DebugInfo/PDB/Native/StringTableStreamBuilder.cppllvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/StringTableStreamBuilder.cpp
The file was modified/llvm/trunk/lib/Support/BinaryStreamReader.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/BinaryStreamReader.cpp
The file was modified/llvm/trunk/lib/Support/BinaryStreamWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/BinaryStreamWriter.cpp
The file was modified/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp