FailedChanges

Summary

  1. Revert "[AVR] Enable the frame pointer for all functions" This reverts commit 358ad02d999e88853d2cfc954bd2f668308a51f7.
  2. Windows fix for TestConflictingDefinition makefile gnuwin32 rm does not like wildcards that match nothing even if we specify -f (probably because the wildcard expansion happens in-process there). We could use make $(wildcard) here, but it seems safer to explicitly list the files here, just like the normal Makefile.rules does.
  3. Undo turning ExtBehavior into a bitfield. This produces warnings that I can't explain in a GCC build: In file included from ../tools/clang/include/clang/Lex/LexDiagnostic.h:13:0, from /usr/local/google/home/djasper/llvm/tools/clang/lib/Lex/PTHLexer.cpp:19: ../tools/clang/include/clang/Basic/Diagnostic.h:219:34: warning: ‘clang::DiagnosticsEngine::DiagState::ExtBehavior’ is too small to hold all values of ‘enum class clang::diag::Severity’ [enabled by default] diag::Severity ExtBehavior : 4; // Map extensions to warnings or errors? ^ While I don't think this warning makes sense, I'd like to get this back to being warning-free. This only seems to trigger for "enum class". Reproducer: https://godbolt.org/g/P2ekVd
Revision 302014 by dylanmckay:
Revert "[AVR] Enable the frame pointer for all functions"

This reverts commit 358ad02d999e88853d2cfc954bd2f668308a51f7.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AVR/AVRFrameLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AVR/AVRFrameLowering.cpp
Revision 302013 by labath:
Windows fix for TestConflictingDefinition makefile

gnuwin32 rm does not like wildcards that match nothing even if we
specify -f (probably because the wildcard expansion happens in-process
there). We could use make $(wildcard) here, but it seems safer to
explicitly list the files here, just like the normal Makefile.rules
does.
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile (diff)llvm-revision.src/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/conflicting-definition/Makefile
Revision 302012 by djasper:
Undo turning ExtBehavior into a bitfield.

This produces warnings that I can't explain in a GCC build:

In file included from ../tools/clang/include/clang/Lex/LexDiagnostic.h:13:0,
                 from /usr/local/google/home/djasper/llvm/tools/clang/lib/Lex/PTHLexer.cpp:19:
../tools/clang/include/clang/Basic/Diagnostic.h:219:34: warning: ‘clang::DiagnosticsEngine::DiagState::ExtBehavior’ is too small to hold all values of ‘enum class clang::diag::Severity’ [enabled by default]
     diag::Severity ExtBehavior : 4;     // Map extensions to warnings or errors?
                                  ^

While I don't think this warning makes sense, I'd like to get this back to being
warning-free. This only seems to trigger for "enum class".

Reproducer:
https://godbolt.org/g/P2ekVd
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/Diagnostic.h (diff)llvm-revision.src/cfe/trunk/include/clang/Basic/Diagnostic.h