FailedChanges

Summary

  1. Revert r302037 The commit caused the following two buildbot failures: Clang :: Misc/error-limit-multiple-notes.cpp Clang :: Misc/error-limit.c
  2. Revert my bad winasan coverage test fix and apply one that actually works trace-pc doesn't work, but trace-pc-guard does. *shrug*
  3. Create DWARFVerifier.cpp and .h and move all DWARF verification code over into it. Adrian requested we create a DWARFVerifier.cpp file to contain all of the DWARF verification stuff. This change simply moves the functionality over into DWARFVerifier.h and DWARFVerifier.cpp, renames the DWARFVerifier methods to start with lower case, and switches DWARFContext.cpp over to using the new functionality. Differential Revision: https://reviews.llvm.org/D32809
  4. Speculative fix for WinASan after r301994
  5. Resubmit r301986 and r301987 "Add codeview::StringTable" This was reverted due to a "missing" file, but in reality what happened was that I renamed a file, and then due to a merge conflict both the old file and the new file got added to the repository. This led to an unused cpp file being in the repo and not referenced by any CMakeLists.txt but #including a .h file that wasn't in the repo. In an even more unfortunate coincidence, CMake didn't report the unused cpp file because it was in a subdirectory of the folder with the CMakeLists.txt, and not in the same directory as any CMakeLists.txt. The presence of the unused file was then breaking certain tools that determine file lists by globbing rather than by what's specified in CMakeLists.txt In any case, the fix is to just remove the unused file from the patch set.
  6. [X86][LWP] Add llvm support for LWP instructions (reapplied). This patch adds support for the the LightWeight Profiling (LWP) instructions which are available on all AMD Bulldozer class CPUs (bdver1 to bdver4). Reapplied - this time without changing line endings of existing files. Differential Revision: https://reviews.llvm.org/D32769
  7. [APInt] Give the value union a name so we can remove assumptions on VAL being the larger member Currently several places assume the VAL member is always at least the same size as pVal. In particular for a memcpy in the move assignment operator. While this is a true assumption, it isn't good practice to assume this. This patch gives the union a name so we can write the memcpy in terms of the union itself. This also adds a similar memcpy to the move constructor where we previously just copied using VAL directly. This patch is mostly just a mechanical addition of the U in front of VAL and pVAL everywhere. But several constructors had to be modified since we can't directly initializer a field of named union from the initializer list. Differential Revision: https://reviews.llvm.org/D30629
  8. Verify that no compile units share the same line table in "llvm-dwarfdump --verify" Check to make sure no compile units have the same DW_AT_stmt_list values. Report a verification error if they do. Differential Revision: https://reviews.llvm.org/D32771
  9. Revert rL302028 due to accidental line ending changes.
  10. DiagnosticsEngine should clear DelayedDiagID before reporting the delayed diagnostic This avoids an infinite loop that was uncovered in one of our internal tests by r301992. The testcase is the most reduced version of that auto-generated test. rdar://31962618
Revision 302046 by arphaman:
Revert r302037

The commit caused the following two buildbot failures:

    Clang :: Misc/error-limit-multiple-notes.cpp
    Clang :: Misc/error-limit.c
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Basic/Diagnostic.cpp (diff)llvm-revision.src/cfe/trunk/lib/Basic/Diagnostic.cpp
The file was removed/cfe/trunk/test/Index/KeepGoingWithLotsOfErrors.mmllvm-revision.src/cfe/trunk/test/Index/KeepGoingWithLotsOfErrors.mm
Revision 302045 by rnk:
Revert my bad winasan coverage test fix and apply one that actually works

trace-pc doesn't work, but trace-pc-guard does. *shrug*
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-basic.cc (diff)llvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-basic.cc
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-dll-stdio.cc (diff)llvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-dll-stdio.cc
Revision 302044 by gclayton:
Create DWARFVerifier.cpp and .h and move all DWARF verification code over into it.

Adrian requested we create a DWARFVerifier.cpp file to contain all of the DWARF verification stuff. This change simply moves the functionality over into DWARFVerifier.h and DWARFVerifier.cpp, renames the DWARFVerifier methods to start with lower case, and switches DWARFContext.cpp over to using the new functionality.

Differential Revision: https://reviews.llvm.org/D32809
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.hllvm-revision.src/llvm/trunk/include/llvm/DebugInfo/DWARF/DWARFVerifier.h
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/CMakeLists.txt (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/CMakeLists.txt
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was added/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cppllvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFVerifier.cpp
Revision 302043 by rnk:
Speculative fix for WinASan after r301994
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-basic.cc (diff)llvm-revision.src/compiler-rt/trunk/test/asan/TestCases/Windows/coverage-basic.cc
Revision 302042 by zturner:
Resubmit r301986 and r301987 "Add codeview::StringTable"

This was reverted due to a "missing" file, but in reality
what happened was that I renamed a file, and then due to
a merge conflict both the old file and the new file got
added to the repository.  This led to an unused cpp file
being in the repo and not referenced by any CMakeLists.txt
but #including a .h file that wasn't in the repo.  In an
even more unfortunate coincidence, CMake didn't report the
unused cpp file because it was in a subdirectory of the
folder with the CMakeLists.txt, and not in the same directory
as any CMakeLists.txt.

The presence of the unused file was then breaking certain
tools that determine file lists by globbing rather than
by what's specified in CMakeLists.txt

In any case, the fix is to just remove the unused file from
the patch set.
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/include/llvm/DebugInfo/CodeView/StringTable.hllvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/StringTable.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFile.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFile.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBFileBuilder.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTable.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTable.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/PDBStringTableBuilder.h
The file was modified/llvm/trunk/include/llvm/DebugInfo/PDB/Native/RawTypes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/PDB/Native/RawTypes.h
The file was modified/llvm/trunk/include/llvm/Support/BinaryStreamReader.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/BinaryStreamReader.h
The file was modified/llvm/trunk/include/llvm/Support/BinaryStreamWriter.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/BinaryStreamWriter.h
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/CMakeLists.txt (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/CMakeLists.txt
The file was added/llvm/trunk/lib/DebugInfo/CodeView/StringTable.cppllvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/StringTable.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/DbiStream.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/DbiStream.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFile.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFile.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBFileBuilder.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTable.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTable.cpp
The file was modified/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/PDB/Native/PDBStringTableBuilder.cpp
The file was modified/llvm/trunk/lib/Support/BinaryStreamReader.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/BinaryStreamReader.cpp
The file was modified/llvm/trunk/lib/Support/BinaryStreamWriter.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/BinaryStreamWriter.cpp
The file was modified/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp
Revision 302041 by rksimon:
[X86][LWP] Add llvm support for LWP instructions (reapplied).

This patch adds support for the the LightWeight Profiling (LWP) instructions which are available on all AMD Bulldozer class CPUs (bdver1 to bdver4).

Reapplied - this time without changing line endings of existing files.

Differential Revision: https://reviews.llvm.org/D32769
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicsX86.td (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/IntrinsicsX86.td
The file was modified/llvm/trunk/lib/Support/Host.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/Host.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86.td
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.h (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86ISelLowering.h
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86InstrInfo.td
The file was modified/llvm/trunk/lib/Target/X86/X86Schedule.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Schedule.td
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Subtarget.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.h (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Subtarget.h
The file was added/llvm/trunk/test/CodeGen/X86/lwp-intrinsics-x86_64.llllvm-revision.src/llvm/trunk/test/CodeGen/X86/lwp-intrinsics-x86_64.ll
The file was added/llvm/trunk/test/CodeGen/X86/lwp-intrinsics.llllvm-revision.src/llvm/trunk/test/CodeGen/X86/lwp-intrinsics.ll
The file was modified/llvm/trunk/test/MC/Disassembler/X86/x86-32.txt (diff)llvm-revision.src/llvm/trunk/test/MC/Disassembler/X86/x86-32.txt
The file was modified/llvm/trunk/test/MC/Disassembler/X86/x86-64.txt (diff)llvm-revision.src/llvm/trunk/test/MC/Disassembler/X86/x86-64.txt
The file was added/llvm/trunk/test/MC/X86/lwp-x86_64.sllvm-revision.src/llvm/trunk/test/MC/X86/lwp-x86_64.s
The file was added/llvm/trunk/test/MC/X86/lwp.sllvm-revision.src/llvm/trunk/test/MC/X86/lwp.s
Revision 302040 by ctopper:
[APInt] Give the value union a name so we can remove assumptions on VAL being the larger member

Currently several places assume the VAL member is always at least the same size as pVal. In particular for a memcpy in the move assignment operator. While this is a true assumption, it isn't good practice to assume this.

This patch gives the union a name so we can write the memcpy in terms of the union itself. This also adds a similar memcpy to the move constructor where we previously just copied using VAL directly.

This patch is mostly just a mechanical addition of the U in front of VAL and pVAL everywhere. But several constructors had to be modified since we can't directly initializer a field of named union from the initializer list.

Differential Revision: https://reviews.llvm.org/D30629
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/APInt.h (diff)llvm-revision.src/llvm/trunk/include/llvm/ADT/APInt.h
The file was modified/llvm/trunk/lib/IR/LLVMContextImpl.h (diff)llvm-revision.src/llvm/trunk/lib/IR/LLVMContextImpl.h
The file was modified/llvm/trunk/lib/Support/APInt.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/APInt.cpp
Revision 302039 by gclayton:
Verify that no compile units share the same line table in "llvm-dwarfdump --verify"

Check to make sure no compile units have the same DW_AT_stmt_list values. Report a verification error if they do.

Differential Revision: https://reviews.llvm.org/D32771
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFContext.cpp
The file was modified/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
Revision 302038 by rksimon:
Revert rL302028 due to accidental line ending changes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/IntrinsicsX86.td (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/IntrinsicsX86.td
The file was modified/llvm/trunk/lib/Support/Host.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/Host.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86.td
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.h (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86ISelLowering.h
The file was modified/llvm/trunk/lib/Target/X86/X86InstrInfo.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86InstrInfo.td
The file was modified/llvm/trunk/lib/Target/X86/X86Schedule.td (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Schedule.td
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Subtarget.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86Subtarget.h (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86Subtarget.h
The file was removed/llvm/trunk/test/CodeGen/X86/lwp-intrinsics-x86_64.llllvm-revision.src/llvm/trunk/test/CodeGen/X86/lwp-intrinsics-x86_64.ll
The file was removed/llvm/trunk/test/CodeGen/X86/lwp-intrinsics.llllvm-revision.src/llvm/trunk/test/CodeGen/X86/lwp-intrinsics.ll
The file was modified/llvm/trunk/test/MC/Disassembler/X86/x86-32.txt (diff)llvm-revision.src/llvm/trunk/test/MC/Disassembler/X86/x86-32.txt
The file was modified/llvm/trunk/test/MC/Disassembler/X86/x86-64.txt (diff)llvm-revision.src/llvm/trunk/test/MC/Disassembler/X86/x86-64.txt
The file was removed/llvm/trunk/test/MC/X86/lwp-x86_64.sllvm-revision.src/llvm/trunk/test/MC/X86/lwp-x86_64.s
The file was removed/llvm/trunk/test/MC/X86/lwp.sllvm-revision.src/llvm/trunk/test/MC/X86/lwp.s
Revision 302037 by arphaman:
DiagnosticsEngine should clear DelayedDiagID before reporting the
delayed diagnostic

This avoids an infinite loop that was uncovered in one of our internal tests
by r301992. The testcase is the most reduced version of that auto-generated
test.

rdar://31962618
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Basic/Diagnostic.cpp (diff)llvm-revision.src/cfe/trunk/lib/Basic/Diagnostic.cpp
The file was added/cfe/trunk/test/Index/KeepGoingWithLotsOfErrors.mmllvm-revision.src/cfe/trunk/test/Index/KeepGoingWithLotsOfErrors.mm