FailedChanges

Summary

  1. [IR] Abstract away ArgNo+1 attribute indexing as much as possible Summary: Do three things to help with that: - Add AttributeList::FirstArgIndex, which is an enumerator currently set to 1. It allows us to change the indexing scheme with fewer changes. - Add addParamAttr/removeParamAttr. This just shortens addAttribute call sites that would otherwise need to spell out FirstArgIndex. - Remove some attribute-specific getters and setters from Function that take attribute list indices. Most of these were only used from BuildLibCalls, and doesNotAlias was only used to test or set if the return value is malloc-like. I'm happy to split the patch, but I think they are probably easier to review when taken together. This patch should be NFC, but it sets the stage to change the indexing scheme to this, which is more convenient when indexing into an array: 0: func attrs 1: retattrs 2...: arg attrs Reviewers: chandlerc, pete, javed.absar Subscribers: david2050, llvm-commits Differential Revision: https://reviews.llvm.org/D32811
  2. [CodeView] Remove constructor initialization of a removed field. I should've staged this with my last commit.
  3. [RuntimeLoopUnroller] Add assert that we dont unroll non-rotated loops Summary: Cloning basic blocks in the loop for runtime loop unroller depends on loop being in rotated form (i.e. loop latch target is the exit block). Assert that this is true, so that callers of runtime loop unroller pass in canonical loops. The single caller of this function has that check recently added: https://reviews.llvm.org/rL301239 Reviewers: davide Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D32801
  4. Delete dead function causing compilation failure.
  5. [CodeView] Remove unused private field. NFCI.
  6. [bpf] add relocation support . there should be no runtime relocation inside the bpf function. . relocation supported here mostly for debugging. . a test case is added. Signed-off-by: Yonghong Song <yhs@fb.com> Signed-off-by: Alexei Starovoitov <ast@kernel.org>
  7. Revert "CMake: Move sphinx detection into AddSphinxTarget.cmake" This reverts commit r302025. clang and lld need to be updated too so they don't break with this patch.
Revision 302060 by rnk:
[IR] Abstract away ArgNo+1 attribute indexing as much as possible

Summary:
Do three things to help with that:
- Add AttributeList::FirstArgIndex, which is an enumerator currently set
  to 1. It allows us to change the indexing scheme with fewer changes.
- Add addParamAttr/removeParamAttr. This just shortens addAttribute call
  sites that would otherwise need to spell out FirstArgIndex.
- Remove some attribute-specific getters and setters from Function that
  take attribute list indices.  Most of these were only used from
  BuildLibCalls, and doesNotAlias was only used to test or set if the
  return value is malloc-like.

I'm happy to split the patch, but I think they are probably easier to
review when taken together.

This patch should be NFC, but it sets the stage to change the indexing
scheme to this, which is more convenient when indexing into an array:
  0: func attrs
  1: retattrs
  2...: arg attrs

Reviewers: chandlerc, pete, javed.absar

Subscribers: david2050, llvm-commits

Differential Revision: https://reviews.llvm.org/D32811
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGObjCGNU.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
The file was modified/llvm/trunk/include/llvm/IR/Attributes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Attributes.h
The file was modified/llvm/trunk/include/llvm/IR/CallSite.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/CallSite.h
The file was modified/llvm/trunk/include/llvm/IR/Function.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Function.h
The file was modified/llvm/trunk/include/llvm/IR/Instructions.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Instructions.h
The file was modified/llvm/trunk/lib/Analysis/CFLGraph.h (diff)llvm-revision.src/llvm/trunk/lib/Analysis/CFLGraph.h
The file was modified/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/GlobalISel/CallLowering.cpp
The file was modified/llvm/trunk/lib/IR/Attributes.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Attributes.cpp
The file was modified/llvm/trunk/lib/IR/Function.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Function.cpp
The file was modified/llvm/trunk/lib/IR/Instructions.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Instructions.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AArch64/AArch64CallLowering.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMCallLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/ARM/ARMCallLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86WinEHState.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86WinEHState.cpp
The file was modified/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Coroutines/CoroSplit.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/ArgumentPromotion.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/IPO/ArgumentPromotion.cpp
The file was modified/llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/IPO/FunctionAttrs.cpp
The file was modified/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/InstCombine/InstCombineCalls.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/InstrProfiling.cpp
The file was modified/llvm/trunk/lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h (diff)llvm-revision.src/llvm/trunk/lib/Transforms/ObjCARC/ARCRuntimeEntryPoints.h
The file was modified/llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/CorrelatedValuePropagation.cpp
The file was modified/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Scalar/RewriteStatepointsForGC.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/BuildLibCalls.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/BuildLibCalls.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modified/llvm/trunk/unittests/ExecutionEngine/Orc/IndirectionUtilsTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/ExecutionEngine/Orc/IndirectionUtilsTest.cpp
The file was modified/llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp (diff)llvm-revision.src/llvm/trunk/utils/TableGen/IntrinsicEmitter.cpp
Revision 302059 by davide:
[CodeView] Remove constructor initialization of a removed field.

I should've staged this with my last commit.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugLineFragment.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/CodeView/ModuleDebugLineFragment.cpp
Revision 302058 by annat:
[RuntimeLoopUnroller] Add assert that we dont unroll non-rotated loops

Summary:
Cloning basic blocks in the loop for runtime loop unroller depends on loop being
in rotated form (i.e. loop latch target is the exit block).
Assert that this is true, so that callers of runtime loop unroller pass in
canonical loops.
The single caller of this function has that check recently added:
https://reviews.llvm.org/rL301239

Reviewers: davide

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D32801
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/LoopUnrollRuntime.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/LoopUnrollRuntime.cpp
Revision 302057 by zturner:
Delete dead function causing compilation failure.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/DebugInfo/PDB/StringTableBuilderTest.cpp
Revision 302056 by davide:
[CodeView] Remove unused private field. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugLineFragment.h (diff)llvm-revision.src/llvm/trunk/include/llvm/DebugInfo/CodeView/ModuleDebugLineFragment.h
Revision 302055 by ast:
[bpf] add relocation support

  . there should be no runtime relocation inside the bpf function.
  . relocation supported here mostly for debugging.
  . a test case is added.

Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp (diff)llvm-revision.src/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.cpp
The file was modified/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h (diff)llvm-revision.src/llvm/trunk/lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
The file was modified/llvm/trunk/lib/MC/MCObjectFileInfo.cpp (diff)llvm-revision.src/llvm/trunk/lib/MC/MCObjectFileInfo.cpp
The file was added/llvm/trunk/test/CodeGen/BPF/reloc.llllvm-revision.src/llvm/trunk/test/CodeGen/BPF/reloc.ll
Revision 302054 by tstellar:
Revert "CMake: Move sphinx detection into AddSphinxTarget.cmake"

This reverts commit r302025.

clang and lld need to be updated too so they don't break with this patch.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/cmake/config-ix.cmake (diff)llvm-revision.src/llvm/trunk/cmake/config-ix.cmake
The file was modified/llvm/trunk/cmake/modules/AddSphinxTarget.cmake (diff)llvm-revision.src/llvm/trunk/cmake/modules/AddSphinxTarget.cmake
The file was modified/llvm/trunk/docs/CMakeLists.txt (diff)llvm-revision.src/llvm/trunk/docs/CMakeLists.txt