FailedChanges

Summary

  1. [clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &=
  2. [clang-tidy] Code cleanup, (almost) NFC (*). (*) Printed types of member pointers don't use elaborated type specifiers (`int struct S::*` -> `int S::*`).
  3. [Tooling] add a createReplacement overload for StringRef
  4. [test] variant: enable constexpr construction tests on MSVC STL * Add a new macro _MSVC_STL_VER to detect when the MSVC STL is being tested * Workaround C1XX __is_trivially_copyable bug
  5. Introduce VirtualUse. NFC. If a ScopStmt references a (scalar) value, there are multiple possibilities where this value can come. The decision about what kind of use it is must be handled consistently at different places, which can be error-prone. VirtualUse is meant to centralize the handling of the different types of value uses. This patch makes ScopBuilder and CodeGeneration use VirtualUse. This already helps to show inconsistencies with the value handling. In order to keep this patch NFC, exceptions to the general rules are added. These might be fixed later if they turn to problems. Overall, this should result in fewer post-codegen IR-verification errors, but instead assertion failures in `getNewValue` that are closer to the actual error. Differential Revision: https://reviews.llvm.org/D32667
  6. clang-format: [JS] exponentiation operator Summary: While its precedence should be higher than multiplicative, LLVM does not have a level for that, so for the time being just treat it as multiplicative. Reviewers: djasper Subscribers: cfe-commits, klimek Differential Revision: https://reviews.llvm.org/D32864
Revision 302161 by alexfh:
[clang-tidy] fix readability-implicit-bool-cast false alarm on |=, &=
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp
Revision 302160 by alexfh:
[clang-tidy] Code cleanup, (almost) NFC (*).

(*) Printed types of member pointers don't use elaborated type specifiers
(`int struct S::*` -> `int S::*`).
Change TypePath in RepositoryPath in Workspace
The file was modified/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/clang-tidy/readability/ImplicitBoolCastCheck.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-allow-conditional-casts.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-allow-conditional-casts.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-cxx98.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast-cxx98.cpp
The file was modified/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp (diff)llvm-revision.src/clang-tools-extra/trunk/test/clang-tidy/readability-implicit-bool-cast.cpp
Revision 302159 by alexfh:
[Tooling] add a createReplacement overload for StringRef
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Tooling/FixIt.h (diff)llvm-revision.src/cfe/trunk/include/clang/Tooling/FixIt.h
Revision 302158 by caseycarter:
[test] variant: enable constexpr construction tests on MSVC STL

* Add a new macro _MSVC_STL_VER to detect when the MSVC STL is being tested
* Workaround C1XX __is_trivially_copyable bug
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/copy.pass.cpp
The file was modified/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp (diff)llvm-revision.src/libcxx/trunk/test/std/utilities/variant/variant.variant/variant.ctor/move.pass.cpp
The file was modified/libcxx/trunk/test/support/msvc_stdlib_force_include.hpp (diff)llvm-revision.src/libcxx/trunk/test/support/msvc_stdlib_force_include.hpp
The file was added/libcxx/trunk/test/support/test.workarounds/c1xx_broken_is_trivially_copyable.pass.cppllvm-revision.src/libcxx/trunk/test/support/test.workarounds/c1xx_broken_is_trivially_copyable.pass.cpp
The file was modified/libcxx/trunk/test/support/test_workarounds.h (diff)llvm-revision.src/libcxx/trunk/test/support/test_workarounds.h
Revision 302157 by meinersbur:
Introduce VirtualUse. NFC.

If a ScopStmt references a (scalar) value, there are multiple
possibilities where this value can come. The decision about what kind of
use it is must be handled consistently at different places, which can be
error-prone. VirtualUse is meant to centralize the handling of the
different types of value uses.

This patch makes ScopBuilder and CodeGeneration use VirtualUse. This
already helps to show inconsistencies with the value handling. In order
to keep this patch NFC, exceptions to the general rules are added.
These might be fixed later if they turn to problems. Overall, this
should result in fewer post-codegen IR-verification errors, but instead
assertion failures in `getNewValue` that are closer to the actual error.

Differential Revision: https://reviews.llvm.org/D32667
Change TypePath in RepositoryPath in Workspace
The file was added/polly/trunk/include/polly/Support/VirtualInstruction.hllvm-revision.src/polly/trunk/include/polly/Support/VirtualInstruction.h
The file was modified/polly/trunk/lib/Analysis/ScopBuilder.cpp (diff)llvm-revision.src/polly/trunk/lib/Analysis/ScopBuilder.cpp
The file was modified/polly/trunk/lib/CMakeLists.txt (diff)llvm-revision.src/polly/trunk/lib/CMakeLists.txt
The file was modified/polly/trunk/lib/CodeGen/BlockGenerators.cpp (diff)llvm-revision.src/polly/trunk/lib/CodeGen/BlockGenerators.cpp
The file was added/polly/trunk/lib/Support/VirtualInstruction.cppllvm-revision.src/polly/trunk/lib/Support/VirtualInstruction.cpp
Revision 302156 by mprobst:
clang-format: [JS] exponentiation operator

Summary: While its precedence should be higher than multiplicative, LLVM does not have a level for that, so for the time being just treat it as multiplicative.

Reviewers: djasper

Subscribers: cfe-commits, klimek

Differential Revision: https://reviews.llvm.org/D32864
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Format/FormatToken.h (diff)llvm-revision.src/cfe/trunk/lib/Format/FormatToken.h
The file was modified/cfe/trunk/lib/Format/FormatTokenLexer.cpp (diff)llvm-revision.src/cfe/trunk/lib/Format/FormatTokenLexer.cpp
The file was modified/cfe/trunk/unittests/Format/FormatTestJS.cpp (diff)llvm-revision.src/cfe/trunk/unittests/Format/FormatTestJS.cpp