SuccessChanges

Summary

  1. [Lit] Fix to prevent creation of "%SystemDrive%" directory on Windows. This patch propogates the environment variable SYSTEMDRIVE on Windows when running the unit tests. This prevents the creation of a directory named "%SystemDrive%" when running the unit tests from FileSystemTest that use the function llvm::sys::fs::remove_directories which in turn uses SHFileOperationW. It is within SHFileOperationW that this environment variable may be used and if undefined causes the creation of a "%SystemDrive%" directory in the current directory. Differential Revision: https://reviews.llvm.org/D32910
  2. [APInt] Modify tcMultiplyPart's overflow detection to not depend on 'i' from the earlier loop. NFC The value of 'i' is always the smaller of DstParts and SrcParts so we can just use that fact to write all the code in terms of SrcParts and DstParts.
  3. [APInt] Use std::min instead of writing the same thing with the ternary operator. NFC
  4. [APInt] Remove 'else' after 'return' in tcMultiply methods. NFC
Revision 302409 by anng:
[Lit] Fix to prevent creation of "%SystemDrive%" directory on Windows.

This patch propogates the environment variable SYSTEMDRIVE on Windows when
running the unit tests. This prevents the creation of a directory named
"%SystemDrive%" when running the unit tests from FileSystemTest that use the
function llvm::sys::fs::remove_directories which in turn uses SHFileOperationW.
It is within SHFileOperationW that this environment variable may be used and if
undefined causes the creation of a "%SystemDrive%" directory in the current
directory.

Differential Revision: https://reviews.llvm.org/D32910
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Unit/lit.cfg (diff)llvm-revision.src/llvm/trunk/test/Unit/lit.cfg
Revision 302408 by ctopper:
[APInt] Modify tcMultiplyPart's overflow detection to not depend on 'i' from the earlier loop. NFC

The value of 'i' is always the smaller of DstParts and SrcParts so we can just use that fact to write all the code in terms of SrcParts and DstParts.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Support/APInt.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/APInt.cpp
Revision 302407 by ctopper:
[APInt] Use std::min instead of writing the same thing with the ternary operator. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Support/APInt.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/APInt.cpp
Revision 302406 by ctopper:
[APInt] Remove 'else' after 'return' in tcMultiply methods. NFC
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Support/APInt.cpp (diff)llvm-revision.src/llvm/trunk/lib/Support/APInt.cpp