FailedChanges

Summary

  1. [codeview] Check for a DIExpression offset for local variables Fixes inalloca parameters, which previously all pointed to the same offset. Extend the test to use llvm-readobj so that we can test the offset in a readable way.
  2. Update testcase for upstream LLVM changes (r302469).
  3. Make it illegal for two Functions to point to the same DISubprogram As recently discussed on llvm-dev [1], this patch makes it illegal for two Functions to point to the same DISubprogram and updates FunctionCloner to also clone the debug info of a function to conform to the new requirement. To simplify the implementation it also factors out the creation of inlineAt locations from the Inliner into a general-purpose utility in DILocation. [1] http://lists.llvm.org/pipermail/llvm-dev/2017-May/112661.html <rdar://problem/31926379> Differential Revision: https://reviews.llvm.org/D32975 This reapplies r302469 with a fix for a bot failure (reparentDebugInfo now checks for the case the orig and new function are identical).
  4. NFC: refactor replaceDominatedUsesWith Summary: Since I will post patch with some changes to replaceDominatedUsesWith, it would be good to avoid duplicating code again. Reviewers: davide, dberlin Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D32798
  5. [DWARF] Fix a parsing issue with type unit headers. Reviewers: dblaikie Differential Revision: https://reviews.llvm.org/D32987
  6. Fix the Endianness bug by adding the little endian UTF marker. Summary: Quick fix Reviewers: zturner, uweigand Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D33014
  7. Suppress all uses of LLVM_END_WITH_NULL. NFC. Use variadic templates instead of relying on <cstdarg> + sentinel. This enforces better type checking and makes code more readable. Differential revision: https://reviews.llvm.org/D32550
  8. Suppress all uses of LLVM_END_WITH_NULL. NFC. Use variadic templates instead of relying on <cstdarg> + sentinel. This enforces better type checking and makes code more readable. Differential Revision: https://reviews.llvm.org/D32541
  9. [mips] XFAIL dfsan's custom.cc test on mips64. Test was already marked as failing for mips64el. Now that it's being tested on mips64, it has to be XFAILed there as well.
Revision 302578 by rnk:
[codeview] Check for a DIExpression offset for local variables

Fixes inalloca parameters, which previously all pointed to the same
offset. Extend the test to use llvm-readobj so that we can test the
offset in a readable way.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/DebugInfoMetadata.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/AsmPrinter/CodeViewDebug.cpp
The file was modified/llvm/trunk/lib/IR/DebugInfoMetadata.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/DebugInfoMetadata.cpp
The file was modified/llvm/trunk/test/DebugInfo/X86/dbg-declare-inalloca.ll (diff)llvm-revision.src/llvm/trunk/test/DebugInfo/X86/dbg-declare-inalloca.ll
Revision 302577 by Adrian Prantl:
Update testcase for upstream LLVM changes (r302469).
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp (diff)llvm-revision.src/cfe/trunk/test/CodeGenCXX/linetable-virtual-variadic.cpp
Revision 302576 by Adrian Prantl:
Make it illegal for two Functions to point to the same DISubprogram

As recently discussed on llvm-dev [1], this patch makes it illegal for
two Functions to point to the same DISubprogram and updates
FunctionCloner to also clone the debug info of a function to conform
to the new requirement. To simplify the implementation it also factors
out the creation of inlineAt locations from the Inliner into a
general-purpose utility in DILocation.

[1] http://lists.llvm.org/pipermail/llvm-dev/2017-May/112661.html
<rdar://problem/31926379>

Differential Revision: https://reviews.llvm.org/D32975

This reapplies r302469 with a fix for a bot failure (reparentDebugInfo
now checks for the case the orig and new function are identical).
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/IR/DebugLoc.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/DebugLoc.h
The file was modified/llvm/trunk/lib/IR/DebugLoc.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/DebugLoc.cpp
The file was modified/llvm/trunk/lib/IR/Verifier.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Verifier.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/CloneFunction.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/InlineFunction.cpp
The file was modified/llvm/trunk/test/Verifier/metadata-function-dbg.ll (diff)llvm-revision.src/llvm/trunk/test/Verifier/metadata-function-dbg.ll
The file was modified/llvm/trunk/unittests/Transforms/Utils/Cloning.cpp (diff)llvm-revision.src/llvm/trunk/unittests/Transforms/Utils/Cloning.cpp
Revision 302575 by prazek:
NFC: refactor replaceDominatedUsesWith

Summary:
Since I will post patch with some changes to
replaceDominatedUsesWith, it would be good to avoid
duplicating code again.

Reviewers: davide, dberlin

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D32798
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Utils/Local.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/Local.cpp
Revision 302574 by wolfgangp:
[DWARF] Fix a parsing issue with type unit headers.

Reviewers: dblaikie

Differential Revision: https://reviews.llvm.org/D32987
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp (diff)llvm-revision.src/llvm/trunk/lib/DebugInfo/DWARF/DWARFTypeUnit.cpp
The file was added/llvm/trunk/test/DebugInfo/Inputs/typeunit-header.elf-x86-64llvm-revision.src/llvm/trunk/test/DebugInfo/Inputs/typeunit-header.elf-x86-64
The file was added/llvm/trunk/test/DebugInfo/Inputs/typeunit-header.sllvm-revision.src/llvm/trunk/test/DebugInfo/Inputs/typeunit-header.s
The file was added/llvm/trunk/test/DebugInfo/typeunit-header.testllvm-revision.src/llvm/trunk/test/DebugInfo/typeunit-header.test
Revision 302573 by ecbeckmann:
Fix the Endianness bug by adding the little endian UTF marker.

Summary: Quick fix

Reviewers: zturner, uweigand

Subscribers: llvm-commits

Differential Revision: https://reviews.llvm.org/D33014
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Object/COFFObjectFile.cpp (diff)llvm-revision.src/llvm/trunk/lib/Object/COFFObjectFile.cpp
The file was modified/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp (diff)llvm-revision.src/llvm/trunk/tools/llvm-readobj/COFFDumper.cpp
Revision 302572 by serge_sans_paille:
Suppress all uses of LLVM_END_WITH_NULL. NFC.

Use variadic templates instead of relying on <cstdarg> + sentinel.

This enforces better type checking and makes code more readable.

Differential revision: https://reviews.llvm.org/D32550
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/CodeGen/CGBlocks.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGBlocks.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGBuiltin.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGBuiltin.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGCUDANV.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGCUDANV.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGCleanup.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGCleanup.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGException.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGException.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGExpr.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGExpr.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGExprConstant.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGExprConstant.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGObjCGNU.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGObjCGNU.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGObjCMac.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGObjCMac.cpp
The file was modified/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
The file was modified/cfe/trunk/lib/CodeGen/CodeGenModule.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CodeGenModule.cpp
The file was modified/cfe/trunk/lib/CodeGen/CodeGenTypes.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/CodeGenTypes.cpp
The file was modified/cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp
The file was modified/cfe/trunk/lib/CodeGen/TargetInfo.cpp (diff)llvm-revision.src/cfe/trunk/lib/CodeGen/TargetInfo.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp (diff)llvm-revision.src/cfe/trunk/lib/StaticAnalyzer/Checkers/BasicObjCFoundationChecks.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp (diff)llvm-revision.src/cfe/trunk/lib/StaticAnalyzer/Checkers/NoReturnFunctionChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp (diff)llvm-revision.src/cfe/trunk/lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
The file was modified/cfe/trunk/lib/StaticAnalyzer/Checkers/SelectorExtras.h (diff)llvm-revision.src/cfe/trunk/lib/StaticAnalyzer/Checkers/SelectorExtras.h
Revision 302571 by serge_sans_paille:
Suppress all uses of LLVM_END_WITH_NULL. NFC.

Use variadic templates instead of relying on <cstdarg> + sentinel.
This enforces better type checking and makes code more readable.

Differential Revision: https://reviews.llvm.org/D32541
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/ADT/STLExtras.h (diff)llvm-revision.src/llvm/trunk/include/llvm/ADT/STLExtras.h
The file was modified/llvm/trunk/include/llvm/IR/Constants.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/Constants.h
The file was modified/llvm/trunk/include/llvm/IR/DerivedTypes.h (diff)llvm-revision.src/llvm/trunk/include/llvm/IR/DerivedTypes.h
The file was modified/llvm/trunk/include/llvm/Support/Compiler.h (diff)llvm-revision.src/llvm/trunk/include/llvm/Support/Compiler.h
The file was modified/llvm/trunk/lib/CodeGen/SjLjEHPrepare.cpp (diff)llvm-revision.src/llvm/trunk/lib/CodeGen/SjLjEHPrepare.cpp
The file was modified/llvm/trunk/lib/IR/Constants.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Constants.cpp
The file was modified/llvm/trunk/lib/IR/Instructions.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Instructions.cpp
The file was modified/llvm/trunk/lib/IR/Module.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Module.cpp
The file was modified/llvm/trunk/lib/IR/Type.cpp (diff)llvm-revision.src/llvm/trunk/lib/IR/Type.cpp
The file was modified/llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/ARM/ARMISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm-revision.src/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/DataFlowSanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Instrumentation/EfficiencySanitizer.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Instrumentation/EfficiencySanitizer.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/EscapeEnumerator.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/EscapeEnumerator.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/ModuleUtils.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/ModuleUtils.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/SimplifyLibCalls.cpp
The file was modified/llvm/trunk/lib/Transforms/Utils/ValueMapper.cpp (diff)llvm-revision.src/llvm/trunk/lib/Transforms/Utils/ValueMapper.cpp
The file was modified/llvm/trunk/tools/bugpoint/ExtractFunction.cpp (diff)llvm-revision.src/llvm/trunk/tools/bugpoint/ExtractFunction.cpp
The file was modified/llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h (diff)llvm-revision.src/llvm/trunk/unittests/ExecutionEngine/Orc/OrcTestCommon.h
The file was modified/llvm/trunk/unittests/IR/TypeBuilderTest.cpp (diff)llvm-revision.src/llvm/trunk/unittests/IR/TypeBuilderTest.cpp
Revision 302570 by sdardis:
[mips] XFAIL dfsan's custom.cc test on mips64.

Test was already marked as failing for mips64el. Now that it's being
tested on mips64, it has to be XFAILed there as well.
Change TypePath in RepositoryPath in Workspace
The file was modified/compiler-rt/trunk/test/dfsan/custom.cc (diff)llvm-revision.src/compiler-rt/trunk/test/dfsan/custom.cc