FailedChanges

Summary

  1. Revert r368237 - Update fix-it hints for std::move warnings. r368237 attempted to improve fix-its for move warnings, but introduced some regressions to -Wpessimizing-move. Revert that change and add the missing test cases to the pessimizing move test to prevent future regressions.
  2. DebugInfo: Update support for detecting C++ language variants in debug info emission
  3. gn build: (manually) merge r373407
  4. Fix crash on constant-evaluation of pseudo-destruction of a pointer. We got confused and thought we might be pseudo-destroying the pointee instead.
  5. AMDGPU/GlobalISel: Use getIntrinsicID helper
  6. Remove TypeNodes.def from the modulemap. We currently just look for files named in the modulemap in its associated source directory. This means that we can't name generated files, like TypeNodes.def now is, which means we can't explicitly mark it as textual. But fortunately that's okay because (as I understand it) the most important purpose of naming the header in the modulemap is to ensure that it's not treated as public, and the search for public headers also only considers files in the associated source directory. This isn't an elegant solution, since among other things it means that a build which wrote the generated files directly into the source directory would result in something that wouldn't build as a module, but that's a problem for all our other generated files as well.
  7. AMDGPU/GlobalISel: Assume VGPR for G_FRAME_INDEX In principle this should behave as any other constant. However eliminateFrameIndex currently assumes a VALU use and uses a vector shift. Work around this by selecting to VGPR for now until eliminateFrameIndex is fixed.
  8. AMDGPU/GlobalISel: Private loads always use VGPRs
  9. AMDGPU/GlobalISel: Legalize 1024-bit G_BUILD_VECTOR This will be needed to support AGPR operations.
  10. AMDGPU/GlobalISel: Fix RegBankSelect for 1024-bit values
Revision 373421 by rtrieu:
Revert r368237 - Update fix-it hints for std::move warnings.

r368237 attempted to improve fix-its for move warnings, but introduced some
regressions to -Wpessimizing-move.  Revert that change and add the missing
test cases to the pessimizing move test to prevent future regressions.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaInit.cpp (diff)clang.src/lib/Sema/SemaInit.cpp
The file was modified/cfe/trunk/test/SemaCXX/warn-pessmizing-move.cpp (diff)clang.src/test/SemaCXX/warn-pessmizing-move.cpp
The file was modified/cfe/trunk/test/SemaCXX/warn-redundant-move.cpp (diff)clang.src/test/SemaCXX/warn-redundant-move.cpp
Revision 373420 by dblaikie:
DebugInfo: Update support for detecting C++ language variants in debug info emission
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/BinaryFormat/Dwarf.h (diff)llvm.src/include/llvm/BinaryFormat/Dwarf.h
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfDebug.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/DwarfDebug.cpp
The file was modified/llvm/trunk/lib/CodeGen/AsmPrinter/DwarfUnit.cpp (diff)llvm.src/lib/CodeGen/AsmPrinter/DwarfUnit.cpp
The file was modified/llvm/trunk/test/DebugInfo/X86/gnu-public-names.ll (diff)llvm.src/test/DebugInfo/X86/gnu-public-names.ll
Revision 373419 by nico:
gn build: (manually) merge r373407
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang/include/clang/AST/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/include/clang/AST/BUILD.gn
The file was modified/llvm/trunk/utils/gn/secondary/clang/lib/AST/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/lib/AST/BUILD.gn
The file was modified/llvm/trunk/utils/gn/secondary/clang/utils/TableGen/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/utils/TableGen/BUILD.gn
Revision 373418 by rsmith:
Fix crash on constant-evaluation of pseudo-destruction of a pointer.

We got confused and thought we might be pseudo-destroying the pointee
instead.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/AST/ExprConstant.cpp (diff)clang.src/lib/AST/ExprConstant.cpp
The file was modified/cfe/trunk/test/SemaCXX/constant-expression-cxx2a.cpp (diff)clang.src/test/SemaCXX/constant-expression-cxx2a.cpp
Revision 373417 by arsenm:
AMDGPU/GlobalISel: Use getIntrinsicID helper
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPUInstructionSelector.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
Revision 373416 by rjmccall:
Remove TypeNodes.def from the modulemap.

We currently just look for files named in the modulemap in its
associated source directory.  This means that we can't name
generated files, like TypeNodes.def now is, which means we can't
explicitly mark it as textual.  But fortunately that's okay
because (as I understand it) the most important purpose of naming
the header in the modulemap is to ensure that it's not treated as
public, and the search for public headers also only considers
files in the associated source directory.  This isn't an elegant
solution, since among other things it means that a build which
wrote the generated files directly into the source directory would
result in something that wouldn't build as a module, but that's
a problem for all our other generated files as well.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/module.modulemap (diff)clang.src/include/clang/module.modulemap
Revision 373415 by arsenm:
AMDGPU/GlobalISel: Assume VGPR for G_FRAME_INDEX

In principle this should behave as any other constant. However
eliminateFrameIndex currently assumes a VALU use and uses a vector
shift. Work around this by selecting to VGPR for now until
eliminateFrameIndex is fixed.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-frame-index.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/regbankselect-frame-index.mir
Revision 373414 by arsenm:
AMDGPU/GlobalISel: Private loads always use VGPRs
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPURegisterBankInfo.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/regbankselect-load.mir
Revision 373413 by arsenm:
AMDGPU/GlobalISel: Legalize 1024-bit G_BUILD_VECTOR

This will be needed to support AGPR operations.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp (diff)llvm.src/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/legalize-build-vector.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/legalize-build-vector.mir
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/legalize-phi.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/legalize-phi.mir
Revision 373412 by arsenm:
AMDGPU/GlobalISel: Fix RegBankSelect for 1024-bit values
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def (diff)llvm.src/lib/Target/AMDGPU/AMDGPUGenRegisterBankInfo.def
The file was modified/llvm/trunk/test/CodeGen/AMDGPU/GlobalISel/regbankselect-extract.mir (diff)llvm.src/test/CodeGen/AMDGPU/GlobalISel/regbankselect-extract.mir