FailedChanges

Summary

  1. [NFC][LoopIdiom] Adjust FIXME to be self-explanatory
  2. Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
  3. Fix cppcheck shadow variable name warnings. NFCI.
  4. [X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
  5. [lit] Adjust error handling for decode introduced by r374665 On that decode, Windows bots fail with: ``` UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128) ``` That's the same error as before r374665 except it's now at the decode before the write to stdout.
  6. [lit] Try yet again to fix new tests that fail on Windows bots I seem to have misread the bot logs on my last attempt. When lit's internal diff runs on Windows under Python 2.7, it's text diffs not binary diffs that need decoding to avoid this error when writing the diff to stdout: ``` UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128) ``` There is no `decode` attribute in this case under Python 3.6.8 under Ubuntu, so this patch checks for the `decode` attribute before using it here. Hopefully nothing else is needed when `decode` isn't available. It might take a couple more attempts to figure out what error handling, if any, is needed for this decoding.
  7. Revert r374657: "[lit] Try again to fix new tests that fail on Windows bots"
Revision 374670 by lebedevri:
[NFC][LoopIdiom] Adjust FIXME to be self-explanatory
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/LoopIdiomRecognize.cpp (diff)llvm.src/lib/Transforms/Scalar/LoopIdiomRecognize.cpp
Revision 374669 by rksimon:
Replace for-loop of SmallVector::push_back with SmallVector::append. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374668 by rksimon:
Fix cppcheck shadow variable name warnings. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374667 by rksimon:
[X86] Use any_of/all_of patterns in shuffle mask pattern recognisers. NFCI.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
Revision 374666 by jdenny:
[lit] Adjust error handling for decode introduced by r374665

On that decode, Windows bots fail with:

```
UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128)
```

That's the same error as before r374665 except it's now at the decode
before the write to stdout.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374665 by jdenny:
[lit] Try yet again to fix new tests that fail on Windows bots

I seem to have misread the bot logs on my last attempt.  When lit's
internal diff runs on Windows under Python 2.7, it's text diffs not
binary diffs that need decoding to avoid this error when writing the
diff to stdout:

```
UnicodeEncodeError: 'ascii' codec can't encode characters in position 7-8: ordinal not in range(128)
```

There is no `decode` attribute in this case under Python 3.6.8 under
Ubuntu, so this patch checks for the `decode` attribute before using
it here.  Hopefully nothing else is needed when `decode` isn't
available.

It might take a couple more attempts to figure out what error
handling, if any, is needed for this decoding.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374664 by jdenny:
Revert r374657: "[lit] Try again to fix new tests that fail on Windows bots"
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py