FailedChanges

Summary

  1. [Attributor][FIX] Do not apply h2s for arbitrary mallocs H2S did apply to mallocs of non-constant sizes if the uses were OK. This is now forbidden through reording of the "good" and "bad" cases in the conditional.
  2. [Attributor][FIX] Add missing function declaration in test case
  3. [Attributor][FIX] Avoid modifying naked/optnone functions The check for naked/optnone was insufficient for different reasons. We now check before we initialize an abstract attribute and we do it for all abstract attributes.
  4. [SROA] Reuse existing lifetime markers if possible Summary: If the underlying alloca did not change, we do not necessarily need new lifetime markers. This patch adds a check and reuses the old ones if possible. Reviewers: reames, ssarda, t.p.northover, hfinkel Subscribers: hiraditya, bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D68900
  5. Revert r374663 "[clang-format] Proposal for clang-format to give compiler style warnings" The test fails on macOS and looks a bit wrong, see comments on the review. Also revert follow-up r374686.
  6. gn build: (manually) merge r374663
  7. [libc++][test] Silence MSVC warning in std::optional test `make_optional<string>(4, 'X')` passes `4` (an `int`) as the first argument to `string`'s `(size_t, charT)` constructor, triggering a signed/unsigned mismatch warning when compiling with MSVC at `/W4`. The incredibly simple fix is to instead use an unsigned literal (`4u`).
  8. Revert r374648: "Reland r374388: [lit] Make internal diff work in pipelines" This series of patches still breaks a Windows bot.
  9. Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding handling" This series of patches still breaks a Windows bot.
  10. Revert r374650: "Reland r374390: [lit] Extend internal diff to support `-` argument" This series of patches still breaks a Windows bot.
  11. Revert 374651: "Reland r374392: [lit] Extend internal diff to support -U" This series of patches still breaks a Windows bot.
  12. Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use it" This series of patches still breaks a Windows bot.
  13. Revert r374653: "[lit] Fix a few oversights in r374651 that broke some bots" This series of patches still breaks a Windows bot.
  14. Revert r374665: "[lit] Try yet again to fix new tests that fail on Windows bots" This series of patches still breaks a Windows bot.
  15. Revert r374666: "[lit] Adjust error handling for decode introduced by r374665" This series of patches still breaks a Windows bot.
  16. Revert r374671: "[lit] Try errors="ignore" for decode introduced by r374665" This series of patches still breaks a Windows bot.
  17. [X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
Revision 374698 by jdoerfert:
[Attributor][FIX] Do not apply h2s for arbitrary mallocs

H2S did apply to mallocs of non-constant sizes if the uses were OK. This
is now forbidden through reording of the "good" and "bad" cases in the
conditional.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cpp (diff)llvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/heap_to_stack.ll (diff)llvm.src/test/Transforms/FunctionAttrs/heap_to_stack.ll
Revision 374696 by jdoerfert:
[Attributor][FIX] Add missing function declaration in test case
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/nonnull.ll (diff)llvm.src/test/Transforms/FunctionAttrs/nonnull.ll
Revision 374694 by jdoerfert:
[Attributor][FIX] Avoid modifying naked/optnone functions

The check for naked/optnone was insufficient for different reasons. We
now check before we initialize an abstract attribute and we do it for
all abstract attributes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.h (diff)llvm.src/include/llvm/Transforms/IPO/Attributor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cpp (diff)llvm.src/lib/Transforms/IPO/Attributor.cpp
The file was modified/llvm/trunk/test/Transforms/FunctionAttrs/nonnull.ll (diff)llvm.src/test/Transforms/FunctionAttrs/nonnull.ll
Revision 374692 by jdoerfert:
[SROA] Reuse existing lifetime markers if possible

Summary:
If the underlying alloca did not change, we do not necessarily need new
lifetime markers. This patch adds a check and reuses the old ones if
possible.

Reviewers: reames, ssarda, t.p.northover, hfinkel

Subscribers: hiraditya, bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D68900
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/Scalar/SROA.cpp (diff)llvm.src/lib/Transforms/Scalar/SROA.cpp
The file was added/llvm/trunk/test/Transforms/SROA/reuse_lifetime_markers.llllvm.src/test/Transforms/SROA/reuse_lifetime_markers.ll
Revision 374688 by nico:
Revert r374663 "[clang-format] Proposal for clang-format to give compiler style warnings"

The test fails on macOS and looks a bit wrong, see comments on the review.

Also revert follow-up r374686.
Change TypePath in RepositoryPath in Workspace
The file was removed/cfe/trunk/test/Format/dry-run-alias.cppclang.src/test/Format/dry-run-alias.cpp
The file was removed/cfe/trunk/test/Format/dry-run.cppclang.src/test/Format/dry-run.cpp
The file was modified/cfe/trunk/tools/clang-format/CMakeLists.txt (diff)clang.src/tools/clang-format/CMakeLists.txt
The file was modified/cfe/trunk/tools/clang-format/ClangFormat.cpp (diff)clang.src/tools/clang-format/ClangFormat.cpp
The file was modified/llvm/trunk/utils/gn/secondary/clang/tools/clang-format/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/tools/clang-format/BUILD.gn
Revision 374686 by nico:
gn build: (manually) merge r374663
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/gn/secondary/clang/tools/clang-format/BUILD.gn (diff)llvm.src/utils/gn/secondary/clang/tools/clang-format/BUILD.gn
Revision 374684 by caseycarter:
[libc++][test] Silence MSVC warning in std::optional test

`make_optional<string>(4, 'X')` passes `4` (an `int`) as the first argument to `string`'s `(size_t, charT)` constructor, triggering a signed/unsigned mismatch warning when compiling with MSVC at `/W4`. The incredibly simple fix is to instead use an unsigned literal (`4u`).
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/test/std/utilities/optional/optional.specalg/make_optional_explicit.pass.cpp (diff)libcxx.src/test/std/utilities/optional/optional.specalg/make_optional_explicit.pass.cpp
Revision 374683 by jdenny:
Revert r374648: "Reland r374388: [lit] Make internal diff work in pipelines"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/TestRunner.py (diff)llvm.src/utils/lit/lit/TestRunner.py
The file was removed/llvm/trunk/utils/lit/lit/builtin_commands/diff.pyllvm.src/utils/lit/lit/builtin_commands/diff.py
The file was added/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-error-0.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374682 by jdenny:
Revert r374649: "Reland r374389: [lit] Clean up internal diff's encoding handling"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.binllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.bin
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.utf16
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.utf8
The file was modified/llvm/trunk/utils/lit/tests/max-failures.py (diff)llvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374681 by jdenny:
Revert r374650: "Reland r374390: [lit] Extend internal diff to support `-` argument"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
The file was modified/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt (diff)llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-encodings.txt
The file was modified/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt (diff)llvm.src/utils/lit/tests/Inputs/shtest-shell/diff-pipes.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-r-error-7.txt
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-r-error-8.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.py (diff)llvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374680 by jdenny:
Revert 374651: "Reland r374392: [lit] Extend internal diff to support -U"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-unified.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-unified.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.py (diff)llvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374679 by jdenny:
Revert r374652: "[lit] Fix internal diff's --strip-trailing-cr and use it"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/MC/AsmParser/preserve-comments.s (diff)llvm.src/test/MC/AsmParser/preserve-comments.s
The file was modified/llvm/trunk/test/tools/llvm-cxxmap/remap.test (diff)llvm.src/test/tools/llvm-cxxmap/remap.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/profile-symbol-list.test (diff)llvm.src/test/tools/llvm-profdata/profile-symbol-list.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/roundtrip.test (diff)llvm.src/test/tools/llvm-profdata/roundtrip.test
The file was modified/llvm/trunk/test/tools/llvm-profdata/sample-remap.test (diff)llvm.src/test/tools/llvm-profdata/sample-remap.test
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.dosllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.dos
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-in.unixllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-in.unix
The file was removed/llvm/trunk/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txtllvm.src/utils/lit/tests/Inputs/shtest-shell/diff-strip-trailing-cr.txt
The file was modified/llvm/trunk/utils/lit/tests/max-failures.py (diff)llvm.src/utils/lit/tests/max-failures.py
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374678 by jdenny:
Revert r374653: "[lit] Fix a few oversights in r374651 that broke some bots"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/MC/ARM/preserve-comments-arm.s (diff)llvm.src/test/MC/ARM/preserve-comments-arm.s
The file was modified/llvm/trunk/utils/lit/tests/shtest-shell.py (diff)llvm.src/utils/lit/tests/shtest-shell.py
Revision 374677 by jdenny:
Revert r374665: "[lit] Try yet again to fix new tests that fail on Windows bots"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374676 by jdenny:
Revert r374666: "[lit] Adjust error handling for decode introduced by r374665"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374675 by jdenny:
Revert r374671: "[lit] Try errors="ignore" for decode introduced by r374665"

This series of patches still breaks a Windows bot.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/utils/lit/lit/builtin_commands/diff.py (diff)llvm.src/utils/lit/lit/builtin_commands/diff.py
Revision 374674 by rksimon:
[X86] scaleShuffleMask - use size_t Scale to avoid overflow warnings
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (diff)llvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.h (diff)llvm.src/lib/Target/X86/X86ISelLowering.h