FailedChanges

Summary

  1. Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in (details)
  2. Avoid memory leak in ASan test (details)
  3. Add __lsan::ScopedInterceptorDisabler for strerror(3) (details)
  4. Attempt to fix a windows buildbot failure (details)
Commit 8827047551570b7ed7088765c3de2a8cce6823b8 by n54
Stop tracking atexit/__cxa_atexit/pthread_atfork allocations in
LSan/NetBSD
Summary: The atexit(3) and __cxa_atexit() calls allocate internally
memory and free on exit, after executing all callback. This causes false
positives as DoLeakCheck() is called from the atexit handler. In the
LSan/ASan tests there are strict checks triggering false positives here.
Intercept all atexit(3) and __cxa_atexit() calls and disable LSan when
calling the real functions.
Stop tracing allocations in pthread_atfork(3) funtions, as there are
performed internal allocations that are not freed for the time of
running StopTheWorld() code. This avoids false-positives.
The same changes have to be replicated in the ASan and LSan runtime.
Non-NetBSD OSs are not tested and this code is restricted to NetBSD
only.
Reviewers: dvyukov, joerg, mgorny, vitalybuka, eugenis
Reviewed By: vitalybuka
Subscribers: jfb, llvm-commits, #sanitizers
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D67331
llvm-svn: 372459
The file was modifiedcompiler-rt/lib/asan/asan_interceptors.h
The file was modifiedcompiler-rt/lib/lsan/lsan_interceptors.cpp
The file was modifiedcompiler-rt/lib/asan/asan_interceptors.cpp
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_platform_interceptors.h
Commit 5fe1e55d35413b1904cfcf16ec15495398921fe5 by n54
Avoid memory leak in ASan test
Summary: Add missing free(3) for the malloc(3) call.
Detected on NetBSD with LSan.
Reviewers: joerg, mgorny, vitalybuka, dvyukov
Reviewed By: vitalybuka
Subscribers: llvm-commits, #sanitizers
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D67330
llvm-svn: 372460
The file was modifiedcompiler-rt/test/asan/TestCases/inline.cpp
Commit 1b58389428ed07a7322ba9c2bcaeec99807f9457 by n54
Add __lsan::ScopedInterceptorDisabler for strerror(3)
Summary: strerror(3) on NetBSD uses internally TSD with a destructor
that is never fired for exit(3). It's correctly called for
pthread_exit(3) scenarios.
This is a case when a leak on exit(3) is expected, unavoidable and
harmless.
Reviewers: joerg, vitalybuka, dvyukov, mgorny
Reviewed By: vitalybuka
Subscribers: dmgreen, kristof.beyls, jfb, llvm-commits, #sanitizers
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D67337
llvm-svn: 372461
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
The file was modifiedcompiler-rt/lib/asan/asan_interceptors.cpp
The file was modifiedcompiler-rt/lib/lsan/lsan_interceptors.cpp
Commit c90fda6abe84127a99a8fe4341b6ed7c8abee47e by kristof.umann
Attempt to fix a windows buildbot failure
llvm-svn: 372462
The file was modifiedclang/lib/StaticAnalyzer/Checkers/MallocChecker.cpp