SuccessChanges

Summary

  1. Add LLD to slow builder sanitizer bot. (details)
Commit 7b38316441a50c2a3f48cd3e5691c85b7234085f by 31459023+hctim
Add LLD to slow builder sanitizer bot.
Bots started spuriously failing this morning because the gcc-built
bootstrap clang then is used to check-*san. Some of the check-*san
suites (like check-hwasan) use -fuse-ld=lld in their lit config, and we
didn't build LLD.
Fix this by building LLD when we build the bootstrap clang.
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_cmake.sh (diff)

Summary

  1. [docs] Fix references to a renamed flag. (details)
  2. [lldb] Remove dead code from STLUtils.h (details)
  3. [test] Fix apple_simulator_test decorator when simulators are (details)
  4. [lldb] Mark ASan & TSan as test dependencies (details)
  5. When lowering calls and tail calls in AArch64, the register mask and (details)
  6. gn build: (manually) merge b5913e6d2f (details)
  7. [LoopPred] Selectively disable to preserve test cases (details)
  8. [LoopPred] Enable new transformation by default (details)
  9. unwind: reflow some of the build rules (NFC) (details)
  10. unwind: restore the LINKER_LANGUAGE (details)
  11. [AMDGPU] Add handling of 160 bit registers in analyzeResourceUsage (details)
  12. [LLDB] Adding caching to libc++ std::function formatter for lookups that (details)
  13. Temporarily Revert: (details)
  14. TableGen: Remove assert that pattern results match input number (details)
  15. AMDGPU: Select global atomicrmw fadd (details)
  16. Revert "Introduce llvm-install-name-tool" (details)
  17. Revert "gn build: (manually) merge b5913e6d2f" (details)
  18. [AArch64][SVE] Add remaining patterns and intrinsics for add/sub/mad (details)
  19. Keep import function list for inlinee profile update (details)
  20. [OPENMP] [DOCS] fix section formatting issues [NFC] (details)
Commit baaa097360a0e92164119574febcc5613221fa0d by Lang Hames
[docs] Fix references to a renamed flag.
The -use-mcjit option was replaced with -jit-kind=mcjit a while back.
This patch updates the docs to reflect that.
Patch by Yu Jian. Thanks Jian!
The file was modifiedllvm/docs/DebuggingJITedCode.rst
Commit cfca0056f054602dd46d1224c63d2275a4ecd90f by Jonas Devlieghere
[lldb] Remove dead code from STLUtils.h
The file was modifiedlldb/source/Commands/CommandObjectCommands.h
The file was modifiedlldb/include/lldb/Core/STLUtils.h
The file was modifiedlldb/source/Commands/CommandObjectSource.h
The file was modifiedlldb/source/API/SBTarget.cpp
The file was modifiedlldb/source/Commands/CommandObjectSource.cpp
The file was modifiedlldb/source/Commands/CommandObjectBreakpoint.h
Commit a6b5daa701d3a276ace90c688f913b96d396bed1 by apl
[test] Fix apple_simulator_test decorator when simulators are
unavailable
In the case where xcodebuild fails as you set up simulator tests, you
would fail because `feature` is never defined.
The file was modifiedlldb/packages/Python/lldbsuite/test/decorators.py
Commit 703c97be2492dfb0e4f3138e47fc1fe71c91adfa by Jonas Devlieghere
[lldb] Mark ASan & TSan as test dependencies
Without asan and tsan as test dependencies, you might end up with a
clang that points to sanitizer runtime library that hasn't been build
yet.
The file was modifiedlldb/test/CMakeLists.txt
Commit 8d694a45ab6626a5768240ca370774c72722ca7c by echristo
When lowering calls and tail calls in AArch64, the register mask and
return value location depends on the calling convention of the callee.
`F.getCallingConv()`, however, is the caller CC. Correct it to the
callee CC from `CallLoweringInfo`.
Fixes PR43449
Patch by Shu-Chun Weng!
The file was modifiedllvm/lib/Target/AArch64/AArch64CallLowering.cpp
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
The file was addedllvm/test/CodeGen/AArch64/arm64-preserve-most.ll
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/call-translator-tail-call.ll
Commit c52efdc52cef2597a1d21595a9685e2f798025b8 by thakis
gn build: (manually) merge b5913e6d2f
The file was modifiedllvm/utils/gn/secondary/llvm/tools/llvm-objcopy/BUILD.gn
Commit 20cbb6cdf8b33dd3732b9ef8702e7946b6d8c739 by listmail
[LoopPred] Selectively disable to preserve test cases
I'm about to enable the new loop predication transform by default.  It
has the effect of completely destroying many read only loops - which
happen to be a super common idiom in our test cases.  So as to preserve
test coverage of other transforms, disable the new transform where it
would cause sharp test coverage regressions.
(This is semantically part of the enabling commit.  It's committed
separate to ease revert if the actual flag flip gets reverted.)
The file was modifiedllvm/test/Transforms/IndVarSimplify/pr39673.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/lftr-dead-ivs.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/pr38674.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/eliminate-trunc.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/pr24356.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/no-iv-rewrite.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/sink-from-preheader.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/lftr-reuse.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/lftr.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/lftr-pr20680.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/loop-invariant-conditions.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/replace-loop-exit-folds.ll
Commit 8748be7750920b7bd669a47be72a81ee7f1d305c by listmail
[LoopPred] Enable new transformation by default
The basic idea of the transform is to convert variant loop exit
conditions into invariant exit conditions by changing the iteration on
which the exit is taken when we know that the trip count is
unobservable.  See the original patch which introduced the code for a
more complete explanation.
The individual parts of this have been reviewed, the result has been
fuzzed, and then further analyzed by hand, but despite all of that, I
will not be suprised to see breakage here.  If you see problems, please
don't hesitate to revert - though please do provide a test case.  The
most likely class of issues are latent SCEV bugs and without a reduced
test case, I'll be essentially stuck on reducing them.
(Note: A bunch of tests were opted out of the new transform to preserve
coverage.  That landed in a previous commit to simplify revert cycles if
they turn out to be needed.)
The file was modifiedllvm/lib/Transforms/Scalar/IndVarSimplify.cpp
The file was modifiedllvm/test/Transforms/LoopUnroll/scevunroll.ll
The file was modifiedllvm/test/Transforms/IndVarSimplify/exit_value_tests.ll
Commit aa582e3648cc4036aec3b9302ab93bfe9929d19c by Saleem Abdulrasool
unwind: reflow some of the build rules (NFC)
Reflow the CMake properties to take less vertical space.  This just
makes it easier to read.  NFC.
The file was modifiedlibunwind/src/CMakeLists.txt
Commit e74e61ff297e81c0a9bda54037033fc40fc76e1d by Saleem Abdulrasool
unwind: restore the LINKER_LANGUAGE
Have CMake treat the unwind libraries as C libraries rather than C++.
There is no C++ runtime dependency at runtime.  This ensures that we do
not accidentally end up with a link against the C++ runtime.
We need to explicitly reset the implicitly linked libraries for C++ to
ensure that we do not have CMake force the link against the C++ runtime.
This adjustment should enable the NetBSD bots to be happy with this
change.
The file was modifiedlibunwind/src/CMakeLists.txt
Commit d17bcf2bb9195c7d6ac8d8cf9faaa103bfd40ef2 by Stanislav.Mekhanoshin
[AMDGPU] Add handling of 160 bit registers in analyzeResourceUsage
This was omitted. Also SReg_96Reg missed IsSGPR assignment.
Differential Revision: https://reviews.llvm.org/D69919
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUAsmPrinter.cpp
The file was modifiedllvm/test/CodeGen/AMDGPU/call-graph-register-usage.ll
Commit e18f4db208baa84800cf304d7e15f2ee7343cd05 by shafik
[LLDB] Adding caching to libc++ std::function formatter for lookups that
require scanning symbols
Performance issues lead to the libc++ std::function formatter to be
disabled. This change is the first of two changes that should address
the performance issues and allow us to enable the formatter again. In
some cases we end up scanning the symbol table for the callable wrapped
by std::function for those cases we will now cache the results and used
the cache in subsequent look-ups. This still leaves a large cost for the
initial lookup which will be addressed in the next change.
Differential Revision: https://reviews.llvm.org/D67111
The file was modifiedlldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.h
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/TestLibCxxFunction.py
The file was modifiedlldb/source/Plugins/LanguageRuntime/CPlusPlus/CPPLanguageRuntime.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/function/main.cpp
Commit e511c4b0dff1692c267addf17dce3cebe8f97faa by echristo
Temporarily Revert:
"[SLP] Generalization of stores vectorization."
"[SLP] Fix -Wunused-variable. NFC"
"[SLP] Vectorize jumbled stores."
As they're causing significant (10-30x) compile time regressions on
vectorizable code.
The primary cause of the compile-time regression is
f228b5371647f471853c5fb3e6719823a42fe451.
This reverts commits:
f228b5371647f471853c5fb3e6719823a42fe451
5503455ccb3f5fcedced158332c016c8d3a7fa81
21d498c9c0f32dcab5bc89ac593aa813b533b43a
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/store-jumbled.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/bitreverse.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-usat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/stores_vectorize.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-mul.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-lshr.ll
The file was removedllvm/test/Transforms/SLPVectorizer/X86/jumbled_store_crash.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-ashr.ll
The file was modifiedllvm/include/llvm/Transforms/Vectorize/SLPVectorizer.h
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub-ssat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/different-vec-widths.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/shift-shl.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-fix.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/ctlz.ll
The file was modifiedllvm/lib/Transforms/Vectorize/SLPVectorizer.cpp
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/pr35497.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-ssat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-add-usat.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/arith-sub.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/cttz.ll
The file was modifiedllvm/test/Transforms/SLPVectorizer/X86/ctpop.ll
Commit 9f9f42dbc5f54bbee6785a62acc8cd7e5ed12ea5 by Matthew.Arsenault
TableGen: Remove assert that pattern results match input number
AMDGPU has some atomic instructions that do not return the previous
result, and can only be selected if there are no uses. The source
pattern will only match if the use is empty, so it should be safe to
discard the result.
The file was modifiedllvm/utils/TableGen/DAGISelMatcherGen.cpp
Commit e16a71382d689c39561e94b13af2feb4bf1b15cc by Matthew.Arsenault
AMDGPU: Select global atomicrmw fadd
This only works if there is no use of the return value.
The file was modifiedllvm/lib/Target/AMDGPU/SIISelLowering.cpp
The file was addedllvm/test/CodeGen/AMDGPU/global-atomics-fp.ll
The file was modifiedllvm/test/Transforms/AtomicExpand/AMDGPU/expand-atomic-rmw-fadd.ll
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.td
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
The file was modifiedllvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
The file was modifiedllvm/lib/Target/AMDGPU/FLATInstructions.td
Commit 7d83c2989092fbfc4afb41bed43848dbc69e35d6 by alexshap
Revert "Introduce llvm-install-name-tool"
This reverts commit b5913e6d2f6d13fb753df701619731ca11936316.
The file was removedllvm/test/tools/llvm-objcopy/MachO/install-name-tool-help-message.test
The file was modifiedllvm/tools/llvm-objcopy/CMakeLists.txt
The file was removedllvm/test/tools/llvm-objcopy/MachO/Inputs/x86_64.yaml
The file was modifiedllvm/tools/llvm-objcopy/CopyConfig.h
The file was modifiedllvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
The file was modifiedllvm/tools/llvm-objcopy/CopyConfig.cpp
The file was removedllvm/test/tools/llvm-objcopy/MachO/install-name-tool-version.test
The file was removedllvm/test/tools/llvm-objcopy/MachO/install-name-tool-add-rpath.test
The file was removedllvm/tools/llvm-objcopy/InstallNameToolOpts.td
The file was modifiedllvm/tools/llvm-objcopy/MachO/Object.cpp
The file was modifiedllvm/tools/llvm-objcopy/MachO/Object.h
The file was removedllvm/test/tools/llvm-objcopy/MachO/Inputs/i386.yaml
The file was modifiedllvm/tools/llvm-objcopy/llvm-objcopy.cpp
Commit fe6fee9445d8d7037aee0de5e04aa0ba97f7d802 by thakis
Revert "gn build: (manually) merge b5913e6d2f"
This reverts commit c52efdc52cef2597a1d21595a9685e2f798025b8, because
b5913e6d2f got reverted.
The file was modifiedllvm/utils/gn/secondary/llvm/tools/llvm-objcopy/BUILD.gn
Commit e55b536d7d810393f0a03c800e8263d83926090c by amehsan
[AArch64][SVE] Add remaining patterns and intrinsics for add/sub/mad
patterns
Add pattern matching and intrinsics for the following instructions:
predicated orr, eor, and, bic predicated mul, smulh, umulh, sdiv, udiv,
sdivr, udivr predicated smax, umax, smin, umin, sabd, uabd mad, msb,
mla, mls
https://reviews.llvm.org/D69588
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was addedllvm/test/CodeGen/AArch64/sve-int-mad-pred.ll
The file was addedllvm/test/CodeGen/AArch64/sve-int-mul-pred.ll
The file was addedllvm/test/CodeGen/AArch64/sve-int-log-pred.ll
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td
The file was modifiedllvm/test/CodeGen/AArch64/sve-int-arith-pred.ll
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td
The file was addedllvm/test/CodeGen/AArch64/sve-int-div-pred.ll
Commit ba1dfae054b4c9a8b11aabd62fd0dcb792366206 by aktoon
Keep import function list for inlinee profile update
Summary: When adjusting function entry counts after inlining,
Funciton::setEntryCount is called without providing an import function
list. The side effect of that is the previously set import function list
will be dropped. The import function list is used by ThinLTO to help
import hot cross module callee for LTO inlining, so dropping that during
ThinLTO pre-link may adversely affect LTO inlining. The fix is to keep
the list while updating entry counts for inlining.
Reviewers: wmi, davidxl, tejohnson
Subscribers: mehdi_amini, hiraditya, dexonsmith, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69736
The file was addedllvm/test/Transforms/SampleProfile/inline-callee-update.ll
The file was addedllvm/test/Transforms/SampleProfile/Inputs/inline-callee-update.prof
The file was modifiedllvm/lib/IR/Function.cpp
The file was modifiedllvm/lib/Transforms/Utils/InlineFunction.cpp
Commit 9f10cc2d124c275f2e7a6764e168f6b75527e78f by kkwli0
[OPENMP] [DOCS] fix section formatting issues [NFC]
Differential Revision: https://reviews.llvm.org/D69909
The file was modifiedclang/docs/OpenMPSupport.rst

Summary

  1. Add LLD to slow builder sanitizer bot. (details)
Commit 7b38316441a50c2a3f48cd3e5691c85b7234085f by 31459023+hctim
Add LLD to slow builder sanitizer bot.
Bots started spuriously failing this morning because the gcc-built
bootstrap clang then is used to check-*san. Some of the check-*san
suites (like check-hwasan) use -fuse-ld=lld in their lit config, and we
didn't build LLD.
Fix this by building LLD when we build the bootstrap clang.
The file was modifiedzorg/buildbot/builders/sanitizers/buildbot_cmake.sh