FailedChanges

Summary

  1. [InstCombine] fix comments to match code; NFC (details)
  2. [InstCombine] add icmp tests with extra uses; NFC (details)
  3. [clangd] Bump vscode-clangd v0.0.17 (details)
  4. [InstCombine] remove unneeded one-use checks for icmp fold (details)
  5. [ARM] Fold VCMP into VPT (details)
  6. [docs][llvm-size] Write llvm-size documentation (details)
Commit 91c2cd0691d1c84202e08e3d240a0fead0dfd8d5 by spatel
[InstCombine] fix comments to match code; NFC
This blob was written before match() existed, so it could probably be
reduced significantly.
But I suspect it isn't well tested, so tests would have to be added to
reduce risk from logic changes.
llvm-svn: 371978
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
Commit 14ce3fde046ad0e9f4266a611a2f3a040b976749 by spatel
[InstCombine] add icmp tests with extra uses; NFC
llvm-svn: 371979
The file was modifiedllvm/test/Transforms/InstCombine/icmp.ll
Commit 72b9c4f3bcea2a87580551afa96ad9f68c7cae38 by hokein
[clangd] Bump vscode-clangd v0.0.17
CHANGELOG:
- added semantic highlighting support (under the
clangd.semanticHighlighting
flag);
- better error message when clangd fails to execute refactoring-like
actions;
- improved the readme doc;
llvm-svn: 371980
The file was modifiedclang-tools-extra/clangd/clients/clangd-vscode/package.json
Commit c5cd80815666f535ffc37cd582e7576a29ba6816 by spatel
[InstCombine] remove unneeded one-use checks for icmp fold
This fold and several others were added in: rL125734
<https://reviews.llvm.org/rL125734>
...with no explanation for the one-use checks other than the code
comments about register pressure.
Given that this is IR canonicalization, we shouldn't be worried about
register pressure though; the backend should be able to adjust for that
as needed.
This is part of solving PR43310 the theoretically right way:
https://bugs.llvm.org/show_bug.cgi?id=43310
...ie, if we don't cripple basic transforms, then we won't need to add
special-case code to detect larger patterns.
rL371940 is a related patch in this series.
llvm-svn: 371981
The file was modifiedllvm/test/Transforms/InstCombine/icmp.ll
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
Commit ce7328cb61d0aedae2261d0e50c259336f125e88 by david.green
[ARM] Fold VCMP into VPT
MVE has VPT instructions, which perform the duties of both a VCMP and a
VPST in a single instruction, performing the compare and starting the
VPT block in one. This teaches the MVEVPTBlockPass to fold them,
searching back through the basicblock for a valid VCMP and creating the
VPT from its operands.
There are some changes to the VPT instructions to accommodate this,
altering the order of the operands to match the VCMP better, and
changing P0 register defs to be VPR defs, as is used in other places.
Differential Revision: https://reviews.llvm.org/D66577
llvm-svn: 371982
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-nots.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block4.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block5.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpfr.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block2.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpfz.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block6.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-masked-ldst.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vcmpf.ll
The file was modifiedllvm/lib/Target/ARM/ARMInstrMVE.td
The file was modifiedllvm/test/CodeGen/Thumb2/mve-pred-not.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block7.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block8.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-masked-store.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-pred-or.ll
The file was modifiedllvm/lib/Target/ARM/MVEVPTBlockPass.cpp
The file was modifiedllvm/test/CodeGen/Thumb2/mve-masked-load.ll
The file was modifiedllvm/test/CodeGen/Thumb2/mve-vpt-block3.mir
The file was modifiedllvm/test/CodeGen/Thumb2/mve-pred-and.ll
Commit e8ed932683ee6a26154ffc98c58e1888a2112494 by jh7370
[docs][llvm-size] Write llvm-size documentation
Previously we only had a stub document.
Reviewed by: serge-sans-paille, MaskRay
Differential Revision: https://reviews.llvm.org/D67555
llvm-svn: 371983
The file was modifiedllvm/docs/CommandGuide/llvm-size.rst