FailedChanges

Summary

  1. Revert "[FrontendTests] Don't actually run the full compiler, parsing is (details)
  2. [builtins][test] Avoid unportable mmap call in clear_cache_test.c (details)
  3. [FrontendTests] Try again to make test not write an output file (details)
  4. [LLVMDebugInfoPDB] - Use cantFail() instead of assert(). (details)
  5. [ThinLTO] Don't internalize during promotion (details)
  6. [Alignment][NFC] Attributes use Align/MaybeAlign (details)
Commit 2108a974f78afe5b098758e1a517cd159dcae95c by benny.kra
Revert "[FrontendTests] Don't actually run the full compiler, parsing is
sufficient."
This reverts commit 375488.
llvm-svn: 375489
The file was modifiedclang/unittests/Frontend/OutputStreamTest.cpp
Commit 1876e6c83c7a713de2851af686417892cd717adc by ro
[builtins][test] Avoid unportable mmap call in clear_cache_test.c
Within the last two weeks, the Builtins-*-sunos :: clear_cache_test.c
started to FAIL on Solaris.  Running it under truss shows
  mmap(0x00000000, 128, PROT_READ|PROT_WRITE|PROT_EXEC,
MAP_PRIVATE|MAP_ANON, 0, 0) Err#22 EINVAL
_exit(1)
While there are several possible reasons mmap can return EINVAL on
Solaris, it turns out it's this one (from mmap(2)):
  MAP_ANON  was  specified,  but the file descriptor was not
  -1.
And indeed even the Linux mmap(2) documents this as unportable:
  MAP_ANONYMOUS
         The mapping is not backed by any file; its contents are
initial‐
         ized to zero.  The fd argument is ignored; however, some
imple‐
         mentations require fd to be -1 if MAP_ANONYMOUS (or MAP_ANON)
is
         specified, and portable applications should  ensure  this. 
The
This patch follows this advise.  Tested on x86_64-pc-linux-gnu,
amd64-pc-solaris2.11 and sparcv9-sun-solaris2.11.
Differential Revision: https://reviews.llvm.org/D68455
llvm-svn: 375490
The file was modifiedcompiler-rt/test/builtins/Unit/clear_cache_test.c
Commit ecc999101aadc8dc7d4af9fd88be10fe42674aa0 by benny.kra
[FrontendTests] Try again to make test not write an output file
Setting the output stream to nulls seems to work.
llvm-svn: 375491
The file was modifiedclang/unittests/Frontend/OutputStreamTest.cpp
Commit 78d632d1055467dd2880dc9ff6dfdc554505eda7 by grimar
[LLVMDebugInfoPDB] - Use cantFail() instead of assert().
Currently injected-sources-native.test fails with "Expected<T> value was
in success state.
(Note: Expected<T> values in success mode must still be checked prior to
being destroyed)" when llvm is compiled with
LLVM_ENABLE_ABI_BREAKING_CHECKS in Release.
The problem is that getStringForID returns Expected<StringRef> and
Expected value must always be checked, even if it is in success state.
Checking with assert only helps in Debug and is wrong.
Differential revision: https://reviews.llvm.org/D69251
llvm-svn: 375492
The file was modifiedllvm/lib/DebugInfo/PDB/Native/NativeEnumInjectedSources.cpp
Commit 0f4186779e0415de8c771cba32f10b3023700ad7 by eleviant
[ThinLTO] Don't internalize during promotion
Differential revision: https://reviews.llvm.org/D69107
llvm-svn: 375493
The file was modifiedllvm/lib/Transforms/IPO/FunctionImport.cpp
The file was modifiedllvm/test/ThinLTO/X86/weak_externals.ll
The file was addedllvm/test/ThinLTO/X86/not-internalized.ll
Commit 17f5d2b1a5c942f1c0576c50274dbb07b6dc7036 by gchatelet
[Alignment][NFC] Attributes use Align/MaybeAlign
Summary: This is patch is part of a series to introduce an Alignment
type. See this thread for context:
http://lists.llvm.org/pipermail/llvm-dev/2019-July/133851.html See this
patch for the introduction of the type: https://reviews.llvm.org/D64790
Reviewers: courbet
Subscribers: jholewinski, hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D69278
llvm-svn: 375495
The file was modifiedllvm/include/llvm/IR/InstrTypes.h
The file was modifiedllvm/lib/IR/Attributes.cpp
The file was modifiedllvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
The file was modifiedllvm/include/llvm/IR/Function.h
The file was modifiedllvm/include/llvm/IR/Attributes.h
The file was modifiedllvm/lib/IR/AttributeImpl.h
The file was modifiedllvm/unittests/IR/AttributesTest.cpp