FailedChanges

Summary

  1. [lldb][DataFormatters] Support pretty printing std::string when built (details)
  2. [lit] Attempt to print test summary on CTRL+C (details)
  3. [APFloat] Fix subtraction of subnormal numbers (details)
  4. Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version (details)
  5. Reinstate MSan suppression of PR24578. (details)
  6. [APFloat] Enlarge ExponentType to 32bit integer (details)
  7. [clang-include-fixer] Suppress cmd prompt from Vim on Windows (details)
  8. Slightly speculative buildbot fix for issue reported in 8293f74 commit (details)
  9. [DWARF] Handle call sites with indirect call targets (details)
  10. [CMake] Support installation of InstrProfData.inc (details)
  11. Revert "[CMake] Support installation of InstrProfData.inc" (details)
Commit 506144da04b94d7d492ad34f7d3d81e8368677bb by rupprecht
[lldb][DataFormatters] Support pretty printing std::string when built
with -funsigned-char.
Summary: When built w/ `-funsigned-char`, `std::string` becomes
equivalent to `std::basic_string<unsigned char>`, causing these
formatters to not match. This patch adds overloads for both libstdc++
and libc++ string formatters that accepts unsigned char.
Motivated by the following example:
```
$ cat pretty_print.cc
template <typename T> void print_val(T s) {
std::cerr << s << '\n';  // Set a breakpoint here!
}
int main() {
std::string val = "hello";
print_val(val);
return 0;
}
$ clang++ -stdlib=libc++ -funsigned-char -fstandalone-debug -g
pretty_print.cc
$ lldb ./a.out -b -o 'b pretty_print.cc:6' -o r -o 'fr v'
...
(lldb) fr v
(std::__1::basic_string<unsigned char, std::__1::char_traits<unsigned
char>, std::__1::allocator<unsigned char> >) s = {
__r_ = {
   std::__1::__compressed_pair_elem<std::__1::basic_string<unsigned
char, std::__1::char_traits<unsigned char>, std::__1::allocator<unsigned
char> >::__rep, 0, false> = {
     __value_ = {
        = {
         __l = (__cap_ = 122511465736202, __size_ = 0, __data_ =
0x0000000000000000)
         __s = {
            = (__size_ = '\n', __lx = '\n')
           __data_ = {
             [0] = 'h'
             [1] = 'e'
             [2] = 'l'
             [3] = 'l'
             [4] = 'o'
             [5] = '\0'
...
```
Reviewers: labath, JDevlieghere, shafik
Subscribers: christof, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70517
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/main.cpp
The file was modifiedlldb/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/string/TestDataFormatterLibcxxString.py
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/main.cpp
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libstdcpp/string/TestDataFormatterStdString.py
Commit 718d68e6ca874fcb8a720790c899fa311f15675a by julian.lettner
[lit] Attempt to print test summary on CTRL+C
The file was modifiedllvm/utils/lit/lit/display.py
The file was modifiedllvm/utils/lit/lit/main.py
The file was modifiedllvm/utils/lit/lit/ProgressBar.py
Commit e62555c129d535d524354351791c5474c9929582 by ehudkatz
[APFloat] Fix subtraction of subnormal numbers
Fix incorrect determination of the bigger number out of the two
subtracted, while subnormal numbers are involved. Fixes PR44010.
Differential Revision: https://reviews.llvm.org/D69772
The file was modifiedllvm/unittests/ADT/APFloatTest.cpp
The file was modifiedllvm/lib/Support/APFloat.cpp
Commit 97e0fd27eb9b2004b4d51a859fe364ace8d46b35 by Vitaly Buka
Don't forward __pthread_mutex_* interceptors to pthread_mutex_* version
Summary: Allows to use rr with asan
Fixes PR41095
Reviewers: eugenis
Subscribers: jfb, #sanitizers, llvm-commits
Tags: #sanitizers, #llvm
Differential Revision: https://reviews.llvm.org/D70581
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_common_interceptors.inc
Commit 8ca7871addc53a8ddb356ae8b99fa6f7e0e8dd15 by eugenis
Reinstate MSan suppression of PR24578.
Summary: Revert "Rollback of commit "Repress sanitization on User
dtor.""
There is no point in keeping an active MSan error in the codebase.
PR24578 tracks the actual UB in LLVM code; this change enables testing
of LLVM with MSAN + -fsanitize-memory-use-after-dtor.
This reverts commit 21c1bc46aee2b69c2c48db8e961f0ce8394f21e1.
Reviewers: vitalybuka
Subscribers: hiraditya, llvm-commits
Tags: #llvm
Differential Revision: https://reviews.llvm.org/D70611
The file was modifiedllvm/include/llvm/Support/Compiler.h
The file was modifiedllvm/lib/IR/User.cpp
The file was modifiedllvm/lib/IR/Metadata.cpp
Commit 8606d013983d2098ba0d9ea9c2129a0b32a93e33 by ehudkatz
[APFloat] Enlarge ExponentType to 32bit integer
Enlarge the size of ExponentType from 16bit integer to 32bit. This is
required to prevent exponent overflow/underflow.
Note that IEEEFloat size and alignment don't change in 64bit or 32bit
compilation targets (and in turn, neither does APFloat).
Fixes PR34851.
Differential Revision: https://reviews.llvm.org/D69771
The file was modifiedllvm/include/llvm/ADT/APFloat.h
The file was modifiedllvm/unittests/ADT/APFloatTest.cpp
Commit e1e7b6f381a9a5640605fdc4a3e78eb01f8fc8b9 by rnk
[clang-include-fixer] Suppress cmd prompt from Vim on Windows
Copied from the clang-format.py editor integration.
Reviewers: bkramer
Differential Revision: https://reviews.llvm.org/D70518
The file was modifiedclang-tools-extra/clang-include-fixer/tool/clang-include-fixer.py
Commit 3f8a2af8f43faf6da15070108ceeacb9a5d2c42b by listmail
Slightly speculative buildbot fix for issue reported in 8293f74 commit
thread
The file was modifiedllvm/lib/Analysis/GuardUtils.cpp
Commit 4fdbc0728d4b8acb1921fc48301622e971fc3961 by Vedant Kumar
[DWARF] Handle call sites with indirect call targets
Split CallEdge into DirectCallEdge and IndirectCallEdge. Teach
DWARFExpression how to evaluate entry values in cases where the current
activation was created by an indirect call.
rdar://57094085
Differential Revision: https://reviews.llvm.org/D70100
The file was modifiedlldb/include/lldb/Symbol/SymbolFile.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.cpp
The file was modifiedlldb/include/lldb/Symbol/Function.h
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
The file was modifiedlldb/source/Expression/DWARFExpression.cpp
The file was modifiedlldb/source/Target/StackFrameList.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARFDebugMap.h
The file was modifiedlldb/packages/Python/lldbsuite/test/functionalities/param_entry_vals/basic_entry_values_x86_64/main.cpp
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.h
The file was modifiedlldb/source/Symbol/Function.cpp
Commit f11bc1776fd2815b60e0b1ed97be00b517348162 by phosek
[CMake] Support installation of InstrProfData.inc
This header fragment is useful on its own for any consumer that wants to
use custom instruction profile runtime with the LLVM instrumentation.
The concrete use case is in Fuchsia's kernel where we want to use
instruction profile instrumentation, but we cannot use the compiler-rt
runtime because it's not designed for use in the kernel environment.
This change allows installing this header as part of compiler-rt.
Differential Revision: https://reviews.llvm.org/D64532
The file was removedcompiler-rt/lib/profile/InstrProfData.inc
The file was modifiedcompiler-rt/lib/profile/InstrProfilingValue.c
The file was modifiedcompiler-rt/lib/profile/InstrProfilingMergeFile.c
The file was modifiedcompiler-rt/include/CMakeLists.txt
The file was modifiedcompiler-rt/lib/profile/InstrProfilingMerge.c
The file was modifiedcompiler-rt/lib/profile/InstrProfiling.h
The file was modifiedcompiler-rt/lib/profile/InstrProfilingWriter.c
The file was modifiedcompiler-rt/lib/profile/InstrProfiling.c
The file was addedcompiler-rt/include/profile/InstrProfData.inc
Commit 262b10ba1f9db4d00f43bcb1d8c1e557dced3bcd by phosek
Revert "[CMake] Support installation of InstrProfData.inc"
This reverts commit f11bc1776fd2815b60e0b1ed97be00b517348162 since it's
failing to build on some bots.
The file was modifiedcompiler-rt/lib/profile/InstrProfiling.h
The file was modifiedcompiler-rt/lib/profile/InstrProfilingValue.c
The file was modifiedcompiler-rt/lib/profile/InstrProfiling.c
The file was modifiedcompiler-rt/lib/profile/InstrProfilingWriter.c
The file was removedcompiler-rt/include/profile/InstrProfData.inc
The file was modifiedcompiler-rt/lib/profile/InstrProfilingMerge.c
The file was modifiedcompiler-rt/lib/profile/InstrProfilingMergeFile.c
The file was modifiedcompiler-rt/include/CMakeLists.txt
The file was addedcompiler-rt/lib/profile/InstrProfData.inc