SuccessChanges

Summary

  1. clang-x86-ninja-win10 enabling LLD (details)
Commit b1195d9085987c09d9c1ada0b47122d6bfc00771 by kuhnel
clang-x86-ninja-win10 enabling LLD
The file was modifiedbuildbot/osuosl/master/config/builders.py (diff)

Summary

  1. Revert "[lld-macho] Implement and test resolution of common symbols" (details)
  2. Revert "[lld-macho] Initial support for common symbols" (details)
  3. [flang][driver] Fix options flag in the frontend driver (details)
  4. [OpenMP][MLIR] Add assembly format for master op (details)
  5. [flang][driver] Add missing dependency in CMake files (details)
  6. [flang][NFC] Fix CMake variable name in README.md (details)
  7. [clangd] Disable suffix matching fallback for C during include insertion (details)
  8. [clangd] Fix comment. NFC (details)
  9. [llvm-objcopy][MachO] Fix --add-section (details)
  10. [mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp. (details)
  11. [SVE] Add new isKnownXX comparison functions to TypeSize (details)
  12. [clang][Sema] Use enumerator instead of hard-coded constant (details)
  13. [unittests] Use std::make_tuple to make some toolchains happy again (details)
  14. [llvm] Use instead of  in IRSimilarityIdentifierTest.cpp. (details)
Commit c367f93e8539c4d0bcdc86ad7ea7923e06231a93 by omair.javaid
Revert "[lld-macho] Implement and test resolution of common symbols"

This reverts commit cd7cb0c30305501982ba37b4905bb264b3539ad0.
Break lldb Arm build:
http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409
The file was modifiedlld/MachO/SymbolTable.cpp
The file was removedlld/test/MachO/common-symbol-resolution.s
The file was modifiedlld/test/MachO/nonweak-definition-override.s
Commit 8112d494d344dc0935d5c078f066a43d7c984e0c by omair.javaid
Revert "[lld-macho] Initial support for common symbols"

This reverts commit 63ace77962543f961f1d566dd1243b1fb37129ef.

Breaks LLDB Arm build:
http://lab.llvm.org:8011/builders/lldb-arm-ubuntu/builds/4409
The file was modifiedlld/MachO/Symbols.h
The file was modifiedlld/MachO/SyntheticSections.h
The file was modifiedlld/MachO/Driver.cpp
The file was modifiedlld/MachO/SymbolTable.cpp
The file was modifiedlld/MachO/SymbolTable.h
The file was modifiedlld/MachO/InputFiles.cpp
The file was removedlld/test/MachO/common-symbol-coalescing.s
Commit 99edb9b79c46706a41921c4edb1b849c1a618d26 by andrzej.warzynski
[flang][driver] Fix options flag in the frontend driver

In the frontend driver we should be using FC1Option (frontend driver
options) instead of FlangOption (flang driver options).

Differential Revision: https://reviews.llvm.org/D88108
The file was modifiedflang/lib/FrontendTool/ExecuteCompilerInvocation.cpp
Commit 7a6627b83539cc3b7970764e96dcfc2c9607b47f by kiran.chandramohan
[OpenMP][MLIR] Add assembly format for master op

Reviewed By: SouraVX, kiranktp

Differential Revision: https://reviews.llvm.org/D87549
The file was modifiedmlir/test/Dialect/OpenMP/ops.mlir
The file was modifiedmlir/include/mlir/Dialect/OpenMP/OpenMPOps.td
Commit 2f90e01a963acc1a4db2fbdd1c7fcf1433955744 by andrzej.warzynski
[flang][driver] Add missing dependency in CMake files

The Flang driver depends on libclangBasic. This means, among other
things, that some of the tablegen files (e.g. diagnostic definitions)
need to be generated before various libclangBasic header files can be
included (e.g. DiagnosticIDs.h). If we are lucky, libclangBasic is
indeed built before various flang driver libraries that depend on it
are. This patch makes sure that this is deterministic - i.e.
libclangBasic is built before the Flang driver libraries are.

Differential Revision: https://reviews.llvm.org/D88110
The file was modifiedflang/lib/FrontendTool/CMakeLists.txt
The file was modifiedflang/lib/Frontend/CMakeLists.txt
Commit 27da2875070ac00f6cd9f8040c6f994aca915406 by andrzej.warzynski
[flang][NFC] Fix CMake variable name in README.md

The CMake variable for the new flang driver is FLANG_BUILD_NEW_DRIVER
rather than BUILD_FLANG_NEW_DRIVER.
The file was modifiedflang/README.md
Commit 64168c6d996b6fdd017488785e0e9ce5ce05be54 by kadircet
[clangd] Disable suffix matching fallback for C during include insertion

Clangd currently doesn't respect language and breaks the builds with
include insertion for C. This patch aims to stop the bleeding by not mapping
back to CPP standard library headers.

Improves https://github.com/clangd/clangd/issues/376.

Differential Revision: https://reviews.llvm.org/D88144
The file was modifiedclang-tools-extra/clangd/unittests/CanonicalIncludesTests.cpp
The file was modifiedclang-tools-extra/clangd/index/CanonicalIncludes.cpp
Commit 98756d865b696bece858ff0832ed3687b6b8ba4b by sam.mccall
[clangd] Fix comment. NFC
The file was modifiedclang-tools-extra/clangd/XRefs.cpp
Commit e60a760b7da970b6eeabc26faa9e065ec7cec1a8 by alexshap
[llvm-objcopy][MachO] Fix --add-section

This diff fixes --add-section functionality and simplifies the tests organization.

Test plan: make check-all

Differential revision: https://reviews.llvm.org/D87497
The file was addedllvm/test/tools/llvm-objcopy/MachO/add-section-64.test
The file was removedllvm/test/tools/llvm-objcopy/MachO/add-section.test
The file was addedllvm/test/tools/llvm-objcopy/MachO/add-section-error.test
The file was modifiedllvm/tools/llvm-objcopy/MachO/Object.h
The file was addedllvm/test/tools/llvm-objcopy/MachO/add-section-32.test
The file was modifiedllvm/tools/llvm-objcopy/MachO/MachOObjcopy.cpp
The file was modifiedllvm/tools/llvm-objcopy/MachO/Object.cpp
Commit 56ffb8d1697932c1097fba3315dba6d9e55b7bb8 by pifon
[mlir] Stop allowing LLVMType Int arguments for GPULaunchFuncOp.

Conversion to LLVM becomes confusing and incorrect if someone tries to lower
STD -> LLVM and only then GPULaunchFuncOp to LLVM separately. Although it is
technically allowed now, it works incorrectly because of the argument
promotion. The correct way to use this conversion pattern is to add to the
STD->LLVM patterns before running the pass.

Differential Revision: https://reviews.llvm.org/D88147
The file was modifiedmlir/include/mlir/Dialect/GPU/GPUOps.td
The file was modifiedmlir/test/Conversion/GPUCommon/lower-launch-func-to-gpu-runtime-calls.mlir
Commit 4035cb7ac5755357222b6a83d76bdc4c2d718c54 by david.sherwood
[SVE] Add new isKnownXX comparison functions to TypeSize

This patch introduces four new comparison functions:

  isKnownLT, isKnownLE, isKnownGT, isKnownGE

that return true if we know at compile time that a particular
condition is met, i.e. that one size is definitely greater than
another. The existing operators <,>,<=,>= remain in the code for
now, but over time we would like to remove them and change the
code to use the isKnownXY routines instead. These functions do
not assert like the existing operators because the caller is
expected to properly deal with cases where we return false by
analysing the scalable properties. I've made more of an effort
to deal with cases where there are mixed comparisons, i.e. between
fixed width and scalable types.

I've also added some knownBitsXY routines to the EVT and MVT
classes that call the equivalent TypeSize::isKnownXY routines.
I've changed the existing bitsXY functions to call their knownBitsXY
equivalents and added asserts that the scalable properties match.
Again, over time we expect to migrate callers to use knownBitsXY
and make the code more aware of the scalable nature of the sizes.

Differential revision: https://reviews.llvm.org/D88098
The file was modifiedllvm/include/llvm/CodeGen/ValueTypes.h
The file was modifiedllvm/include/llvm/Support/TypeSize.h
The file was modifiedllvm/include/llvm/Support/MachineValueType.h
Commit 8cc842a95072aaa87b5067a12aa9ef5b3ac8e592 by mikhail.maltsev
[clang][Sema] Use enumerator instead of hard-coded constant

Sema::DiagnoseSwiftName uses the constant 12 instead of the
corresponding enumerator ExpectedFunctionWithProtoType. This is
fragile and will fail if a new value gets added in the middle of the
enum.

Reviewed By: aaron.ballman

Differential Revision: https://reviews.llvm.org/D88164
The file was modifiedclang/lib/Sema/SemaDeclAttr.cpp
Commit a1217620a87f66616c15e869d56783ba18e51b12 by mikael.holmen
[unittests] Use std::make_tuple to make some toolchains happy again

My toolchain stopped working (LLVM 8.0, libstdc++ 5.4.0) after 577adda:

06:25:37 ../unittests/Support/Path.cpp:91:7: error: chosen constructor is explicit in copy-initialization
06:25:37       {"", false, false},  {"/", true, true},      {"/foo", true, true},
06:25:37       ^~~~~~~~~~~~~~~~~~
06:25:37 /proj/flexasic/app/llvm/8.0/bin/../lib/gcc/x86_64-unknown-linux-gnu/5.4.0/../../../../include/c++/5.4.0/tuple:479:19: note: explicit constructor declared here
06:25:37         constexpr tuple(_UElements&&... __elements)
06:25:37                   ^

This commit adds explicit calls to std::make_tuple to work around
the problem.
The file was modifiedllvm/unittests/Support/Path.cpp
Commit a90d72127a814ea242227456be711aca07cc83a6 by pifon
[llvm] Use instead of  in IRSimilarityIdentifierTest.cpp.
The file was modifiedllvm/unittests/Analysis/IRSimilarityIdentifierTest.cpp