SuccessChanges

Summary

  1. [docs] Recommend dropLocation() over setDebugLoc(DebugLoc()) (details)
  2. [NFC][MSAN] Remove an attribute in test (details)
  3. [NFC][Msan] Add llvm.fabs test (details)
  4. Fix test failures with trunk clang (details)
  5. [lldb] Hoist -s (trace directory) argument out of LLDB_TEST_COMMON_ARGS (NFC) (details)
  6. [gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation(), NFC (details)
  7. Add remquo, frexp and modf overload functions to HIP header (details)
  8. [RISCV] Use the extensions in the canonical order (NFC) (details)
  9. [AIX] asm output: use character literals in byte lists for strings (details)
  10. [X86] Increase the depth threshold required to form VPERMI2W/VPERMI2B in shuffle combining (details)
  11. [GlobalISel] Fix multiply with overflow intrinsics legalization generating invalid MIR. (details)
  12. Remove further OpenBSD/sparc bits (details)
  13. [gn build] Add missing dependency to Extensions (details)
  14. [mlir] Update docs referencing OpTrait::Symbol. (details)
  15. Remove test AST/const-fpfeatures-diag.c (details)
  16. [lldb] Use config.lldb_src_root in lit_config.load_config (NFC) (details)
  17. [ARM] Change VPT state assertion (details)
  18. [RDA] Switch isSafeToMove iterators (details)
  19. [NFC][ARM] Add LowOverheadLoop test (details)
  20. [clangd] Extract options struct for ClangdLSPServer. NFC (details)
  21. [clangd] Mark code action as "preferred" if it's the sole quickfix action (details)
  22. [ARM][LowOverheadLoops] TryRemove helper. (details)
  23. [MLIR][Standard] Add `atan2` to standard dialect (details)
  24. [llvm-readobj][ARM] - Improve support of printing unwind (-u) information for non-relocatable objects. (details)
  25. [llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test (details)
  26. Revert "[gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation(), NFC" (details)
Commit f71849c74ed58e5d9ed3681cc6294128098012dc by Vedant Kumar
[docs] Recommend dropLocation() over setDebugLoc(DebugLoc())
The file was modifiedllvm/docs/HowToUpdateDebugInfo.rst
Commit 616c68aab75016d5d7ebc0b79bb3c38405b18ae6 by Vitaly Buka
[NFC][MSAN] Remove an attribute in test
The file was modifiedllvm/test/Instrumentation/MemorySanitizer/abs-vector.ll
Commit 795d94fdb9d2377452f86952dcf0921a6c68d2b5 by Vitaly Buka
[NFC][Msan] Add llvm.fabs test

llvm.fabs does not need a special handler as llvm.abs as its
single argument type match the return type.
The file was modifiedllvm/test/Instrumentation/MemorySanitizer/abs-vector.ll
Commit afcf9c47c5e74a0b567531547b677ff1d383ae50 by richard
Fix test failures with trunk clang

- Make the consteval constructor for the zero type be noexcept
- Don't expect three-way comparison of 0 against a comparison category
  to fail
The file was modifiedlibcxx/test/std/language.support/cmp/cmp.categories.pre/zero_type.verify.cpp
The file was modifiedlibcxx/include/compare
Commit bd14d6ea1517c93ceecaec29dad016d9a122fa1b by Jonas Devlieghere
[lldb] Hoist -s (trace directory) argument out of LLDB_TEST_COMMON_ARGS (NFC)

Give the trace directory argument its own variable
(LLDB_TEST_TRACE_DIRECTORY) so that we can configure it in
lit.site.cfg.py if we so desire.
The file was modifiedlldb/test/API/lit.cfg.py
The file was modifiedlldb/test/API/lit.site.cfg.py.in
The file was modifiedlldb/utils/lldb-dotest/CMakeLists.txt
The file was modifiedlldb/utils/lldb-dotest/lldb-dotest.in
The file was modifiedlldb/test/API/CMakeLists.txt
Commit 674f57870f4c8a7fd7b629bffc85b149cbefd3e0 by Vedant Kumar
[gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation(), NFC
The file was modifiedllvm/lib/Transforms/Scalar/LICM.cpp
The file was modifiedllvm/lib/Transforms/Utils/SimplifyCFG.cpp
Commit d04775e16bba456f0be0aaa7478959c5bfa22c41 by Yaxun.Liu
Add remquo, frexp and modf overload functions to HIP header
The file was modifiedclang/lib/Headers/__clang_hip_math.h
Commit c6b18cf9672bca4f61bb3ef401173742068e46ea by ebahapo
[RISCV] Use the extensions in the canonical order (NFC)

Use the ISA extensions for specific processors in the conventional canonical order.
The file was modifiedllvm/lib/Target/RISCV/RISCV.td
Commit 0a146a9d0bdd54411f0b0712e27481a4c280ae03 by hubert.reinterpretcast
[AIX] asm output: use character literals in byte lists for strings

This patch improves the assembly output produced for string literals by
using character literals in byte lists. This provides the benefits of
having printable characters appear as such in the assembly output and of
having strings kept as logical units on the same line.

Reviewed By: daltenty

Differential Revision: https://reviews.llvm.org/D80953
The file was modifiedllvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-str.ll
The file was modifiedllvm/include/llvm/MC/MCAsmInfo.h
The file was modifiedllvm/test/CodeGen/PowerPC/aix-xcoff-rodata.ll
The file was addedllvm/test/CodeGen/PowerPC/aix-bytestring.ll
The file was modifiedllvm/lib/MC/MCAsmStreamer.cpp
The file was modifiedllvm/lib/MC/MCAsmInfoXCOFF.cpp
The file was modifiedllvm/test/CodeGen/PowerPC/aix-xcoff-data.ll
Commit 618a890b72f874cbc41168737d03f724f58805fc by craig.topper
[X86] Increase the depth threshold required to form VPERMI2W/VPERMI2B in shuffle combining

These instructions are implemented with two port 5 uops and one port 015 uop so they are more complicated that most shuffles.

This patch increases the depth threshold for when we form them during shuffle combining to try to limit increasing the number of uops especially on port 5.

Differential Revision: https://reviews.llvm.org/D88503
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-128-v16.ll
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-256-v32.ll
The file was modifiedllvm/test/CodeGen/X86/vector-zext.ll
The file was modifiedllvm/test/CodeGen/X86/vector-shuffle-128-v8.ll
The file was modifiedllvm/test/CodeGen/X86/min-legal-vector-width.ll
The file was modifiedllvm/lib/Target/X86/X86ISelLowering.cpp
Commit 1d54e75cf26a4c60b66659d5d9c62f4bb9452b03 by Amara Emerson
[GlobalISel] Fix multiply with overflow intrinsics legalization generating invalid MIR.

During lowering of G_UMULO and friends, the previous code moved the builder's
insertion point to be after the legalizing instruction. When that happened, if
there happened to be a "G_CONSTANT i32 0" immediately after, the CSEMIRBuilder
would try to find that constant during the buildConstant(zero) call, and since
it dominates itself would return the iterator unchanged, even though the def
of the constant was *after* the current insertion point. This resulted in the
compare being generated *before* the constant which it was using.

There's no need to modify the insertion point before building the mul-hi or
constant. Delaying moving the insert point ensures those are built/CSEd before
the G_ICMP is built.

Fixes PR47679

Differential Revision: https://reviews.llvm.org/D88514
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/llvm-ir/mul.ll
The file was modifiedllvm/test/CodeGen/Mips/GlobalISel/legalizer/mul.mir
The file was modifiedllvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
The file was modifiedllvm/test/CodeGen/AArch64/GlobalISel/legalize-mul.mir
Commit 6f01c53f26af7fb0393464079ec5e839a497d4da by brad
Remove further OpenBSD/sparc bits
The file was modifiedclang/lib/Driver/ToolChains/CommonArgs.cpp
Commit e6e73712ddfa18d4a2937a5775990dcefc8bd2f7 by aeubanks
[gn build] Add missing dependency to Extensions
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Extensions/BUILD.gn
Commit 1c5aa8aeca29c7d4b891e5b60b25fdb74f9bf0e9 by joker.eph
[mlir] Update docs referencing OpTrait::Symbol.

Since https://reviews.llvm.org/D78522, Symbol is not a Trait itself.

Reviewed By: rriddle

Differential Revision: https://reviews.llvm.org/D88512
The file was modifiedmlir/docs/Traits.md
The file was modifiedmlir/docs/Interfaces.md
The file was modifiedmlir/docs/SymbolsAndSymbolTables.md
Commit 4e4f926e83cf77f0d36b821a3d2aa1de78338a82 by sepavloff
Remove test AST/const-fpfeatures-diag.c

This test is going to be removed because using dynamic rounding mode
in initializers is changing. It also causes build failures in some
cases, so remove it now.
The file was removedclang/test/AST/const-fpfeatures-diag.c
Commit 154860af338f7b0c82cb04e91d6f199aa72cfdff by Jonas Devlieghere
[lldb] Use config.lldb_src_root in lit_config.load_config (NFC)

Rather than relaying on CMake to substitute the full path to the lldb
source root, use the  value set in config.lldb_src_root. This makes it
slightly easier to write a custom lit.site.cfg.py.
The file was modifiedlldb/test/Unit/lit.site.cfg.py.in
The file was modifiedlldb/test/API/lit.site.cfg.py.in
The file was modifiedlldb/test/Shell/lit.site.cfg.py.in
Commit 195c22f2733cf923b932412f0fe212f4ef397d2c by sam.parker
[ARM] Change VPT state assertion

Just because we haven't encountered an instruction setting the VPR,
it doesn't mean we can't create a VPT block - the VPR maybe a
live-in.

Differential Revision: https://reviews.llvm.org/D88224
The file was addedllvm/test/CodeGen/Thumb2/LowOverheadLoops/begin-vpt-without-inst.mir
The file was modifiedllvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
Commit 700f93e92b6d4cdbab66133f75c143c9677f2d41 by sam.parker
[RDA] Switch isSafeToMove iterators

So forwards is forwards and backwards is reverse. Also add a check
so that we know the instructions are in the expected order.

Differential Revision: https://reviews.llvm.org/D88419
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/move-def-before-start.mir
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/it-block-mov.mir
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/mov-operand.ll
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/lstp-insertion-position.mir
The file was modifiedllvm/lib/CodeGen/ReachingDefAnalysis.cpp
The file was modifiedllvm/test/CodeGen/Thumb2/LowOverheadLoops/move-start-after-def.mir
Commit 834b6470d9f111c355053ecff8bed71bf44a6624 by sam.parker
[NFC][ARM] Add LowOverheadLoop test
The file was addedllvm/test/CodeGen/Thumb2/LowOverheadLoops/it-block-chain-store.mir
Commit 7ba0779fbb41b6fa8213aa31622ff45484037eb4 by sam.mccall
[clangd] Extract options struct for ClangdLSPServer. NFC

In preparation for making moving TweakFilter from ClangdServer::Options to
a ClangdLSPServer option, and letting it vary per-request.
(In order to implement CodeActionParams.only)

Also a general overdue cleanup.

Differential Revision: https://reviews.llvm.org/D88470
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.h
The file was modifiedclang-tools-extra/clangd/tool/ClangdMain.cpp
The file was modifiedclang-tools-extra/clangd/unittests/ClangdLSPServerTests.cpp
Commit 8392685c2b9f3c2025100dd25b6c6e5eae312d92 by sam.mccall
[clangd] Mark code action as "preferred" if it's the sole quickfix action

Differential Revision: https://reviews.llvm.org/D88489
The file was modifiedclang-tools-extra/clangd/test/fixits-embed-in-diagnostic.test
The file was modifiedclang-tools-extra/clangd/Diagnostics.cpp
The file was modifiedclang-tools-extra/clangd/Protocol.cpp
The file was modifiedclang-tools-extra/clangd/Protocol.h
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
Commit 779a8a028f53f16234b41e5252b805304788b989 by sam.parker
[ARM][LowOverheadLoops] TryRemove helper.

Make a helper function that wraps around RDA::isSafeToRemove and
utilises the existing DCE IT block checks.
The file was modifiedllvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
The file was modifiedllvm/lib/CodeGen/ReachingDefAnalysis.cpp
Commit cdda7822d6ce9cd6fe305e6fffedf3480d4bb769 by frgossen
[MLIR][Standard] Add `atan2` to standard dialect

Differential Revision: https://reviews.llvm.org/D88168
The file was modifiedmlir/include/mlir/Dialect/StandardOps/IR/Ops.td
The file was modifiedmlir/test/Dialect/Standard/ops.mlir
Commit fdceec7aeac6ae0fba4db9703bf4e4e69a126d0d by grimar
[llvm-readobj][ARM] - Improve support of printing unwind (-u) information for non-relocatable objects.

This is the one more patch for https://bugs.llvm.org/show_bug.cgi?id=47581

It fixes how we print an information for the Generic model. With this patch
we are able to read values from `.ARM.extab` and dump proper personality routines names/addresses.

Differential revision: https://reviews.llvm.org/D88478
The file was modifiedllvm/test/tools/llvm-readobj/ELF/ARM/unwind-non-relocatable.test
The file was modifiedllvm/tools/llvm-readobj/ARMEHABIPrinter.h
Commit 0767a0b53e37009a70788c2a44834ed14a951cba by grimar
[llvm-readobj][test] - Stop using few precompiled binaries in mips-got.test

This removes 4 input files (one source file and 3 precompiled binaries) from
`mips-got.test` (now YAMLs are used instead) and also makes the testing of
the GNU output a bit stricter (`--strict-whitespace --match-full-lines`).

Differential revision: https://reviews.llvm.org/D88488
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/got-tls.so.elf-mips64el
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/dynamic-table.c
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/dynamic-table-so.mips
The file was removedllvm/test/tools/llvm-readobj/ELF/Inputs/dynamic-table-exe.mips
The file was modifiedllvm/test/tools/llvm-readobj/ELF/mips-got.test
Commit 05659606a2af76710fb19a65fbd1a6c88ba12dad by jeremy.morse
Revert "[gardening] Replace some uses of setDebugLoc(DebugLoc()) with dropLocation(), NFC"

Some of the buildbots have croaked with this patch, for examples failures
that begin in this build:

  http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/29933

This reverts commit 674f57870f4c8a7fd7b629bffc85b149cbefd3e0.
The file was modifiedllvm/lib/Transforms/Utils/SimplifyCFG.cpp
The file was modifiedllvm/lib/Transforms/Scalar/LICM.cpp