SuccessChanges

Summary

  1. [mlir][Linalg] Fix ASAN bug (details)
  2. [SVE][CodeGen] Lower scalable fp_extend & fp_round operations (details)
  3. [CFGuard] Add address-taken IAT tables and delay-load support (details)
  4. [InstCombine] collectBitParts - use APInt directly to check for out of range bit shifts. NFCI. (details)
  5. [lldb] Skip the flakey part of TestStopHookScripted on Linux (details)
  6. [libc++] Simplify how we re-export symbols from libc++abi (details)
  7. [lldb] Add missing import for LLDB test decorators to TestStopHookScripted (details)
  8. [NFC][ARM] LowOverheadLoop DEBUG statements (details)
  9. [LoopFlatten] Add a loop-flattening pass (details)
  10. [gn build] Port d53b4bee0cc (details)
  11. [Archive] Don't throw away errors for malformed archive members (details)
  12. [SVE][CodeGen] Replace use of TypeSize operator< in GlobalMerge::doMerge (details)
  13. [AMDGPU] Tiny cleanup in isLegalFLATOffset. NFC. (details)
  14. [IR] PatternMatch - add m_FShl/m_FShr funnel shift intrinsic matchers. NFCI. (details)
  15. [InstCombine] Use m_FAbs matcher helper. NFCI. (details)
  16. [compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake (details)
  17. [clangd] clangd --check: standalone diagnosis of common problems (details)
Commit a81b938b6dee0e1ed4dd44e7d59325d0aa4774cc by ntv
[mlir][Linalg] Fix ASAN bug

```
LinalgTilingOptions &setTileSizes(ValueRange ts)
```
makes it all too easy to create stack-use-after-return errors.

In particular, c694588fc52a8845174fee06ad0bcfa338e87816 introduced one such issue.

Instead just take a copy in the lambda and be done with it.
The file was modifiedmlir/include/mlir/Dialect/Linalg/Transforms/Transforms.h
Commit fcf70e1e3b1d57d5fde6b99d0188d1b1774429af by kerry.mclaughlin
[SVE][CodeGen] Lower scalable fp_extend & fp_round operations

This patch adds FP_EXTEND_MERGE_PASSTHRU & FP_ROUND_MERGE_PASSTHRU
ISD nodes, used to lower scalable vector fp_extend/fp_round operations.
fp_round has an additional argument, the 'trunc' flag, which is an integer of zero or one.

This also fixes a warning introduced by the new tests added to sve-split-fcvt.ll,
resulting from an implicit TypeSize -> uint64_t cast in SplitVecOp_FP_ROUND.

Reviewed By: sdesmalen, paulwalker-arm

Differential Revision: https://reviews.llvm.org/D88321
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.h
The file was modifiedllvm/lib/Target/AArch64/SVEInstrFormats.td
The file was modifiedllvm/lib/Target/AArch64/AArch64SVEInstrInfo.td
The file was modifiedllvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64ISelLowering.cpp
The file was modifiedllvm/test/CodeGen/AArch64/sve-split-fcvt.ll
The file was modifiedllvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modifiedllvm/lib/Target/AArch64/AArch64InstrFormats.td
The file was modifiedllvm/test/CodeGen/AArch64/sve-fcvt.ll
Commit ef4e971e5e18ae796466623df8f26265ba6bdfb5 by David.Chisnall
[CFGuard] Add address-taken IAT tables and delay-load support

This patch adds support for creating Guard Address-Taken IAT Entry Tables (.giats$y sections) in object files, matching the behavior of MSVC. These contain lists of address-taken imported functions, which are used by the linker to create the final GIATS table.
Additionally, if any DLLs are delay-loaded, the linker must look through the .giats tables and add the respective load thunks of address-taken imports to the GFIDS table, as these are also valid call targets.

Reviewed By: rnk

Differential Revision: https://reviews.llvm.org/D87544
The file was modifiedlld/COFF/ICF.cpp
The file was modifiedlld/COFF/InputFiles.h
The file was modifiedllvm/tools/llvm-readobj/COFFDumper.cpp
The file was addedlld/test/COFF/giats.s
The file was modifiedllvm/lib/MC/MCObjectFileInfo.cpp
The file was addedllvm/test/CodeGen/WinCFGuard/cfguard-giats.ll
The file was modifiedllvm/lib/CodeGen/AsmPrinter/WinCFGuard.cpp
The file was modifiedllvm/include/llvm/MC/MCObjectFileInfo.h
The file was modifiedlld/COFF/InputFiles.cpp
The file was modifiedlld/COFF/DLL.cpp
The file was modifiedlld/COFF/Writer.cpp
The file was modifiedlld/COFF/Symbols.h
Commit bc730b5e43ad4b7efeca977359271fa0eaa7ed45 by llvm-dev
[InstCombine] collectBitParts - use APInt directly to check for out of range bit shifts. NFCI.
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp
Commit b272250221595b14c32db6721a0ae4e5f17ea4d2 by Raphael Isemann
[lldb] Skip the flakey part of TestStopHookScripted on Linux

This test seems to randomly fail on Linux machines. It's only one part of the
test failing randomly, so let's just skip it instead of reverting the whole
patch (again).
The file was modifiedlldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
Commit 4f13b999297140486b2faa1b5d8d7c768fb40dfb by Louis Dionne
[libc++] Simplify how we re-export symbols from libc++abi

Instead of managing two copies of the symbol lists, reuse the same list
in libc++abi and libc++.

Differential Revision: https://reviews.llvm.org/D88623
The file was modifiedlibcxx/lib/abi/CHANGELOG.TXT
The file was modifiedlibcxx/lib/abi/x86_64-apple-darwin.v1.abilist
The file was modifiedlibcxxabi/src/CMakeLists.txt
The file was removedlibcxx/lib/libc++abi-exceptions.exp
The file was modifiedlibcxx/src/CMakeLists.txt
The file was removedlibcxx/lib/libc++abi-new-delete.exp
The file was removedlibcxx/lib/libc++abi-exceptions.sjlj.exp
Commit cccb7cf1a52f38182f56d947bd609027726c778b by Raphael Isemann
[lldb] Add missing import for LLDB test decorators to TestStopHookScripted

This test wasn't using decorators before and was missing the import, so my
previous commit broke the test.
The file was modifiedlldb/test/API/commands/target/stop-hooks/TestStopHookScripted.py
Commit 7e02bc81c6dad90b0f98f74152f4b0991087d78d by sam.parker
[NFC][ARM] LowOverheadLoop DEBUG statements
The file was modifiedllvm/lib/Target/ARM/ARMLowOverheadLoops.cpp
Commit d53b4bee0ccd408cfe6e592540858046244e74ce by sjoerd.meijer
[LoopFlatten] Add a loop-flattening pass

This is a simple pass that flattens nested loops.  The intention is to optimise
loop nests like this, which together access an array linearly:

  for (int i = 0; i < N; ++i)
    for (int j = 0; j < M; ++j)
      f(A[i*M+j]);

into one loop:

  for (int i = 0; i < (N*M); ++i)
    f(A[i]);

It can also flatten loops where the induction variables are not used in the
loop. This can help with codesize and runtime, especially on simple cpus
without advanced branch prediction.

This is only worth flattening if the induction variables are only used in an
expression like i*M+j. If they had any other uses, we would have to insert a
div/mod to reconstruct the original values, so this wouldn't be profitable.

This partially fixes PR40581 as this pass triggers on one of the two cases. I
will follow up on this to learn LoopFlatten a few more (small) tricks. Please
note that LoopFlatten is not yet enabled by default.

Patch by Oliver Stannard, with minor tweaks from Dave Green and myself.

Differential Revision: https://reviews.llvm.org/D42365
The file was modifiedllvm/include/llvm/InitializePasses.h
The file was addedllvm/test/Transforms/LoopFlatten/pr40581.ll
The file was addedllvm/test/Transforms/LoopFlatten/loop-flatten.ll
The file was addedllvm/test/Transforms/LoopFlatten/loop-flatten-negative.ll
The file was addedllvm/include/llvm/Transforms/Scalar/LoopFlatten.h
The file was modifiedllvm/lib/Transforms/IPO/PassManagerBuilder.cpp
The file was modifiedllvm/lib/Transforms/Scalar/CMakeLists.txt
The file was modifiedllvm/lib/Passes/PassRegistry.def
The file was addedllvm/lib/Transforms/Scalar/LoopFlatten.cpp
The file was modifiedllvm/lib/Passes/PassBuilder.cpp
The file was modifiedllvm/include/llvm/Transforms/Scalar.h
The file was modifiedllvm/lib/Transforms/Scalar/Scalar.cpp
The file was modifiedllvm/include/llvm/LinkAllPasses.h
Commit 5101e7e8dd01719f9161e01e2f053c9797c247a8 by llvmgnsyncbot
[gn build] Port d53b4bee0cc
The file was modifiedllvm/utils/gn/secondary/llvm/lib/Transforms/Scalar/BUILD.gn
Commit a20168d0307860047ad7c8a2074f98fc25b057c2 by james.henderson
[Archive] Don't throw away errors for malformed archive members

When adding an archive member with a problem, e.g. a new bitcode with an
old archiver, containing an unsupported attribute, or an ELF file with a
malformed symbol table, the archiver would throw away the error and
simply add the member to the archive without any symbol entries. This
meant that the resultant archive could be silently unusable when not
using --whole-archive, and result in unexpected undefined symbols.

This change fixes this issue by addressing two FIXMEs and only throwing
away not-an-object errors. However, this meant that some LLD tests which
didn't need symbol tables and were using invalid members deliberately to
test the linker's malformed input handling no longer worked, so this
patch also stops the archiver from looking for symbols in an object if
it doesn't require a symbol table, and updates the tests accordingly.

Differential Revision: https://reviews.llvm.org/D88288

Reviewed by: grimar, rupprecht, MaskRay
The file was modifiedllvm/lib/Object/ArchiveWriter.cpp
The file was addedllvm/test/Object/archive-unknown-filetype.test
The file was modifiedlld/test/ELF/invalid/data-encoding.test
The file was modifiedllvm/lib/Object/SymbolicFile.cpp
The file was modifiedllvm/include/llvm/Object/SymbolicFile.h
The file was addedllvm/test/Object/archive-malformed-object.test
The file was modifiedlld/test/ELF/invalid/invalid-file-class.test
Commit 15474d769110139f9cc96d42434988d7aaa77634 by david.sherwood
[SVE][CodeGen] Replace use of TypeSize operator< in GlobalMerge::doMerge

We don't support global variables with scalable vector types so I've
changed the code to compare the fixed sizes instead.

Differential Revision: https://reviews.llvm.org/D88564
The file was modifiedllvm/lib/CodeGen/GlobalMerge.cpp
Commit 866d9b03f2902c177533d7ce148339d47bf092e1 by jay.foad
[AMDGPU] Tiny cleanup in isLegalFLATOffset. NFC.
The file was modifiedllvm/lib/Target/AMDGPU/SIInstrInfo.cpp
Commit 95a440b936c26b97eb47d691df551d21ce8c13d3 by llvm-dev
[IR] PatternMatch - add m_FShl/m_FShr funnel shift intrinsic matchers. NFCI.
The file was modifiedllvm/include/llvm/IR/PatternMatch.h
The file was modifiedllvm/lib/Analysis/InstructionSimplify.cpp
Commit 567049f89282d10ec2e82ea21e239fb0174a0ee1 by llvm-dev
[InstCombine] Use m_FAbs matcher helper. NFCI.
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
The file was modifiedllvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp
Commit 5665ec4e182dba9965847d3698ad64a950bb00a7 by daltenty
[compiler-rt][cmake][powerpc] Remove TEST_BIG_ENDIAN from base-config-ix.cmake

It's actually not safe to call TEST_BIG_ENDIAN here, since we may be
running from the builtins build (i.e builtins-config-ix) context where
TEST_COMPILE_ONLY  is set since without builtins already built we may
fail to link, and TEST_BIG_ENDIAN internally performs tests which may
fail to link without builtins.

Fortunately powerpc is the only target that uses this information here and
we actually already know the whether we are targeting the LE variant due
to earlier macro checks, so we can simply this to remove our reliance on
TEST_BIG_ENDIAN.

Reviewed By: hubert.reinterpretcast, Whitney

Differential Revision: https://reviews.llvm.org/D88608
The file was modifiedcompiler-rt/cmake/base-config-ix.cmake
Commit 79fbcbff41734e3d07e6200d33c3e40732dfae6a by sam.mccall
[clangd] clangd --check: standalone diagnosis of common problems

This is a tool to simply parse a file as clangd would, and run some
common features (code actions, go-to-definition, hover) in an attempt to
trigger or reproduce crashes, error diagnostics, etc.

This is easier and more predictable than loading the file in clangd, because:
- there's no editor/plugin variation to worry about
- there's no accidental variation of user behavior or other extraneous requests
- we trigger features at every token, rather than guessing
- everything is synchronoous, logs are easier to reason about
- it's easier to (get users to) capture logs when running on the command-line

This is a fairly lightweight variant of this idea.
We could do a lot more with it, and maybe we should.
But I can't in the near future, and experience will tell us if we made
the right tradeoffs and if it's worth investing further.

Differential Revision: https://reviews.llvm.org/D88338
The file was addedclang-tools-extra/clangd/test/check.test
The file was addedclang-tools-extra/clangd/test/check-fail.test
The file was modifiedclang-tools-extra/clangd/tool/CMakeLists.txt
The file was addedclang-tools-extra/clangd/tool/Check.cpp
The file was modifiedclang-tools-extra/clangd/tool/ClangdMain.cpp

Summary

  1. Revert accidental commits. (details)
Commit 83e8ccb5b5b1a22c79dd31735330cd2b95c6a789 by zakk.chen
Revert accidental commits.

Revert "[RISCV] get toolchain path from enviroment variable"
This reverts commit f9af83f302b397d59361f0dd72f2b55171535901.

Revert "[RISCV] Add a toolchain file for RISC-V."
This reverts commit 8141fe6213d911f469f92bfe5f8a85672f9d8a3d.

Revert "[HACK] Disable matrix_types tests."
This reverts commit a9efc190f2a5c0735562c014211bfce35706d5bd.
The file was removedcmake/caches/target-riscv64-linux.cmake
The file was modifiedSingleSource/UnitTests/matrix-types-spec.cpp (diff)