FailedChanges

Summary

  1. [CodeComplete] Fix a crash in preferred type and signature help (details)
  2. [DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be (details)
  3. [llvm-readelf] - Do no print an empty symbol version as "<corrupt>" (details)
  4. [LiveRegUnits] Add phys_regs_and_masks iterator range (NFC). (details)
  5. [PowerPC] [CodeGen] Use MachineBranchProbabilityInfo in (details)
  6. [AArch64][SVE] Move TableGen class definitions for gather loads (NFC) (details)
  7. [clangd] Deduplicate refs from index for cross-file rename. (details)
  8. [MCRegInfo] Add sub_and_superregs_inclusive iterator range. (details)
  9. [NFC][PowerPC] Remove the dead conditions in the if(cond) (details)
  10. [ARM][TypePromotion] Enable by default (details)
  11. [NFC] Correct the example in the comments of JSON.h to avoid mislead (details)
  12. [lldb/DWARF] Add support for DW_AT_loclists_base&DW_FORM_loclistx (details)
Commit f7c8ace4a52acecff7cd6ab61cbeaf677da1dd86 by ibiryukov
[CodeComplete] Fix a crash in preferred type and signature help
Summary: Null type pointers could be dereferenced in some cases.
Reviewers: kadircet, sammccall
Reviewed By: sammccall
Subscribers: cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71329
The file was modifiedclang/unittests/Sema/CodeCompleteTest.cpp (diff)
The file was modifiedclang/lib/Parse/ParseExprCXX.cpp (diff)
Commit 21bc8958668a4dc21de8328ef856ddcf38a97da7 by a.v.lapshin
[DWARF5][SplitDwarf] Set default state for -fsplit-dwarf-inlining to be
false.
    The -fsplit-dwarf-inlining option does not conform to DWARF5
standard. It creates children for Skeleton compilation unit. We need
default behavior to be DWARF5 compatible. Thus set default state for
-fsplit-dwarf-inlining into "false".
Differential Revision: https://reviews.llvm.org/D71304
The file was modifiedclang/test/Driver/split-debug.c (diff)
The file was modifiedclang/lib/Driver/ToolChains/Clang.cpp (diff)
Commit 445c3fdd2ae8648cd79f98d3d72ff142b4c19792 by grimar
[llvm-readelf] - Do no print an empty symbol version as "<corrupt>"
It is discussed here https://reviews.llvm.org/D71118#inline-643172
Currently when a version is empty, llvm-readelf prints:
"000:   0 (*local*)       2 (<corrupt>)"
But GNU readelf does not treat empty section as corrupt. There is no
sense in having empty versions anyways it seems, but this change is for
consistency with GNU.
Differential revision: https://reviews.llvm.org/D71243
The file was modifiedllvm/test/tools/llvm-readobj/ELF/verneed-invalid.test (diff)
The file was modifiedllvm/tools/llvm-readobj/ELFDumper.cpp (diff)
Commit 11f311875f092e59cac2936b54f922b968e615e3 by flo
[LiveRegUnits] Add phys_regs_and_masks iterator range (NFC).
This iterator range just includes physical registers and register masks,
which are interesting when dealing with register liveness.
Reviewers: evandro, t.p.northover, paquette, MatzeB, arsenm
Reviewed By: paquette
Differential Revision: https://reviews.llvm.org/D70562
The file was modifiedllvm/lib/CodeGen/LivePhysRegs.cpp (diff)
The file was modifiedllvm/lib/CodeGen/LiveRegUnits.cpp (diff)
The file was modifiedllvm/include/llvm/CodeGen/LiveRegUnits.h (diff)
Commit 1408e7e17525287c596a8f575957aecb684fa75d by shkzhang
[PowerPC] [CodeGen] Use MachineBranchProbabilityInfo in
EarlyIfPredicator to avoid the potential bug
Summary: In the function `EarlyIfPredicator::shouldConvertIf()`, we call
`TII->isProfitableToIfCvt()` with `BranchProbability::getUnknown()`, it
may cause the potential assertion error for those hook which use
`BranchProbability` in `isProfitableToIfCvt()`, for example `SystemZ`.
`SystemZ` use `Probability < BranchProbability(1, 8))` in the function
`SystemZInstrInfo::isProfitableToIfCvt()`, if we call this function with
`BranchProbability::getUnknown()`, it will cause assertion error.
This patch is to fix the potential bug.
Reviewed By: ThomasRaoux
Differential Revision: https://reviews.llvm.org/D71273
The file was modifiedllvm/lib/CodeGen/EarlyIfConversion.cpp (diff)
Commit 1eecbda0872832da936d37c4288eaaa2645a7415 by andrzej.warzynski
[AArch64][SVE] Move TableGen class definitions for gather loads (NFC)
Move 2 intrinsic class definitions so that they're all clustered in one
place.
Patch submitted to test commit access.
The file was modifiedllvm/include/llvm/IR/IntrinsicsAArch64.td (diff)
Commit f0004aad5565d4b76d41a03549c5a80efc4212c7 by hokein.wu
[clangd] Deduplicate refs from index for cross-file rename.
Summary: If the index returns duplicated refs, it will trigger the
assertion in BuildRenameEdit (we expect the processing position is
always larger the the previous one, but it is not true if we have
duplication), and also breaks our heuristics.
This patch make the code robost enough to handle duplications, also save
some cost of redundnat llvm::sort.
Though clangd's index doesn't return duplications, our internal index
kythe will.
Reviewers: ilya-biryukov
Subscribers: MaskRay, jkorous, mgrang, arphaman, kadircet, usaxena95,
cfe-commits
Tags: #clang
Differential Revision: https://reviews.llvm.org/D71300
The file was modifiedclang-tools-extra/clangd/refactor/Rename.h (diff)
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp (diff)
The file was modifiedclang-tools-extra/clangd/unittests/RenameTests.cpp (diff)
Commit b48b4ed1a0bd81531d3aeb4e719b273751548a34 by flo
[MCRegInfo] Add sub_and_superregs_inclusive iterator range.
Reviewers: evandro, qcolombet, paquette, MatzeB, arsenm
Reviewed By: paquette
Differential Revision: https://reviews.llvm.org/D70566
The file was modifiedllvm/include/llvm/MC/MCRegisterInfo.h (diff)
Commit eba7cbd3d06b3a84a72dcb6601a667a095c32664 by qshanz
[NFC][PowerPC] Remove the dead conditions in the if(cond)
The file was modifiedllvm/lib/Target/PowerPC/PPCISelLowering.cpp (diff)
Commit ee7579409b7d940c4e1314d126e900db30c4edff by sam.parker
[ARM][TypePromotion] Enable by default
Enable the TypePromotion pass my default (again).
This patch was originally committed in 393dacacf7e7. This patch was
reverted in a38396939c54.
Differential Revision: https://reviews.llvm.org/D70998
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/icmps.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/calls.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/phis-ret.ll (diff)
The file was modifiedllvm/lib/CodeGen/TypePromotion.cpp (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/wrapping.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/signed.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/signed-icmps.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/clear-structures.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/pointers.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/casts.ll (diff)
The file was modifiedllvm/test/Transforms/TypePromotion/ARM/switch.ll (diff)
Commit 46822083ef9f03ceb26db80410e47f23aa9bd7ae by qshanz
[NFC] Correct the example in the comments of JSON.h to avoid mislead
user
The file was modifiedllvm/include/llvm/Support/JSON.h (diff)
Commit c8b74ee264a943aad29fd0864c610ba5504f73a8 by pavel
[lldb/DWARF] Add support for DW_AT_loclists_base&DW_FORM_loclistx
Summary: This adds support for DWARF5 location lists which are specified
indirectly, via an index into the debug_loclists offset table. This
includes parsing the DW_AT_loclists_base attribute which determines the
location of this offset table, and support for new form DW_FORM_loclistx
which is used in conjuction with DW_AT_location to refer to the location
lists in this way.
The code uses the llvm class to parse the offset information, and I've
also tried to structure it similarly to how the relevant llvm
functionality works.
Reviewers: JDevlieghere, aprantl, clayborg
Subscribers: lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D71268
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp (diff)
The file was addedlldb/test/Shell/SymbolFile/DWARF/DW_AT_loclists_base.s
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp (diff)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.h (diff)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp (diff)
The file was modifiedlldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp (diff)