FailedChanges

Summary

  1. Add flang dylib/shared libs buildbots (details)
Commit 1a3cb9aabf5eb27f2c6d515fb4711d0719a30947 by diana.picus
Add flang dylib/shared libs buildbots

Differential Revision: https://reviews.llvm.org/D91843
The file was modifiedbuildbot/osuosl/master/config/workers.py (diff)
The file was modifiedbuildbot/osuosl/master/config/builders.py (diff)

Summary

  1. [clangd] Implement Decl canonicalization rules for rename (details)
  2. [AArch64][SVE] Allow lax conversion between VLATs and GNU vectors (details)
  3. [clangd] Get rid of clangToolingRefactoring dependency (details)
  4. [APInt] Add the truncOrSelf resizing operator to APInt (details)
  5. [clangd] testPath's final result agrees with the passed in Style (details)
  6. [VE][NFC] Clean stack frame description (details)
  7. [VE] Clean canRealignStack implementation (details)
  8. Revert "[clangd] testPath's final result agrees with the passed in Style" (details)
  9. [mlir][Linalg] Drop symbol_source abstraction which does not pay for itself. (details)
  10. [AMDGPU][MC] Improved diagnostic messages for invalid literals (details)
  11. [clangd] textDocument/implementation (LSP layer) (details)
  12. [mlir] Avoid cloning ops in SCF parallel conversion to CFG (details)
  13. Ignore noderef attribute in unevaluated context (details)
  14. [AMDGPU][MC] Improved diagnostic messages (details)
  15. [llvm-readobj][test] - Simplify the gnu-notes.test (details)
  16. [lldb] [test] Restore Windows-skip on 'process connect' tests (details)
  17. [Inline] Fix in handling of ptrtoint in InlineCost (details)
  18. [mlir] canonicalize away zero-iteration SCF for loops (details)
  19. [test] Update PR reference in testcase [NFC] (details)
Commit cf39bdb49086350e7178a0a058273907d180e809 by kbobyrev
[clangd] Implement Decl canonicalization rules for rename

This patch introduces new canonicalization rules which are used for AST-based
rename in Clangd. By comparing two canonical declarations of inspected nodes,
Clangd determines whether both of them belong to the same entity user would
like to rename. Such functionality is relatively concise compared to the
Clang-Rename API that is used right now. It also helps to overcome the
limitations that Clang-Rename originally had and helps to eliminate several
classes of bugs.

Clangd AST-based rename currently relies on Clang-Rename which has design
limitations and also lacks some features. This patch breaks this dependency and
significantly reduces the amount of code to maintain (Clang-Rename is ~2000 LOC,
this patch is just <30 LOC of replacement code).

We eliminate technical debt by simultaneously

* Maintaining feature parity and ensuring no regressions
* Opening a straightforward path to improving existing rename bugs
* Making it possible to add more capabilities to rename feature which would not
  be possible with Clang-Rename

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D71880
The file was modifiedclang-tools-extra/clangd/refactor/Rename.cpp
Commit 3c696a212ba4328e4f8f92136bc4d728a6490ef7 by joe.ellis
[AArch64][SVE] Allow lax conversion between VLATs and GNU vectors

Previously, lax conversions were only allowed between SVE vector-length
agnostic types and vector-length specific types. This meant that code
such as the following:

    #include <arm_sve.h>
    #define N __ARM_FEATURE_SVE_BITS
    #define FIXED_ATTR __attribute__ ((vector_size (N/8)))
    typedef float fixed_float32_t FIXED_ATTR;

    void foo() {
        fixed_float32_t fs32;
        svfloat64_t s64;
        fs32 = s64;
    }

was not allowed.

This patch makes a minor change to areLaxCompatibleSveTypes to allow for
lax conversions to be performed between SVE vector-length agnostic types
and GNU vectors.

Differential Revision: https://reviews.llvm.org/D91696
The file was modifiedclang/test/Sema/aarch64-sve-lax-vector-conversions.c
The file was modifiedclang/test/SemaCXX/aarch64-sve-lax-vector-conversions.cpp
The file was modifiedclang/lib/AST/ASTContext.cpp
The file was modifiedclang/test/Sema/attr-arm-sve-vector-bits.c
Commit 1319c6624ed6b0a6fb48d975bbf278263a85fcef by kbobyrev
[clangd] Get rid of clangToolingRefactoring dependency

D71880 makes this dependency redundant and we can safely remove it. Tested for
both shared lib build and static lib build.

Reviewed By: hokein

Differential Revision: https://reviews.llvm.org/D91951
The file was modifiedclang-tools-extra/clangd/CMakeLists.txt
Commit d3a0f9b9ec88ce0737470652330262f8ed46daa7 by kerry.mclaughlin
[APInt] Add the truncOrSelf resizing operator to APInt

Truncates the APInt if the bit width is greater than the width specified,
otherwise do nothing

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D91445
The file was modifiedllvm/lib/Support/APInt.cpp
The file was modifiedllvm/include/llvm/ADT/APInt.h
The file was modifiedllvm/unittests/ADT/APIntTest.cpp
Commit 8cec8de2a4e6692da6226bb02cf417eb0e50adde by kadircet
[clangd] testPath's final result agrees with the passed in Style

This was confusing, as testRoot on windows results in C:\\clangd-test
and testPath generated with posix explicitly still contained backslashes.

This patch ensures not only the relative part, but the whole final result
respects passed in Style.

Differential Revision: https://reviews.llvm.org/D91947
The file was modifiedclang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestFS.cpp
Commit 3a302349ebd11279d0c49fbd03c66ed502968f19 by marukawa
[VE][NFC] Clean stack frame description

Move stack frame description from VESubtarget.cpp to VEFrameLowering.cpp
and add detail.

Reviewed By: simoll

Differential Revision: https://reviews.llvm.org/D91946
The file was modifiedllvm/lib/Target/VE/VESubtarget.cpp
The file was modifiedllvm/lib/Target/VE/VEFrameLowering.cpp
Commit 677e94c0f09bf48d92b57a34ba7cf2e0d94016fb by marukawa
[VE] Clean canRealignStack implementation

Old canRealignStack calls TRI::canRealignStack and hasReservedCallFrame.
But, this hasReservedCallFrame return true whenever for VE since VE
allocates call frame all the time.  It means this canRealignStack is
identical to TRI::canRealignStack.  This patch removes VE's
canRealignStack and let caller call TRI::canRealignStack directly.

Reviewed By: simoll

Differential Revision: https://reviews.llvm.org/D91929
The file was modifiedllvm/lib/Target/VE/VERegisterInfo.h
The file was modifiedllvm/lib/Target/VE/VERegisterInfo.cpp
Commit 61e538b15ddb2de9250277d151f0f655c2220d9b by kadircet
Revert "[clangd] testPath's final result agrees with the passed in Style"

This reverts commit 8cec8de2a4e6692da6226bb02cf417eb0e50adde as it
breaks windows buildbots.
The file was modifiedclang-tools-extra/clangd/unittests/ConfigCompileTests.cpp
The file was modifiedclang-tools-extra/clangd/unittests/TestFS.cpp
Commit 9ac0b314a431405aa6a681124f83138f7544807e by nicolas.vasilache
[mlir][Linalg] Drop symbol_source abstraction which does not pay for itself.

Differential Revision: https://reviews.llvm.org/D91956
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Loops.cpp
The file was modifiedmlir/test/Dialect/Linalg/invalid.mlir
The file was modifiedmlir/include/mlir/Dialect/Linalg/Passes.td
The file was modifiedmlir/test/Dialect/Linalg/loops.mlir
The file was modifiedmlir/include/mlir/Dialect/Utils/StructuredOpsUtils.h
The file was modifiedmlir/lib/Dialect/Linalg/EDSC/Builders.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/FusionOnTensors.cpp
The file was modifiedmlir/lib/Dialect/Linalg/IR/LinalgOps.cpp
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Bufferize.cpp
The file was modifiedmlir/include/mlir/Dialect/Linalg/IR/LinalgStructuredOps.td
Commit e4effef330599edd9faa55de2f47640e7c99e7e3 by dmitry.preobrazhensky
[AMDGPU][MC] Improved diagnostic messages for invalid literals

See bug 47518 (https://bugs.llvm.org/show_bug.cgi?id=47518)

Reviewers: rampitec

Differential Revision: https://reviews.llvm.org/D91793
The file was modifiedllvm/test/MC/AMDGPU/gfx9_err_pos.s
The file was modifiedllvm/test/MC/AMDGPU/literals.s
The file was modifiedllvm/test/MC/AMDGPU/vop3-gfx9.s
The file was modifiedllvm/test/MC/AMDGPU/expressions-gfx9.s
The file was modifiedllvm/test/MC/AMDGPU/gfx7_err_pos.s
The file was modifiedllvm/test/MC/AMDGPU/gfx8_asm_all.s
The file was modifiedllvm/test/MC/AMDGPU/literalv216-err.s
The file was modifiedllvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
The file was modifiedllvm/test/MC/AMDGPU/mai-err.s
The file was modifiedllvm/test/MC/AMDGPU/gfx10_err_pos.s
The file was modifiedllvm/test/MC/AMDGPU/vop3-literal.s
The file was modifiedllvm/test/MC/AMDGPU/gfx908_err_pos.s
The file was modifiedllvm/test/MC/AMDGPU/gfx9-asm-err.s
The file was modifiedllvm/test/MC/AMDGPU/vop3-errs.s
The file was modifiedllvm/test/MC/AMDGPU/gfx9_asm_all.s
The file was modifiedllvm/test/MC/AMDGPU/vop2-err.s
The file was modifiedllvm/test/MC/AMDGPU/expressions-gfx10.s
The file was modifiedllvm/test/MC/AMDGPU/literalv216.s
The file was modifiedllvm/test/MC/AMDGPU/vop3.s
Commit b31486ad971774c859e3e031fc0d8d9b77e3b083 by usx
[clangd] textDocument/implementation (LSP layer)

Differential Revision: https://reviews.llvm.org/D91721
The file was modifiedclang-tools-extra/clangd/ClangdServer.cpp
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.h
The file was modifiedclang-tools-extra/clangd/test/initialize-params.test
The file was modifiedclang-tools-extra/clangd/ClangdLSPServer.cpp
The file was addedclang-tools-extra/clangd/test/implementations.test
The file was modifiedclang-tools-extra/clangd/ClangdServer.h
Commit 1ec60862d7024118b2db5bcbb280eafcd9193ac5 by zinenko
[mlir] Avoid cloning ops in SCF parallel conversion to CFG

The existing implementation of the conversion from SCF Parallel operation to
SCF "for" loops in order to further convert those loops to branch-based CFG has
been cloning the loop and reduction body operations into the new loop because
ConversionPatternRewriter was missing support for moving blocks while replacing
their arguments. This functionality now available, use it to implement the
conversion and avoid cloning operations, which may lead to doubling of the IR
size during the conversion.

In addition, this fixes an issue with converting nested SCF "if" conditionals
present in "parallel" operations that would cause the conversion infrastructure
to stop because of the repeated application of the pattern converting "newly"
created "if"s (which were in fact just moved). Arguably, this should be fixed
at the infrastructure level and this fix is a workaround.

Reviewed By: herhut

Differential Revision: https://reviews.llvm.org/D91955
The file was modifiedmlir/lib/Conversion/SCFToStandard/SCFToStandard.cpp
The file was modifiedmlir/test/Conversion/SCFToStandard/convert-to-cfg.mlir
Commit 00dad9d028ce31739b992a3ce2df5de054a9fa3c by aaron
Ignore noderef attribute in unevaluated context

The noderef attribute is for catching code that accesses pointers in
a different address space. Unevaluated code is always safe in that regard.
The file was modifiedclang/test/Frontend/noderef.c
The file was modifiedclang/test/Frontend/noderef.cpp
The file was modifiedclang/lib/Sema/SemaExpr.cpp
The file was modifiedclang/lib/Sema/SemaExprMember.cpp
Commit ce44bf2cf229c179948b97639587c92c3f2e8b19 by dmitry.preobrazhensky
[AMDGPU][MC] Improved diagnostic messages

See bug 47518 (https://bugs.llvm.org/show_bug.cgi?id=47518)

Reviewers: rampitec

Differential Revision: https://reviews.llvm.org/D91794
The file was modifiedllvm/test/MC/AMDGPU/gfx908_err_pos.s
The file was modifiedllvm/test/MC/AMDGPU/gfx10_err_pos.s
The file was modifiedllvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp
The file was modifiedllvm/test/MC/AMDGPU/gfx9_err_pos.s
Commit 2745d9c586d1fea438f5542dfd0718feefd14ad9 by grimar
[llvm-readobj][test] - Simplify the gnu-notes.test

This test contains YAMLs that can be merged with use of macros.
This opens road for adding more test cases.

Differential revision: https://reviews.llvm.org/D91953
The file was modifiedllvm/test/tools/llvm-readobj/ELF/gnu-notes.test
Commit a8f6f4e8733cd601246ddc3e391cd82236231846 by mgorny
[lldb] [test] Restore Windows-skip on 'process connect' tests
The file was modifiedlldb/test/API/functionalities/gdb_remote_client/TestProcessConnect.py
The file was modifiedlldb/test/Shell/Commands/command-process-connect.test
Commit faf848ac321801ba92b1d3038fccc84988d46ac8 by mikael.holmen
[Inline] Fix in handling of ptrtoint in InlineCost

ConstantOffsetPtrs contains mappings from a Value to a base pointer and
an offset. The offset is typed and has a size, and at least when dealing
with ptrtoint, it could happen that we had a mapping from a ptrtoint
with type i32 to an offset with type i16. This could later cause
problems, showing up in PR 47969 and PR 38500.

In PR 47969 we ended up in an assert complaining that trunc i16 to i16
is invalid and in Pr 38500 that a cmp on an i32 and i16 value isn't
valid.

Reviewed By: spatel

Differential Revision: https://reviews.llvm.org/D90610
The file was modifiedllvm/lib/Analysis/InlineCost.cpp
The file was addedllvm/test/Transforms/Inline/inline-ptrtoint-different-sizes.ll
Commit 31a233d46367636f94c487b51aa2931a1cc9cf79 by zinenko
[mlir] canonicalize away zero-iteration SCF for loops

An SCF 'for' loop does not iterate if its lower bound is equal to its upper
bound. Remove loops where both bounds are the same SSA value as such bounds are
guaranteed to be equal. Similarly, remove 'parallel' loops where at least one
pair of respective lower/upper bounds is specified by the same SSA value.

Reviewed By: gysit

Differential Revision: https://reviews.llvm.org/D91880
The file was modifiedmlir/test/Dialect/SCF/canonicalize.mlir
The file was modifiedmlir/lib/Dialect/SCF/SCF.cpp
Commit 410c150abb20b71895ea75749b1393647c7ec79f by mikael.holmen
[test] Update PR reference in testcase [NFC]

The testcase was added in faf848ac32 to test the fix of PR 47969, but
it was named pr48980 (which happens to be the TR number in my downstream
issue system).
The file was modifiedllvm/test/Transforms/Inline/inline-ptrtoint-different-sizes.ll

Summary

  1. Add flang dylib/shared libs buildbots (details)
Commit 1a3cb9aabf5eb27f2c6d515fb4711d0719a30947 by diana.picus
Add flang dylib/shared libs buildbots

Differential Revision: https://reviews.llvm.org/D91843
The file was modifiedbuildbot/osuosl/master/config/builders.py
The file was modifiedbuildbot/osuosl/master/config/workers.py