SuccessChanges

Summary

  1. [GISel][NFC]: Make members of CombinerHelper accessible in derived classes https://reviews.llvm.org/D65842 Make some members protected to enable access in derived classes.
  2. [Driver] Move LIBRARY_PATH before user inputs Fixes PR16786 Currently, library paths specified by LIBRARY_PATH are placed after inputs: `inputs LIBRARY_PATH stdlib` In gcc, the order is: `LIBRARY_PATH inputs stdlib` if not cross compiling. (On Darwin targets, isCrossCompiling() always returns false.) This patch changes the behavior to match gcc. Reviewed By: hfinkel Differential Revision: https://reviews.llvm.org/D65880
  3. Inline diagnostic text into .td file. NFC.
  4. [Utility] Remove unused function 'GetMatchSpanningIndices'
  5. [llvm-strip] Support --strip-sections llvm-objcopy already supports --strip-sections. It is a good fit for its alias llvm-strip to support it as well. Reviewers: rupprecht, jhenderson Differential Revision: https://reviews.llvm.org/D65787
  6. Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it happens to be there" This also reverts "[libc++] Remove temporary hack for D63883". Clearly, I don't understand how the Linux build bots are configured. Differential Revision: https://reviews.llvm.org/D63883
  7. Update fix-it hints for std::move warnings. Fix -Wpessimizing-move and -Wredundant-move when warning on initializer lists. The new fix-it hints for removing the std::move call will now also suggest removing the braces for the initializer list so that the resulting code will still be compilable. This fixes PR42832
  8. [llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags Summary: The information for -info -thin -create -replace and -segalign flags are added to llvm-lipo.rst Test Plan: Reviewers: smeenai, alexshap, compnerd, mtrent Subscribers: llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65676
  9. [ScalarizeMaskedMemIntrin] Add test case for expanding scatter. This pass expands 6 intrinsics, but we only had test for 5 of them.
  10. [Docs] Fix (incorrect) code highlighting
  11. Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG" with a fix to clear the SDNode map when SelectionDAG is cleared.
  12. [Attributor][NFC] remove leftover and format code
  13. [Attributor][Stats] Locate statistics tracking with the attributes Summary: The ever growing switch required Attribute::AttrKind values but they might not be available for all abstract attributes we deduce. With the new method we track statistics at the abstract attribute level. The provided macros simplify the usage and make the messages uniform. Reviewers: sstefan1, uenoku Subscribers: hiraditya, bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65732
  14. Adjust a ValueObjectChild's offset when the child is a bitfield If a bitfield doesn't fit into the child_byte_size'd window at child_byte_offset, move the window forward until it fits. The problem here is that Value has no notion of bitfields and thus the Value's DataExtractor is sized like the bitfields CompilerType; a sequence of bitfields, however, can be larger than their underlying type. This was not in the big-endian-derived DWARF 2 bitfield attributes because their offsets were counted from the end of the window, so they always fit. rdar://problem/53132189 Differential Revision: https://reviews.llvm.org/D65492
  15. [Attributor][NFC] Code simplification and style normalization
  16. [Attributor] Introduce a state wrapper class Summary: The wrapper reduces boilerplate code and also provide a nice way to determine the state type used by an abstract attributes statically via AAType::StateType. This was already discussed as part of the review of D65711. Reviewers: sstefan1, uenoku Subscribers: hiraditya, bollu, llvm-commits Tags: #llvm Differential Revision: https://reviews.llvm.org/D65786
  17. [Attributor][NFC] Avoid unnecessary liveness queries If we know everything is live there is no need to query for liveness. Indicating a pessimistic fixpoint will cause the state to be "invalid" which will cause the Attributor to not return the AAIsDead on request, which will prevent us from querying isAssumedDead().
Revision 368248 by aditya_nandakumar:
[GISel][NFC]: Make members of CombinerHelper accessible in derived classes

https://reviews.llvm.org/D65842

Make some members protected to enable access in derived classes.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/GlobalISel/CombinerHelper.hllvm.src/include/llvm/CodeGen/GlobalISel/CombinerHelper.h
Revision 368245 by maskray:
[Driver] Move LIBRARY_PATH before user inputs

Fixes PR16786

Currently, library paths specified by LIBRARY_PATH are placed after inputs: `inputs LIBRARY_PATH stdlib`
In gcc, the order is: `LIBRARY_PATH inputs stdlib` if not cross compiling.
(On Darwin targets, isCrossCompiling() always returns false.)

This patch changes the behavior to match gcc.

Reviewed By: hfinkel

Differential Revision: https://reviews.llvm.org/D65880
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Driver/ToolChains/CommonArgs.cppclang.src/lib/Driver/ToolChains/CommonArgs.cpp
The file was modified/cfe/trunk/test/Driver/linker-opts.cclang.src/test/Driver/linker-opts.c
Revision 368244 by rtrieu:
Inline diagnostic text into .td file.  NFC.
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/include/clang/Basic/DiagnosticSemaKinds.tdclang.src/include/clang/Basic/DiagnosticSemaKinds.td
The file was modified/cfe/trunk/lib/Sema/SemaExpr.cppclang.src/lib/Sema/SemaExpr.cpp
Revision 368243 by Jonas Devlieghere:
[Utility] Remove unused function 'GetMatchSpanningIndices'
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/include/lldb/Utility/RegularExpression.hlldb.src/include/lldb/Utility/RegularExpression.h
The file was modified/lldb/trunk/source/Utility/RegularExpression.cpplldb.src/source/Utility/RegularExpression.cpp
Revision 368241 by wolfgangp:
[llvm-strip] Support --strip-sections

llvm-objcopy already supports --strip-sections. It is a good fit for its alias llvm-strip
to support it as well.

Reviewers: rupprecht, jhenderson

Differential Revision: https://reviews.llvm.org/D65787
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/test/tools/llvm-objcopy/ELF/strip-sections.testllvm.src/test/tools/llvm-objcopy/ELF/strip-sections.test
The file was modified/llvm/trunk/tools/llvm-objcopy/CopyConfig.cppllvm.src/tools/llvm-objcopy/CopyConfig.cpp
The file was modified/llvm/trunk/tools/llvm-objcopy/StripOpts.tdllvm.src/tools/llvm-objcopy/StripOpts.td
Revision 368238 by Louis Dionne:
Revert "[libc++] Take 3: Do not cleverly link against libc++abi just because it happens to be there"

This also reverts "[libc++] Remove temporary hack for D63883".
Clearly, I don't understand how the Linux build bots are configured.

Differential Revision: https://reviews.llvm.org/D63883
Change TypePath in RepositoryPath in Workspace
The file was modified/libcxx/trunk/CMakeLists.txtlibcxx.src/CMakeLists.txt
The file was modified/libcxx/trunk/cmake/Modules/HandleLibCXXABI.cmakelibcxx.src/cmake/Modules/HandleLibCXXABI.cmake
Revision 368237 by rtrieu:
Update fix-it hints for std::move warnings.

Fix -Wpessimizing-move and -Wredundant-move when warning on initializer lists.
The new fix-it hints for removing the std::move call will now also suggest
removing the braces for the initializer list so that the resulting code will
still be compilable.

This fixes PR42832
Change TypePath in RepositoryPath in Workspace
The file was modified/cfe/trunk/lib/Sema/SemaInit.cppclang.src/lib/Sema/SemaInit.cpp
The file was modified/cfe/trunk/test/SemaCXX/warn-pessmizing-move.cppclang.src/test/SemaCXX/warn-pessmizing-move.cpp
The file was modified/cfe/trunk/test/SemaCXX/warn-redundant-move.cppclang.src/test/SemaCXX/warn-redundant-move.cpp
Revision 368235 by anushabasana:
[llvm-lipo] Update llvm-lipo docs for -info -thin -create -replace -segalign flags

Summary:
The information for -info -thin -create -replace and -segalign flags are added to llvm-lipo.rst

Test Plan:

Reviewers: smeenai, alexshap, compnerd, mtrent

Subscribers: llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65676
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/docs/CommandGuide/llvm-lipo.rstllvm.src/docs/CommandGuide/llvm-lipo.rst
Revision 368234 by ctopper:
[ScalarizeMaskedMemIntrin] Add test case for expanding scatter.

This pass expands 6 intrinsics, but we only had test for 5 of
them.
Change TypePath in RepositoryPath in Workspace
The file was added/llvm/trunk/test/Transforms/ScalarizeMaskedMemIntrin/X86/expand-masked-scatter.llllvm.src/test/Transforms/ScalarizeMaskedMemIntrin/X86/expand-masked-scatter.ll
Revision 368233 by Jonas Devlieghere:
[Docs] Fix (incorrect) code highlighting
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/docs/use/symbolication.rstlldb.src/docs/use/symbolication.rst
Revision 368230 by akhuang:
Recommit "[MS] Emit S_HEAPALLOCSITE debug info in Selection DAG"
with a fix to clear the SDNode map when SelectionDAG is cleared.
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/CodeGen/SelectionDAG.hllvm.src/include/llvm/CodeGen/SelectionDAG.h
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cppllvm.src/lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.cpp
The file was modified/llvm/trunk/lib/CodeGen/SelectionDAG/SelectionDAG.cppllvm.src/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
The file was modified/llvm/trunk/lib/Target/X86/X86ISelLowering.cppllvm.src/lib/Target/X86/X86ISelLowering.cpp
The file was modified/llvm/trunk/test/CodeGen/X86/label-heapallocsite.llllvm.src/test/CodeGen/X86/label-heapallocsite.ll
Revision 368228 by jdoerfert:
[Attributor][NFC] remove leftover and format code
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.hllvm.src/include/llvm/Transforms/IPO/Attributor.h
Revision 368227 by jdoerfert:
[Attributor][Stats] Locate statistics tracking with the attributes

Summary:
The ever growing switch required Attribute::AttrKind values but they
might not be available for all abstract attributes we deduce. With the
new method we track statistics at the abstract attribute level. The
provided macros simplify the usage and make the messages uniform.

Reviewers: sstefan1, uenoku

Subscribers: hiraditya, bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65732
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.hllvm.src/include/llvm/Transforms/IPO/Attributor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
Revision 368226 by Adrian Prantl:
Adjust a ValueObjectChild's offset when the child is a bitfield

If a bitfield doesn't fit into the child_byte_size'd window at
child_byte_offset, move the window forward until it fits.  The problem
here is that Value has no notion of bitfields and thus the Value's
DataExtractor is sized like the bitfields CompilerType; a sequence of
bitfields, however, can be larger than their underlying type.

This was not in the big-endian-derived DWARF 2 bitfield attributes
because their offsets were counted from the end of the window, so they
always fit.

rdar://problem/53132189

Differential Revision: https://reviews.llvm.org/D65492
Change TypePath in RepositoryPath in Workspace
The file was modified/lldb/trunk/packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.pylldb.src/packages/Python/lldbsuite/test/lang/c/bitfields/TestBitfields.py
The file was modified/lldb/trunk/packages/Python/lldbsuite/test/lang/c/bitfields/main.clldb.src/packages/Python/lldbsuite/test/lang/c/bitfields/main.c
The file was modified/lldb/trunk/source/Core/ValueObjectChild.cpplldb.src/source/Core/ValueObjectChild.cpp
Revision 368225 by jdoerfert:
[Attributor][NFC] Code simplification and style normalization
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
Revision 368224 by jdoerfert:
[Attributor] Introduce a state wrapper class

Summary:
The wrapper reduces boilerplate code and also provide a nice way to
determine the state type used by an abstract attributes statically via
AAType::StateType.

This was already discussed as part of the review of D65711.

Reviewers: sstefan1, uenoku

Subscribers: hiraditya, bollu, llvm-commits

Tags: #llvm

Differential Revision: https://reviews.llvm.org/D65786
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/include/llvm/Transforms/IPO/Attributor.hllvm.src/include/llvm/Transforms/IPO/Attributor.h
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp
Revision 368223 by jdoerfert:
[Attributor][NFC] Avoid unnecessary liveness queries

If we know everything is live there is no need to query for liveness.
Indicating a pessimistic fixpoint will cause the state to be "invalid"
which will cause the Attributor to not return the AAIsDead on request,
which will prevent us from querying isAssumedDead().
Change TypePath in RepositoryPath in Workspace
The file was modified/llvm/trunk/lib/Transforms/IPO/Attributor.cppllvm.src/lib/Transforms/IPO/Attributor.cpp