Changes

#18501 (Jul 23, 2019 2:30:43 PM)

366832. [Remarks] Add unit tests for YAML serialization
        
        Add tests for both the string table and non string table case. — thegameg / ViewSVN
366831. clang-format: Fix namespace end comments for namespaces with attributes and macros.
        
        Fixes PR39247.
        
        While here, also make C++20 `namespace A::inline B::inline C` nested
        inline namespaced definitions work.
        
        Before:
            #define DEPRECATE_WOOF [[deprecated("meow")]]
        
            namespace DEPRECATE_WOOF woof {
            void f() {}
            } // namespace DEPRECATE_WOOFwoof
        
            namespace [[deprecated("meow")]] woof {
              void f() {}
            } // namespace [[deprecated("meow")]]woof
        
            namespace woof::inline bark {
              void f() {}
            } // namespace woof::inlinebark
        
        Now:
            #define DEPRECATE_WOOF [[deprecated("meow")]]
        
            namespace DEPRECATE_WOOF woof {
            void f() {}
            } // namespace woof
        
            namespace [[deprecated("meow")]] woof {
            void f() {}
            } // namespace woof
        
            namespace woof::inline bark {
            void f() {}
            } // namespace woof::inline bark
        
        (In addition to the fixed namespace end comments, also note the correct
        indent of the namespace contents.)
        
        Differential Revision: https://reviews.llvm.org/D65125 — nico / ViewSVN
366829. [IndVars] Fix a subtle bug in optimizeLoopExits
        
        The original code failed to account for the fact that one exit can have a pointer exit count without all of them having pointer exit counts.  This could cause two separate bugs:
        1) We might exit the loop early, and leave optimizations undone.  This is what triggered the assertion failure in the reported test case.
        2) We might optimize one exit, then exit without indicating a change.  This could result in an analysis invalidaton bug if no other transform is done by the rest of indvars.
        
        Note that the pointer exit counts are a really fragile concept.  They show up only when we have a pointer IV w/o a datalayout to provide their size.  It's really questionable to me whether the complexity implied is worth it. — reames / ViewSVN
366828. Improve clang-format-diff help output
        
        The description in clang-format-diff.py is more useful than the one
        in `clang-format-diff -h`, so use the same description in both places.
        
        Differential Revision: https://reviews.llvm.org/D64998 — nico / ViewSVN
366826. [IR][Verifier] Allow IntToPtrInst to be !dereferenceable
        
        Summary:
        Allow IntToPtrInst to carry !dereferenceable metadata tag.
        This is valid since !dereferenceable can be only be applied to
        pointer type values.
        
        Change-Id: If8a6e3c616f073d51eaff52ab74535c29ed497b4
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64954 — rtayl / ViewSVN
366825. [RISCV][NFC] Correct RUN in rvi-pseudos-invalid.s
        
        This test should test both riscv32 and riscv64. — lenary / ViewSVN
366823. [clang][NFCI] Fix random typos — Jan Korous / ViewSVN
366822. [compiler-rt][builtins] Provide __clear_cache for SPARC
        
        While working on https://reviews.llvm.org/D40900, two tests were failing since __clear_cache
        aborted.  While libgcc's __clear_cache is just empty, this only happens because
        gcc (in gcc/config/sparc/sparc.c (sparc32_initialize_trampoline, sparc64_initialize_trampoline))
        emits flush insns directly.
        
        The following patch mimics that.
        
        Tested on sparcv9-sun-solaris2.11.
        
        Differential Revision: https://reviews.llvm.org/D64496 — ro / ViewSVN
366821. [CMake] Add -z defs on Solaris
        
        Like other ELF targets, shared objects should be linked with -z defs on Solaris.
        
        Tested on x86_64-pc-solaris2.11 and sparcv9-sun-solaris2.11.
        
        Differential Revision: https://reviews.llvm.org/D64484 — ro / ViewSVN
366820. [clang, test] Fix Clang :: Headers/max_align.c on 64-bit SPARC
        
        Clang :: Headers/max_align.c currently FAILs on 64-bit SPARC:
        
          error: 'error' diagnostics seen but not expected:
            File /vol/llvm/src/clang/dist/test/Headers/max_align.c Line 12: static_assert failed due to requirement '8 == _Alignof(max_align_t)' ""
          1 error generated.
        
        This happens because SuitableAlign isn't defined for SPARCv9 unlike SPARCv8
        (which uses the default of 64 bits).  gcc's sparc/sparc.h has
        
          #define BIGGEST_ALIGNMENT (TARGET_ARCH64 ? 128 : 64)
        
        This patch sets SuitableAlign to match and updates the corresponding testcase.
        
        Tested on sparcv9-sun-solaris2.11.
        
        Differential Revision: https://reviews.llvm.org/D64487 — ro / ViewSVN
366819. [GlobalISel][AArch64] Teach GISel to handle shifts in load addressing modes
        
        When we select the XRO variants of loads, we can pull in very specific shifts
        (of the size of an element). E.g.
        
        ```
        ldr x1, [x2, x3, lsl #3]
        ```
        
        This teaches GISel to handle these when they're coming from shifts
        specifically.
        
        This adds a new addressing mode function, `selectAddrModeShiftedExtendXReg`
        which recognizes this pattern.
        
        This also packs this up with `selectAddrModeRegisterOffset` into
        `selectAddrModeXRO`. This is intended to be equivalent to `selectAddrModeXRO`
        in AArch64ISelDAGtoDAG.
        
        Also update load-addressing-modes to show that all of the cases here work.
        
        Differential Revision: https://reviews.llvm.org/D65119 — paquette / ViewSVN
366818. [ASTImporter] Fix inequivalence of ClassTemplateInstantiations
        
        Summary:
        We falsely state inequivalence if the template parameter is a
        qualified/nonquialified template in the first/second instantiation.
        Also, different kinds of TemplateName should be equal if the template
        decl (if available) is equal (even if the name kind is different).
        
        Reviewers: a_sidorin, a.sidorin
        
        Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64241 — martong / ViewSVN

#18500 (Jul 23, 2019 10:21:18 AM)

366817. [TargetLowering] SimplifyMultipleUseDemandedBits - add VECTOR_SHUFFLE support.
        
        If all the demanded elts are from one operand and are inline, then we can use the operand directly.
        
        The changes are mainly from SSE41 targets which has blendvpd but not cmpgtq, allowing the v2i64 comparison to be simplified as we only need the signbit from alternate v4i32 elements. — rksimon / ViewSVN
366815. Revert "[Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections()."
        
        This reverts commit r366796 because it was causing ubsan buildbot
        failures. — vlad.tsyrklevich / ViewSVN
366813. [llvm-ar] Fix support for archives with members larger than 4GB
        
        llvm-ar outputs a strange error message when handling archives with
        members larger than 4GB due to not checking file size when passing the
        value as an unsigned 32 bit integer. This overflow issue caused
        malformed archives to be created.:
        
        https://bugs.llvm.org/show_bug.cgi?id=38058
        
        This change allows for members above 4GB and will error in a case that
        is over the formats size limit, a 10 digit decimal integer.
        
        Differential Revision: https://reviews.llvm.org/D65093 — gbreynoo / ViewSVN
366811. [clangd] Log version, cwd, args, and transport on startup. NFC
        
        Reviewers: hokein
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D65146 — sammccall / ViewSVN
366809. [ARM][LowOverheadLoops] Fix branch target codegen
           
        While lowering test.set.loop.iterations, it wasn't checked how the
        brcond was using the result and so the wls could branch to the loop
        preheader instead of not entering it. The same was true for
        loop.decrement.reg.
           
        So brcond and br_cc and now lowered manually when using the hwloop
        intrinsics. During this we now check whether the result has been
        negated and whether we're using SETEQ or SETNE and 0 or 1. We can
        then figure out which basic block the WLS and LE should be targeting.
        
        Differential Revision: https://reviews.llvm.org/D64616 — sam_parker / ViewSVN
366808. Fix MSVC warning about extending a uint32_t shift result to uint64_t. NFCI. — rksimon / ViewSVN
366807. [SLPVectorizer] Revert local change that got accidently got committed in rL366799
        
        This wasn't part of D63281 — rksimon / ViewSVN
366806. Revert [RISCV] Re-enable rv32i-aliases-invalid.s test
        
        This reverts r366797 (git commit 53f9fec8e8b58f5a904bbfb4a1d648cde65aa860) — lenary / ViewSVN
366805. [NFC][ASAN] Add brackets around not command
        
        Under certain execution conditions, the `not` command binds to the command the
        output is piped to rather than the command piping the output. In this case, that
        flips the return code of the FileCheck invocation, causing a failure when
        FileCheck succeeds. — lei / ViewSVN
366802. [NFC][InstCombine] Fixup commutative/negative tests with icmp preds in @llvm.umul.with.overflow tests — lebedevri / ViewSVN
366801. [InstSimplify][NFC] Tests for skipping 'div-by-0' checks before inverted @llvm.umul.with.overflow
        
        It would be already handled by the non-inverted case if we were hoisting
        the `not` in InstCombine, but we don't (granted, we don't sink it
        in this case either), so this is a separate case. — lebedevri / ViewSVN
366800. [NFC][PhaseOredering][SimplifyCFG] Add more runlines to umul.with.overflow tests
        
        This way it will be more obvious that the problem is both
        in cost threshold and in hardcoded benefit check,
        plus will show how the instsimplify cleans this all in the end. — lebedevri / ViewSVN
366799. [TargetLowering] Add SimplifyMultipleUseDemandedBits
        
        This patch introduces the DAG version of SimplifyMultipleUseDemandedBits, which attempts to peek through ops (mainly and/or/xor so far) that don't contribute to the demandedbits/elts of a node - which means we can do this even in cases where we have multiple uses of an op, which normally requires us to demanded all bits/elts. The intention is to remove a similar instruction - SelectionDAG::GetDemandedBits - once SimplifyMultipleUseDemandedBits has matured.
        
        The InstCombine version of SimplifyMultipleUseDemandedBits can constant fold which I haven't added here yet, and so far I've only wired this up to some basic binops (and/or/xor/add/sub/mul) to demonstrate its use.
        
        We do see a couple of regressions that need to be addressed:
        
            AMDGPU unsigned dot product codegen retains an AND mask (for ZERO_EXTEND) that it previously removed (but otherwise the dotproduct codegen is a lot better).
        
            X86/AVX2 has poor handling of vector ANY_EXTEND/ANY_EXTEND_VECTOR_INREG - it prematurely gets converted to ZERO_EXTEND_VECTOR_INREG.
        
        The code owners have confirmed its ok for these cases to fixed up in future patches.
        
        Differential Revision: https://reviews.llvm.org/D63281 — rksimon / ViewSVN
366797. [RISCV] Re-enable rv32i-aliases-invalid.s test
        
        We were getting test failures on some builders, which pointed to @LINE
        being an undefined variable. I think that these failures should have
        been fixed by https://reviews.llvm.org/rL366434, so I'm re-enabling the
        test. — lenary / ViewSVN
366796. [Object/ELF.h] - Improve testing of the fields in ELFFile<ELFT>::sections().
        
        This eliminates a one error untested and
        also introduces a error for one more possible case
        which lead to crash previously.
        
        Differential revision: https://reviews.llvm.org/D64987 — grimar / ViewSVN

#18499 (Jul 23, 2019 7:26:41 AM)

366794. [yaml2obj] - Add a support for defining null sections in YAMLs.
        
        ELF spec shows (Figure 4-10: Section Header Table Entry:Index 0,
        http://www.sco.com/developers/gabi/latest/ch4.sheader.html)
        that section header at index 0 (null section) can have sh_size and
        sh_link fields set to non-zero values.
        
        It says (https://docs.oracle.com/cd/E19683-01/817-3677/6mj8mbtc9/index.html):
        
        "If the number of sections is greater than or equal to SHN_LORESERVE (0xff00),
        this member has the value zero and the actual number of section header table
        entries is contained in the sh_size field of the section header at index 0.
        Otherwise, the sh_size member of the initial entry contains 0."
        
        and:
        
        "If the section name string table section index is greater than or equal to SHN_LORESERVE
        (0xff00), this member has the value SHN_XINDEX (0xffff) and the actual index of the section
        name string table section is contained in the sh_link field of the section header at index 0.
        Otherwise, the sh_link member of the initial entry contains 0."
        
        At this moment it is not possible to create custom section headers at index 0 using yaml2obj.
        
        This patch implements this.
        
        Differential revision: https://reviews.llvm.org/D64913 — grimar / ViewSVN
366793. [SLPVectorizer] Remove null-pointer test. NFCI.
        
        cast<CallInst> shouldn't return null and we dereference the pointer in a lot of other places, causing both MSVC + cppcheck to warn about dereferenced null pointers — rksimon / ViewSVN
366792. PlistDiagnostics Fix for compile warning (NFC). — balazske / ViewSVN
366790. [ARM] Rename NEONModImm to VMOVModImm. NFC
        
        Rename NEONModImm to VMOVModImm as it is used in both NEON and MVE. — dmgreen / ViewSVN

#18498 (Jul 23, 2019 5:19:18 AM)

366789. [Attributor][NFC] Re-run clang-format on the Attributor.cpp — uenoku / ViewSVN
366788. [Attributor] Deduce "dereferenceable" attribute
        
        Summary:
        Deduce dereferenceable attribute in Attributor.
        
        These will be added in a later patch.
        * dereferenceable(_or_null)_globally (D61652)
        * Deduction based on load instruction (similar to D64258)
        
        Reviewers: jdoerfert, sstefan1
        
        Reviewed By: jdoerfert
        
        Subscribers: hiraditya, jfb, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64876 — uenoku / ViewSVN
366787. [llvm-objcopy] Allow strip symtab in executables and DSOs
        
        Re-commit of the patch after addressing -Wl,--emit-relocs case.
        Differential revision: https://reviews.llvm.org/D61672 — evgeny777 / ViewSVN
366786. Fix gold-plugin Windows build
        
        r365588 missed one instance of integer file descriptor use in
        gold-plugin.cpp. — kongyi / ViewSVN
366785. [yaml2elf] - Treat the SHN_UNDEF section as kind of regular section.
        
        We have a logic that adds a few sections implicitly.
        Though the SHT_NULL section with section number 0
        is an exception.
        
        In D64913 I want to teach yaml2obj to redefine the null section.
        And in this patch I add it to the sections list,
        to make it kind of a regular section.
        
        Differential revision: https://reviews.llvm.org/D65087 — grimar / ViewSVN
366782. [CrossTU] Added CTU argument to diagnostic consumer create fn.
        
        Summary:
        The PListDiagnosticConsumer needs a new CTU parameter that is passed
        through the create functions.
        
        Reviewers: NoQ, Szelethus, xazax.hun, martong
        
        Reviewed By: Szelethus
        
        Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64635 — balazske / ViewSVN
366781. [AMDGPU][NFC] Simplify test file for amdgcn intrinsics
        
        Summary: Remove unchecked attribute in the call site and use FileCheck String Substitution for `convergent` check.
        
        Reviewers: nhaehnle
        
        Reviewed By: nhaehnle
        
        Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64901 — uenoku / ViewSVN
366779. [DAGCombiner] Make ShrinkLoadReplaceStoreWithStore return an SDValue instead of an SDNode*. NFCI
        
        The function was calling getNode() on an SDValue to return and the
        caller turned the result back into a SDValue. So just return the
        original SDValue to avoid this. — ctopper / ViewSVN
366778. [DAGCombiner] Use SDNode::isOperandOf to simplify some code. NFCI — ctopper / ViewSVN
366777. [LLVM-C] Improve Bindings to The Internalize Pass
        
        Summary: Adds a binding to the internalize pass that allows the caller to pass a function pointer that acts as the visibility-preservation predicate.  Previously, one could only pass an unsigned value (not LLVMBool?) that directed the pass to consider "main" or not.
        
        Reviewers: whitequark, deadalnix, harlanhaskins
        
        Reviewed By: whitequark, harlanhaskins
        
        Subscribers: kren1, hiraditya, llvm-commits, harlanhaskins
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D62456 — codafi / ViewSVN
366776. Implement most of P1612R1: Relocate endian.  Moves the std::endian functionality from 'type-traits' to 'bit'. No other change. The reason that this is 'partial' is that P1621 also recommends a feature-test macro, but I don't have the value for that one yet. In a month or so, I'll add that — marshall / ViewSVN

#18496 (Jul 22, 2019 10:29:50 PM)

366775. [PowerPC] Replace float load/store pair with integer load/store pair when it's only used in load/store
        
        Replace float load/store pair with integer load/store pair when it's only used in load/store,
        because float load/store instructions cost more cycles then integer load/store.
        
        A typical scenario is when there is a call with more than 13 float arguments passing, we need pass them by stack.
        So we need a load/store pair to do such memory operation if the variable is global variable.
        
        Differential Revision: https://reviews.llvm.org/D64195 — wuzish / ViewSVN
366774. Inline function call into assert to fix unused variable warning. — rtrieu / ViewSVN
366773. Move variable out from debug only section.
        
        MFI is no longer just needed for an assert.  Move it out of the debug only
        section to allow non-assert builds to be able to find it. — rtrieu / ViewSVN

#18491 (Jul 22, 2019 6:32:48 PM)

366772. [llvm-lipo] Implement -info
        
        Prints architecture type of all input files.
        
        Patch by Anusha Basana <anusha.basana@gmail.com>
        
        Differential Revision: https://reviews.llvm.org/D64668 — smeenai / ViewSVN
366769. Fixing build error from commit 95cbc3d
        
        [Attributor] Liveness analysis.
        
        Liveness analysis abstract attribute used to indicate which BasicBlocks are dead and can therefore be ignored.
        Right now we are only looking at noreturn calls.
        
        Reviewers: jdoerfert, uenoku
        
        Subscribers: hiraditya, llvm-commits
        
        Differential Revision: https://reviews.llvm.org/D64162 — sstefan / ViewSVN
366765. [Statepoints] Fix a bug in statepoint lowering for functions w/no-realign-stack
        
        We were silently using the ABI alignment for all of the stores generated for deopt and gc values.  We'd gotten the alignment of the stack slot itself properly reduced (via MachineFrameInfo's clamping), but having the MMO on the store incorrect was enough for us to generate an aligned store to a unaligned location.
        
        The simplest fix would have been to just pass the alignment to the helper function, but once we do that, the helper function doesn't really help.  So, inline it and directly call the MMO version of DAG.getStore with a properly constructed MMO.
        
        Note that there's a separate performance possibility here.  Even if we *can* realign stacks, we probably don't *want to* if all of the stores are in slowpaths.  But that's a later patch, if at all.  :) — reames / ViewSVN
366764. Fix pointer width in test from r366754. — pcc / ViewSVN
366763. gn build: Wrap two comments to 80 columns — nico / ViewSVN
366762. [DWARF] Add more error handling to debug line parser.
        
        This patch exnteds the error handling in the debug line parser to get
        rid of the existing MD5 assertion. I want to reuse the debug line parser
        from LLVM in LLDB where we cannot crash on invalid input.
        
        Differential revision: https://reviews.llvm.org/D64544 — Jonas Devlieghere / ViewSVN
366761. [NFC][clang] Refactor getCompilationPhases()+Types.def step 1.
        
        Moves list of phases into Types.def table: Currently Types.def contains a
        table of strings that are used to assemble a list of compilation phases to be
        setup in the clang driver's jobs pipeline. This change makes it so that the table
        itself contains the list of phases. A subsequent patch will remove the strings.
        
        Differential Revision: https://reviews.llvm.org/D64098 — zer0 / ViewSVN
366760. [Statepoints] Add a test which shows a miscompile with no-realign-stacks — reames / ViewSVN
366759. Revert "Fixing build error from commit 9285295."
        
        This reverts commit 95cbc3da8871f43c1ce2b2926afaedcd826202b1. — sstefan / ViewSVN
366755. llvm-objcopy/test: add REQUIRES: shell for use of umask
        
        (follow-up to r365162) — dblaikie / ViewSVN
366754. Analysis: Don't look through aliases when simplifying GEPs.
        
        It is not safe in general to replace an alias in a GEP with its aliasee
        if the alias can be replaced with another definition (i.e. via strong/weak
        resolution (linkonce_odr) or via symbol interposition (default visibility
        in ELF)) while the aliasee cannot. An example of how this can go wrong is
        in the included test case.
        
        I was concerned that this might be a load-bearing misoptimization (it's
        possible for us to use aliases to share vtables between base and derived
        classes, and on Windows, vtable symbols will always be aliases in RTTI
        mode, so this change could theoretically inhibit trivial devirtualization
        in some cases), so I built Chromium for Linux and Windows with and without
        this change. The file sizes of the resulting binaries were identical, so it
        doesn't look like this is going to be a problem.
        
        Differential Revision: https://reviews.llvm.org/D65118 — pcc / ViewSVN
366753. Fixing build error from commit 9285295.
        
        [Attributor] Liveness analysis.
        
        Liveness analysis abstract attribute used to indicate which BasicBlocks are dead and can therefore be ignored.
        Right now we are only looking at noreturn calls.
        
        Reviewers: jdoerfert, uenoku
        
        Subscribers: hiraditya, llvm-commits
        
        Differential revision: https://reviews.llvm.org/D64162 — sstefan / ViewSVN
366752. [NFC][PatternMatch] Refactor code into a proper "matcher for any integral constant"
        
        Having it as a proper matcher is better for reusability elsewhere
        (in a follow-up patch.) — lebedevri / ViewSVN
366751. [InstSimplify][NFC] Tests for skipping 'div-by-0' checks before @llvm.umul.with.overflow
        
        These may remain after @llvm.umul.with.overflow was canonicalized
        from the code that was originally doing the check via division. — lebedevri / ViewSVN
366750. [SimplifyCFG][NFC] Test that we fail to flatten CFG in JPEG "sign" value extend pattern
        
        This comes up in JPEG decoding, see e.g.
        Figure F.12 – Extending the sign bit of a decoded value in V
        of ITU T.81 (JPEG specification). — lebedevri / ViewSVN
366749. [SimplifyCFG][NFC] Test that we fail to flatten CFG after forming @llvm.umul.with.overflow
        
        Even if we formed @llvm.umul.with.overflow, we are still stuck
        with that guard against div-by-zero, which is no longer needed,
        because we didn't flatten the CFG. — lebedevri / ViewSVN
366748. [InstCombine][NFC] Tests for canonicalization of unsigned multiply overflow check — lebedevri / ViewSVN
366747. [NFC][PhaseOrdering] Add tests showcasing the problems of unsigned multiply overflow check
        
        While we can form the @llvm.mul.with.overflow easily,
        we are still left with that check that was guarding against div-by-0.
        And in the second case we won't even flatten the CFG. — lebedevri / ViewSVN
366746. [IndVarSimplify][NFC] Autogenerate check lines in loop_evaluate_1.ll
        
        Being affected by upcoming patch. — lebedevri / ViewSVN
366744. [Driver] Set the default win32-macho debug format to DWARF
        
        rdar://53267670
        
        Differential Revision: https://reviews.llvm.org/D65116 — Vedant Kumar / ViewSVN

#18490 (Jul 22, 2019 5:36:16 PM)

366743. AMDGPU: Don't use SDNodeXForm for DS offset output
        
        The xform has no real valuewhen it's using out of a complex pattern
        output. The complex pattern was already creating TargetConstants with
        i16, so this was just unnecessary machinery.
        
        This allows global isel to import the simple cases once the complex
        pattern is implemented. — arsenm / ViewSVN
366738. [TSan] Enable fiber tests on iOS simulator
        
        These tests *do not* work on device, but they *do* work in the
        simulator.
        
        rdar://53403778 — yln / ViewSVN
366737. Temporarily Revert "[Attributor] Liveness analysis." as it's breaking the build.
        
        This reverts commit 9285295f75a231dc446fa7cbc10a0a391b3434a5. — echristo / ViewSVN
366736. [Attributor] Liveness analysis.
        
        Liveness analysis abstract attribute used to indicate which BasicBlocks are dead and can therefore be ignored.
        Right now we are only looking at noreturn calls.
        
        Reviewers: jdoerfert, uenoku
        
        Subscribers: hiraditya, llvm-commits
        
        Differential revision: https://reviews.llvm.org/D64162 — sstefan / ViewSVN
366735. [NFC][libc++] Add missing EXPLICIT to pair and tuple synopsis
        
        The constructors for std::pair and std::tuple have been made conditionally
        explicit, however the synopsis in the headers do not reflect that. — Louis Dionne / ViewSVN
366734. [runtimes] Don't depend on libpthread on Android
        
        r362048 added support for ELF dependent libraries, but broke Android
        build since Android does not have libpthread. Remove the dependency on
        the Android build.
        
        Differential Revision: https://reviews.llvm.org/D65098 — kongyi / ViewSVN
366732. [X86] When using AND+PACKUS in lowerV16I8Shuffle, generate the build vector directly in v16i8 with the correct 0x00 or 0xFF elements rather than using another VT and bitcasting it.
        
        The build_vector will become a constant pool load. By using the
        desired type initially, it ensures we don't generate a bitcast
        of the constant pool load which will need to be folded with
        the load.
        
        While experimenting with another patch, I noticed that when the
        load type and the constant pool type don't match, then
        SimplifyDemandedBits can't handle it. While we should probably
        fix that, this was a simple way to fix the issue I saw. — ctopper / ViewSVN
366731. [NFC][PowerPC]Change ADDIStocHA to ADDIStocHA8 to follow 64-bit naming convention
        
        Summary:
        
        Since we are planning to add ADDIStocHA for 32bit in later patch, we decided
        to change 64bit one first to follow naming convention with 8 behind opcode.
        
        Patch by: Xiangling_L
        
        Differential Revision: https://reviews.llvm.org/D64814 — jasonliu / ViewSVN
366730. [libc++] Set __file_ to 0 in basic_filebuf::close() even if fclose fails
        
        This issue was detected by ASan in one of our tests. This test manually
        invokes basic_filebuf::cloe(). fclose(__h.release() returned a non-zero
        exit status, so __file_ wasn't set to 0. Later when basic_filebuf
        destructor ran, we would enter the if (__file_) block again leading to
        heap-use-after-free error.
        
        The POSIX specification for fclose says that independently of the return
        value, fclose closes the underlying file descriptor and any further
        access (including another call to fclose()) to the stream results in
        undefined behavior. This is exactly what happened in our test case.
        
        To avoid this issue, we have to always set __file_ to 0 independently of
        the fclose return value.
        
        Differential Revision: https://reviews.llvm.org/D64979 — phosek / ViewSVN
366728. [Attributor] NoAlias on return values.
        
        Porting function return value attribute noalias to attributor.
        This will be followed with a patch for callsite and function argumets.
        
        Reviewers: jdoerfert
        
        Subscribers: lebedev.ri, hiraditya, llvm-commits
        
        Differential Revision: https://reviews.llvm.org/D63067 — sstefan / ViewSVN
366727. Stubs out TLOF for AIX and add support for common vars in assembly output.
        
        Stubs out a TargetLoweringObjectFileXCOFF class, implementing only
        SelectSectionForGlobal for common symbols. Also adds an override of
        EmitGlobalVariable in PPCAIXAsmPrinter which adds a number of defensive errors
        and adds support for emitting common globals. — sfertile / ViewSVN
366726. [SafeStack] Insert the deref after the offset
        
        While debugging code that uses SafeStack, we've noticed that LLVM
        produces an invalid DWARF. Concretely, in the following example:
        
          int main(int argc, char* argv[]) {
            std::string value = "";
            printf("%s\n", value.c_str());
            return 0;
          }
        
        DWARF would describe the value variable as being located at:
        
          DW_OP_breg14 R14+0, DW_OP_deref, DW_OP_constu 0x20, DW_OP_minus
        
        The assembly to get this variable is:
        
          leaq    -32(%r14), %rbx
        
        The order of operations in the DWARF symbols is incorrect in this case.
        Specifically, the deref is incorrect; this appears to be incorrectly
        re-inserted in repalceOneDbgValueForAlloca.
        
        With this change which inserts the deref after the offset instead of
        before it, LLVM produces correct DWARF:
        
          DW_OP_breg14 R14-32
        
        Differential Revision: https://reviews.llvm.org/D64971 — phosek / ViewSVN
366725. WholeProgramDevirt: Teach the pass to respect the global's alignment.
        
        The bytes inserted before an overaligned global need to be padded according
        to the alignment set on the original global in order for the initializer
        to meet the global's alignment requirements. The previous implementation
        that padded to the pointer width happened to be correct for vtables on most
        platforms but may do the wrong thing if the vtable has a larger alignment.
        
        This issue is visible with a prototype implementation of HWASAN for globals,
        which will overalign all globals including vtables to 16 bytes.
        
        There is also no padding requirement for the bytes inserted after the global
        because they are never read from nor are they significant for alignment
        purposes, so stop inserting padding there.
        
        Differential Revision: https://reviews.llvm.org/D65031 — pcc / ViewSVN
366724. [PowerPC] Fix comment on MO_PLT Target Operand Flag. [NFC]
        
        Patch by Xiangling Liao. — sfertile / ViewSVN
366723. [Object][XCOFF] Remove extra includes from XCOFF related files. [NFC]
        
        Differential Revision: https://reviews.llvm.org/D60885 — sfertile / ViewSVN
366722. LowerTypeTests: Teach the pass to respect global alignments.
        
        We were previously ignoring alignment entirely when combining globals
        together in this pass. There are two main things that we need to do here:
        add additional padding before each global to meet the alignment requirements,
        and set the combined global's alignment to the maximum of all of the original
        globals' alignments.
        
        Since we now need to calculate layout as we go anyway, use the calculated
        layout to produce GlobalLayout instead of using StructLayout.
        
        Differential Revision: https://reviews.llvm.org/D65033 — pcc / ViewSVN
366720. Changes to emit CodeView debug info nested type records properly using MCStreamer directives — nilanjana_basu / ViewSVN
366719. Adds support for formatting NS_CLOSED_ENUM and CF_CLOSED_ENUM alongside NS_ENUM and CF_ENUM.
        
        Summary:
        Addresses the formatting of NS_CLOSED_ENUM and CF_CLOSED_ENUM, introduced in Swift 5.
        
        Before:
        
        ```
        typedef NS_CLOSED_ENUM(NSInteger, Foo){FooValueOne = 1, FooValueTwo,
                                               FooValueThree};
        ```
        
        After:
        
        ```
        typedef NS_CLOSED_ENUM(NSInteger, Foo) {
          FooValueOne = 1,
          FooValueTwo,
          FooValueThree
        };
        ```
        
        Contributed by heijink.
        
        Reviewers: benhamilton, krasimir
        
        Reviewed By: benhamilton
        
        Subscribers: cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D65012 — benhamilton / ViewSVN
366715. [AMDGPU] Test update. NFC. — rampitec / ViewSVN
366712. [SLPVectorizer] Fix some MSVC/cppcheck uninitialized variable warnings. NFCI. — rksimon / ViewSVN
366708. Revert "Reland [ELF] Loose a condition for relocation with a symbol"
        
        This reverts commit r366686 as it appears to be causing buildbot
        failures on sanitizer-x86_64-linux-android and sanitizer-x86_64-linux. — vlad.tsyrklevich / ViewSVN
366702. [OPENMP][MSVC]Enable /openmp[:experimental] to compile OpenMP.
        
        Mapped /openmp[:experimental] to -fopenmp option and /openmp- option to
        -fno-openmp — abataev / ViewSVN
366700. [libc++] Do not infer support for C++17 in GCC < 7
        
        libc++'s lit configuration infers the C++ language dialect when it is
        not provided by checking which -std= flags that a compiler supports.
        GCC 5 and GCC 6 have a -std=c++17 flag, however, they do not have full
        C++17 support. The lit configuration has hardcoded logic that removes
        -std=c++1z as an option to test for GCC < 7, but not -std=c++17.
        
        This leads to a bunch of failures when running libc++ tests with GCC 5
        or GCC 6. This patch adds -std=c++17 to the list of flags that are
        discarded for GCC < 7 by lit's language dialect inference.
        
        Thanks to Bryce Adelstein Lelbach for the patch.
        
        Differential Revision: https://reviews.llvm.org/D62874 — Louis Dionne / ViewSVN
366699. [X86] Remove const from some intrinsics that shouldn't have them — probinson / ViewSVN
366698. [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp
        
        Summary:
        SelectionTree is a RecursiveASTVisitor which processes getSourceRange() for
        every node. This is a lot of surface area with the AST, as getSourceRange()
        is specialized for *many* node types.
        And the resulting SelectionTree depends on the source ranges of many
        visited nodes, and the order of traversal.
        
        Put together, this means we really need a traversal log to debug when we
        get an unexpected SelectionTree. I've built this ad-hoc a few times, now
        it's time to check it in.
        
        Example output:
        ```
        D[14:07:44.184] Computing selection for </usr/local/google/home/sammccall/test.cc:1:7, col:8>
        D[14:07:44.184]  push: VarDecl const auto x = 42
        D[14:07:44.184]   claimRange: </usr/local/google/home/sammccall/test.cc:1:12, col:13>
        D[14:07:44.184]   push: NestedNameSpecifierLoc (empty NestedNameSpecifierLoc)
        D[14:07:44.184]   pop: NestedNameSpecifierLoc (empty NestedNameSpecifierLoc)
        D[14:07:44.184]   push: QualifiedTypeLoc const auto
        D[14:07:44.184]   pop: QualifiedTypeLoc const auto
        D[14:07:44.184]    claimRange: </usr/local/google/home/sammccall/test.cc:1:7, col:11>
        D[14:07:44.184]    hit selection: </usr/local/google/home/sammccall/test.cc:1:7, col:8>
        D[14:07:44.184]   skip: IntegerLiteral 42
        D[14:07:44.184]    skipped range = </usr/local/google/home/sammccall/test.cc:1:16>
        D[14:07:44.184]  pop: VarDecl const auto x = 42
        D[14:07:44.184]   claimRange: </usr/local/google/home/sammccall/test.cc:1:1, col:18>
        D[14:07:44.184]  skip: VarDecl int y = 43
        D[14:07:44.184]   skipped range = </usr/local/google/home/sammccall/test.cc:2:1, col:9>
        D[14:07:44.184] Built selection tree
        TranslationUnitDecl
          VarDecl const auto x = 42
             .QualifiedTypeLoc const auto
        
        ```
        
        Reviewers: hokein
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D65073 — sammccall / ViewSVN
366696. Update c++2a status page with post-Cologne information — marshall / ViewSVN

#18488 (Jul 22, 2019 12:18:45 PM)

366695. TableGen: Support physical register inputs > 255
        
        This was truncating register value that didn't fit in unsigned char.
        Switch AMDGPU sendmsg intrinsics to using a tablegen pattern. — arsenm / ViewSVN
366694. [NFC] Relaxed regression tests for PR42665
        
        Following up on the buildbot failures, this commits relaxes some tests:
        instead of checking for specific IR output, it now ensures that the
        underlying issue (the crash), and only that, doesn't happen. — mantognini / ViewSVN
366691. [ARM][LowOverheadLoops] Revert remaining pseudos
        
        ARMLowOverheadLoops would assert a failure if it did not find all the
        pseudo instructions that comprise the hardware loop. Instead of doing
        this, iterate through all the instructions of the function and revert
        any remaining pseudo instructions that haven't been converted.
        
        Differential Revision: https://reviews.llvm.org/D65080 — sam_parker / ViewSVN
366689. [OPENMP]Add support for analysis of firstprivate variables.
        
        Summary:
        Firstprivate variables are the variables, for which the private copies
        must be created in the OpenMP regions and must be initialized with the
        original values. Thus, we must report if the uninitialized variable is
        used as firstprivate.
        
        Reviewers: NoQ
        
        Subscribers: guansong, jdoerfert, caomhin, kkwli0, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64765 — abataev / ViewSVN
366688. AMDGPU/GlobalISel: Fix broken tests — arsenm / ViewSVN
366687. Update documentation for all CERT checks that correspond to a recommendation.
        
        CERT removed their C++ secure coding recommendations from public view and so the links within that documentation are stale. This updates various pieces of documentation to make this more clear, and to help add substance where our docs deferred to CERT's wiki. — aaronballman / ViewSVN
366686. Reland [ELF] Loose a condition for relocation with a symbol
        
        This patch was not the reason of the buildbot failure.
        
        Deleted code was introduced as a work around for a bug in the gold linker
        (http://sourceware.org/PR16794). Test case that was given as a reason for
        this part of code, the one on previous link, now works for the gold.
        This condition is too strict and when a code is compiled with debug info
        it forces generation of numerous relocations with symbol for architectures
        that do not have relocation addend.
        
        Reviewers: arsenm, espindola
        
        Reviewed By: MaskRay
        
        Differential Revision: https://reviews.llvm.org/D64327 — nikolaprica / ViewSVN
366685. AMDGPU/GlobalISel: Remove unnecessary code
        
        The minnum/maxnum case are dead, and the cvt is handled by the
        default. — arsenm / ViewSVN
366684. [ARM] Fix for MVE VPT block pass
        
        We need to ensure that the number of T's is correct when adding multiple
        instructions into the same VPT block.
        
        Differential revision: https://reviews.llvm.org/D65049 — dmgreen / ViewSVN
366683. Updated the signature for some stack related intrinsics (CLANG)
        
        Modified the intrinsics
        int_addressofreturnaddress,
        int_frameaddress & int_sponentry.
        This commit depends on the changes in rL366679
        
        Reviewed By: arsenm
        
        Differential Revision: https://reviews.llvm.org/D64563 — cdevadas / ViewSVN
366682. Revert the change to the [[nodiscard]] feature test macro value.
        
        This value only gets bumped once both P1301 and P1771 are implemented. — aaronballman / ViewSVN
366681. [X86] EltsFromConsecutiveLoads - support common source loads (REAPPLIED)
        
        This patch enables us to find the source loads for each element, splitting them into a Load and ByteOffset, and attempts to recognise consecutive loads that are in fact from the same source load.
        
        A helper function, findEltLoadSrc, recurses to find a LoadSDNode and determines the element's byte offset within it. When attempting to match consecutive loads, byte offsetted loads then attempt to matched against a previous load that has already been confirmed to be a consecutive match.
        
        Next step towards PR16739 - after this we just need to account for shuffling/repeated elements to create a vector load + shuffle.
        
        Fixed out of bounds load assert identified in rL366501
        
        Differential Revision: https://reviews.llvm.org/D64551 — rksimon / ViewSVN
366680. AMDGPU/GlobalISel: Fix tests without asserts
        
        The legality check is only done under NDEBUG, so the failure cases are
        different in a release build. — arsenm / ViewSVN
366679. Added address-space mangling for stack related intrinsics
        
        Modified the following 3 intrinsics:
        int_addressofreturnaddress,
        int_frameaddress & int_sponentry.
        
        Reviewed By: arsenm
        
        Differential Revision: https://reviews.llvm.org/D64561 — cdevadas / ViewSVN
366678. [X86][SSE] Add EltsFromConsecutiveLoads test case identified in rL366501
        
        Test case that led to rL366441 being reverted at rL366501 — rksimon / ViewSVN
366677. [yaml2obj] - Change how we handle implicit sections.
        
        Instead of having the special list of implicit sections,
        that are mixed with the sections read from YAML on late
        stages, I just create the placeholders and add them to
        the main sections list early.
        
        That allows to significantly simplify the code.
        
        Differential revision: https://reviews.llvm.org/D64999 — grimar / ViewSVN
366675. [clangd] Set buffer name for main file. NFCI — sammccall / ViewSVN
366674. [clangd] Log input code of failed highlighting tests. NFC — ibiryukov / ViewSVN
366672. [AST] Treat semantic form of InitListExpr as implicit code in traversals
        
        Summary:
        In particular, do not traverse the semantic form if shouldVisitImplicitCode()
        returns false.
        
        This simplifies the common case of traversals, avoiding the need to
        worry about some expressions being traversed twice.
        
        No tests break after the change, the change would allow to simplify at
        least one of the usages, i.e. r366070 which had to handle this in
        clangd.
        
        Reviewers: gribozavr
        
        Reviewed By: gribozavr
        
        Subscribers: kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64762 — ibiryukov / ViewSVN

#18486 (Jul 22, 2019 6:18:38 AM)

366671. Add location of SVN staging dir to git-llvm error output
        
        Summary:
        In pre-monorepo times the svn staging directory was `.git/svn`. The below error message wasn't mentioning the new name yet.
        
        Example before:
        ```
        Can't push git rev 104cfa289d9 because svn status is not empty:
        !     llvm/trunk/include/llvm
        ```
        
        Example after:
        ```
        Can't push git rev 104cfa289d9 because status in svn staging dir (.git/llvm-upstream-svn) is not empty:
        !     llvm/trunk/include/llvm
        ```
        
        Reviewers: mehdi_amini, jlebar, teemperor
        
        Reviewed By: mehdi_amini
        
        Subscribers: llvm-commits, #llvm
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D65038 — stefan.graenitz / ViewSVN
366670. [OpenCL] Improve destructor support in C++ for OpenCL
        
        This re-applies r366422 with a fix for Bug PR42665 and a new regression
        test. — mantognini / ViewSVN
366669. [IPRA][ARM] Make use of the "returned" parameter attribute
        
        ARM has code to recognise uses of the "returned" function parameter
        attribute which guarantee that the value passed to the function in r0
        will be returned in r0 unmodified. IPRA replaces the regmask on call
        instructions, so needs to be told about this to avoid reverting the
        optimisation.
        
        Differential revision: https://reviews.llvm.org/D64986 — ostannard / ViewSVN
366668. [llvm-readobj] - Stop using precompiled objects in file-headers.test
        
        This converts all sub-tests except one to YAML instead of precompiled inputs.
        
        Differential revision: https://reviews.llvm.org/D64800 — grimar / ViewSVN
366667. [AMDGPU] Save some work when an atomic op has no uses
        
        Summary:
        In the atomic optimizer, save doing a bunch of work and generating a
        bunch of dead IR in the fairly common case where the result of an
        atomic op (i.e. the value that was in memory before the atomic op was
        performed) is not used. NFC.
        
        Reviewers: arsenm, dstuttard, tpr
        
        Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, t-tye, hiraditya, jfb, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64981 — foad / ViewSVN
366666. [PowerPC][NFC] Precommit a test case where ppc-mi-peepholes miscompiles extswsli
        
        Added a test case to show codegen differences. — lkail / ViewSVN

#18484 (Jul 22, 2019 12:34:06 AM)

366665. [Loop Peeling] Fix the handling of branch weights of peeled off branches.
        
        Current algorithm to update branch weights of latch block and its copies is
        based on the assumption that number of peeling iterations is approximately equal
        to trip count.
        
        However it is not correct. According to profitability check in one case we can decide to peel
        in case it helps to reduce the number of phi nodes. In this case the number of peeled iteration
        can be less then estimated trip count.
        
        This patch introduces another way to set the branch weights to peeled of branches.
        Let F is a weight of the edge from latch to header.
        Let E is a weight of the edge from latch to exit.
        F/(F+E) is a probability to go to loop and E/(F+E) is a probability to go to exit.
        Then, Estimated TripCount = F / E.
        For I-th (counting from 0) peeled off iteration we set the the weights for
        the peeled latch as (TC - I, 1). It gives us reasonable distribution,
        The probability to go to exit 1/(TC-I) increases. At the same time
        the estimated trip count of remaining loop reduces by I.
        
        As a result after peeling off N iteration the weights will be
        (F - N * E, E) and trip count of loop becomes
        F / E - N or TC - N.
        
        The idea is taken from the review of the patch D63918 proposed by Philip.
        
        Reviewers: reames, mkuper, iajbar, fhahn
        Reviewed By: reames
        Subscribers: hiraditya, zzheng, llvm-commits
        Differential Revision: https://reviews.llvm.org/D64235 — skatkov / ViewSVN
366664. [utils] Clean up UpdateTestChecks/common.py — maskray / ViewSVN
366663. [analyzer] Fix -Wunused-function in NDEBUG builds with #ifdef LLVM_DUMP_METHOD — maskray / ViewSVN
366662. [InstCombine] Add foldAndOfICmps test cases inspired by PR42691.
        
        icmp ne %x, INT_MIN can be treated similarly to icmp sgt %x, INT_MIN.
        icmp ne %x, INT_MAX can be treated similarly to icmp slt %x, INT_MAX.
        icmp ne %x, UINT_MAX can be treated similarly to icmp ult %x, UINT_MAX.
        
        We already treat icmp ne %x, 0 similarly to icmp ugt %x, 0 — ctopper / ViewSVN

#18483 (Jul 21, 2019 7:27:32 PM)

366661. [PowerPC][NFC] Precomit test case for upcoming patch
        
        Just committing a test case for an upcoming patch so that the review can show
        only the codegen differences. — nemanjai / ViewSVN

#18482 (Jul 21, 2019 6:42:42 PM)

366660. [X86] SimplifyDemandedVectorEltsForTargetNode - Move SUBV_BROADCAST narrowing handling. NFCI.
        
        Move the narrowing of SUBV_BROADCAST to where we handle all the other opcodes. — rksimon / ViewSVN
366659. [PowerPC][NFC] Regenerate test using script
        
        This test case ended up as a hybrid of generated checks and manually inserted
        checks. Regenerate using script to make it consistent. — nemanjai / ViewSVN
366658. [InstCombine] Update comment I missed in r366649. NFC — ctopper / ViewSVN
366657. [SmallBitVector] Fix bug in find_next_unset for small types with indices >=32
        
        We were creating a bitmask from a shift of unsigned instead of uintptr_t, meaning we couldn't create masks for indices above 31.
        
        Noticed due to a MSVC analyzer warning. — rksimon / ViewSVN

#18481 (Jul 21, 2019 1:20:33 PM)

366656. [GISel]: Attach missing range metadata while translating G_LOADs
        
        https://reviews.llvm.org/D65048
        
        Attach range information to G_LOAD when only defining one register.
        
        reviewed by: arsenm — aditya_nandakumar / ViewSVN
366655. [ARM] Move MVE VPT block tests into the Thumb2 directory. NFC — dmgreen / ViewSVN

#18479 (Jul 21, 2019 3:45:10 AM)

366649. [InstCombine] Remove insertRangeTest code that handles the equality case.
        
        For equality, the function called getTrue/getFalse with the VT
        of the comparison input. But getTrue/getFalse need the boolean VT.
        So if this code ever executed, it would assert.
        
        I believe these cases are removed by InstSimplify so we don't get here.
        
        So this patch just fixes up an assert to exclude the equality
        possibility and removes the broken code. — ctopper / ViewSVN

#18478 (Jul 20, 2019 11:23:36 PM)

366648. [InstCombine] Don't use AddOne/SubOne to see if two APInts are 1 apart. Use APInt operations instead. NFCI
        
        AddOne/SubOne create new Constant objects. That seems heavy for
        comparing ConstantInts which wrap APInts. Just do the math on
        on the APInts and compare them. — ctopper / ViewSVN

#18477 (Jul 20, 2019 10:09:35 PM)

366646. gn build: Merge r366622 — nico / ViewSVN
366645. [Clang] Replace cc1 options '-mdisable-fp-elim' and '-momit-leaf-frame-pointer'
        with '-mframe-pointer'
        
        After D56351 and D64294, frame pointer handling is migrated to tri-state
        (all, non-leaf, none) in clang driver and on the function attribute.
        This patch makes the frame pointer handling cc1 option tri-state.
        
        Reviewers: chandlerc, rnk, t.p.northover, MaskRay
        
        Reviewed By: MaskRay
        
        Differential Revision: https://reviews.llvm.org/D56353 — yuanfang / ViewSVN

#18475 (Jul 20, 2019 5:13:40 PM)

366643. [NFC][InstCombine] Autogenerate a few tests — lebedevri / ViewSVN
366642. [NFC][InstCombine] Add srem-by-signbit tests - still can fold to bittest
        
        https://rise4fun.com/Alive/IIeS — lebedevri / ViewSVN
366640. [NFC][Codegen][X86][AArch64] Add "(x s% C) == 0" tests
        
        Much like with `urem`, the same optimization (albeit with slightly
        different algorithm) applies for the signed case, too.
        
        I'm simply copying the test coverage from `urem` case for now,
        i believe it should be (close to?) sufficient. — lebedevri / ViewSVN
366638. Fix asan infinite loop on undefined symbol
        
        Fix llvm#39641
        
        Recommit of r366413
        
        Differential Revision: https://reviews.llvm.org/D63877
        
        llvm-svn: 366632 — serge_sans_paille / ViewSVN

#18473 (Jul 20, 2019 11:51:29 AM)

366637. [Codegen][SelectionDAG] X u% C == 0 fold: non-splat vector improvements
        
        Summary:
        Four things here:
        1. Generalize the fold to handle non-splat divisors. Reasonably trivial.
        2. Unban power-of-two divisors. I don't see any reason why they should
           be illegal.
           * There is no ban in Hacker's Delight
           * I think the ban came from the same bug that caused the miscompile
              in the base patch - in `floor((2^W - 1) / D)` we were dividing by
              `D0` instead of `D`, and we **were** ensuring that `D0` is not `1`,
              which made sense.
        3. Unban `1` divisors. I no longer believe Hacker's Delight actually says
           that the fold is invalid for `D = 0`. Further considerations:
           * We know that
             * `(X u% 1) == 0`  can be constant-folded to `1`,
             * `(X u% 1) != 0`  can be constant-folded to `0`,
           *  Also, we know that
             * `X u<= -1` can be constant-folded to `1`,
             * `X u>  -1` can be constant-folded to `0`,
           * https://godbolt.org/z/7jnZJX https://rise4fun.com/Alive/oF6p
           * We know will end up with the following:
               `(setule/setugt (rotr (mul N, P), K), Q)`
           * Therefore, for given new DAG nodes and comparison predicates
             (`ule`/`ugt`), we will still produce the correct answer if:
             `Q` is a all-ones constant; and both `P` and `K` are *anything*
             other than `undef`.
           * The fold will indeed produce `Q = all-ones`.
        4. Try to re-splat the `P` and `K` vectors - we don't care about
           their values for the lanes where divisor was `1`.
        
        Reviewers: RKSimon, hermord, craig.topper, spatel, xbolva00
        
        Reviewed By: RKSimon
        
        Subscribers: hiraditya, javed.absar, dexonsmith, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63963 — lebedevri / ViewSVN
366636. [X86][SSE] Use PSADBW to improve vXi8 sum reduction (PR42674)
        
        As detailed on PR42674, we can reduce a vXi8 down until we have the final <8 x i8>, and then use PSADBW with zero, to sum those values. We then extract the bottom i8, discarding any overflow from the upper bits of the i16 result. — rksimon / ViewSVN
366635. Fix cppcheck reduce scope variable warnings. NFCI
        
        Move a couple of variables inside the block where they are actually needed. — rksimon / ViewSVN
366634. Revert "Fix asan infinite loop on undefined symbol"
        
        This reverts commit cbd28cd05bb11e9d76d71c6cc2d38d89dbb1fe1a.
        
        Buildbot fail: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22434/steps/64-bit%20check-asan-dynamic/ — serge_sans_paille / ViewSVN
366633. [Local] Zap blockaddress without users in ConstantFoldTerminator.
        
        If the blockaddress is not destoryed, the destination block will still
        be marked as having its address taken, limiting further transformations.
        
        I think there are other places where the dead blockaddress constants are kept
        around, I'll look into that as follow up.
        
        Reviewers: craig.topper, brzycki, davide
        
        Reviewed By: brzycki, davide
        
        Differential Revision: https://reviews.llvm.org/D64936 — fhahn / ViewSVN
366632. Fix asan infinite loop on undefined symbol
        
        Fix llvm#39641
        
        Recommit of r366413
        
        Differential Revision: https://reviews.llvm.org/D63877 — serge_sans_paille / ViewSVN
366630. [c++20] P1161R3: a[b,c] is deprecated. — rsmith / ViewSVN
366629. Mark P1301R4 in C++2a as being SVN instead. — aaronballman / ViewSVN
366628. We support P1301R4 in C++2a as of r366626. — aaronballman / ViewSVN
366627. [cxx_status] Update status page for WG21 Cologne meeting motions.
        
        Note that many of the paper links will be dead until the post-meeting
        mailing is released. — rsmith / ViewSVN
366626. Implement P1301R4, which allows specifying an optional message on the [[nodiscard]] attribute.
        
        This also bumps the attribute feature test value and introduces the notion of a C++2a extension warning. — aaronballman / ViewSVN

#18468 (Jul 19, 2019 9:40:46 PM)

366625. [GlobalISel][AArch64] Contract trivial same-size cross-bank copies into G_STOREs
        
        Sometimes, you can end up with cross-bank copies between same-sized GPRs and
        FPRs, which feed into G_STOREs. When these copies feed only into stores, they
        aren't necessary; we can just store using the original register bank.
        
        This provides some minor code size savings for some floating point SPEC
        benchmarks. (Around 0.2% for 453.povray and 450.soplex)
        
        This issue doesn't seem to show up due to regbankselect or anything similar. So,
        this patch introduces an early select function, `contractCrossBankCopyIntoStore`
        which performs the contraction when possible. The selector then continues
        normally and selects the correct store opcode, eliminating needless copies
        along the way.
        
        Differential Revision: https://reviews.llvm.org/D65024 — paquette / ViewSVN
366624. [WebAssembly] Compute and export TLS block alignment
        
        Summary:
        Add immutable WASM global `__tls_align` which stores the alignment
        requirements of the TLS segment.
        
        Add `__builtin_wasm_tls_align()` intrinsic to get this alignment in Clang.
        
        The expected usage has now changed to:
        
            __wasm_init_tls(memalign(__builtin_wasm_tls_align(),
                                     __builtin_wasm_tls_size()));
        
        Reviewers: tlively, aheejin, sbc100, sunfish, alexcrichton
        
        Reviewed By: tlively
        
        Subscribers: dschuff, jgravelle-google, hiraditya, cfe-commits, llvm-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D65028 — quantum / ViewSVN
366623. [LTO] Always mark regular LTO units with EnableSplitLTOUnit=1
        
        Summary:
        Regular LTO modules do not need LTO Unit splitting, only ThinLTO does
        (they must be consistently split into regular and Thin units for
        optimizations such as whole program devirtualization and lower type
        tests). In order to avoid spurious errors from LTO when combining with
        split ThinLTO modules, always set this flag for regular LTO modules.
        
        Reviewers: pcc
        
        Subscribers: mehdi_amini, Prazek, inglorion, steven_wu, dexonsmith, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D65009 — tejohnson / ViewSVN
366622. Re-commit: r366610 and r366612: Expand pseudo-components before embedding in llvm-config
        
        There were two main problems:
        * The 'nativecodegen' pseudo-component was unconditionally adding
          ${native_tgt}CodeGen even though it conditionally added ${native_tgt}Info and
          ${native_tgt}Desc. This has been fixed by making ${native_tgt}CodeGen
          conditional too
        * The 'all' pseudo-component was causing library names like LLVMLLVMDemangle as
          the expansion was to a library name and not a component. There doesn't seem to
          be a list of available components anywhere so this has been fixed by moving the
          expansion of 'all' back where it was before. This manifested in different ways
          on different builders but it was the same root cause — dsanders / ViewSVN
366621. AMDGPU/GlobalISel: Legalize GEP for other 32-bit address spaces — arsenm / ViewSVN
366620. [NFC] Remove unused variable
        
        Change-Id: I5aee24dcdf6eebfbf788e52be22463387f23d927 — dendibakh / ViewSVN

#18467 (Jul 19, 2019 4:46:07 PM)

366619. [AMDGPU] Autogenerate register sequences in tuples
        
        Differential Revision: https://reviews.llvm.org/D65007 — rampitec / ViewSVN
366618. Revert "Fix asan infinite loop on undefined symbol"
        
        This reverts commit 8e46275488ca453a24964cb26be0736172ad1db8.
        
        This was failing on sanitizer-x86_64-linux and our internal CI. — ormris / ViewSVN
366617. Disallow most calling convention attributes on PS4
        
        PS4 now only allows "cdecl", and its equivalent on PS4, "sysv_abi".
        
        Differential Revision: https://reviews.llvm.org/D64780 — ssrivastava / ViewSVN
366616. [AMDGPU] Fixed occupancy calculation for gfx10
        
        Differential Revision: https://reviews.llvm.org/D65010 — rampitec / ViewSVN
366615. Revert r366610 and r366612: Expand pseudo-components before embedding in llvm-config
        
        Some targets are missing LLVMDemangle, one is adding the LLVM prefix twice, and two
        are hitting the very error this patch fixes for my target. Reverting while I work
        through the reports. — dsanders / ViewSVN
366614. [InstCombine] Fix copy/paste mistake in the test cases I added for PR42691. NFC — ctopper / ViewSVN
366613. AMDGPU: Avoid custom predicates for stores with glue — arsenm / ViewSVN
366612. Fix a latent bug discovered by r366610: nativecodegen includes X86CodeGen when X86 is not compiled
        
        I believe this to have been a latent bug as the same expansion checks for the
        existence of ${native_tgt}Info and ${native_tgt}Desc and only adds them if
        they were compiled but unconditionally adds ${native_tgt}CodeGen.
        
        This should fix llvm-clang-x86_64-win-fast which builds ARM only on an X86 host and similar builders. — dsanders / ViewSVN
366611. [InstCombine] Add test cases for PR42691. NFC — ctopper / ViewSVN
366610. Expand pseudo-components before embedding in llvm-config
        
        Summary:
        If you use pseudo-targets like AllTargetsCodeGens in LLVM_DYLIB_COMPONENTS
        then a test will fail because `./bin/llvm-config --shared-mode` can't
        handle these targets. We can fix this by expanding them before embedding
        the string into llvm-config
        
        Reviewers: bogner
        
        Reviewed By: bogner
        
        Subscribers: mgorny, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D65011 — dsanders / ViewSVN
366609. AMDGPU: Redefine setcc condition PatLeafs
        
        Avoid using custom code predicates. — arsenm / ViewSVN
366608. AMDGPU: Don't rely on m0 being -1 for GWS offsets
        
        This only works if the high bits of m0 are also 0, so m0 would have to
        be set to 0xffff. — arsenm / ViewSVN
366607. AMDGPU: Force s_waitcnt after GWS instructions
        
        This is apparently required to be the immediately following
        instruction, so force it into a bundle with a waitcnt. — arsenm / ViewSVN
366606. [libc++] Mark libcpp_deallocate.sh.cpp as UNSUPPORTED instead of XFAIL on AppleClang 9
        
        Some minor versions of AppleClang 9 appear not to fail the test. It's
        such a mess that the only sane thing to do is to mark the test as
        UNSUPPORTED. — Louis Dionne / ViewSVN
366605. LiveIntervals: Fix handleMove asserting on BUNDLE
        
        The top-level BUNDLE instruction should behave as an ordinary
        instruction. It is supposed to have all relevant registers as implicit
        operands. Moving it should work as any other instruction. I believe
        the assert intended to avoid moving instructions inside bundles. — arsenm / ViewSVN
366603. Revert "[libc++] Integrate the PSTL into libc++"
        
        This reverts r366593, which caused unforeseen breakage on the build bots.
        I'm reverting until the problems have been figured out and fixed. — Louis Dionne / ViewSVN
366602. [AMDGPU] Add test case on crashing of `si-lower-sgpr-spills` pass
        
        Reviewers: arsenm
        
        Subscribers: qcolombet, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64273 — hliao / ViewSVN
366601. [libc++] Allow passing additional CMake arguments in macOS trunk CI script — Louis Dionne / ViewSVN
366600. Revert "Use the MachineBasicBlock symbol for a callbr target"
        
        This reverts commit r366523/ccbffefccaff42b0d094c9ef0f49fc3e8c8456ea.
        
        Two regressions were immediately reported:
        - https://github.com/ClangBuiltLinux/linux/issues/614
        - https://github.com/ClangBuiltLinux/linux/issues/615
        
        Reported-by: nathanchance — nickdesaulniers / ViewSVN
366599. [RISCV] Disable tests failing on buildbots.
        
        r366399 enabled a couple tests that are failing on a few buildbots. — morehouse / ViewSVN
366598. [AMDGPU] Allow register tuples to set asm names
        
        This change reverts most of the previous register name generation.
        The real problem is that RegisterTuple does not generate asm names.
        Added optional operand to RegisterTuple. This way we can simplify
        register name access and dramatically reduce the size of static
        tables for the backend.
        
        Differential Revision: https://reviews.llvm.org/D64967 — rampitec / ViewSVN
366597. AMDGPU/GlobalISel: Fix MMO flags for kernel argument loads
        
        The DAG lowering sets dereferencable and invariant, not nontemporal. — arsenm / ViewSVN
366596. GlobalISel: Add GINodeEquiv for fcopysign
        
        I don't need this at the moment, but it should be here. — arsenm / ViewSVN
366595. [llvm-lipo] Remove trailing whitespace. NFC — smeenai / ViewSVN
366594. [libc++] Use _EnableIf instead of std::enable_if in deduction guides for map and set — Louis Dionne / ViewSVN
366593. [libc++] Integrate the PSTL into libc++
        
        Summary:
        This commit allows specifying LIBCXX_ENABLE_PARALLEL_ALGORITHMS when
        configuring libc++ in CMake. When that option is enabled, libc++ will
        assume that the PSTL can be found somewhere on the CMake module path,
        and it will provide the C++17 parallel algorithms based on the PSTL
        (that is assumed to be available).
        
        The commit also adds support for running the PSTL tests as part of
        the libc++ test suite.
        
        Reviewers: rodgert, EricWF
        
        Subscribers: mgorny, christof, jkorous, dexonsmith, libcxx-commits, mclow.lists, EricWF
        
        Tags: #libc
        
        Differential Revision: https://reviews.llvm.org/D60480 — Louis Dionne / ViewSVN
366592. [Format/ObjC] Avoid breaking between unary operators and operands
        
        Summary:
        Test Plan:
          New tests added. Ran tests with:
          % ninja FormatTests && ./tools/clang/unittests/Format/FormatTests
          Confirmed tests failed before change and passed after change.
        
        Reviewers: krasimir, djasper, sammccall, klimek
        
        Reviewed By: sammccall
        
        Subscribers: klimek, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64775 — benhamilton / ViewSVN
366591. AMDGPU: Add some function return test cases — arsenm / ViewSVN
366589. [AMDGPU] Regenerate test file for upcoming patch. NFCI. — rksimon / ViewSVN
366588. Fix asan infinite loop on undefined symbol
        
        Fix llvm#39641
        
        Recommit of r366413
        
        Differential Revision: https://reviews.llvm.org/D63877 — serge_sans_paille / ViewSVN
366586. AMDGPU: Attempt to fix bot error
        
        Manually remove file name from check line, since it somehow ends
        up being different on an msvc bot. — arsenm / ViewSVN

#18465 (Jul 19, 2019 10:50:46 AM)

366585. AMDGPU/GlobalISel: Selection for fminnum/fmaxnum
        
        v2f16 case doesn't work yet because the VOP3P complex patterns haven't
        been ported yet. — arsenm / ViewSVN
366584. AMDGPU/GlobalISel: Support arguments with multiple registers
        
        Handles structs used directly in argument lists. — arsenm / ViewSVN
366582. AMDGPU/GlobalISel: Rewrite lowerFormalArguments
        
        This should now handle everything except structs passed as multiple
        registers.
        
        I think most of the packing logic should be handled by
        handleAssignments, but I'm unclear on what the contract is for
        multiple registers. This is copying how x86 handles this.
        
        This does change the behavior of the test_sgpr_alignment0 amdgpu_vs
        test. I don't think shader arguments should try to follow the
        alignment, and registers need to be repacked. I also don't think it
        matters, since I think the pointers are packed to the beginning of the
        argument list anyway. — arsenm / ViewSVN
366579. [libc++] Add missing %link_flags to .sh.cpp test
        
        Without the link flags, the test always fails on Linux. For some reason,
        however, it works on Darwin -- which is why it wasn't caught at first. — Louis Dionne / ViewSVN
366578. AMDGPU: Decompose all values to 32-bit pieces for calling conventions
        
        This is the more natural lowering, and presents more opportunities to
        reduce 64-bit ops to 32-bit.
        
        This should also help avoid issues graphics shaders have had with
        64-bit values, and simplify argument lowering in globalisel. — arsenm / ViewSVN
366577. [clangd] Provide a way to publish highlightings in non-racy manner
        
        Summary:
        By exposing a callback that can guard code publishing results of
        'onMainAST' callback in the same manner we guard diagnostics.
        
        Reviewers: sammccall
        
        Reviewed By: sammccall
        
        Subscribers: javed.absar, MaskRay, jkorous, arphaman, kadircet, hokein, jvikstrom, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64985 — ibiryukov / ViewSVN
366576. gn build: Set +x on symlink_or_copy.py — nico / ViewSVN
366575. [clangd] Disable background-index on lit-tests by default
        
        Summary:
        Since background-index can perform disk writes, we don't want to turn
        it on tests that won't clear it.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64990 — kadircet / ViewSVN
366574. DAG: Handle dbg_value for arguments split into multiple subregs
        
        This was handled previously for arguments split due to not fitting in
        an MVT. This was dropping the register for argument registers split
        due to TLI::getRegisterTypeForCallingConv. — arsenm / ViewSVN
366572. [NFC] include cstdint/string prior to using uint8_t/string
        
        Summary: include proper header prior to use of uint8_t typedef
        and std::string.
        
        Subscribers: llvm-commits
        
        Reviewers: cherry
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64937 — thanm / ViewSVN
366571. [AMDGPU][MC] Corrected parsing of branch offsets
        
        See bug 40820: https://bugs.llvm.org/show_bug.cgi?id=40820
        
        Reviewers: artem.tamazov, arsenm
        
        Differential Revision: https://reviews.llvm.org/D64629 — dpreobra / ViewSVN
366570. [MachineCSE][MachinePRE] Avoid hoisting code from code regions into hot BBs.
        
        Summary:
        Current PRE hoists common computations into
        CMBB = DT->findNearestCommonDominator(MBB, MBB1).
        However, if CMBB is in a hot loop body, we might get performance
        degradation.
        
        Differential Revision: https://reviews.llvm.org/D64394 — lkail / ViewSVN
366569. [X86] for split stack, not save/restore nested arg if unused
        
        Summary:
        For split-stack, if the nested argument (i.e. R10) is not used, no need to save/restore it in the prologue.
        
        Reviewers: thanm
        
        Reviewed By: thanm
        
        Subscribers: mstorsjo, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64673 — thanm / ViewSVN
366568. [Clangd] Fixed ExtractVariable test — sureyeaah / ViewSVN
366567. [libc++] Fix link error with _LIBCPP_HIDE_FROM_ABI_PER_TU and std::string
        
        Summary:
        This is effectively a revert of r344616, which was a partial fix for
        PR38964 (compilation of <string> with GCC in C++03 mode). However, that
        configuration is explicitly not supported anymore and that partial fix
        breaks compilation with Clang when per-TU insulation is provided.
        
        PR42676
        rdar://52899715
        
        Reviewers: mclow.lists, EricWF
        
        Subscribers: christof, jkorous, dexonsmith, libcxx-commits
        
        Tags: #libc
        
        Differential Revision: https://reviews.llvm.org/D64941 — Louis Dionne / ViewSVN
366566. [Clangd] Fixed SelectionTree bug for macros
        
        Summary:
        Fixed SelectionTree bug for macros
        - Fixed SelectionTree claimRange for macros and template instantiations
        - Fixed SelectionTree unit tests
        - Changed a breaking test in TweakTests
        
        Reviewers: sammccall, kadircet
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64329 — sureyeaah / ViewSVN
366565. [NFC][InstCombine] Tests for 'rem' formation from sub-of-mul-by-'div' (PR42673)
        
        https://rise4fun.com/Alive/8Rp
        https://bugs.llvm.org/show_bug.cgi?id=42673 — lebedevri / ViewSVN
366564. [NFC][InstCombine] Redundant masking before left-shift: tests with assume
        
        If the legality check is `(shiftNbits-maskNbits) s>= 0`,
        then we can simplify it to `shiftNbits u>= maskNbits`,
        which is easier to check for.
        
        However, currently switching the `dropRedundantMaskingOfLeftShiftInput()`
        to `SimplifyICmpInst()` does not catch these cases and regresses
        currently-handled cases, so i'll leave it as is for now.
        
        https://rise4fun.com/Alive/25P — lebedevri / ViewSVN
366563. Fix MSVC "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI. — rksimon / ViewSVN
366562. Don't update NoTrappingFPMath and FPDenormalMode in resetTargetOptions
        
        We'd like to remove this whole function, because these are properties of
        functions, not the target as a whole. These two are easy to remove
        because they are only used for emitting ARM build attributes, which
        expects them to represent the defaults for the whole module, not just
        the last function generated.
        
        This is needed to get correct build attributes when using IPRA on ARM,
        because IPRA causes resetTargetOptions to get called before
        ARMAsmPrinter::emitAttributes.
        
        Differential revision: https://reviews.llvm.org/D64929 — ostannard / ViewSVN
366559. Revert "Revert r366458, r366467 and r366468"
        
        This reverts commit 9c377105da0be7c2c9a3c70035ce674c71b846af.
        
        [clangd][BackgroundIndexLoader] Directly store DependentTU while loading shard
        
        Summary:
        We were deferring the population of DependentTU field in LoadedShard
        until BackgroundIndexLoader was consumed. This actually triggers a use after
        free since the shards FileToTU was pointing at could've been moved while
        consuming the Loader.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64980 — kadircet / ViewSVN
366558. [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"
        
        Fixes https://bugs.llvm.org/show_bug.cgi?id=42622.
        (--hash-symbols switch is currently broken for 64-bit ELF files, due to r352630.)
        
        Differential revision: https://reviews.llvm.org/D64788 — grimar / ViewSVN
366557. [IPRA] Don't rely on non-exact function definitions
        
        If a function definition is not exact, then the linker could select a
        differently-compiled version of it, which could use different registers.
        
        https://reviews.llvm.org/D64909 — ostannard / ViewSVN

#18463 (Jul 19, 2019 4:18:03 AM)

366558. [llvm-readelf] - A fix for: "--hash-symbols asserts for 64-bit ELFs"
        
        Fixes https://bugs.llvm.org/show_bug.cgi?id=42622.
        (--hash-symbols switch is currently broken for 64-bit ELF files, due to r352630.)
        
        Differential revision: https://reviews.llvm.org/D64788 — grimar / ViewSVN
366557. [IPRA] Don't rely on non-exact function definitions
        
        If a function definition is not exact, then the linker could select a
        differently-compiled version of it, which could use different registers.
        
        https://reviews.llvm.org/D64909 — ostannard / ViewSVN
366555. [ARM] Add <saturate> operand to SQRSHRL and UQRSHLL
        
        Summary:
        According to the new Armv8-M specification
        https://static.docs.arm.com/ddi0553/bh/DDI0553B_h_armv8m_arm.pdf the
        instructions SQRSHRL and UQRSHLL now have an additional immediate
        operand <saturate>. The new assembly syntax is:
        
        SQRSHRL<c> RdaLo, RdaHi, #<saturate>, Rm
        UQRSHLL<c> RdaLo, RdaHi, #<saturate>, Rm
        
        where <saturate> can be either 64 (the existing behavior) or 48, in
        that case the result is saturated to 48 bits.
        
        The new operand is encoded as follows:
          #64 Encoded as sat = 0
          #48 Encoded as sat = 1
        sat is bit 7 of the instruction bit pattern.
        
        This patch adds a new assembler operand class MveSaturateOperand which
        implements parsing and encoding. Decoding is implemented in
        DecodeMVEOverlappingLongShift.
        
        Reviewers: ostannard, simon_tatham, t.p.northover, samparker, dmgreen, SjoerdMeijer
        
        Reviewed By: simon_tatham
        
        Subscribers: javed.absar, kristof.beyls, hiraditya, pbarrio, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64810 — miyuki / ViewSVN
366551. Revert r366458, r366467 and r366468
        
        r366458 is causing test failures. r366467 and r366468 had to be reverted as
        they were casuing conflict while reverting r366458.
        
        r366468 [clangd] Remove dead code from BackgroundIndex
        r366467 [clangd] BackgroundIndex stores shards to the closest project
        r366458 [clangd] Refactor background-index shard loading — Azharuddin Mohammed / ViewSVN
366546. [OpenCL] Define CLK_NULL_EVENT without cast
        
        Defining CLK_NULL_EVENT with a `(void*)` cast has the (unintended?)
        side-effect that the address space will be fixed (as generic in OpenCL
        2.0 mode).  The consequence is that any target specific address space
        for the clk_event_t type will not be applied.
        
        It is not clear why the void pointer cast was needed in the first
        place, and it seems we can do without it.
        
        Differential Revision: https://reviews.llvm.org/D63876 — svenvh / ViewSVN
366545. [clangd] Handle windows line endings in QueryDriver
        
        Summary:
        The previous patch did not fix the end mark. D64789
        fixes second case of https://github.com/clangd/clangd/issues/93
        
        Patch by @lh123 !
        
        Reviewers: sammccall, kadircet
        
        Reviewed By: kadircet
        
        Subscribers: MaskRay, ilya-biryukov, jkorous, arphaman, cfe-commits
        
        Tags: #clang-tools-extra, #clang
        
        Differential Revision: https://reviews.llvm.org/D64970 — kadircet / ViewSVN
366544. [sanitizers] Use covering ObjectFormatType switches
        
        Summary:
        This patch removes the `default` case from some switches on
        `llvm::Triple::ObjectFormatType`, and cases for the missing enumerators
        (`UnknownObjectFormat`, `Wasm`, and `XCOFF`) are then added.
        
        For `UnknownObjectFormat`, the effect of the action for the `default`
        case is maintained; otherwise, where `llvm_unreachable` is called,
        `report_fatal_error` is used instead.
        
        Where the `default` case returns a default value, `report_fatal_error`
        is used for XCOFF as a placeholder. For `Wasm`, the effect of the action
        for the `default` case in maintained.
        
        The code is structured to avoid strongly implying that the `Wasm` case
        is present for any reason other than to make the switch cover all
        `ObjectFormatType` enumerator values.
        
        Reviewers: sfertile, jasonliu, daltenty
        
        Reviewed By: sfertile
        
        Subscribers: hiraditya, aheejin, sunfish, llvm-commits, cfe-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D64222 — hubert.reinterpretcast / ViewSVN
366543. [AMDGPU] Simplify the exclusive scan used for optimized atomics
        
        Summary:
        Change the scan algorithm to use only power-of-two shifts (1, 2, 4, 8,
        16, 32) instead of starting off shifting by 1, 2 and 3 and then doing
        a 3-way ADD, because:
        
        1. It simplifies the compiler a little.
        2. It minimizes vgpr pressure because each instruction is now of the
           form vn = vn + vn << c.
        3. It is more friendly to the DPP combiner, which currently can't
           combine into an ADD3 instruction.
        
        Because of #2 and #3 the end result is improved from this:
        
          v_add_u32_dpp v4, v3, v3  row_shr:1 row_mask:0xf bank_mask:0xf bound_ctrl:0
          v_mov_b32_dpp v5, v3  row_shr:2 row_mask:0xf bank_mask:0xf
          v_mov_b32_dpp v1, v3  row_shr:3 row_mask:0xf bank_mask:0xf
          v_add3_u32 v1, v4, v5, v1
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_shr:4 row_mask:0xf bank_mask:0xe
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_shr:8 row_mask:0xf bank_mask:0xc
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_bcast:15 row_mask:0xa bank_mask:0xf
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_bcast:31 row_mask:0xc bank_mask:0xf
        
        To this:
        
          v_add_u32_dpp v1, v1, v1  row_shr:1 row_mask:0xf bank_mask:0xf bound_ctrl:0
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_shr:2 row_mask:0xf bank_mask:0xf bound_ctrl:0
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_shr:4 row_mask:0xf bank_mask:0xe
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_shr:8 row_mask:0xf bank_mask:0xc
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_bcast:15 row_mask:0xa bank_mask:0xf
          s_nop 1
          v_add_u32_dpp v1, v1, v1  row_bcast:31 row_mask:0xc bank_mask:0xf
        
        I.e. two fewer computational instructions, one extra nop where we could
        schedule something else.
        
        Reviewers: arsenm, sheredom, critson, rampitec, vpykhtin
        
        Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64411 — foad / ViewSVN
366542. [Loop Peeling] Enable peeling of multiple exits by default.
        
        Enable loop peeling with multiple exits where all non-latch exits
        ends up with deopt by default.
        
        Reviewers: reames, fhahn
        Reviewed By: reames
        Subscribers: xbolva00, hiraditya, zzheng, llvm-commits
        Differential Revision: https://reviews.llvm.org/D64619 — skatkov / ViewSVN
366541. [clangd] cleanup: unify the implemenation of checking a location is inside main file.
        
        Summary: We have variant implementations in the codebase, this patch unifies them.
        
        Reviewers: ilya-biryukov, kadircet
        
        Subscribers: MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64915 — hokein / ViewSVN
366540. [InstCombine] Dropping redundant masking before left-shift [5/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        f. `((x << MaskShAmt) a>> MaskShAmt) << ShiftShAmt`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        f. `(ShiftShAmt-MaskShAmt) s>= 0` (i.e. `ShiftShAmt u>= MaskShAmt`)
        
        Normally, the inner pattern is sign-extend,
        but for our purposes it's no different to other patterns:
        
        alive proofs:
        f: https://rise4fun.com/Alive/7U3
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Differential Revision: https://reviews.llvm.org/D64524 — lebedevri / ViewSVN
366539. [InstCombine] Dropping redundant masking before left-shift [4/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        e. `((x << MaskShAmt) l>> MaskShAmt) << ShiftShAmt`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        e. `(ShiftShAmt-MaskShAmt) s>= 0` (i.e. `ShiftShAmt u>= MaskShAmt`)
        
        alive proofs:
        e: https://rise4fun.com/Alive/0FT
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Differential Revision: https://reviews.llvm.org/D64521 — lebedevri / ViewSVN
366538. [InstCombine] Dropping redundant masking before left-shift [3/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        d. `(x & ((-1 << MaskShAmt) >> MaskShAmt)) << ShiftShAmt`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        d. `(ShiftShAmt-MaskShAmt) s>= 0` (i.e. `ShiftShAmt u>= MaskShAmt`)
        
        alive proofs:
        d: https://rise4fun.com/Alive/I5Y
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Differential Revision: https://reviews.llvm.org/D64519 — lebedevri / ViewSVN
366537. [InstCombine] Dropping redundant masking before left-shift [2/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        c. `(x & (-1 >> MaskShAmt)) << ShiftShAmt`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        c. `(ShiftShAmt-MaskShAmt) s>= 0` (i.e. `ShiftShAmt u>= MaskShAmt`)
        
        alive proofs:
        c: https://rise4fun.com/Alive/RgJh
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Differential Revision: https://reviews.llvm.org/D64517 — lebedevri / ViewSVN
366536. [InstCombine] Dropping redundant masking before left-shift [1/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        b. `(x & (~(-1 << maskNbits))) << shiftNbits`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        b. `(MaskShAmt+ShiftShAmt) u>= bitwidth(x)`
        
        alive proof:
        b: https://rise4fun.com/Alive/y8M
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Differential Revision: https://reviews.llvm.org/D64514 — lebedevri / ViewSVN
366535. [InstCombine] Dropping redundant masking before left-shift [0/5] (PR42563)
        
        Summary:
        If we have some pattern that leaves only some low bits set, and then performs
        left-shift of those bits, if none of the bits that are left after the final
        shift are modified by the mask, we can omit the mask.
        
        There are many variants to this pattern:
        a. `(x & ((1 << MaskShAmt) - 1)) << ShiftShAmt`
        All these patterns can be simplified to just:
        `x << ShiftShAmt`
        iff:
        a. `(MaskShAmt+ShiftShAmt) u>= bitwidth(x)`
        
        alive proof:
        a: https://rise4fun.com/Alive/wi9
        
        Indeed, not all of these patterns are canonical.
        But since this fold will only produce a single instruction
        i'm really interested in handling even uncanonical patterns,
        since i have this general kind of pattern in hotpaths,
        and it is not totally outlandish for bit-twiddling code.
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563
        
        Reviewers: spatel, nikic, huihuiz, xbolva00
        
        Reviewed By: xbolva00
        
        Subscribers: efriedma, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64512 — lebedevri / ViewSVN
366533. [NFC] Fix an indentation issue in llvm/Support/TargetRegistry.h — hubert.reinterpretcast / ViewSVN
366531. [DebugInfo] Some fields do not need relocations even relax is enabled.
        
        In debug frame information, some fields, e.g., Length in CIE/FDE and
        Offset in FDE are attributes to describe the structure of CIE/FDE. They
        are not related to the relaxed code. However, these attributes are
        symbol differences. So, in current design, these attributes will be
        filled as zero and LLVM generates relocations for them.
        
        We only need to generate relocations for symbols in executable sections.
        So, if the symbols are not located in executable sections, we still
        evaluate their values under relaxation.
        
        Differential Revision: https://reviews.llvm.org/D61584 — hsiangkai / ViewSVN
366530. unbreak links — lattner / ViewSVN
366529. replace the old kaleidoscope tutorial files with orphaned pages that forward to the new copy. — lattner / ViewSVN
366528. Point to the dusted off version of the kaleidoscope tutorial. — lattner / ViewSVN
366527. [test] [llvm-objcopy] Fix broken test case
        
        Summary: The test case added in D62718 did not work unless the user was root because write bits were not set for the output file. This change uses only permissions with user write (0200) to ensure tests pass regardless of the users permissions.
        
        Reviewers: jhenderson, rupprecht, MaskRay, espindola, alexshap
        
        Reviewed By: MaskRay
        
        Subscribers: emaste, arichardson, jakehehrlich, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64302 — abrachet / ViewSVN
366526. [NFC][PowerPC] Modify the test case add_cmp.ll — zhangkang / ViewSVN
366525. [libFuzzer] Set Android specific ALL_FUZZER_SUPPORTED_ARCH
        
        Build libFuzzer for all Android supported architectures. — kongyi / ViewSVN
366524. [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
        
        It is necessary to generate fixups in .debug_frame or .eh_frame as
        relaxation is enabled due to the address delta may be changed after
        relaxation.
        
        There is an opcode with 6-bits data in debug frame encoding. So, we
        also need 6-bits fixup types.
        
        Differential Revision: https://reviews.llvm.org/D58335 — hsiangkai / ViewSVN
366523. Use the MachineBasicBlock symbol for a callbr target
        
        Summary:
        Inline asm doesn't use labels when compiled as an object file. Therefore, we
        shouldn't create one for the (potential) callbr destination. Instead, use the
        symbol for the MachineBasicBlock.
        
        Reviewers: nickdesaulniers, craig.topper
        
        Reviewed By: nickdesaulniers
        
        Subscribers: xbolva00, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64888 — void / ViewSVN
366518. Fix formatting of inline argument comments. NFC.
        
        Also, remove the final arg from ItaniumCXXABI in the PNaCl case since
        its not needed.
        
        Differential Revision: https://reviews.llvm.org/D64955 — sbc / ViewSVN
366516. [GlobalISel] Translate calls to memcpy et al to G_INTRINSIC_W_SIDE_EFFECTs and legalize later.
        
        I plan on adding memcpy optimizations in the GlobalISel pipeline, but we can't
        do that unless we delay lowering to actual function calls. This patch changes
        the translator to generate G_INTRINSIC_W_SIDE_EFFECTS for these functions, and
        then have each target specify that using the new custom legalizer for intrinsics
        hook that they want it expanded it a libcall.
        
        Differential Revision: https://reviews.llvm.org/D64895 — aemerson / ViewSVN
366515. [cmake] Fix typo where a varible was checked for Apple instead of Darwin
        
        Subscribers: mgorny, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64965 — lanza / ViewSVN
366514. [cmake] Convert the NATIVE llvm build process to be project agnostic
        
        lldb recently added a tablegen tool. In order to properly cross compile
        lldb standalone there needs to be a mechanism to generate the native
        lldb build, analgous to what's done for the NATIVE llvm build. Thus,
        we can simply modify this setup to allow for any project to be used. — lanza / ViewSVN
366512. Reapply [llvm-lipo] Implement -create (with hardcoded alignments)
        
        This reapplies r366142 with a fix for the failing Windows test.
        
        Original commit message:
        
        Creates universal binary output file from input files. Currently uses
        hard coded value for alignment.  Want to get the create functionality
        approved before implementing the alignment function.
        
        Patch by Anusha Basana <anusha.basana@gmail.com>
        
        Differential Revision: https://reviews.llvm.org/D64102 — smeenai / ViewSVN
366511. Update the SimpleJIT class in the clang-interpreter example to use ORCv2.
        
        This will remove the ORCv1 deprecation warnings. — Lang Hames / ViewSVN
366509. [clang-scan-deps] Dependency directives source minimizer: handle #pragma once
        
        We should re-emit `#pragma once` to ensure the preprocessor will
        still honor it when running on minimized sources.
        
        Differential Revision: https://reviews.llvm.org/D64945 — arphaman / ViewSVN
366505. [AMDGPU] Drop Reg32 and use regular AsmName
        
        This allows to reduce generated AMDGPUGenAsmWriter.inc by ~100Kb.
        
        Differential Revision: https://reviews.llvm.org/D64952 — rampitec / ViewSVN
366503. [GlobalISel][AArch64] Add support for base register + offset register loads
        
        Add support for folding G_GEPs into loads of the form
        
        ```
        ldr reg, [base, off]
        ```
        
        when possible. This can save an add before the load. Currently, this is only
        supported for loads of 64 bits into 64 bit registers.
        
        Add a new addressing mode function, `selectAddrModeRegisterOffset` which
        performs this folding when it is profitable.
        
        Also add a test for addressing modes for G_LOAD.
        
        Differential Revision: https://reviews.llvm.org/D64944 — paquette / ViewSVN
366502. CodeGen: Allow !associated metadata to point to aliases.
        
        This is a small extension of !associated, mostly useful for the implementation
        convenience of instrumentation passes that RAUW globals with aliases, such
        as LowerTypeTests.
        
        Differential Revision: https://reviews.llvm.org/D64951 — pcc / ViewSVN
366501. Revert [X86] EltsFromConsecutiveLoads - support common source loads
        
        This reverts r366441 (git commit 48104ef7c9c653bbb732b66d7254957389fea337)
        
        This causes clang to fail to compile some file in Skia. Reduction soon. — rnk / ViewSVN
366499. [WebAssembly] Fix __builtin_wasm_tls_base intrinsic
        
        Summary:
        Properly generate the outchain for the `__builtin_wasm_tls_base` intrinsic.
        
        Also marked the intrinsic pure, per @sunfish's suggestion.
        
        Reviewers: tlively, aheejin, sbc100, sunfish
        
        Reviewed By: tlively
        
        Subscribers: dschuff, jgravelle-google, hiraditya, cfe-commits, llvm-commits, sunfish
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D64949 — quantum / ViewSVN
366498. [cmake] Only run llvm-codesign if targetting apple on an apple host
        
        Summary:
        Other platforms don't have the capability to perform llvm_codesign
        step. If LLVM_CODESIGNING_IDENTITY is set then this chunk of code would
        attempt to codesign if the target was Apple. But when cross compiling
        to Darwin from Linux, for example, this step would fail. So test if the
        host is Apple as well.
        
        Subscribers: mgorny, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64942 — lanza / ViewSVN
366497. Fix typo in r366494. Spotted by Yuanfang Chen. — pcc / ViewSVN
366496. Remove the static initialize introduced in r365099
        
        Summary:
        Some polish for r365099 which adds a static initializer to
        MachOObjectFile. Remove it by moving it to file scope.
        
        Reviewers: smeenai, alexshap, compnerd, mtrent, anushabasana
        
        Reviewed By: smeenai
        
        Subscribers: hiraditya, jkorous, dexonsmith, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64873 — steven_wu / ViewSVN
366494. IR: Teach Constant::needsRelocation() that relative pointers don't need to be relocated.
        
        This causes sections with relative pointers to be marked as read only,
        which means that they won't end up sharing pages with writable data.
        
        Differential Revision: https://reviews.llvm.org/D64948 — pcc / ViewSVN
366488. [ASan] Support `{f}puts(NULL)` on Darwin, part 2
        
        Add braces around macro `{ MACRO(); }` to guard against macros that
        expand to multiple statements. — yln / ViewSVN
366487. gn build: Merge r366458. — pcc / ViewSVN
366486. FileSystem: Check for DTTOIF alone, not _DIRENT_HAVE_D_TYPE
        
        While 'd_type' is a non-standard extension to `struct dirent`, only
        glibc signals its presence with a macro '_DIRENT_HAVE_D_TYPE'.
        However, any platform with 'd_type' also includes a way to convert to
        mode_t values using the macro 'DTTOIF', so we can check for that alone
        and still be confident that the 'd_type' member exists.
        
        (If this turns out to be wrong, I'll go back and set up an actual
        CMake check.)
        
        I couldn't think of how to write a test for this, because I couldn't
        think of how to test that a 'stat' call doesn't happen without
        controlling the filesystem or intercepting 'stat', and there's no good
        cross-platform way to do that that I know of.
        
        Follow-up (almost a year later) to r342089.
        
        rdar://problem/50592673
        https://reviews.llvm.org/D64940 — jrose / ViewSVN
366485. [ORC] Suppress an ORCv1 deprecation warning. — Lang Hames / ViewSVN
366484. [libc++] Add C++17 deduction guides for std::function
        
        Summary: http://llvm.org/PR39606
        
        Reviewers: Quuxplusone
        
        Subscribers: christof, dexonsmith, libcxx-commits
        
        Differential Revision: https://reviews.llvm.org/D54410 — Louis Dionne / ViewSVN
366483. [OPENMP]Fix sharing of threadprivate variables with TLS support.
        
        If the threadprivate variable is used in the copyin clause on inner
        parallel directive with TLS support, we capture this variable in all
        outer OpenMP scopes. It leads to the fact that in all scopes we're
        working with the original variable, not the threadprivate copies. — abataev / ViewSVN
366482. [compiler-rt] Complete revert of r366413
        
        Incomplete revert. Mea culpa. This test is failing on sanitizer-x86_64-linux
        and our internal CI. — ormris / ViewSVN
366481. Fix C++ modules build
        
        llvm-svn: 366344 missed an include that broke the LLVM_ENABLE_MODULES
        build. — Raphael Isemann / ViewSVN
366480. [RISCV] Hard float ABI support
        
        The RISC-V hard float calling convention requires the frontend to:
        
        * Detect cases where, once "flattened", a struct can be passed using
        int+fp or fp+fp registers under the hard float ABI and coerce to the
        appropriate type(s)
        * Track usage of GPRs and FPRs in order to gate the above, and to
        determine when signext/zeroext attributes must be added to integer
        scalars
        
        This patch attempts to do this in compliance with the documented ABI,
        and uses ABIArgInfo::CoerceAndExpand in order to do this. @rjmccall, as
        author of that code I've tagged you as reviewer for initial feedback on
        my usage.
        
        Note that a previous version of the ABI indicated that when passing an
        int+fp struct using a GPR+FPR, the int would need to be sign or
        zero-extended appropriately. GCC never did this and the ABI was changed,
        which makes life easier as ABIArgInfo::CoerceAndExpand can't currently
        handle sign/zero-extension attributes.
        
        Re-landed after backing out 366450 due to missed hunks.
        
        Differential Revision: https://reviews.llvm.org/D60456 — asb / ViewSVN
366479. [COFF] Change a variable type to be const in the HeapAllocSite map. — akhuang / ViewSVN
366477. [FPEnv] Teach the IRBuilder about constrained FPTrunc and FPExt
        
        The IRBuilder doesn't know that FPTrunc and FPExt have constrained
        equivalents. Add the support by building on the strict FP mode now
        present in the IRBuilder.
        
        Reviewed by: John McCall
        Approved by: John McCall
        Differential Revision: https://reviews.llvm.org/D64934 — kpn / ViewSVN
366475. [WebAssembly] Implement __builtin_wasm_tls_base intrinsic
        
        Summary:
        Add `__builtin_wasm_tls_base` so that LeakSanitizer can find the thread-local
        block and scan through it for memory leaks.
        
        Reviewers: tlively, aheejin, sbc100
        
        Subscribers: dschuff, jgravelle-google, hiraditya, sunfish, cfe-commits, llvm-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D64900 — quantum / ViewSVN
366474. [OPENMP]Provide correct data sharing attributes for loop control
        variables.
        
        Loop control variables are private in loop-based constructs and we shall
        take this into account when generate the code for inner constructs.
        Currently, those variables are reported as shared in many cases. Moved
        the analysis of the data-sharing attributes of the loop control variable
        to an early semantic stage to correctly handle their attributes. — abataev / ViewSVN
366473. [LibTooling] Relax Transformer to allow rewriting macro expansions
        
        Summary:
        Currently, Transformer rejects any changes to source locations inside macro
        expansions. This change relaxes that constraint to allow rewrites when the
        entirety of the expansion is replaced, since that can be mapped to replacing the
        entirety of the expansion range in the file source.  This change makes
        Transformer consistent with the handling of edit ranges in `clang::edit::Commit`
        (which is used, for example, for applying `FixItHint`s from diagnostics).
        
        Reviewers: ilya-biryukov
        
        Subscribers: gribozavr, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64518 — ymandel / ViewSVN
366472. Revert "Fix asan infinite loop on undefined symbol"
        
        This reverts commit 63719119c78ca965b5d80e5c20fcfe81ba28f896.
        
        The tests in this commit were failing on a Linux sanitizer bot
        and our internal CI.
        
        http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/22401/steps/test%20standalone%20compiler-rt%20with%20symbolizer/logs/stdio — ormris / ViewSVN
366470. [LAA] Re-check bit-width of pointers after stripping.
        
        Summary:
        - As the pointer stripping now tracks through `addrspacecast`, prepare
          to handle the bit-width difference from the result pointer.
        
        Reviewers: jdoerfert
        
        Subscribers: jvesely, nhaehnle, hiraditya, arphaman, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64928 — hliao / ViewSVN
366469. [LibTooling] Add function to translate and validate source range for editing
        
        Summary:
        Adds the function `getRangeForEdit` to validate that a given source range is
        editable and, if needed, translate it into a range in the source file (for
        example, if it's sourced in macro expansions).
        
        Reviewers: ilya-biryukov
        
        Subscribers: cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64924 — ymandel / ViewSVN
366468. [clangd] Remove dead code from BackgroundIndex — kadircet / ViewSVN
366467. [clangd] BackgroundIndex stores shards to the closest project
        
        Summary:
        Changes persistance logic to store shards at the directory of closest
        CDB. Previously we were storing all shards to directory of the CDB that
        triggered indexing, it had its downsides.
        
        For example, if you had two TUs coming from a different CDB but depending on the
        same header foo.h, we will store the foo.h only for the first CDB, and it would
        be missing for the second and we would never persist it since it was actually
        present in the memory and persisted before.
        
        This patch still stores only a single copy of a shard, but makes the directory a
        function of the file name. So that the shard place will be unique even with
        multiple CDBs accessing the file. This directory is determined as the first
        directory containing a CDB in the file's parent directories, if no such
        directory exists we make use of the home directory.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64745 — kadircet / ViewSVN
366464. [NFC][llvm-readobj] Refactor dynamic string table indexing into a function.
        
        Restore printDynamicString removed in rL363868. It provides better
        error handling whenever indexing dynamic string table is needed.
        
        Reviewers: jhenderson, MaskRay, grimar
        
        Reviewed by: jhenderson, MaskRay, grimar
        
        Differential Revision: https://reviews.llvm.org/D64674 — yuanfang / ViewSVN
366462. MC: AArch64: Add support for prel_g* relocation specifiers.
        
        Differential Revision: https://reviews.llvm.org/D64683 — pcc / ViewSVN
366461. AArch64: Unify relocation restrictions between MOVK/MOVN/MOVZ.
        
        There doesn't seem to be a practical reason for these instructions to have
        different restrictions on the types of relocations that they may be used
        with, notwithstanding the language in the ELF AArch64 spec that implies that
        specific relocations are meant to be used with specific instructions.
        
        For example, we currently forbid the first instruction in the following
        sequence, despite it currently being used by clang to generate a global
        reference under -mcmodel=large:
        
        movz x0, #:abs_g0_nc:foo
        movk x0, #:abs_g1_nc:foo
        movk x0, #:abs_g2_nc:foo
        movk x0, #:abs_g3:foo
        
        Therefore, allow MOVK/MOVN/MOVZ to accept the union of the set of relocations
        that they currently accept individually.
        
        Differential Revision: https://reviews.llvm.org/D64466 — pcc / ViewSVN
366458. [clangd] Refactor background-index shard loading
        
        Reviewers: sammccall
        
        Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64712 — kadircet / ViewSVN
366457. [ASTUnit] Attempt to unbreak Windows buildbots after r366448 — ibiryukov / ViewSVN
366456. Minor styling fix. NFC. — hliao / ViewSVN
366455. [clangd] Get rid of dots and dotsdots within GlobalCompilationDatabase
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64860 — kadircet / ViewSVN
366454. Revert "[RISCV] Hard float ABI support" r366450
        
        The commit was missing a few hunks. Will fix and recommit. — asb / ViewSVN
366453. Revert r366449: [CrossTU] Add a function to retrieve original source location.
        
        Reason: the commit breaks layering by adding a dependency on ASTUnit
        (which is inside clangFrontend) from the ASTImporter (which is inside
        clangAST). — ibiryukov / ViewSVN
366452. [Clangd] NFC: Fixed tweaks CMakeLists order to alphabetical — sureyeaah / ViewSVN
366451. [Clangd] Changed ExtractVariable to only work on non empty selections
        
        Summary:
        - For now, we don't trigger in any case if it's an empty selection
        - Fixed unittests
        
        Reviewers: kadircet, sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64912 — sureyeaah / ViewSVN
366450. [RISCV] Hard float ABI support
        
        The RISC-V hard float calling convention requires the frontend to:
        
        * Detect cases where, once "flattened", a struct can be passed using
        int+fp or fp+fp registers under the hard float ABI and coerce to the
        appropriate type(s) * Track usage of GPRs and FPRs in order to gate the
        above, and to
        determine when signext/zeroext attributes must be added to integer
        scalars
        
        This patch attempts to do this in compliance with the documented ABI,
        and uses ABIArgInfo::CoerceAndExpand in order to do this. @rjmccall, as
        author of that code I've tagged you as reviewer for initial feedback on
        my usage.
        
        Note that a previous version of the ABI indicated that when passing an
        int+fp struct using a GPR+FPR, the int would need to be sign or
        zero-extended appropriately. GCC never did this and the ABI was changed,
        which makes life easier as ABIArgInfo::CoerceAndExpand can't currently
        handle sign/zero-extension attributes.
        
        Differential Revision: https://reviews.llvm.org/D60456 — asb / ViewSVN
366449. [CrossTU] Add a function to retrieve original source location.
        
        Summary:
        A new function will be added to get the original SourceLocation
        for a SourceLocation that was imported as result of getCrossTUDefinition.
        The returned SourceLocation is in the context of the (original)
        SourceManager for the original source file. Additionally the
        ASTUnit object for that source file is returned. This is needed
        to get a SourceManager to operate on with the returned source location.
        
        The new function works if multiple different source files are loaded
        with the same CrossTU context.
        
        This patch can be treated as part of a bigger change that is needed to
        improve macro expansion handliong at plist generation.
        
        Reviewers: martong, shafik, a_sidorin, xazax.hun
        
        Reviewed By: martong
        
        Subscribers: rnkovacs, dkrupp, Szelethus, gamesh411, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64554 — balazske / ViewSVN
366448. [ASTUnit] Fix a regression in cached completions
        
        Summary:
        After r345152 cached completions started adding namespaces after
        nested name specifiers, e.g. in `some_name::^`
        
        The CCC_Symbol indicates the completed item cannot be a namespace (it is
        described as being "a type, a function or a variable" in the comments).
        
        Therefore, 'nested specifier' completions should only be added from cache
        when the context is CCC_SymbolOrNewName (which roughly seems to indicate
        that a nested name specifier is allowed).
        
        Fixes https://bugs.llvm.org/show_bug.cgi?id=42646
        
        Reviewers: kadircet, sammccall
        
        Reviewed By: kadircet, sammccall
        
        Subscribers: arphaman, nik, sammccall, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64918 — ibiryukov / ViewSVN
366447. [CMake] Don't set Python_ADDITIONAL_VERSIONS
        
        Until recently, Python_ADDITIONAL_VERSIONS was used to limit LLVM's
        Python support to 2.7. Now that both LLVM and LLDB both support Python
        3, there's no longer a need to put an arbitrary limit on this.
        
        However, instead of removing the variable, r365692 expanded the list,
        which has the (presumably unintentional) side-effect of expression
        preference for Python 3.
        
        Instead, as Michal proposed in the original code review, we should just
        not set the list at all, and let CMake pick whatever Python interpreter
        you have in your path.
        
        This patch removes the Python_ADDITIONAL_VERSIONS variable in llvm,
        clang and lld. I've also updated the docs with the default behavior and
        how to force a different Python version to be used.
        
        Differential revision: https://reviews.llvm.org/D64894 — Jonas Devlieghere / ViewSVN
366446. [clangd] Suppress unwritten scopes when expanding auto.
        
        Summary: otherwise the replacement will break the code.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64627 — hokein / ViewSVN
366444. Revert "[DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame."
        
        This reverts commit 17e3cbf5fe656483d9016d0ba9e1d0cd8629379e. — hsiangkai / ViewSVN
366443. [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670 — sammccall / ViewSVN
366442. [DebugInfo] Generate fixups as emitting DWARF .debug_frame/.eh_frame.
        
        It is necessary to generate fixups in .debug_frame or .eh_frame as
        relaxation is enabled due to the address delta may be changed after
        relaxation.
        
        There is an opcode with 6-bits data in debug frame encoding. So, we
        also need 6-bits fixup types.
        
        Differential Revision: https://reviews.llvm.org/D58335 — hsiangkai / ViewSVN
366441. [X86] EltsFromConsecutiveLoads - support common source loads
        
        This patch enables us to find the source loads for each element, splitting them into a Load and ByteOffset, and attempts to recognise consecutive loads that are in fact from the same source load.
        
        A helper function, findEltLoadSrc, recurses to find a LoadSDNode and determines the element's byte offset within it. When attempting to match consecutive loads, byte offsetted loads then attempt to matched against a previous load that has already been confirmed to be a consecutive match.
        
        Next step towards PR16739 - after this we just need to account for shuffling/repeated elements to create a vector load + shuffle.
        
        Differential Revision: https://reviews.llvm.org/D64551 — rksimon / ViewSVN
366439. [analyzer] Add CTU user docs
        
        Reviewers: dkrupp, a_sidorin, Szelethus, NoQ
        
        Subscribers: whisperity, xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalho, donat.nagy, gamesh411, Charusso, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64801 — martong / ViewSVN
366437. [OPENMP][NVPTX]Mark barrier functions calls as convergent.
        
        Added convergent attribute to the barrier functions calls for correct
        optimizations. — abataev / ViewSVN
366436. Restrict asan + dlopen testcase to x86 — serge_sans_paille / ViewSVN
366435. [DAGCombine] Pull getSubVectorSrc helper out of narrowInsertExtractVectorBinOp. NFCI.
        
        NFC step towards reusing this in other EXTRACT_SUBVECTOR combines. — rksimon / ViewSVN
366434. [FileCheck] Fix numeric variable redefinition
        
        Summary:
        Commit r365249 changed usage of FileCheckNumericVariable to have one
        instance of that class per variable as opposed to one instance per
        definition of a given variable as was done before. However, it retained
        the safety check in setValue that it should only be called with the
        variable unset, even after r365625.
        
        However this causes assert failure when a non-pseudo variable is being
        redefined. And while redefinition of @LINE at each CHECK line work in
        the general case, it caused problem when a substitution failed (fixed in
        r365624) and still causes problem when a CHECK line does not match since
        @LINE's value is cleared after substitutions in match() happened but
        printSubstitutions also attempts a substitution.
        
        This commit solves the root of the problem by changing setValue to set a
        new value regardless of whether a value was set or not, thus fixing all
        the aforementioned issues.
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64882 — thopre / ViewSVN
366432. Relax regexp to detect failed interception by asan
        
        This should fix failed detection on aarch64/ppc64/thumbv8... — serge_sans_paille / ViewSVN
366431. [x86] try harder to form LEA from ADD to avoid flag conflicts (PR40483)
        
        LEA doesn't affect flags, so use it more liberally to replace an ADD when
        we know that the ADD operands affect flags.
        
        In the motivating example from PR40483:
        https://bugs.llvm.org/show_bug.cgi?id=40483
        ...this lets us avoid duplicating a math op just to avoid flag conflict.
        
        As mentioned in the TODO comments, this heuristic can be extended to
        fire more often if that leads to more improvements.
        
        Differential Revision: https://reviews.llvm.org/D64707 — spatel / ViewSVN
366430. [llvm-readelf] - Remove the precompiled binary from gnu-hash-symbols.test
        
        I am working on https://bugs.llvm.org/show_bug.cgi?id=42622
        and this patch reworks the gnu-hash-symbols.test so that it
        will be easier to expand it with x86_64 case.
        
        Differential revision: https://reviews.llvm.org/D64750 — grimar / ViewSVN
366429. Revert r366422: [OpenCL] Improve destructor support in C++ for OpenCL
        
        Reason: this commit causes crashes in the clang compiler when building
        LLVM Support with libc++, see https://bugs.llvm.org/show_bug.cgi?id=42665
        for details. — ibiryukov / ViewSVN
366427. Bump the trunk version to 10.0.0svn
        
        and clear the release notes. — hans / ViewSVN
366423. [ARM][DAGCOMBINE][FIX] PerformVMOVRRDCombine
        
        Summary:
        PerformVMOVRRDCombine ommits adding a offset
        of 4 to the PointerInfo, when converting a
        f64 = load[M]
        to
        {i32, i32} = {load[M], load[M + 4]}
        
        Which would allow the machine scheduller
        to break dependencies with the second load.
        
        - pr42638
        
        Reviewers: eli.friedman, dmgreen, ostannard
        
        Reviewed By: ostannard
        
        Subscribers: ostannard, javed.absar, kristof.beyls, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64870 — dnsampaio / ViewSVN
366422. [OpenCL] Improve destructor support in C++ for OpenCL
        
        Summary:
        This patch does mainly three things:
        1. It fixes a false positive error detection in Sema that is similar to
            D62156. The error happens when explicitly calling an overloaded
            destructor for different address spaces.
        2. It selects the correct destructor when multiple overloads for
            address spaces are available.
        3. It inserts the expected address space cast when invoking a
            destructor, if needed, and therefore fixes a crash due to the unmet
            assertion in llvm::CastInst::Create.
        
        The following is a reproducer of the three issues:
        
            struct MyType {
              ~MyType() {}
              ~MyType() __constant {}
            };
        
            __constant MyType myGlobal{};
        
            kernel void foo() {
              myGlobal.~MyType(); // 1 and 2.
              // 1. error: cannot initialize object parameter of type
              //    '__generic MyType' with an expression of type '__constant MyType'
              // 2. error: no matching member function for call to '~MyType'
            }
        
            kernel void bar() {
              // 3. The implicit call to the destructor crashes due to:
              //    Assertion `castIsValid(op, S, Ty) && "Invalid cast!"' failed.
              //    in llvm::CastInst::Create.
              MyType myLocal;
            }
        
        The added test depends on D62413 and covers a few more things than the
        above reproducer.
        
        Subscribers: yaxunl, Anastasia, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64569 — mantognini / ViewSVN
366421. [OpenCL] Update comments/diagnostics to refer to C++ for OpenCL
        
        Clang doesn't implement OpenCL C++, change the comments to
        reflect that.
        
        Differential Revision: https://reviews.llvm.org/D64867 — stulova / ViewSVN
366420. [clangd] Added highlightings for template parameters and specializations.
        
        Summary: Template parameters and specializations were not being highlighted before. This adds highlightings to those types of tokens by adding two Visit* methods.
        
        Reviewers: hokein, sammccall, ilya-biryukov
        
        Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64855 — jvikstrom / ViewSVN
366419. [SCEV] add no wrap flag for SCEVAddExpr.
        Differential Revision: https://reviews.llvm.org/D64868 — shchenz / ViewSVN
366417. [OpenCL][PR42033] Fix addr space deduction with template parameters
        
        If dependent types appear in pointers or references we allow addr
        space deduction because the addr space in template argument will
        belong to the pointee and not the pointer or reference itself.
        
        We also don't diagnose addr space on a function return type after
        template instantiation. If any addr space for the return type was
        provided on a template parameter this will be diagnosed during the
        parsing of template definition.
        
        Differential Revision: https://reviews.llvm.org/D62584 — stulova / ViewSVN
366413. Fix asan infinite loop on undefined symbol
        
        Fix llvm#39641
        
        Differential Revision: https://reviews.llvm.org/D63877 — serge_sans_paille / ViewSVN
366412. [RISCV] Reset NoPHIS MachineFunctionProperty in emitSelectPseudo
        
        We insered PHIS were there were none before, so the property must be
        reset. This error was found on an EXPENSIVE_CHECKS build. — asb / ViewSVN
366411. [LoopInfo] Use early return in branch weight update functions. NFC. — skatkov / ViewSVN
366410. [RISCV][DebugInfo] Fix dwarf-riscv-relocs.ll test on Windows
        
        Windows sees DW_AT_decl_file (".\dwarf-riscv-relocs.c") while Linux sees
        DW_AT_decl_file ("./dwarf-riscv-relocs.c").
        
        This fixes a failure introduced in rL366402. — asb / ViewSVN
366409. [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528
        
        Summary:
        The problem is the default LoadExternal with no completer, which happens when
        loading global results.
        
        Reviewers: ilya-biryukov, nik
        
        Subscribers: arphaman, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64864 — sammccall / ViewSVN
366408. clang-tidy release notes: Split and order changes by type
        
        Patch by Eugene Zelenko! — hans / ViewSVN
366407. [NFC][PowerPC] Add the test to test the pass block-placement — zhangkang / ViewSVN
366406. [PowerPC][Clang] Remove use of malloc in mm_malloc
        
        Remove dependency of malloc in implementation of mm_malloc function in PowerPC
        intrinsics and alignment assumption on glibc.
        
        Reviewed By: Hal Finkel
        
        Differential Revision: https://reviews.llvm.org/D64850 — chaofan / ViewSVN
366405. [X86] Disable combineConcatVectors for vXi1 vectors.
        
        I'm not convinced the code this calls is properly vetted for
        vXi1 vectors. Experimental vector widening legalization testing
        for D55251 is now hitting an assertion failure inside
        EltsFromConsecutiveLoads. This is occurring from a v2i1 load
        having a store size different than its VT size. Hopefully
        this commit will keep such issues from happening. — ctopper / ViewSVN
366403. Fix typo in programmer's manual cantFile -> cantFail — lanza / ViewSVN
366402. [DWARF][RISCV] Add support for RISC-V relocations needed for debug info
        
        When code relaxation is enabled many RISC-V fixups are not resolved but
        instead relocations are emitted. This happens even for DWARF debug
        sections. Therefore, to properly support the parsing of DWARF debug info
        we need to be able to resolve RISC-V relocations. This patch adds:
        
        * Support for RISC-V relocations in RelocationResolver
        * DWARF support for two relocations per object file offset
        * DWARF changes to support relocations in more DIE fields
        
        The two relocations per offset change is needed because some RISC-V
        relocations (used for label differences) come in pairs.
        
        Relocations can also be emitted for DWARF fields where relocations were
        not yet evaluated. Adding relocation support for some of these fields is
        essencial. On the other hand, LLVM currently emits RISC-V relocations
        for fixups that could be safely evaluated, since they can never be
        affected by code relaxations. This patch also adds relocation support
        for the fields affected by those extraneous relocations (the DWARF unit
        entry Length, and the DWARF debug line entry TotalLength and
        PrologueLength), for testing purposes.
        
        Differential Revision: https://reviews.llvm.org/D62062
        Patch by Luís Marques. — asb / ViewSVN
366400. [clangd] Fix Fix -Wunused-lambda-capture after r366339 — maskray / ViewSVN
366399. [RISCV] Re-land r366331 d RISCV to LLVM_ALL_TARGETS
        
        *San flagged issues should be now be addressed. — asb / ViewSVN
366398. [RISCV] Avoid signed integer overflow UB in RISCVMatInt::generateInstSeq
        
        Found by UBSan. — asb / ViewSVN
366397. [RISCV] Don't acccess an invalidated iterator in RISCVInstrInfo::removeBranch
        
        Issue found by ASan. — asb / ViewSVN

#18453 (Jul 13, 2019 11:11:13 AM)

366009. [Attributor][Fix] Never override given argument numbers — jdoerfert / ViewSVN

#18452 (Jul 13, 2019 10:10:13 AM)

366008. [ARM] Add sign and zero extend patterns for MVE
        
        The vmovlb instructions can be uses to sign or zero extend vector registers
        between types. This adds some patterns for them and relevant testing. The
        VBICIMM generation is also put behind a hasNEON check (as is already done for
        VORRIMM).
        
        Code originally by David Sherwood.
        
        Differential Revision: https://reviews.llvm.org/D64069 — dmgreen / ViewSVN
366007. Template-related improvements to Visual Studio visualizers — mps / ViewSVN
366006. [ARM] MVE VNEG instruction patterns
        
        This selects integer VNEG instructions, which can be especially useful with shifts.
        
        Differential Revision: https://reviews.llvm.org/D64204 — dmgreen / ViewSVN
366005. [ARM] MVE integer abs
        
        Similar to floating point abs, we also have instructions for integers.
        
        Differential Revision: https://reviews.llvm.org/D64027 — dmgreen / ViewSVN
366004. [ARM] MVE integer min and max
        
        This simply makes the MVE integer min and max instructions legal and adds the
        relevant patterns for them.
        
        Differential Revision: https://reviews.llvm.org/D64026 — dmgreen / ViewSVN
366003. [ARM] MVE VRINT support
        
        This adds support for the floor/ceil/trunc/... series of instructions,
        converting to various forms of VRINT. They use the same suffixes as their
        floating point counterparts. There is not VTINTR, so nearbyint is expanded.
        
        Also added a copysign test, to show it is expanded.
        
        Differential Revision: https://reviews.llvm.org/D63985 — dmgreen / ViewSVN
366002. [ARM] MVE minnm and maxnm instructions
        
        This adds the patterns for minnm and maxnm from the fminnum and fmaxnum nodes,
        similar to scalar types.
        
        Original patch by Simon Tatham
        
        Differential Revision: https://reviews.llvm.org/D63870 — dmgreen / ViewSVN
366001. FileCheck [7/12]: Arbitrary long numeric expressions
        
        Summary:
        This patch is part of a patch series to add support for FileCheck
        numeric expressions. This specific patch extend numeric expression to
        support an arbitrary number of operands, either variable or literals.
        
        Copyright:
            - Linaro (changes up to diff 183612 of revision D55940)
            - GraphCore (changes in later versions of revision D55940 and
                         in new revision created off D55940)
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D60387 — thopre / ViewSVN
366000. Revert "[InstCombine] add tests for umin/umax via usub.sat; NFC"
        
        This reverts commit rL365999 / 0f6148df23edcd3081f5e761de19edd4f823f16d.
        The tests already exist in this file, and the hoped-for transform
        (mentioned in D62871) is invalid because of undef as discussed in
        D63060. — spatel / ViewSVN

#18451 (Jul 13, 2019 8:11:50 AM)

366001. FileCheck [7/12]: Arbitrary long numeric expressions
        
        Summary:
        This patch is part of a patch series to add support for FileCheck
        numeric expressions. This specific patch extend numeric expression to
        support an arbitrary number of operands, either variable or literals.
        
        Copyright:
            - Linaro (changes up to diff 183612 of revision D55940)
            - GraphCore (changes in later versions of revision D55940 and
                         in new revision created off D55940)
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D60387 — thopre / ViewSVN
366000. Revert "[InstCombine] add tests for umin/umax via usub.sat; NFC"
        
        This reverts commit rL365999 / 0f6148df23edcd3081f5e761de19edd4f823f16d.
        The tests already exist in this file, and the hoped-for transform
        (mentioned in D62871) is invalid because of undef as discussed in
        D63060. — spatel / ViewSVN

#18450 (Jul 13, 2019 7:15:38 AM)

366001. FileCheck [7/12]: Arbitrary long numeric expressions
        
        Summary:
        This patch is part of a patch series to add support for FileCheck
        numeric expressions. This specific patch extend numeric expression to
        support an arbitrary number of operands, either variable or literals.
        
        Copyright:
            - Linaro (changes up to diff 183612 of revision D55940)
            - GraphCore (changes in later versions of revision D55940 and
                         in new revision created off D55940)
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D60387 — thopre / ViewSVN
366000. Revert "[InstCombine] add tests for umin/umax via usub.sat; NFC"
        
        This reverts commit rL365999 / 0f6148df23edcd3081f5e761de19edd4f823f16d.
        The tests already exist in this file, and the hoped-for transform
        (mentioned in D62871) is invalid because of undef as discussed in
        D63060. — spatel / ViewSVN
365999. [InstCombine] add tests for umin/umax via usub.sat; NFC — spatel / ViewSVN
365998. [x86] simplify cmov with same true/false operands — spatel / ViewSVN

#18449 (Jul 13, 2019 3:49:59 AM)

365997. [Object] isNotObjectErrorInvalidFileType: simplify — maskray / ViewSVN
365996. [Object] isNotObjectErrorInvalidFileType: fix use-after-move — maskray / ViewSVN
365995. Fix -Wdocumentation warning. NFCI. — rksimon / ViewSVN
365994. [CMake][Fuchsia] Define asan+noexcept multilib
        
        Using noexcept multilib with -fno-exceptions can lead to significant
        space savings when statically linking libc++abi because we don't need
        all the unwinding and demangling code.
        
        When compiling with ASan, we already get a lot of overhead from the
        instrumentation itself, when statically linking libc++abi, that overhead
        is even larger.
        
        Having the noexcept variant for ASan can help significantly, we've seen
        more than 50% size reduction in our system image, which offsets the cost
        of having to build another multilib.
        
        Differential Revision: https://reviews.llvm.org/D64140 — phosek / ViewSVN
365993. Simplify with llvm::is_contained. NFC — maskray / ViewSVN
365992. This reverts commit 632a36bfcfc8273c1861f04ff6758d863c47c784.
        
        Some targets such as Python 2.7.16 still use VERSION in
        their builds. Without VERSION defined, the source code
        has syntax errors.
        
        Reverting as it will probably break many other things.
        
        Noticed by Sterling Augustine — sylvestre / ViewSVN
365989. Initialize the non-trivial C union bits I added to RecordDeclBitfields
        in r365985
        
        These bits weren't being initialized in the RecordDecl's constructor,
        which probably caused test/Modules/stress1.cpp to fail on a couple of
        bots. — ahatanak / ViewSVN
365987. [clangd] Mark type hierarchy as a supported feature in the docs
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64614 — nridge / ViewSVN
365986. [clangd] Implement typeHierarchy/resolve for subtypes
        
        Summary:
        This allows the client to resolve subtypes one level at a time.
        
        For supertypes, this is not necessary, because we eagerly compute
        supertypes and return all levels.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64308 — nridge / ViewSVN
365985. [Sema] Diagnose default-initialization, destruction, and copying of
        non-trivial C union types
        
        This patch diagnoses uses of non-trivial C unions and structs/unions
        containing non-trivial C unions in the following contexts, which require
        default-initialization, destruction, or copying of the union objects,
        instead of disallowing fields of non-trivial types in C unions, which is
        what we currently do:
        
        - function parameters.
        - function returns.
        - assignments.
        - compound literals.
        - block captures except capturing of `__block` variables by non-escaping
          blocks.
        - local and global variable definitions.
        - lvalue-to-rvalue conversions of volatile types.
        
        See the discussion in https://reviews.llvm.org/D62988 for more background.
        
        rdar://problem/50679094
        
        Differential Revision: https://reviews.llvm.org/D63753 — ahatanak / ViewSVN

#18444 (Jul 12, 2019 6:54:24 PM)

365984. [Attributor][NFC] Run clang-format on the attributor files (.h/.cpp)
        
        The Attributor files are kept formatted with clang-format, we should try
        to keep this state. — jdoerfert / ViewSVN
365983. [Attributor] Only return attributes with a valid state
        
        Attributor::getAAFor will now only return AbstractAttributes with a
        valid AbstractState. This simplifies call sites as they only need to
        check if the returned pointer is non-null. It also reduces the potential
        for accidental misuse. — jdoerfert / ViewSVN
365982. [TSan] Tiny cleanup of UnmangleLongJmpSp for Linux/x86_64
        
        NFC. — yln / ViewSVN
365981. clang/test/Driver/fsanitize.c: Fix -fsanitize=vptr using default target
        
        The default implementation of getSupportedSanitizers isn't able to turn
        on the vptr sanitizer, and thus, any platform that runs this test will
        fail with the error:
        
            clang: error: unsupported option '-fsanitize=vptr' for target '<target>'
        
        Patch by James Nagurne! — maskray / ViewSVN
365980. Extend function attributes bitset size from 64 to 96.
        
        Summary: We are going to add a function attribute number 64.
        
        Reviewers: pcc, jdoerfert, lebedev.ri
        
        Subscribers: hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64663 — eugenis / ViewSVN
365977. [Attributor][FIX] Lookup of (call site) argument attributes — jdoerfert / ViewSVN
365976. [DirectoryWatcher][test][NFC] Add information to test failure reports — Jan Korous / ViewSVN
365975. Re-land [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.
        
        Use //net/dir like other test cases for windows compatibility — sammccall / ViewSVN
365974. PDB HashTable: Move TraitsT from class parameter to the methods that need it
        
        The traits object is only used by a few methods. Deserializing a hash
        table and walking it is possible without the traits object, so it
        shouldn't be required to build a dummy object for that use case.
        
        The TraitsT object used to be a function template parameter before
        r327647, this restores it to that state.
        
        This makes it clear that the traits object isn't needed at all in 1 of
        the current 3 uses of HashTable (and I am going to add another use that
        doesn't need it), and that the default PdbHashTraits isn't used outside
        of tests.
        
        While here, also re-enable 3 checks in the test that were commented out
        (which requires making HashTableInternals templated and giving FooBar
        an operator==).
        
        No intended behavior change.
        
        Differential Revision: https://reviews.llvm.org/D64640 — nico / ViewSVN
365973. Fix non-conformance it `std::tuple`.
        
        Previously we implemented all one trillion tuple-like constructors using
        a single generic overload. This worked fairly well, except that it
        differed in behavior from the standard version because it didn't
        consider both T&& and T const&. This was observable for certain
        types.
        
        This patch addresses that issue by splitting the generic constructor
        in two. We now provide both T&& and T const& versions of the
        tuple-like constructors (sort of). — ericwf / ViewSVN

#18443 (Jul 12, 2019 5:57:02 PM)

365972. [AMDGPU] use v32f32 for 3 mfma intrinsics
        
        These should really use v32f32, but were defined as v32i32
        due to the lack of the v32f32 type.
        
        Differential Revision: https://reviews.llvm.org/D64667 — rampitec / ViewSVN
365971. isBytewiseValue checks ConstantVector element by element
        
        Summary: Vector of the same value with few undefs will sill be considered "Bytewise"
        
        Reviewers: eugenis, pcc, jfb
        
        Reviewed By: jfb
        
        Subscribers: dexonsmith, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64031 — Vitaly Buka / ViewSVN
365970. [MemorySSA] Use SetVector to avoid nondeterminism.
        
        Summary:
        Use a SetVector for DeadBlockSet.
        Resolves PR42574.
        
        Reviewers: george.burgess.iv, uabelho, dblaikie
        
        Subscribers: jlebar, Prazek, mgrang, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64601 — asbirlea / ViewSVN
365969. NFC: utils/perf-training: Python 3 compatibility for lit.cfg
        
        The output of subprocess.check_output is now bytes. We need to decode it. — arphaman / ViewSVN
365968. [DirectoryWatcher][NFC] Silence warnings in release build — Jan Korous / ViewSVN
365967. [clang-doc] Fix failing tests on Windows
        
        Tests on Windows were failing due to path separator differences.
        '/' was being used as separator in the expected output, paths in expected
        output are now changed to their native form before comparing them to the
        actual output.
        
        Committed on behalf of Diego Astiazarán (diegoaat97@gmail.com).
        
        Differential Revision: https://reviews.llvm.org/D64669 — juliehockett / ViewSVN
365966. [DirectoryWatcher][linux] Fix use of uninitialized value — Jan Korous / ViewSVN
365965. [WebAssembly] refactored utilities to not depend on MachineInstr
        
        Summary:
        Most of these functions can work for MachineInstr and MCInst
        equally now.
        
        Reviewers: dschuff
        
        Subscribers: MatzeB, sbc100, jgravelle-google, aheejin, sunfish, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64643 — aardappel / ViewSVN
365964. [macCatalyst] Use macCatalyst pretty name in .build_version darwin
        assembly command
        
        'macCatalyst' is more readable than 'maccatalyst'. I renamed the objdump output,
        but the assembly should match it as well. — arphaman / ViewSVN
365962. Remove __VERSION__
        
        Summary:
        It has been introduced in 2011 for gcc compat:
        https://github.com/llvm-mirror/clang/commit/ad1a4c6e89594e704775ddb6b036ac982fd68cad
        it is probably time to remove it
        
        
        Reviewers: rnk, dexonsmith
        
        Reviewed By: rnk
        
        Subscribers: dschuff, aheejin, fedor.sergeev, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64062 — sylvestre / ViewSVN

#18442 (Jul 12, 2019 3:59:54 PM)

365961. [test][AArch64] Relax the opcode tests for FP min/max instructions. — dyung / ViewSVN
365960. Add option to disable variant narrowing conversion changes.
        
        The paper P0608R3 - "A sane variant converting constructor" disallows
        narrowing conversions in variant. It was meant to address this
        surprising problem:
        
          std::variant<std::string, bool> v = "abc";
          assert(v.index() == 1); // constructs a bool.
        
        However, it also disables every potentially narrowing conversion. For
        example:
        
          variant<unsigned> v = 0; // ill-formed
          variant<string, double> v2 = 42; // ill-formed (int -> double narrows)
        
        These latter changes break code. A lot of code. Within Google it broke
        on the order of a hundred thousand target with thousands of root causes
        responsible for the breakages.
        
        Of the breakages related to the narrowing restrictions, none of them
        exposed outstanding bugs. However, the breakages caused by boolean
        conversions (~13 root causes), all but one of them were bugs.
        
        For this reasons, I am adding a flag to disable the narrowing conversion
        changes but not the boolean conversions one.
        
        One purpose of this flag is to allow users to opt-out of breaking changes
        in variant until the offending code can be cleaned up. For non-trivial
        variant usages the amount of cleanup may be significant.
        
        This flag is also required to support automated tooling, such as
        clang-tidy, that can automatically fix code broken by this change.
        In order for clang-tidy to know the correct alternative to construct,
        it must know what alternative was being constructed previously, which
        means running it over the old version of std::variant.
        
        Because this change breaks so much code, I will be implementing the
        aforementioned clang-tidy check in the very near future.
        
        Additionally I'm plan present this new information to the committee so they can
        re-consider if this is a breaking change we want to make.
        
        I think libc++ should very seriously consider pulling this change
        before the 9.0 release branch is cut. But that's a separate discussion
        that I will start on the lists.
        
        For now this is the minimal first step. — ericwf / ViewSVN
365959. [InstCombine] Disable fold from D64285 for non-integer types — xbolva00 / ViewSVN
365958. Factor out resolveFrameOffsetReference (NFC).
        
        Split AArch64FrameLowering::resolveFrameIndexReference in two parts
        * Finding frame offset for the index.
        * Finding base register and offset to that register.
        
        The second part will be used to implement a virtual frame pointer in
        armv8.5 MTE stack instrumentation lowering.
        
        Reviewers: pcc, vitalybuka, hctim, ostannard
        
        Subscribers: javed.absar, kristof.beyls, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64171 — eugenis / ViewSVN
365957. [builtins] Fix assembly in arm sync-ops.h
        
        This assembly is part of a macro that was reformatted in D60351.
        The missing space between push and { results in:
        
            Error: bad instruction `push{r4, r5,r6,lr}' — nikic / ViewSVN
365956. Revert driver: Don't warn about assembler flags being unused when not assembling
        
        This reverts r365703 (git commit 101c1afdfd1c88f05da94c6fd317b489bb704f40)
        and r365714.
        
        This broke some autoconf-style assembler flags checks in the Linux
        build:
        https://github.com/ClangBuiltLinux/linux/issues/598 — rnk / ViewSVN
365955. [clangd] Fix off-by-one in CodeComplete and assertion in Dex — sammccall / ViewSVN
365954. Reland [clang] DirectoryWatcher
        
        This reverts commit f561227d133224d2d6a5a016abe4be051fa75501.
        
        - DirectoryWatcher
        - Fix the build for platforms that don't have DW implementated.
        - Fix the threading dependencies (thanks to compnerd). — Jan Korous / ViewSVN

#18441 (Jul 12, 2019 2:58:12 PM)

365953. AMDGPU: Drop remnants of byval support for shaders
        
        Before 2018, mesa used to use byval interchangably with inreg, which
        didn't really make sense. Fix tests still using it to avoid breaking
        in a future commit. — arsenm / ViewSVN
365952. Fix missing use of defined() in include guard
        
        Subscribers: arsenm, jvesely, nhaehnle, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64657 — daltenty / ViewSVN
365949. [SystemZ] Fix addcarry of addcarry of const carry (PR42606)
        
        This fixes https://bugs.llvm.org/show_bug.cgi?id=42606 by extending
        D64213. Instead of only checking if the carry comes from a matching
        operation, we now check the full chain of carries. Otherwise we might
        custom lower the outermost addcarry, but then generically legalize
        an inner addcarry.
        
        Differential Revision: https://reviews.llvm.org/D64658 — nikic / ViewSVN
365948. Revert "Reland [clang] DirectoryWatcher"
        
        This reverts commit fdcb7f47e783933e0af8a5fae91132269a208268. — Jan Korous / ViewSVN
365947. Reland [clang] DirectoryWatcher
        
        This reverts commit abce8c457dd3de6b156756e547cc0eefb7653c79.
        
        + Fix the build for platforms that don't have DW implementated. — Jan Korous / ViewSVN
365946. [X86] Use MachineInstr::findRegisterDefOperand to simplify some code in optimizeCompareInstr. NFCI — ctopper / ViewSVN
365945. [DebugInfo] Add column info for inline sites
        
        The column field is missing for all inline sites, currently it's always
        zero. This changes populates DW_AT_call_column field for inline sites.
        Test case modified to cover this change.
        
        Patch by: Wenlei He
        
        Differential revision: https://reviews.llvm.org/D64033 — Jonas Devlieghere / ViewSVN
365943. The variable "Latch" is only used in an assert, which makes builds that use "-DNDEBUG" fail with unused variable messages.
        
        Summary: Move the logic into the assert itself.
        
        Subscribers: hiraditya, sanjoy, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64654 — saugustine / ViewSVN
365942. [SystemZ] Fix build bot failure after r365932
        
        Insert LLVM_FALLTHROUGH to avoid compiler warning. — uweigand / ViewSVN
365941. [x86] add test for bogus cmov (PR40483); NFC — spatel / ViewSVN
365940. [AMDGPU] Extend MIMG opcode to 8 bits
        
        This is NFC, but required for future commit.
        
        Differential Revision: https://reviews.llvm.org/D64649 — rampitec / ViewSVN
365938. Addition to rL365925, removing remaining virtuals — sstefan / ViewSVN
365937. [clang-doc] Add html links to references
        
        <a> tags are added for the parents and members of records and return type and
        params of functions. The link redirects to the reference's info file.
        
        The directory path where each info file will be saved is now generated in the
        serialization phase and stored as an attribute in each Info.
        
        Bitcode writer and reader were modified to handle the new attributes.
        
        Committed on behalf of Diego Astiazarán (diegoaat97@gmail.com).
        
        Differential Revision: https://reviews.llvm.org/D63663 — juliehockett / ViewSVN
365936. Slightly simplify MappedBlockStream::createIndexedStream() calls
        
        All callers had a PDBFile object at hand, so call
        Pdb.createIndexedStream() instead, which pre-populates all the arguments
        (and returns nullptr for kInvalidStreamIndex).
        
        Also change safelyCreateIndexedStream() to only take the string index,
        and update callers. Make the method public and call it in two places
        that manually did the bounds checking before.
        
        No intended behavior change.
        
        Differential Revision: https://reviews.llvm.org/D64633 — nico / ViewSVN
365935. [WebAssembly] Make pthread imply bulk-memory, mutable-globals
        
        Summary:
        This paves the way for using passive segments in pthread builds, which
        will make separate memory files unnecessary. Mutable globals are also
        necessary for the upcoming implementation of TLS.
        
        Reviewers: aheejin, dschuff
        
        Subscribers: sbc100, jgravelle-google, sunfish, jfb, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64586 — tlively / ViewSVN
365934. Add explicit newline at end of `llvm-pdbutil dump`
        
        All dump modes I checked didn't print a trailing newline, so add one. — nico / ViewSVN
365933. [SystemZ] Add support for new cpu architecture - arch13
        
        This patch series adds support for the next-generation arch13
        CPU architecture to the SystemZ backend.
        
        This includes:
        - Basic support for the new processor and its features.
        - Support for low-level builtins mapped to new LLVM intrinsics.
        - New high-level intrinsics in vecintrin.h.
        - Indicate support by defining  __VEC__ == 10303.
        
        Note: No currently available Z system supports the arch13
        architecture.  Once new systems become available, the
        official system name will be added as supported -march name. — uweigand / ViewSVN
365932. [SystemZ] Add support for new cpu architecture - arch13
        
        This patch series adds support for the next-generation arch13
        CPU architecture to the SystemZ backend.
        
        This includes:
        - Basic support for the new processor and its features.
        - Assembler/disassembler support for new instructions.
        - CodeGen for new instructions, including new LLVM intrinsics.
        - Scheduler description for the new processor.
        - Detection of arch13 as host processor.
        
        Note: No currently available Z system supports the arch13
        architecture.  Once new systems become available, the
        official system name will be added as supported -march name. — uweigand / ViewSVN
365931. Remove unused methods in Sancov. — leonardchan / ViewSVN
365929. [X86] Add NEG to isUseDefConvertible.
        
        We can use the C flag from NEG to detect that the input was zero.
        
        Really we could probably use the Z flag too. But C matches what
        we'd do for usubo 0, X.
        
        Haven't found a test case for this due to the usubo formation
        in CGP. But I verified if I comment out the CGP code this
        transformation catches some of the same cases. — ctopper / ViewSVN
365926. [X86][AVX] Add PR34359 shuffle test case. — rksimon / ViewSVN
365925. [Attributor] Removing unnecessary `virtual` keywords.
        
        Some function in the Attributor framework are unnecessarily
        marked virtual. This patch removes virtual keyword
        
        Reviewers: jdoerfert
        
        Subscribers: hiraditya, llvm-commits
        
        Differential Revision: https://reviews.llvm.org/D64637 — sstefan / ViewSVN
365924. [Attributor] Deduce "nofree" function attribute
        
        Summary: Deduce "nofree" function attribute. A more concise description of "nofree" is on D49165.
        
        Reviewers: jdoerfert
        
        Reviewed By: jdoerfert
        
        Subscribers: homerdin, hfinkel, lebedev.ri, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D62687 — uenoku / ViewSVN
365923. [libc++] Add XFAILs for CTAD tests on older compilers — Louis Dionne / ViewSVN
365922. Revert [clang-shlib] Fix clang-shlib for PRIVATE dependencies
        
        This reverts r365825 (git commit 3173c60f96c3ccfc17d403a192ae58e720153c23)
        
        This is breaking BUILD_SHARED_LIBS=ON builds. Reverting while I rethink it. — smeenai / ViewSVN
365921. CodeGet: Init 32bit pointers with 0xFFFFFFFF
        
        Summary:
        Patch makes D63967 effective for 32bit platforms and improves pattern
        initialization there. It cuts size of 32bit binary compiled with
        -ftrivial-auto-var-init=pattern by 2% (3% with -Os).
        
        Binary size change on CTMark, (with -fuse-ld=lld -Wl,--icf=all, similar results with default linker options)
        ```
                           master           patch      diff
        Os pattern   7.915580e+05    7.698424e+05 -0.028387
        O3 pattern   9.953688e+05    9.752952e+05 -0.019325
        ```
        
        Zero vs Pattern on master
        ```
                       zero       pattern      diff
        Os     7.689712e+05  7.915580e+05  0.031380
        O3     9.744796e+05  9.953688e+05  0.021133
        ```
        
        Zero vs Pattern with the patch
        ```
                       zero       pattern      diff
        Os     7.689712e+05  7.698424e+05  0.000789
        O3     9.744796e+05  9.752952e+05  0.000742
        ```
        
        Reviewers: pcc, eugenis, glider, jfb
        
        Reviewed By: jfb
        
        Subscribers: hubert.reinterpretcast, dexonsmith, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64597 — Vitaly Buka / ViewSVN
365920. [IndVars] Use exit count reasoning to discharge obviously untaken exits
        
        Continue in the spirit of D63618, and use exit count reasoning to prove away loop exits which can not be taken since the backedge taken count of the loop as a whole is provably less than the minimal BE count required to take this particular loop exit.
        
        As demonstrated in the newly added tests, this triggers in a number of cases where IndVars was previously unable to discharge obviously redundant exit tests. And some not so obvious ones.
        
        Differential Revision: https://reviews.llvm.org/D63733 — reames / ViewSVN
365919. Dump actual line numbers when dumping the AST to JSON.
        
        The "line" attribute is now the physical line within the source file for the location. A "presumedLine" attribute is printed when the presumed line number does not match the given source line number. We continue to not print repeated line information in subsequent source locations, but we track presumed and actual lines separately. — aaronballman / ViewSVN
365918. Fix some minor coding-style issues in git-llvm. — jyknight / ViewSVN
365917. Allow the 'git-llvm' tool to push to svn from the split repositories
        for 'test-suite', 'lnt', 'zorg', and 'www'.
        
        This is done by looking at the pathname of the git remote named
        'origin', which is not 100% reliable, but should work in most cases. — jyknight / ViewSVN
365916. [FunctionAttrs] Add a test for "nofree" function attribute
        
        This patch adds a test for nofree function attribute. — uenoku / ViewSVN
365915. [Support] Move the static initializer install_out_memory_new_handler to InitLLVM
        
        An application linking against LLVMSupport should not get the gratuitous
        set::std_new_handler call.
        
        Reviewed By: jfb
        
        Differential Revision: https://reviews.llvm.org/D64505 — maskray / ViewSVN
365914. Add missing <atomic> include to appease MSVC builds. — rksimon / ViewSVN
365913. Minor cleanup.
        
        Simplify things a bit by removing unnecessary full type qualification.
        This also happens to avoid a build break with now-unsupported
        Visual Studio 2015.
        
        Differential Review: https://reviews.llvm.org/D64588 — tra / ViewSVN
365912. Test commit — uenoku / ViewSVN
365911. Support for dumping current PrettyStackTrace on SIGINFO (Ctrl-T)
        
        Support SIGINFO (and SIGUSR1 for POSIX purposes) to tell what
        long-running jobs are doing, as inspired by BSD tools (including on
        macOS), by dumping the current PrettyStackTrace.
        
        This adds a new kind of signal handler for non-fatal "info" signals,
        similar to the "interrupt" handler that already exists for SIGINT
        (Ctrl-C). It then uses that handler to update a "generation count"
        managed by the PrettyStackTrace infrastructure, which is then checked
        whenever a PrettyStackTraceEntry is pushed or popped on each
        thread. If the generation has changed---i.e. if the user has pressed
        Ctrl-T---the stack trace is dumped, though unfortunately it can't
        include the deepest entry because that one is currently being
        constructed/destructed.
        
        https://reviews.llvm.org/D63750 — jrose / ViewSVN
365910. [AMDGPU] Fix DPP combiner check for exec modification
        
        Summary:
        r363675 changed the exec modification helper function, now called
        execMayBeModifiedBeforeUse, so that if no UseMI is specified it checks
        all instructions in the basic block, even beyond the last use. That
        meant that the DPP combiner no longer worked in any basic block that
        ended with a control flow instruction, and in particular it didn't work
        on code sequences generated by the atomic optimizer.
        
        Fix it by reinstating the old behaviour but in a new helper function
        execMayBeModifiedBeforeAnyUse, and limiting the number of instructions
        scanned.
        
        Reviewers: arsenm, vpykhtin
        
        Subscribers: kzhuravl, nemanjai, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, kbarton, MaskRay, jfb, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64393 — foad / ViewSVN
365909. [clang-format][tests] Explicitly specify style in some tests
        
        Summary: This fixes broken tests when doing an out-of-source build that picks up a random .clang-format on the file system due to the default "file" style.
        
        Reviewers: djasper, klimek, MyDeveloperDay, krasimir
        
        Reviewed By: MyDeveloperDay
        
        Subscribers: lebedev.ri, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D61001 — r.stahl / ViewSVN

#18439 (Jul 12, 2019 8:52:43 AM)

365902. cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros
        
        Summary:
        This will simplify the macros by allowing us to remove the hard-coded
        list of libraries that should be installed when
        LLVM_INSTALL_TOOLCHAIN_ONLY is enabled.
        
        Reviewers: beanz, smeenai
        
        Reviewed By: beanz
        
        Subscribers: aheejin, mehdi_amini, mgorny, steven_wu, dexonsmith, cfe-commits, llvm-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D64580 — tstellar / ViewSVN
365901. Delete dead stores — maskray / ViewSVN
365900. Dump floating-point values as strings when dumping to JSON.
        
        This fixes a bug where we would have an invalid JSON attribute (e.g., "value": inf). It also increases the precision of the values because they're not represented as approximate doubles with the host architecture's floating-point model. — aaronballman / ViewSVN
365899. Revert "[clangd] Implement typeHierarchy/resolve for subtypes"
        
        Causing test failure on Windows bot
        
        This reverts commit 5b9484e559d44bd923fc290e335891b1dd2e17c4. — russell_gallop / ViewSVN
365898. [Driver] Delete dead code — maskray / ViewSVN
365897. [gn] Tag unneeded variable.
        
        When only building targets without assembly parsers (e.g. `llvm_targets_to_build
        = ["NVPTX"]`), `all_targets` is empty and causes GN to warn about an
        assigned-but-unused variable.
        
        Differential Revision: https://reviews.llvm.org/D31727 — bryant / ViewSVN
365896. [DAGCombine] narrowExtractedVectorBinOp - wrap subvector extraction in helper. NFCI.
        
        First step towards supporting 'free' subvector extractions other than concat_vectors. — rksimon / ViewSVN
365895. [LIT] Emit timeout error message only if timeout was reached
        
        Summary:
        This improves readability of LIT output: previously
        error messages gets emitted that say that there was no error:
        
        error: command reached timeout: False
        
        Patch by Alexey Sachkov.
        
        Reviewers: ddunbar, mgorny, modocache
        
        Reviewed By: mgorny
        
        Subscribers: delcypher, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64240 — bader / ViewSVN
365894. [clangd] Fixed toHalfOpenFileRange
        
        Summary:
        - Fixed toHalfOpenFileRange to work for macros as well as template
        instantiations
        - Added unit tests
        
        Breaking test case for older version of toHalfOpenFileRange:
        \# define FOO(X) X++
        int a = 1;
        int b = FOO(a);
        toHalfOpenFileRange for the sourceRange of VarDecl for b returned the
        wrong Range.
        
        Reviewers: sammccall, kadircet
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64562 — sureyeaah / ViewSVN
365893. [InstCombine] Fold select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y) to ashr (X, Y))
        
        Summary:
        (select (icmp sgt x, -1), lshr (X, Y), ashr (X, Y)) -> ashr (X, Y))
        (select (icmp slt x, 1), ashr (X, Y), lshr (X, Y)) -> ashr (X, Y))
        
        Fixes PR41173
        
        Alive proof by @lebedev.ri (thanks)
        Name: PR41173
          %cmp = icmp slt i32 %x, 1
          %shr = lshr i32 %x, %y
          %shr1 = ashr i32 %x, %y
          %retval.0 = select i1 %cmp, i32 %shr1, i32 %shr
          =>
          %retval.0 = ashr i32 %x, %y
        
        Optimization: PR41173
        Done: 1
        Optimization is correct!
        
        Reviewers: lebedev.ri, spatel
        
        Reviewed By: lebedev.ri
        
        Subscribers: nikic, craig.topper, llvm-commits, lebedev.ri
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64285 — xbolva00 / ViewSVN
365892. Fix test case of llvm-nm using implicit a.out — abrachet / ViewSVN
365891. [test/Object, obj2yaml] - Move test cases from test/Object and cleanup.
        
        test/Object is not correct place to have tests that check obj2yaml
        functionality, because we have test/tools/obj2yaml folder for that.
        
        In this patch I merged a few test cases with their YAMLs from Inputs
        folder, converted one of binary inputs and moved them to
        tools/obj2yaml folder.
        
        There are still another tests that might need the same, so it is initial step.
        
        Differential revision: https://reviews.llvm.org/D64555 — grimar / ViewSVN
365889. [tools] [llvm-nm] Default to reading from stdin not a.out
        
        Summary: This moves away from defaulting to a.out and uses stdin only if stdin has a file redirected to it. This has been discussed on the llvm-dev mailing list [[ https://lists.llvm.org/pipermail/llvm-dev/2019-July/133642.html | here ]].
        
        Reviewers: jhenderson, rupprecht, MaskRay, chrisjackson
        
        Reviewed By: jhenderson, MaskRay
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64290 — abrachet / ViewSVN
365888. [clangd] Prioritize indexing of files that share a basename with the open file.
        
        Summary:
        In practice, opening Foo.h will still often result in Foo.cpp making the
        second index build instead of the first, as the rebuild policy doesn't
        know to wait.
        
        Reviewers: kadircet
        
        Subscribers: ilya-biryukov, javed.absar, MaskRay, jkorous, arphaman, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64575 — sammccall / ViewSVN
365887. [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.
        
        Summary:
        It's common to use compiler wrappers by setting CC="gomacc clang++".
        This results in both args appearing in compile_commands.json, and clang's driver
        can't handle this.
        
        This patch attempts to recognize this pattern (by looking for well-known
        wrappers) and dropping argv0 in this case.
        
        It conservatively ignores other cases for now:
        - wrappers with unknown names
        - wrappers that accept -flags
        - wrappers where the compiler to use is implied (usually cc or gcc)
        
        This is done at the JSONCompilationDatabase level rather than somewhere more
        fundamental, as (hopefully) this isn't a general conceptual problem, but a messy
        aspect of the nature of the ecosystem around compile_commands.json.
        i.e. compilation databases more tightly tied to the build system should not have
        this problem.
        
        Reviewers: phosek, klimek
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64297 — sammccall / ViewSVN

#18438 (Jul 12, 2019 4:00:55 AM)

365886. Revert "[DwarfDebug] Dump call site debug info"
        
        A build failure was found on the SystemZ platform.
        
        This reverts commit 9e7e73578e54cd22b3c7af4b54274d743b6607cc. — djtodoro / ViewSVN
365885. [clangd] Move the expandAuto tweak from global namespace into annoymous namespace. — hokein / ViewSVN
365884. [Object/ELF] - Improve error reporting for notes.
        
        This patch improves the error messages reported for
        note sections and phdrs and also makes a cleanup for
        existent test case.
        
        Differential revision: https://reviews.llvm.org/D64470 — grimar / ViewSVN
365883. [NFC][PowerPC] Added test for MachinePRE. — lkail / ViewSVN
365882. [clangd] Don't run the prepare for tweaks that are disabled.
        
        Summary: Previously, we ran the prepare, even for the tweaks that are disabled.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64565 — hokein / ViewSVN
365881. [RISCV] Allow parsing dot '.' in assembly
        
        Summary:
        Useful for jumps, such as `j .`.
        
        I am not sure who should review this. Do not hesitate to change the reviewers if needed.
        
        Reviewers: asb, jrtc27, lenary
        
        Reviewed By: lenary
        
        Subscribers: MaskRay, lenary, hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63669
        
        Patch by John LLVM (JohnLLVM) — lenary / ViewSVN
365880. Enable compiler-rt on SPARC
        
        This patch enables compiler-rt on SPARC targets. Most of the changes are straightforward:
        
        - Add 32 and 64-bit sparc to compiler-rt
        
        - lib/builtins/fp_lib.h needed to check if the int128_t and uint128_t types exist (which they don't on sparc)
        
        There's one issue of note: many asan tests fail to compile on Solaris/SPARC:
        
        fatal error: error in backend: Function "_ZN7testing8internal16BoolFromGTestEnvEPKcb": over-aligned dynamic alloca not supported.
        
        Therefore, while asan is still built, both asan and ubsan-with-asan testing is disabled. The
        goal is to check if asan keeps compiling on Solaris/SPARC. This serves asan in gcc,
        which doesn't have the problem above and works just fine.
        
        With this patch, sparcv9-sun-solaris2.11 test results are pretty good:
        
        Failing Tests (9):
            Builtins-sparc-sunos :: divtc3_test.c
            Builtins-sparcv9-sunos :: compiler_rt_logbl_test.c
            Builtins-sparcv9-sunos :: divtc3_test.c
        [...]
            UBSan-Standalone-sparc :: TestCases/TypeCheck/misaligned.cpp
            UBSan-Standalone-sparcv9 :: TestCases/TypeCheck/misaligned.cpp
        
        The builtin failures are due to Bugs 42493 and 42496. The tree contained a few additonal
        patches either currently in review or about to be submitted.
        
        Tested on sparcv9-sun-solaris2.11.
        
        Differential Revision: https://reviews.llvm.org/D40943 — ro / ViewSVN
365879. [Sanitizers] Fix SanitizerCommon-Unit :: ./Sanitizer-*-Test/MemoryMappingLayout.DumpListOfModules on Solaris
        
        The MemoryMappingLayout.DumpListOfModules currently FAILs on Solaris:
        
          [ RUN      ] MemoryMappingLayout.DumpListOfModules
          /vol/llvm/src/compiler-rt/local/lib/sanitizer_common/tests/sanitizer_procmaps_test.cc:52: Failure
          Value of: found
            Actual: false
          Expected: true
          [  FAILED  ] MemoryMappingLayout.DumpListOfModules (22 ms)
        
        The problem is that the test expects the executable name from modules[i].full_name(),
        however the pr_mapname field of struct prmap is just the entry in /proc/<pid>/object,
        which is "a.out" instead of "Sanitizer-i386-Test".  Fortunately, the real name can
        be determined by looking in proc/<pid>/path where "a.out" is a symlink to the
        real path.
        
        Tested on x86_64-pc-solaris2.11.
        
        Differential Revision: https://reviews.llvm.org/D64559 — ro / ViewSVN
365878. Test commit. NFC.
        
        Formatting fix. — bryant / ViewSVN
365877. [Driver] Delete --no-add-needed for RHEL7 or newer
        
        This is really not needed. gcc driver doesn't add this option.
        BTW, since binutils 2.22, --no-copy-dt-needed-entries (new name of
        --no-add-needed) is the default. — maskray / ViewSVN
365876. [YAMLIO] Wrap explicit specialization in llvm::yaml to appease build bots — maskray / ViewSVN
365874. [test] Delete trailing spaces from YAML tests after D65566/r365869 — maskray / ViewSVN
365873. [test] Delete trailing spaces from YAML tests — maskray / ViewSVN
365872. test/Driver/fsanitize.c: delete -target x86_64-linux-gnu from tests that should always be available
        
        Follow-up of D64317/r365587. — maskray / ViewSVN

#18437 (Jul 11, 2019 11:07:53 PM)

365871. [AMDGPU] Fixed comment. NFC. — rampitec / ViewSVN
365870. [mips] Fix JmpLink to texternalsym and tglobaladdr on mcroMIPS R6
        
        There is not match for the `MipsJmpLink texternalsym` and `MipsJmpLink
        tglobaladdr` patterns for microMIPS R6. As a result LLVM incorrectly
        selects the `JALRC16` compact 2-byte instruction which takes a target
        instruction address from a register only and assign `R_MIPS_32` relocation
        for this instruction. This relocation completely overwrites `JALRC16`
        and nearby instructions.
        
        This patch adds missed matching patterns, selects `BALC` instruction and
        assign a correct `R_MICROMIPS_PC26_S1` relocation.
        
        Differential Revision: https://reviews.llvm.org/D64552 — atanasyan / ViewSVN
365869. [YAMLIO] Remove trailing spaces when outputting maps
        
        llvm::yaml::Output::paddedKey unconditionally outputs spaces, which
        are superfluous if the value to be dumped is a sequence or map.
        Change `bool NeedsNewLine` to `StringRef Padding` so that it can be
        overridden to `\n` if the value is a sequence or map.
        
        An empty map/sequence is special. It is printed as `{}` or `[]` without
        a newline, while a non-empty map/sequence follows a newline. To handle
        this distinction, add another variable `PaddingBeforeContainer` and does
        the special handling in endMapping/endSequence.
        
        Reviewed By: grimar, jhenderson
        
        Differential Revision: https://reviews.llvm.org/D64566 — maskray / ViewSVN
365867. [clangd] Implement typeHierarchy/resolve for subtypes
        
        Summary:
        This allows the client to resolve subtypes one level at a time.
        
        For supertypes, this is not necessary, because we eagerly compute
        supertypes and return all levels.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64308 — nridge / ViewSVN
365866. [X86][PowerPC] Support -mlong-double-128
        
        This patch makes the driver option -mlong-double-128 available for X86
        and PowerPC. The CC1 option -mlong-double-128 is available on all targets
        for users to test on unsupported targets.
        
        On PowerPC, -mlong-double-128 uses the IBM extended double format
        because we don't support -mabi=ieeelongdouble yet (D64283).
        
        Reviewed By: rnk
        
        Differential Revision: https://reviews.llvm.org/D64277 — maskray / ViewSVN

#18436 (Jul 11, 2019 9:10:39 PM)

365865. docs/GithubMove.rst: Add link to GitHub migration status page — tstellar / ViewSVN
365864. Return Undef from isBytewiseValue for empty arrays or structs
        
        Reviewers: pcc, eugenis
        
        Subscribers: hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64052 — Vitaly Buka / ViewSVN
365863. NFC: Unforget a colon in a few CHECK: directives.
        
        Differential Revision: https://reviews.llvm.org/D64526 — dergachev / ViewSVN
365862. [PowerPC] Default to -fomit-frame-pointer when optimization is enabled
        
        NetBSD, Linux, CloudABI and Hurd already omit frame pointer for PowerPC.
        Make it do so for other platforms. — maskray / ViewSVN
365861. [analyzer] exploded-graph-rewriter: Improve source location dumps.
        
        - Correctly display macro expansion and spelling locations.
        - Use the same procedure to display location context call site locations.
        - Display statement IDs for program points. — dergachev / ViewSVN
365860. [Driver] Refactor interaction between -f(no-)?omit-frame-pointer and -m(no-)?omit-leaf-frame-pointer
        
        Use a tri-state enum to represent shouldUseFramePointer() and
        shouldUseLeafFramePointer().
        
        This simplifies the logic and fixes PR9825:
          -fno-omit-frame-pointer doesn't imply -mno-omit-leaf-frame-pointer.
        
        and PR24003:
          /Oy- /O2 should not omit leaf frame pointer: this matches MSVC x86-32.
          (/Oy- is a no-op on MSVC x86-64.)
        
        and:
          when CC1 option -mdisable-fp-elim if absent, -momit-leaf-frame-pointer
          can also be omitted.
        
        The new behavior matches GCC:
          -fomit-frame-pointer wins over -mno-omit-leaf-frame-pointer
          -fno-omit-frame-pointer loses out to -momit-leaf-frame-pointer
        
        The behavior makes lots of sense. We have 4 states:
        
        - 00) leaf retained, non-leaf retained
        - 01) leaf retained, non-leaf omitted  (this is invalid)
        - 10) leaf omitted, non-leaf retained  (what -momit-leaf-frame-pointer was designed for)
        - 11) leaf omitted, non-leaf omitted
        
        "omit" options taking precedence over "no-omit" options is the only way
        to make 3 valid states representable with -f(no-)?omit-frame-pointer and
        -m(no-)?omit-leaf-pointer.
        
        Reviewed By: ychen
        
        Differential Revision: https://reviews.llvm.org/D64294 — maskray / ViewSVN
365859. [MachinePipeliner] Fix order for nodes with Anti dependence in same cycle
        
        Summary:
        Problem exposed in PowerPC functional testing.
        
        We did not consider Anti dependence for nodes in same cycle,
        so we may end up generating bad machine code.
        eg: the reduced test won't verify.
        
        *** Bad machine code: Using an undefined physical register ***
        - function:    lame_encode_buffer_interleaved
        - basic block: %bb.4  (0x4bde4e12928)
        - instruction: %29:gprc = ADDZE %27:gprc, implicit-def dead $carry, implicit $carry
        - operand 3:   implicit $carry
        
        Reviewers: bcahoon, kparzysz, hfinkel
        
        Subscribers: MaskRay, wuzish, nemanjai, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64192 — jsji / ViewSVN
365858. Handle IntToPtr in isBytewiseValue
        
        Summary:
        This helps with more efficient use of memset for pattern initialization
        
        From @pcc prototype for -ftrivial-auto-var-init=pattern optimizations
        
        Binary size change on CTMark, (with -fuse-ld=lld -Wl,--icf=all, similar results with default linker options)
        ```
                           master           patch      diff
        Os           8.238864e+05    8.238864e+05       0.0
        O3           1.054797e+06    1.054797e+06       0.0
        Os zero      8.292384e+05    8.292384e+05       0.0
        O3 zero      1.062626e+06    1.062626e+06       0.0
        Os pattern   8.579712e+05    8.338048e+05 -0.030299
        O3 pattern   1.090502e+06    1.067574e+06 -0.020481
        ```
        
        Zero vs Pattern on master
        ```
                       zero       pattern      diff
        Os     8.292384e+05  8.579712e+05  0.036578
        O3     1.062626e+06  1.090502e+06  0.025124
        ```
        
        Zero vs Pattern with the patch
        ```
                       zero       pattern      diff
        Os     8.292384e+05  8.338048e+05  0.003333
        O3     1.062626e+06  1.067574e+06  0.003193
        ```
        
        Reviewers: pcc, eugenis
        
        Subscribers: hiraditya, cfe-commits, llvm-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D63967 — Vitaly Buka / ViewSVN
365857. Codegen, NFC: 32bit test in auto-var-init.cpp — Vitaly Buka / ViewSVN
365856. Mark destroying delete test as UNSUPPORTED with clang 7 — ericwf / ViewSVN
365855. Tolerate import errors in "not.py" implementation — ericwf / ViewSVN
365854. Reorganize the 'bit' header to make most of the facilities available for internal use pre-C++20. NFC for external users — marshall / ViewSVN
365852. NFC: lit: python3 compatibility for functions
        usePlatformSdkOnDarwin/findPlatformSdkVersionOnMacOS
        
        These functions should decode subprocess output — arphaman / ViewSVN
365851. [InstCombine] Reorder pow() transformations (NFC)
        
        Move the transformation from `powf(x, itofp(y))` to `powi(x, y)` to the
        group of transformations related to the exponent. — evandro / ViewSVN
365850. Re-Revert Devirtualize destructor of final class.
        
        This reverts r365509 (git commit d088720edad9c29ee0d622b5d69092e18a9ac0bd)
        
        This is a second revert[1] due to failures in internal test cases (shared offline) found during more thorough testing.
        
        [1] Original patch commited as r364100, reverted as r364359, recommitted as r365509 — rupprecht / ViewSVN
365849. [clangd] Add a missing early return in getTypeHierarchy()
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64307 — nridge / ViewSVN
365848. Add another buildbot username to the workaround list — ericwf / ViewSVN
365847. Attempt to override broken buildbot config for libc++abi.
        
        The buildbots were changed to pass -DLIBCXX_CXX_ABI=libcxxabi, but
        they don't provide an include path for the library, so cxxabi.h is
        never found while building libc++.
        
        This is a temporary change until the buildbots are updated or until
        D63883 lands in a form that unbreaks the bots — ericwf / ViewSVN

#18435 (Jul 11, 2019 6:03:29 PM)

365846. [AMDGPU] Skip calculating callee saved registers for entry function.
        
        Reviewers: arsenm
        
        Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64596 — hliao / ViewSVN
365845. [CMake][Fuchsia] Use RelWithDebInfo to build runtimes
        
        We want to preserve debug info in our runtimes to aid symbolization and
        debugging; for shared libraries this will be stripped away during
        install-stripped step and distributed via .build-id, for static archives
        it's part of the archive and it's a responsibility of the consumer to
        strip it away in the final binary if not needed.
        
        Differential Revision: https://reviews.llvm.org/D64605 — phosek / ViewSVN
365844. [clangd] Fix MSVC build failure.
        
        http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26898 — probinson / ViewSVN
365842. AMDGPU: s_waitcnt field should be treated as unsigned
        
        Also make it an ImmLeaf, so it should work with global isel as well,
        which was part of the point of moving it in the first place. — arsenm / ViewSVN
365841. Use clang driver for libfuzzer tests on Windows
        
        Summary:
        There's no real reason to use clang-cl on Windows, the clang driver
        works just as well. This fixes a test which uses the -O0 flag, which was
        recently removed from clang-cl to match MSVC, which lacks this flag.
        
        While I'm here, remove the explicit -std=c++11 flag. Previously, this
        flag was necessary when the default C++ standard was C++98. Now that the
        default is C++14, this is no longer necessary. It's problematic on
        Windows, because the Visual C++ standard library relies on C++14
        features, and attempting to compile it with C++11 results in errors.
        Rather than adding logic to conditionally set the standard to C++11 only
        on non-Win, this flag can be removed.
        
        See http://lab.llvm.org:8011/builders/clang-x64-windows-msvc and
        https://reviews.llvm.org/D64506.
        
        Reviewers: morehouse, thakis
        
        Subscribers: #sanitizers, llvm-commits
        
        Tags: #sanitizers, #llvm
        
        Differential Revision: https://reviews.llvm.org/D64587 — rnk / ViewSVN
365840. Fix memory leak in set and map.
        
        When assigning an initializer list into set/map, libc++ would
        leak memory if the initializer list contained equivalent keys
        because we failed to check if the insertion was successful. — ericwf / ViewSVN
365839. [sancov] Ignore PC samples with value 0
        
        The sancov runtime for the (Fuchsia) Zircon kernel delivers results
        in the standard format, but as the full array of possible samples
        with 0 in uncovered slots. That runtime delivers "live" data and
        has no final "export" pass to compactify out the uncovered slots,
        and it seems silly to require another offline tool just for that.
        
        Patch By: mcgrathr
        Differential Revision: https://reviews.llvm.org/D63695 — phosek / ViewSVN
365838. [NewPM] Port Sancov
        
        This patch contains a port of SanitizerCoverage to the new pass manager. This one's a bit hefty.
        
        Changes:
        
        - Split SanitizerCoverageModule into 2 SanitizerCoverage for passing over
          functions and ModuleSanitizerCoverage for passing over modules.
        - ModuleSanitizerCoverage exists for adding 2 module level calls to initialization
          functions but only if there's a function that was instrumented by sancov.
        - Added legacy and new PM wrapper classes that own instances of the 2 new classes.
        - Update llvm tests and add clang tests.
        
        Differential Revision: https://reviews.llvm.org/D62888 — leonardchan / ViewSVN
365837. [AMDGPU] Fixed asan error with agpr spilling
        
        Instruction was used after it was erased. — rampitec / ViewSVN
365836. Fix build errors LLVM tests are disabled.
        
        Original patch from alanbaker@google.com
        
        Fixes the error:
        CMake Error in <...>/llvm/cmake/modules/CMakeLists.txt:
        
        export called with target "LLVMTestingSupport" which requires target
        "gtest" that is not in the export set.
        
        This occurs when LLVM is embedded in a larger project, but is configured not to
        include tests. If testing is disabled gtest isn't available and LLVM fails to
        configure.
        
        Differential revision: https://reviews.llvm.org/D63097 — dnovillo / ViewSVN
365835. CodeGen: Suppress c++ warnings in test — Vitaly Buka / ViewSVN
365833. [AMDGPU] gfx908 agpr spilling
        
        Differential Revision: https://reviews.llvm.org/D64594 — rampitec / ViewSVN
365832. Fix a Python3 compatibility error
        
          File "clang/test/lit.cfg.py", line 186, in <module>
            config.available_features.add('macos-sdk-' + macOSSDKVersion)
        TypeError: must be str, not bytes — Azharuddin Mohammed / ViewSVN
365831. Rename libclang_shared to libclang-cpp
        
        Summary: Fix bug 42475
        
        Reviewers: beanz, tstellar
        
        Reviewed By: beanz
        
        Subscribers: kimgr, mgorny, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64278 — sylvestre / ViewSVN
365830. [Attributor] Deduce "nosync" function attribute.
        
        Introduce and deduce "nosync" function attribute to indicate that a function
        does not synchronize with another thread in a way that other thread might free memory.
        
        Reviewers: jdoerfert, jfb, nhaehnle, arsenm
        
        Subscribers: wdng, hfinkel, nhaenhle, mehdi_amini, steven_wu,
        dexonsmith, arsenm, uenoku, hiraditya, jfb, llvm-commits
        
        Differential Revision: https://reviews.llvm.org/D62766 — sstefan / ViewSVN
365829. [AMDGPU] gfx908 hazard recognizer
        
        Differential Revision: https://reviews.llvm.org/D64593 — rampitec / ViewSVN
365828. [InstCombine][NFCI] Add more test coverage to onehot_merge.ll
        
        Prep work for upcoming patch D64275. — huihuiz / ViewSVN
365827. [analyzer] exploded-graph-rewriter: Fix filenames in program point.
        
        Fix a typo in JSON field name. — dergachev / ViewSVN
365826. [AMDGPU] gfx908 scheduling
        
        Differential Revision: https://reviews.llvm.org/D64590 — rampitec / ViewSVN
365825. [clang-shlib] Fix clang-shlib for PRIVATE dependencies
        
        Any static library with a PRIVATE dependency ends up with a
        $<LINK_ONLY:...> generator expression in its INTERFACE_LINK_LIBRARIES,
        which won't be evaluated by the $<TARGET_PROPERTY:...>, so we end up
        with an unevaluated generator expression in the generated build file and
        Ninja chokes on the dollar sign. Just use the static library directly
        for its dependencies instead of trying to propagate dependencies
        manually.
        
        Differential Revision: https://reviews.llvm.org/D64579 — smeenai / ViewSVN
365824. [AMDGPU] gfx908 mfma support
        
        Differential Revision: https://reviews.llvm.org/D64584 — rampitec / ViewSVN
365822. CodeGen, NFC: Test for auto-init for 32bit pointers — Vitaly Buka / ViewSVN
365821. [OPENMP]Improve handling of analysis of unsupported VLAs in reductions.
        
        Fixed the processing of the unsupported VLAs in the reduction clauses.
        Used targetDiag if the diagnostics can be delayed and emit it
        immediately if the target does not support VLAs and we're parsing target
        directive with the reduction clauses. — abataev / ViewSVN
365820. Open native file handles to avoid converting from FDs, NFC
        
        Follow up to r365588. — rnk / ViewSVN
365818. [UpdateTestChecks] Emit warning when invalid test paths
        
        Summary:
        Recently I ran into the following issue:
        
        ./update_test_checks.py /path/not-existing-file.ll
        
        The script was silent and I was suprised why the real test file hadn't been updated.
        
        Solution:
        Emit warning if we detect this problem.
        
        
        
        Reviewers: lebedev.ri, spatel, jdoerfert, nikic
        
        Reviewed By: lebedev.ri, spatel, jdoerfert, nikic
        
        Subscribers: jdoerfert, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64572 — xbolva00 / ViewSVN
365816. [scudo][standalone] NFC corrections
        
        Summary:
        A few corrections:
        - rename `TransferBatch::MaxCached` to `getMaxCached` to conform with
          the style guide;
        - move `getBlockBegin` from `Chunk::` to `Allocator::`: I believe it
          was a fallacy to have this be a `Chunk` method, as chunks'
          relationship to backend blocks are up to the frontend allocator. It
          makes more sense now, particularly with regard to the offset. Update
          the associated chunk test as the method isn't available there
          anymore;
        - add a forgotten `\n` to a log string;
        - for `releaseToOs`, instead of starting at `1`, start at `0` and
          `continue` on `BatchClassId`: in the end it's identical but doesn't
          assume a particular class id for batches;
        - change a `CHECK` to a `reportOutOfMemory`: it's a clearer message
        
        Reviewers: hctim, morehouse, eugenis, vitalybuka
        
        Reviewed By: hctim
        
        Subscribers: delcypher, #sanitizers, llvm-commits
        
        Tags: #llvm, #sanitizers
        
        Differential Revision: https://reviews.llvm.org/D64570 — cryptoad / ViewSVN
365815. [NFC] Revisited tests for D64285 — xbolva00 / ViewSVN
365814. Revert "[CGDebugInfo] Simplify EmitFunctionDecl parameters, NFC"
        
        This reverts commit 1af41074445229fea66b99710a850e5f42ecfa95. — Vedant Kumar / ViewSVN

#18433 (Jul 11, 2019 1:07:52 PM)

365803. [X86] Pre commit test cases for D64574. Along with a test case for PR42571. NFC — ctopper / ViewSVN
365802. [WebAssembly] Assembler: support negative float constants.
        
        Reviewers: dschuff
        
        Subscribers: sbc100, jgravelle-google, aheejin, sunfish, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64367 — aardappel / ViewSVN
365801. Explicitly define __STDC_FORMAT_MACROS for PRIu64
        
        Summary:
        Builds are failing on RHEL machines because of PRIu64.
        
        lvm/projects/compiler-rt/lib/gwp_asan/guarded_pool_allocator.cpp:420:50: error: expected ')'
        
        `snprintf(ThreadBuffer, kThreadBufferLen, "%" PRIu64, ThreadID);`
        inttypes.h in RHEL uses PRIu64 macros only when __STDC_FORMAT_MACROS is defined.
        
        Author: DTharun
        
        Reviewers: hctim
        
        Reviewed By: hctim
        
        Differential Revision: https://reviews.llvm.org/D64388 — hctim / ViewSVN
365799. [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012
        
        Differential Revision: https://reviews.llvm.org/D64364 — yaxunl / ViewSVN
365798. [CodeGen] NVPTX: Switch from atomic.load.add.f32 to atomicrmw fadd — d0k / ViewSVN
365797. [Docs] Add standardized header links to analyzer doc
        
        Summary:
        Header links should have some standard form so clang tidy
        docs can easily reference them. The form is as follows.
        
        Start with the analyzer full name including packages.
        Replace all periods with dashes and lowercase everything.
        
        Ex: core.CallAndMessage -> core-callandmessage
        
        Reviewers: JonasToth, aaron.ballman, NoQ, Szelethus
        
        Reviewed By: aaron.ballman, Szelethus
        
        Subscribers: nickdesaulniers, lebedev.ri, baloghadamsoftware, mgrang, a.sidorin, Szelethus, jfb, donat.nagy, dkrupp, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64543 — nathan-huckleberry / ViewSVN
365796. [NVPTX] Use atomicrmw fadd instead of intrinsics
        
        AutoUpgrade the old intrinsics to atomicrmw fadd. — d0k / ViewSVN
365795. gn build: Merge r365792 — nico / ViewSVN
365794. [clangd] Avoid template in Task constructor, hopefully fix MSVC build — sammccall / ViewSVN
365793. [clangd] Consume llvm::Error in test after r365792 — sammccall / ViewSVN
365792. [clangd] Implementation of auto type expansion.
        
        Add a tweak for clangd to replace an auto keyword to the deduced type.
        
        This way a user can declare something with auto and then have the
        IDE/clangd replace auto with whatever type clangd thinks it is. In case
        of long/complext types this makes is reduces writing effort for the
        user.
        
        The functionality is similar to the hover over the auto keyword.
        
        Example (from the header):
        
        ```
        /// Before:
        ///    auto x = Something();
        ///    ^^^^
        /// After:
        ///    MyClass x = Something();
        ///    ^^^^^^^
        ```
        
        Patch by kuhnel! (Christian Kühnel)
        Differential Revision: https://reviews.llvm.org/D62855 — sammccall / ViewSVN
365791. [X86] Merge negated ISD::SUB nodes into X86ISD::SUB equivalent (PR40483)
        
        Follow up to D58597, where it was noted that the commuted ISD::SUB variant
        was having problems with lack of combines.
        
        See also D63958 where we untangled setcc/sub pairs.
        
        Differential Revision: https://reviews.llvm.org/D58875 — spatel / ViewSVN
365790. [scudo][standalone] Merge Spin & Blocking mutex into a Hybrid one
        
        Summary:
        We ran into a problem on Fuchsia where yielding threads would never
        be deboosted, ultimately resulting in several threads spinning on the
        same TSD, and no possibility for another thread to be scheduled,
        dead-locking the process.
        
        While this was fixed in Zircon, this lead to discussions about if
        spinning without a break condition was a good decision, and settled on
        a new hybrid model that would spin for a while then block.
        
        Currently we are using a number of iterations for spinning that is
        mostly arbitrary (based on sanitizer_common values), but this can
        be tuned in the future.
        
        Since we are touching `common.h`, we also use this change as a vehicle
        for an Android optimization (the page size is fixed in Bionic, so use
        a fixed value too).
        
        Reviewers: morehouse, hctim, eugenis, dvyukov, vitalybuka
        
        Reviewed By: hctim
        
        Subscribers: srhines, delcypher, jfb, #sanitizers, llvm-commits
        
        Tags: #llvm, #sanitizers
        
        Differential Revision: https://reviews.llvm.org/D64358 — cryptoad / ViewSVN
365789. Fix a few 'no newline at end of file' warnings that Xcode emits
        
        (Xcode even has a snazzy "Fix" button, but clicking that inserts two
        newlines. So close!) — nico / ViewSVN
365788. [libc++] Implement deduction guides for <unordered_set>
        
        Thanks to Arthur O'Dwyer for the patch.
        Differential Revision: https://reviews.llvm.org/D58617 — Louis Dionne / ViewSVN
365787. gn build: Merge r365773 — nico / ViewSVN
365786. [OPENMP]Initial fix PR42392: Improve -Wuninitialized warnings for OpenMP programs.
        
        Summary:
        Some OpenMP clauses rely on the values of the variables. If the variable
        is not initialized and used in OpenMP clauses that depend on the
        variables values, it should be reported that the uninitialized variable
        is used in the OpenMP clause expression.
        This patch adds initial processing for uninitialized variables in OpenMP
        constructs. Currently, it checks for use of the uninitialized variables
        in the structured blocks.
        
        Reviewers: NoQ, Szelethus, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet
        
        Subscribers: rnkovacs, guansong, jfb, jdoerfert, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64356 — abataev / ViewSVN
365785. [DAGCombine] narrowInsertExtractVectorBinOp - add CONCAT_VECTORS support
        
        We already split extract_subvector(binop(insert_subvector(v,x),insert_subvector(w,y))) -> binop(x,y).
        
        This patch adds support for extract_subvector(binop(concat_vectors(),concat_vectors())) cases as well.
        
        In particular this means we don't have to wait for X86 lowering to convert concat_vectors to insert_subvector chains, which helps avoid some cases where demandedelts/combine calls occur too late to split large vector ops.
        
        The fast-isel-store.ll load folding regression is annoying but I don't think is that critical.
        
        Differential Revision: https://reviews.llvm.org/D63653 — rksimon / ViewSVN
365784. RegUsageInfoCollector: Skip calling conventions I missed before — arsenm / ViewSVN
365782. AMDGPU/GlobalISel: Move kernel argument handling to separate function — arsenm / ViewSVN
365781. Fix missing C++ mode comment — arsenm / ViewSVN
365780. GlobalISel: Use Register — arsenm / ViewSVN

#18431 (Jul 11, 2019 8:12:53 AM)

365779. Revert r365775 - "[Object/ELF] - Improve error reporting for notes."
        
        It broke BB: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/15419 — grimar / ViewSVN
365778. [clangd] Remove an extra ";", NFC — hokein / ViewSVN
365777. Added mapping for pointers captured in Lambdas in OpenMP target regions,
        by David Truby.
        
        Summary:
        This adds a zero length array section mapping for each pointer captured by a lambda that is used in a target region, as per section 2.19.7.1 of the OpenMP 5 specification.
        
        Reviewers: ABataev
        
        Reviewed By: ABataev
        
        Subscribers: guansong, jdoerfert, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64558 — abataev / ViewSVN
365776. [clangd][QueryDriver] Use language from underlying database if possible
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64489 — kadircet / ViewSVN
365775. [Object/ELF] - Improve error reporting for notes.
        
        This patch improves the error messages reported for
        note sections and phdrs and also makes a cleanup for
        existent test case.
        
        Differential revision: https://reviews.llvm.org/D64470 — grimar / ViewSVN
365774. [InstCombine] don't move FP negation out of a constant expression
        
        -(X * ConstExpr) becomes X * (-ConstExpr), so don't reverse that
        and infinite loop. — spatel / ViewSVN
365773. [clangd] Add priorities to background index queue, extract to separate class
        
        Reviewers: kadircet
        
        Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman, jfb, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64560 — sammccall / ViewSVN
365772. [yaml2obj/elf-override-shsize.yaml] - An attemp to fix ppc64 bot.
        
        Failture:
        http://lab.llvm.org:8011/builders/clang-ppc64be-linux/builds/35670/steps/ninja%20check%201/logs/FAIL%3A%20LLVM%3A%3Aelf-override-shsize.yaml
        
        Solution:
        Change `od` tool invocation to print single bytes. — grimar / ViewSVN
365770. OpaquePtr: switch to GlobalValue::getValueType in a few places. NFC. — Tim Northover / ViewSVN
365769. OpaquePtr: use byval accessor instead of inspecting pointer type. NFC.
        
        The accessor can deal with both "byval(ty)" and "ty* byval" forms
        seamlessly. — Tim Northover / ViewSVN
365768. OpaquePtr: use load instruction directly for type. NFC. — Tim Northover / ViewSVN
365767. InstructionSimplify: Simplify InstructionSimplify. NFC.
        
        The interface predates CallBase, so both it and implementation were
        significantly more complicated than they needed to be. There was even
        some redundancy that could be eliminated.
        
        Should also help with OpaquePointers by not trying to derive a
        function's type from it's PointerType. — Tim Northover / ViewSVN
365766. [yaml2obj] - Allow overriding the sh_size field.
        
        There is no way to set broken sh_size field currently
        for sections. It can be usefull for writing the
        test cases.
        
        Differential revision: https://reviews.llvm.org/D64401 — grimar / ViewSVN
365765. [NFC] Updated tests for D64285 — xbolva00 / ViewSVN
365764. [clangd] Remove the extra ";", NFC — hokein / ViewSVN
365763. [clangd] Fix an assertion crash in "ExtractVariable" tweak
        
        Summary:
        GetTypePtr requires that the type should not be null, otherwise we hit
        an assertion, we should use getTypePtrOrNull instead.
        
        Reviewers: sammccall, SureYeaah
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64556 — hokein / ViewSVN
365762. [llvm-readobj/llvm-readelf] - Report a warning instead of a error when dumping a broken dynamic section.
        
        It does not make sence to stop dumping the object if the broken
        dynamic section was found. In this patch I changed the behavior from
        "report an error" to "report a warning". This matches GNU.
        
        Differential revision: https://reviews.llvm.org/D64472 — grimar / ViewSVN
365758. [InstCombine] Reorder recently added/improved pow transformations
        
        Changed cases are now faster with exp2. — xbolva00 / ViewSVN
365757. Revert [BitcodeReader] Validate OpNum, before accessing Record array.
        
        This reverts r365750 (git commit 8b222ecf2769ee133691f208f6166ce118c4a164)
        
        llvm-dis runs out of memory while opening invalid-fcmp-opnum.bc on
        llvm-hexagon-elf, probably because the bitcode file contains other
        suspicious values.
        
        http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/21949 — fhahn / ViewSVN
365756. [clangd] Fix windows buildbots — kadircet / ViewSVN
365755. [X86] Regenerate intrinsics tests. NFCI. — rksimon / ViewSVN
365754. [AMDGPU] Regenerate idot tests. NFCI.
        
        Reduces diff in D63281. — rksimon / ViewSVN
365753. [llvm-objcopy] Don't change permissions of non-regular output files
        
        There is currently an EPERM error when a regular user executes `llvm-objcopy a.o /dev/null`.
        Worse, root can even change the mode bits of /dev/null.
        
        Fix it by checking if the output file is special.
        
        A new overload of llvm::sys::fs::setPermissions with FD as the parameter
        is added. Users should provide `perm & ~umask` as the parameter if they
        intend to respect umask.
        
        The existing overload of llvm::sys::fs::setPermissions may be deleted if
        we can find an implementation of fchmod() on Windows. fchmod() is
        usually better than chmod() because it saves syscalls and can avoid race
        condition.
        
        Reviewed By: jakehehrlich, jhenderson
        
        Differential Revision: https://reviews.llvm.org/D64236 — maskray / ViewSVN
365752. [X86] -fno-plt: use GOT __tls_get_addr only if GOTPCRELX is enabled
        
        Summary:
        As of binutils 2.32, ld has a bogus TLS relaxation error when the GD/LD
        code sequence using R_X86_64_GOTPCREL (instead of R_X86_64_GOTPCRELX) is
        attempted to be relaxed to IE/LE (binutils PR24784). gold and lld are good.
        
        In gcc/config/i386/i386.md, there is a configure-time check of as/ld
        support and the GOT relaxation will not be used if as/ld doesn't support
        it:
        
            if (flag_plt || !HAVE_AS_IX86_TLS_GET_ADDR_GOT)
              return "call\t%P2";
            return "call\t{*%p2@GOT(%1)|[DWORD PTR %p2@GOT[%1]]}";
        
        In clang, -DENABLE_X86_RELAX_RELOCATIONS=OFF is the default. The ld.bfd
        bogus error can be reproduced with:
        
            thread_local int a;
            int main() { return a; }
        
        clang -fno-plt -fpic a.cc -fuse-ld=bfd
        
        GOTPCRELX gained relative good support in 2016, which is considered
        relatively new.  It is even difficult to conditionally default to
        -DENABLE_X86_RELAX_RELOCATIONS=ON due to cross compilation reasons. So
        work around the ld.bfd bug by only using GOT when GOTPCRELX is enabled.
        
        Reviewers: dalias, hjl.tools, nikic, rnk
        
        Reviewed By: nikic
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64304 — maskray / ViewSVN
365751. [clangd] Add a missing "return nullptr;" to the SelectionTree::commonAncestor.
        
        This would fix some mysterious crashes on codeAction in clangd. — hokein / ViewSVN
365750. [BitcodeReader] Validate OpNum, before accessing Record array.
        
        Currently invalid bitcode files can cause a crash, when OpNum exceeds
        the number of elements in Record, like in the attached bitcode file.
        
        The test case was generated by clusterfuzz: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=15698
        
        Reviewers: t.p.northover, thegameg, jfb
        
        Reviewed By: jfb
        
        Differential Revision: https://reviews.llvm.org/D64507 — fhahn / ViewSVN
365749. [ARM][LowOverheadLoops] Correct offset checking
           
        This patch addresses a couple of problems:
        1) The maximum supported offset of LE is -4094.
        2) The offset of WLS also needs to be checked, this uses a
           maximum positive offset of 4094.
           
        The use of BasicBlockUtils has been changed because the block offsets
        weren't being initialised, but the isBBInRange checks both positive
        and negative offsets.
           
        ARMISelLowering has been tweaked because the test case presented
        another pattern that we weren't supporting. — sam_parker / ViewSVN
365748. [clangd] Reland rL365634
        
        This was reverted in rL365678, the failure was due to YAML parsing of
        compile_commands.json.
        
        Converting backslashes to forward slashes to fix the issue in unittest. — kadircet / ViewSVN
365747. [ARM] Remove nonexistent unsigned forms of MVE VQDMLAH.
        
        The VQDMLAH.U8, VQDMLAH.U16 and VQDMLAH.U32 instructions don't
        actually exist: the Armv8.1-M architecture spec only lists signed
        forms of that instruction. The unsigned ones were added in error: they
        existed in an early draft of the spec, but they were removed before
        the public version, and we missed that particular spec change.
        
        Also affects the variant forms VQDMLASH, VQRDMLAH and VQRDMLASH.
        
        Reviewers: miyuki
        
        Subscribers: javed.absar, kristof.beyls, hiraditya, dmgreen, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64502 — statham / ViewSVN
365746. [NFC][PowerPC] Added test to track current behaviour of TailDup — lkail / ViewSVN
365745. [clangd] Added highlightings for namespace specifiers.
        
        Summary: Added highlightings for namespace specifiers.
        
        Reviewers: hokein, sammccall, ilya-biryukov
        
        Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64492 — jvikstrom / ViewSVN

#18430 (Jul 11, 2019 3:37:38 AM)

365744. [MIPS GlobalISel] Skip copies in addUseDef and addDefUses
        
        Skip copies between virtual registers during search for UseDefs
        and DefUses.
        Since each operand has one def search for UseDefs is straightforward.
        But since operand can have many uses, we have to check all uses of
        each copy we traverse during search for DefUses.
        
        Differential Revision: https://reviews.llvm.org/D64486 — petar.avramovic / ViewSVN
365743. [MIPS GlobalISel] RegBankSelect for chains of ambiguous instructions
        
        When one of the uses/defs of ambiguous instruction is also ambiguous
        visit it recursively and search its uses/defs for instruction with
        only one mapping available.
        When all instruction in a chain are ambiguous arbitrary mapping can
        be selected. For s64 operands in ambiguous chain fprb is selected since
        it results in less instructions then having to narrow scalar s64 to s32.
        For s32 both gprb and fprb result in same number of instructions and
        gprb is selected like a general purpose option.
        
        At the moment we always avoid cross register bank copies.
        TODO: Implement a model for costs calculations of different mappings
        on same instruction and cross bank copies. Allow cross bank copies
        when appropriate according to cost model.
        
        Differential Revision: https://reviews.llvm.org/D64485 — petar.avramovic / ViewSVN
365742. Revert Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."
        
        This reverts r365675 (git commit 43d75f977853c3ec891a440c362b2df183a211b5)
        
        The patch causes a crash in SupportTests (CommandLineTest.AliasesWithArguments). — hokein / ViewSVN
365741. Remove some redundant code from r290372 and improve a comment. — foad / ViewSVN

#18429 (Jul 11, 2019 3:23:53 AM)

365740. [ARM][ParallelDSP] Change the search for smlads
           
        Two functional changes have been made here:
        - Now search up from any add instruction to find the chains of
          operations that we may turn into a smlad. This allows the
          generation of a smlad which doesn't accumulate into a phi.
        - The search function has been corrected to stop it falsely searching
          up through an invalid path.
           
        The bulk of the changes have been making the Reduction struct a class
        and making it more C++y with getters and setters.
        
        Differential Revision: https://reviews.llvm.org/D61780 — sam_parker / ViewSVN
365739. [ASan] Use __sanitizer_fill_shadow for FastPoisonShadow on Fuchsia
        
        This is the optimized implementation for Fuchsia provided by the libc.
        
        Differential Revision: https://reviews.llvm.org/D64166 — phosek / ViewSVN
365738. [test] Silence gcc 7.4 warning [NFC]
        
        Without this gcc 7.4.0 complains with
        ../unittests/Analysis/ValueTrackingTest.cpp:937:66: error: ISO C++11 requires at least one argument for the "..." in a variadic macro [-Werror]
                                  ::testing::ValuesIn(IsBytewiseValueTests));
                                                                           ^ — uabelho / ViewSVN
365736. [clang-doc] Silence compiler warning with gcc 7.4 [NFC]
        
        Without the fix gcc 7.4.0 complains with
        
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'llvm::SmallString<16> clang::doc::{anonymous}::HTMLTag::ToString() const':
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:165:1: error: control reaches end of non-void function [-Werror=return-type]
        }
        ^
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'bool clang::doc::{anonymous}::HTMLTag::HasInlineChildren() const':
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:142:1: error: control reaches end of non-void function [-Werror=return-type]
        }
        ^
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp: In member function 'bool clang::doc::{anonymous}::HTMLTag::IsSelfClosing() const':
        /data/repo/master/clang-tools-extra/clang-doc/HTMLGenerator.cpp:126:1: error: control reaches end of non-void function [-Werror=return-type]
        }
        ^
        cc1plus: all warnings being treated as errors — uabelho / ViewSVN
365735. Add NetBSD LSan support
        
        Summary:
        Combine few relatively small changes into one:
        
        - implement internal_ptrace() and internal_clone() for NetBSD
        - add support for stoptheworld based on the ptrace(2) API
        - define COMPILER_RT_HAS_LSAN for NetBSD
        - enable tests for NetBSD/amd64
        
        Inspired by the original implementation by Christos Zoulas in netbsd/src for GCC.
        
        The implementation is in theory CPU independent through well defined macros
        across all NetBSD ports, however only the x86_64 version was tested.
        
        Reviewers: mgorny, dvyukov, vitalybuka, joerg, jfb
        
        Reviewed By: vitalybuka
        
        Subscribers: dexonsmith, jfb, srhines, kubamracek, llvm-commits, christos
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64057 — kamil / ViewSVN
365731. [WebAssembly] Print error message for llvm.clear_cache intrinsic
        
        Summary:
        Wasm does not currently support `llvm.clear_cache` intrinsic, and this
        prints a proper error message instead of segfault.
        
        Reviewers: dschuff, sbc100, sunfish
        
        Subscribers: jgravelle-google, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64322 — aheejin / ViewSVN
365729. [InstCombine][NFCI] Add test coverage to onehot_merge.ll
        
        Prep work for upcoming patch D64275. — huihuiz / ViewSVN
365727. Increase the number of parser diagnostics.
        
        The reserved range for parser diagnostics is getting close to being filled,
        so increase the space for them. — rtrieu / ViewSVN

#18427 (Jul 10, 2019 9:59:10 PM)

365726. [SCEV] teach SCEV symbolical execution about overflow intrinsics folding.
        Differential Revision: https://reviews.llvm.org/D64422 — shchenz / ViewSVN
365725. Change another test I missed in r365724 — nico / ViewSVN
365724. clang-cl: Remove -O0 option
        
        cl.exe doesn't understand it; there's /Od instead. See also the review
        thread for r229575.
        
        Update lots of compiler-rt tests to use -Od instead of -O0.
        Ran `rg -l 'clang_cl.*O0' compiler-rt/test/ | xargs sed -i -c 's/-O0/-Od/'`
        
        Differential Revision: https://reviews.llvm.org/D64506 — nico / ViewSVN
365723. Replace three "strip & accumulate" implementations with a single one
        
        This patch replaces the three almost identical "strip & accumulate"
        implementations for constant pointer offsets with a single one,
        combining the respective functionalities. The old interfaces are kept
        for now.
        
        Differential Revision: https://reviews.llvm.org/D64468 — jdoerfert / ViewSVN
365722. [NFC] Adjust "invalid.ll.bc" tests to check for AttrKind #255 not #63
        
        We are about to add enum attributes with AttrKind numbers >= 63. This
        means we cannot use AttrKind #63 to test for an invalid attribute number
        in the RAW format anymore. This patch changes the number of an invalid
        attribute to #255. There is no change to the character of the tests.
        
        Differential Revision: https://reviews.llvm.org/D64531 — jdoerfert / ViewSVN
365721. Various minor tweaks to CLCompatOptions.td
        
        - Add back indentation I accidentally removed in r364901
        - Wrap two lines to 80 cols
        - Slightly tighten up help text for several flags
        - Consistently use "Do not" instead of "Don't"
        - Make every option description start with a verb
        - Use "Set" instead of "Specify"
        - Mark default values of options more consistently
        - Remove text about "/Zi" not producing PDBs since it's confusing
          for people not intimately familiar with the implementation of
          the normal PDB pipeline. /Zi lets the linker produce PDBs, which
          is what most users want.
        - Consistently use "file" over "filename" in meta var names,
          consistently use "file name" over "filename" in text
        - Make all output setting options have consistent language — nico / ViewSVN
365720. [X86] Don't convert 8 or 16 bit ADDs to LEAs on Atom in FixupLEAPass.
        
        We use the functions that convert to three address to do the
        conversion, but changing an 8 or 16 bit will cause it to create
        a virtual register. This can't be done after register allocation
        where this pass runs.
        
        I've switched the pass completely to a white list of instructions
        that can be converted to LEA instead of a blacklist that was
        incorrect. This will avoid surprises if we enhance the three
        address conversion function to include additional instructions
        in the future.
        
        Fixes PR42565. — ctopper / ViewSVN
365717. [AMDGPU] gfx908 atomic fadd and atomic pk_fadd
        
        Differential Revision: https://reviews.llvm.org/D64435 — rampitec / ViewSVN
365716. [CGDebugInfo] Fix -femit-debug-entry-values crash on os_log_helpers
        
        An os_log_helper FunctionDecl may not have a body. Ignore these for the
        purposes of debug entry value emission.
        
        Fixes an assertion failure seen in a stage2 build of clang:
        
        Assertion failed: (FD->hasBody() && "Functions must have body here"),
        function analyzeParametersModification — Vedant Kumar / ViewSVN
365715. [AMDGPU] gfx908 dot instruction support
        
        Differential Revision: https://reviews.llvm.org/D64431 — rampitec / ViewSVN
365714. Attempt to fix bots after r365703 — nico / ViewSVN
365713. rL365634 adds a unique_ptr<CompilationDatabase> in GobalCompilationDatabase.h:108 but CompilationDatabase is only forward declared. This makes the header not compile standalone, because unique_ptrs expect to have the full-definition of the...
        
        Summary:
        ...template argument.
        
        Remove the forward declaration and include the appropriate header instead.
        Remove CompileCommand too, which is also in the header. — saugustine / ViewSVN
365712. Revert [llvm-objcopy] Allow strip symtab from executables and DSOs
        
        This reverts r365193 (git commit 194f16b3548bcb23a7f0fd638778ed72edd18d37)
        
        This patch doesn't work with binaries built w/ `--emit-relocs`, e.g.
        
        ```
        $ echo 'int main() { return 0; }' | clang -Wl,--emit-relocs -x c - -o foo && llvm-objcopy --strip-unneeded foo
        llvm-objcopy: error: 'foo': not stripping symbol '__gmon_start__' because it is named in a relocation
        ``` — rupprecht / ViewSVN

#18426 (Jul 10, 2019 5:35:30 PM)

365711. [SDAG] commute setcc operands to match a subtract
        
        If we have:
        
        R = sub X, Y
        P = cmp Y, X
        
        ...then flipping the operands in the compare instruction can allow using a subtract that sets compare flags.
        
        Motivated by diffs in D58875 - not sure if this changes anything there,
        but this seems like a good thing independent of that.
        
        There's a more involved version of this transform already in IR (in instcombine
        although that seems misplaced to me) - see "swapMayExposeCSEOpportunities()".
        
        Differential Revision: https://reviews.llvm.org/D63958 — spatel / ViewSVN
365710. Add IsBytewiseValue unit test
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63966 — Vitaly Buka / ViewSVN
365709. NFC: Pass DataLayout into isBytewiseValue
        
        Summary:
        We will need to handle IntToPtr which I will submit in a separate patch as it's
        not going to be NFC.
        
        Reviewers: eugenis, pcc
        
        Reviewed By: eugenis
        
        Subscribers: hiraditya, cfe-commits, llvm-commits
        
        Tags: #clang, #llvm
        
        Differential Revision: https://reviews.llvm.org/D63940 — Vitaly Buka / ViewSVN
365708. NFC: Convert large lambda into method
        
        Reviewers: pcc, eugenis
        
        Reviewed By: eugenis
        
        Subscribers: cfe-commits, lldb-commits
        
        Tags: #clang, #lldb
        
        Differential Revision: https://reviews.llvm.org/D63854 — Vitaly Buka / ViewSVN
365707. [TSan] Fix linker error on Linux/AArch64 — yln / ViewSVN
365706. GodeGen, NFC: Add test to track emitStoresForConstant behavior
        
        Reviewers: eugenis, pcc
        
        Reviewed By: eugenis
        
        Subscribers: cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64385 — Vitaly Buka / ViewSVN
365705. [X86] Add patterns with and_flag_nocf for BLSI and TBM instructions.
        
        Fixes similar issues to r352306. — ctopper / ViewSVN
365704. [X86] Add a few more TBM and BLSI test cases that show the same issue that r352306 fixed for BLSR. — ctopper / ViewSVN
365703. driver: Don't warn about assembler flags being unused when not assembling
        
        clang currently warns when passing flags for the assembler (e.g.
        -Wa,-mbig-obj) to an invocation that doesn't run the assembler (e.g.
        -E).
        
        At first sight, that makes sense -- the flag really is unused. But many
        other flags don't have an effect if no assembler runs (e.g.
        -fno-integrated-as, -ffunction-sections, and many others), and those
        currently don't warn. So this seems more like a side effect of how
        CollectArgsForIntegratedAssembler() is implemented than like an
        intentional feature.
        
        Since it's a bit inconvenient when debugging builds and adding -E,
        always call CollectArgsForIntegratedAssembler() to make sure assembler
        args always get claimed. Currently, this affects only these flags:
        -mincremental-linker-compatible, -mimplicit-it= (on ARM), -Wa, -Xassembler
        
        It does have the side effect that assembler options now need to be valid
        even if -E is passed. Previously, `-Wa,-mbig-obj` would error for
        non-coff output only if the assembler ran, now it always errors. This
        too makes assembler flags more consistent with all the other flags and
        seems like a progression.
        
        Fixes PR42066.
        
        Differential Revision: https://reviews.llvm.org/D64527 — nico / ViewSVN

#18425 (Jul 10, 2019 5:10:06 PM)

365702. [X86] Add BLSR and BLSMSK to isUseDefConvertible.
        
        Unfortunately subo formation in CGP prevents obvious ways of
        testing this.
        
        But we already have BLSI in here and the flag behavior is
        well understood.
        
        Might become more useful if we improve PR42571. — ctopper / ViewSVN
365701. [NFC]Fix IR/MC depency issue for function descriptor SDAG implementation
        
        Summary: llvm/IR/GlobalValue.h can't be included in MC, that creates a circular dependency between MC and IR libraries. This circular dependency is causing an issue for build system that enforce layering.
        
        Author: Xiangling_L
        
        Reviewers: sfertile, jasonliu, hubert.reinterpretcast, gribozavr
        
        Reviewed By: gribozavr
        
        Subscribers: wuzish, nemanjai, hiraditya, kbarton, MaskRay, jsji, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64445 — daltenty / ViewSVN
365700. [clang-scan-deps] Dependency directives source minimizer:
        single quotes are not digit separators after a valid character literal prefix
        
        The single quote character can act as a c++ digit separator.
        However, the minimizer shouldn't treat it as such when it's actually following
        a valid character literal prefix, like L, U, u, or u8.
        
        Differential Revision: https://reviews.llvm.org/D64525 — arphaman / ViewSVN
365699. [Concepts] Concept definitions (D40381)
        
        First in a series of patches to land C++2a Concepts support.
        This patch adds AST and parsing support for concept-declarations. — saar.raz / ViewSVN
365697. [X86] Remove unused variable. NFC — ctopper / ViewSVN
365695. My first test commit. — saar.raz / ViewSVN
365694. [NFC][InstCombine] Comb through just-added "omit mask before left-shift" tests once more — lebedevri / ViewSVN
365693. [TSan] Fix compiler error on Linux/AArch64 — yln / ViewSVN
365692. Add support for building with Python 3
        
        LLDB supports Python 3 now.
        
        Differential Revision: https://reviews.llvm.org/D64443
        
        Patch from Christian Biesinger <cbiesinger@google.com>! — nico / ViewSVN
365691. [OPENMP]Remove not used check line from the test, NFC. — abataev / ViewSVN
365690. [AArch64][GlobalISel] Optimize compare and branch cases with G_INTTOPTR and unknown values.
        
        Since we have distinct types for pointers and scalars, G_INTTOPTRs can sometimes
        obstruct attempts to find constant source values. These usually come about when
        try to do some kind of null pointer check. Teaching getConstantVRegValWithLookThrough
        about this operation allows the CBZ/CBNZ optimization to catch more cases.
        
        This change also improves the case where we can't find a constant source at all.
        Previously we would emit a cmp, cset and tbnz for that. Now we try to just emit
        a cmp and conditional branch, saving an instruction.
        
        The cumulative code size improvement of this change plus D64354 is 5.5% geomean
        on arm64 CTMark -O0.
        
        Differential Revision: https://reviews.llvm.org/D64377 — aemerson / ViewSVN
365689. gn build: Merge r365687 — nico / ViewSVN
365687. [clang-doc] Add a structured HTML generator
        
        Implements an HTML generator.
        Nodes are used to represent each part of the HTML file. There are TagNodes that
        represent every HTML tag (p, h1, div, ...) and they have children nodes, which
        can be TagNodes or TextNodes (these nodes only have text).
        Proper indentation is rendered within the files generated by tool.
        No styling (CSS) is included.
        
        Committed on behalf of Diego Astiazarán (diegoaat97@gmail.com)
        
        Differential Revision: https://reviews.llvm.org/D63857 — juliehockett / ViewSVN
365685. Revert "[ELF] Loose a condition for relocation with a symbol"
        
        This reverts commit 8507eca1647118e73435b0ce1de8a1952a021d01.
        
        Reveting due to some suspicious failurse in santizer-x86_64-linux. — nikolaprica / ViewSVN
365684. [GlobalISel][AArch64] Use getOpcodeDef instead of findMIFromReg
        
        Some minor cleanup.
        
        This function in Utils does the same thing as `findMIFromReg`. It also looks
        through copies, which `findMIFromReg` didn't.
        
        Delete `findMIFromReg` and use `getOpcodeDef` instead. This only happens in
        `tryOptVectorDup` right now.
        
        Update opt-shuffle-splat to show that we can look through the copies now, too.
        
        Differential Revision: https://reviews.llvm.org/D64520 — paquette / ViewSVN
365683. [GlobalISel][AArch64][NFC] Use getDefIgnoringCopies from Utils where we can
        
        There are a few places where we walk over copies throughout
        AArch64InstructionSelector.cpp. In Utils, there's a function that does exactly
        this which we can use instead.
        
        Note that the utility function works with the case where we run into a COPY
        from a physical register. We've run into bugs with this a couple times, so using
        it should defend us from similar future bugs.
        
        Also update opt-fold-compare.mir to show that we still handle physical registers
        properly.
        
        Differential Revision: https://reviews.llvm.org/D64513 — paquette / ViewSVN
365682. Update libc++ include path detection to use VFS on Linux
        
        The DetectLibcxxIncludePath function had been using
        llvm::sys::fs::directory_iterator, and this updates it to use
        llvm::vfs::directory_iterator.
        
        Differential Revision: https://reviews.llvm.org/D64381 — juliehockett / ViewSVN
365681. [TSan] Attempt to fix linker error on Linux/AArch64 — yln / ViewSVN
365680. Revert "[System Model] [TTI] Update cache and prefetch TTI interfaces"
        
        This broke some PPC prefetching tests.
        
        This reverts commit 9fdfb045ae8bb643ab0d0455dcf9ecaea3b1eb3c. — greened / ViewSVN
365679. Move three folds for FADD, FSUB and FMUL in the DAG combiner away from Unsafe to more aligned checks that reflect context
        
        Summary: Unsafe does not map well alone for each of these three cases as it is missing NoNan context when accessed directly with clang.  I have migrated the fold guards to reflect the expectations of handing nan and zero contexts directly (NoNan, NSZ) and some tests with it.  Unsafe does include NSZ, however there is already precedent for using the target option directly to reflect that context.
        
        Reviewers: spatel, wristow, hfinkel, craig.topper, arsenm
        
        Reviewed By: arsenm
        
        Subscribers: michele.scandale, wdng, javed.absar
        
        Differential Revision: https://reviews.llvm.org/D64450 — mcberg2017 / ViewSVN
365678. Revert "[clangd] Filter out non-governed files from broadcast"
        
        This reverts commit d5214dfa7b5650745eaeb102857c9e90adb16137.
        
        It's causing failures, both in our local CI and the PS4 Windows bot.
        
        http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/26872/steps/test/logs/stdio — ormris / ViewSVN
365676. [System Model] [TTI] Update cache and prefetch TTI interfaces
        
        Rework the TTI cache and software prefetching APIs to prepare for the
        introduction of a general system model.  Changes include:
        
        - Marking existing interfaces const and/or override as appropriate
        - Adding comments
        - Adding BasicTTIImpl interfaces that delegate to a subtarget
          implementation
        - Adding a default "no information" subtarget implementation
        
        Only a handful of targets use these interfaces currently: AArch64,
        Hexagon, PPC and SystemZ.  AArch64 already has a custom subtarget
        implementation, so its custom TTI implementation is migrated to use
        the new facilities in BasicTTIImpl to invoke its custom subtarget
        implementation.  The custom TTI implementations continue to exist for
        the other targets with this change.  They are not moved over to
        subtarget-based implementations.
        
        The end goal is to have the default subtarget implementation defer to
        the system model defined by the target.  With this change, the default
        subtarget implementation essentially returns "no information" for
        these interfaces.  None of the existing users of TTI will hit that
        implementation because they define their own custom TTI
        implementations and won't use the BasicTTIImpl implementations.
        
        Once system models are in place for the targets that use these
        interfaces, their custom TTI implementations can be removed.
        
        Differential Revision: https://reviews.llvm.org/D63614 — greened / ViewSVN
365675. Recommit "[CommandLine] Remove OptionCategory and SubCommand caches from the Option class."
        
        Previously reverted in 364141 due to buildbot breakage, and fixed here
        by making GeneralCategory global a ManagedStatic.
        
        Summary:
        This change processes `OptionCategory`s and `SubCommand`s as they
        are seen instead of caching them in the Option class and processing
        them later.  Doing so simplifies the work needed to be done by the Global
        parser and significantly reduces the size of the Option class to a mere 64
        bytes.
        
        Removing  the `OptionCategory` cache saved 24 bytes, and removing
        the `SubCommand` cache saved an additional 48 bytes, for a total of a
        72 byte reduction.
        
        Reviewed By: serge-sans-paille
        
        Tags: #llvm, #clang
        
        Differential Revision: https://reviews.llvm.org/D62105 — dhinton / ViewSVN
365674. [X86] EltsFromConsecutiveLoads - clean up element size calcs. NFCI.
        
        Determine the element/load size calculations earlier and assert that they are whole bytes in size. — rksimon / ViewSVN
365672. [LoopRotate + MemorySSA] Keep an <instruction-cloned instruction> map.
        
        Summary:
        The map kept in loop rotate is used for instruction remapping, in order
        to simplify the clones of instructions. Thus, if an instruction can be
        simplified, its simplified value is placed in the map, even when the
        clone is added to the IR. MemorySSA in contrast needs to know about that
        clone, so it can add an access for it.
        To resolve this: keep a different map for MemorySSA.
        
        Reviewers: george.burgess.iv
        
        Subscribers: jlebar, Prazek, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63680 — asbirlea / ViewSVN

#18423 (Jul 10, 2019 11:09:13 AM)

365647. [Remarks] Add cl::Hidden to -remarks-yaml-string-table
        
        It was showing up in a lot of unrelated tools. — thegameg / ViewSVN
365645. docs/GithubMove.rst: Remove obsolete information
        
        Summary:
        Remove references to the multirepo and update the document to
        reflect the current state of the github repository.
        
        Reviewers: mehdi_amini, jyknight
        
        Subscribers: jdoerfert, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D58420 — tstellar / ViewSVN
365644. [FileCheck] Use bool operator to test Expected
        
        Use bool() consistently to get boolean value of Error, Optional and
        Expected types in EXPECT calls. While static_cast is used in all cases
        but one, bool provides more clarity and makes more sense as a new
        default. — thopre / ViewSVN
365643. [AMDGPU] Increased the number of implicit argument bytes for both OpenCL and HIP (CLANG).
        
        To enable a new implicit kernel argument,
        increased the number of argument bytes from 48 to 56.
        
        Reviewed By: yaxunl
        
        Differential Revision: https://reviews.llvm.org/D63756 — cdevadas / ViewSVN
365641. [NFC][InstCombine] Redundant masking before left-shift (PR42563)
        
        alive proofs:
        a,b:     https://rise4fun.com/Alive/4zsf
        c,d,e,f: https://rise4fun.com/Alive/RC49
        
        Indeed, not all of these patterns are canonical.
        But since this fold will only produce a single instruction
        i'm really interested in handling even uncanonical patterns.
        
        Other than these 6 patterns, i can't think of any other
        reasonable variants right now, although i'm sure they exist.
        
        For now let's start with patterns where both shift amounts are variable,
        with trivial constant "offset" between them, since i believe this is
        both simplest to handle and i think this is most common.
        But again, there are likely other variants where we could use
        ValueTracking/ConstantRange to handle more cases.
        
        https://bugs.llvm.org/show_bug.cgi?id=42563 — lebedevri / ViewSVN
365640. [AMDGPU] Allow abs/neg source modifiers on v_cndmask_b32
        
        Summary:
        D59191 added support for these modifiers in the assembler and
        disassembler. This patch just teaches instruction selection that it can
        use them.
        
        Reviewers: arsenm, tstellar
        
        Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, hiraditya, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64497 — foad / ViewSVN
365639. [analyzer]Add user docs rst
        
        Summary:
        Add user documentation page. This is an empty page atm, later patches will add
        the specific user documentatoins.
        
        Reviewers: dkrupp
        
        Subscribers: whisperity, xazax.hun, baloghadamsoftware, szepet, rnkovacs, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, gamesh411, Charusso, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64494 — martong / ViewSVN
365638. Remove two unused member variables.
        
        They were added over 10 years ago in r66575 and have never been used as
        far as I can tell.
        
        (r67087 added similar fields to Compilation, and those are used.) — nico / ViewSVN
365637. [InstCombine] pow(C,x) -> exp2(log2(C)*x)
        
        Summary:
        Transform
        pow(C,x)
        
        To
        exp2(log2(C)*x)
        
        if C > 0, C != inf, C != NaN (and C is not power of 2, since we have some fold for such case already).
        
        log(C) is folded by the compiler and exp2 is much faster to compute than pow.
        
        Reviewers: spatel, efriedma, evandro
        
        Reviewed By: evandro
        
        Subscribers: lebedev.ri, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64099 — xbolva00 / ViewSVN
365636. [InferFunctionAttrs] add/adjust tests for dereferenceable; NFC
        
        Based on review comments for D64258. — spatel / ViewSVN
365634. [clangd] Filter out non-governed files from broadcast
        
        Summary:
        This also turns off implicit discovery of additional compilation
        databases.
        
        Reviewers: sammccall
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64247 — kadircet / ViewSVN
365633. gn build: Merge r365585 — nico / ViewSVN
365632. [clangd] Trim spaces around parsed include in include extractor — kadircet / ViewSVN
365631. [clangd] Add a flag to clangdServer rename function to control whether we want format the replacements.
        
        Summary:
        This would allow clangd embedders to use the ClangdServer::rename for other
        purposes (highlighting all the occurrences of the symbol in prepare
        stage).
        
        Reviewers: sammccall, ilya-biryukov
        
        Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64481 — hokein / ViewSVN
365630. [docs][llvm-symbolizer] Fix grammar — jhenderson / ViewSVN
365629. Loop pragma parsing. NFC.
        
        I would like to add some pragma handling here, but couldn't resist a little NFC
        and tidy up first.
        
        Differential Revision: https://reviews.llvm.org/D64471 — sjoerdmeijer / ViewSVN
365628. [X86] EltsFromConsecutiveLoads - cleanup Zero/Undef/Load element collection. NFCI. — rksimon / ViewSVN
365627. [MIPS GlobalISel] Select float and double phi
        
        Select float and double phi for MIPS32.
        
        Differential Revision: https://reviews.llvm.org/D64420 — petar.avramovic / ViewSVN
365626. [MIPS GlobalISel] Select float and double load and store
        
        Select float and double load and store for MIPS32.
        
        Differential Revision: https://reviews.llvm.org/D64419 — petar.avramovic / ViewSVN
365625. [FileCheck] Simplify numeric variable interface
        
        Summary:
        This patch simplifies 2 aspects in the FileCheckNumericVariable code.
        
        First, setValue() method is turned into a void function since being
        called only on undefined variable is an invariant and is now asserted
        rather than returned. This remove the assert from the callers.
        
        Second, clearValue() method is also turned into a void function since
        the only caller does not check its return value since it may be trying
        to clear the value of variable that is already cleared without this
        being noteworthy.
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: JonChesterfield, rogfer01, hfinkel, kristina, rnk, tra, arichardson, grimar, dblaikie, probinson, llvm-commits, hiraditya
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64231
        
        llvm-svn: 365249 — thopre / ViewSVN
365624. [FileCheck] Fix @LINE value after match failure
        
        Summary:
        The value of the FileCheckNumericVariable class instance representing
        the @LINE numeric variable is set and cleared respectively before and
        after substitutions are made, if any. However, when a substitution
        fails, the value is not cleared. This causes the next substitution of
        @LINE later on to give the wrong value since setValue is a nop if the
        value is already set. This is what caused failures after commit r365249.
        
        Reviewers: jhenderson, chandlerc, jdenny, probinson, grimar, arichardson, rnk
        
        Subscribers: hiraditya, llvm-commits, probinson, dblaikie, grimar, arichardson, tra, rnk, kristina, hfinkel, rogfer01, JonChesterfield
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64449 — thopre / ViewSVN
365623. [NFC][ARM] Convert lambdas to static helpers
        
        Break up and convert some of the lambdas in ARMLowOverheadLoops into
        static functions. — sam_parker / ViewSVN
365622. [X86] EltsFromConsecutiveLoads - LDBase is non-null. NFCI.
        
        Don't bother checking for LDBase != null - it should be (and we assert that it is). — rksimon / ViewSVN
365621. [DAGCombine] visitINSERT_SUBVECTOR - use uint64_t subvector index. NFCI.
        
        Keep the uint64_t type from getZExtValue() to stop truncation/extension overflow warnings in MSVC in subvector index math. — rksimon / ViewSVN
365620. [X86] EltsFromConsecutiveLoads - store Loads on a per-element basis. NFCI.
        
        Cache the LoadSDNode nodes so we can easily map to/from the element index instead of packing them together - this will be useful for future patches for PR16739 etc. — rksimon / ViewSVN
365618. [ELF] Loose a condition for relocation with a symbol
        
        Deleted code was introduced as a work around for a bug in the gold linker
        (http://sourceware.org/PR16794). Test case that was given as a reason for
        this part of code, the one on previous link, now works for the gold.
        This condition is too strict and when a code is compiled with debug info
        it forces generation of numerous relocations with symbol for architectures
        that do not have relocation addend.
        
        Reviewers: arsenm, espindola
        
        Reviewed By: MaskRay
        
        Differential Revision: https://reviews.llvm.org/D64327 — nikolaprica / ViewSVN
365614. [X86][SSE] EltsFromConsecutiveLoads - add basic dereferenceable support
        
        This patch checks to see if the vector element loads are based off a dereferenceable pointer that covers the entire vector width, in which case we don't need to have element loads at both extremes of the vector width - just the start (base pointer) of it.
        
        Another step towards partial vector loads......
        
        Differential Revision: https://reviews.llvm.org/D64205 — rksimon / ViewSVN
365613. Fix const/non-const lambda return type warning. NFCI. — rksimon / ViewSVN
365612. Fix "result of 32-bit shift implicitly converted to 64 bits" warning. NFCI. — rksimon / ViewSVN
365611. [SimpleLoopUnswitch] Don't consider unswitching `switch` insructions with one unique successor
        
        Only instructions with two or more unique successors should be considered for unswitching.
        
        Patch Author: Daniil Suchkov.
        
        Reviewers: reames, asbirlea, skatkov
        Reviewed By: skatkov
        Subscribers: hiraditya, llvm-commits
        Differential Revision: https://reviews.llvm.org/D64404 — skatkov / ViewSVN
365609. [AArch64] Fix vector vuqadd intrinsics operands
        
        Summary:
        Change the vuqadd vector instrinsics to have the second argument as unsigned values, not signed,
        accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics
        
        Reviewers: LukeCheeseman, ostannard
        
        Reviewed By: ostannard
        
        Subscribers: javed.absar, kristof.beyls, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64211 — dnsampaio / ViewSVN
365608. [NFC][AArch64] Fix vector vsqadd intrinsics operands
        
        Summary:
        Change the vsqadd vector instrinsics to have the second argument as signed values, not unsigned,
        accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics
        
        Reviewers: LukeCheeseman, ostannard
        
        Reviewed By: ostannard
        
        Subscribers: javed.absar, kristof.beyls, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64210 — dnsampaio / ViewSVN
365607. [clangd] Stop recording tokens before running clang-tidy
        
        modernize-trailing-return-type runs the preprocessor, breaking the token
        collection logic.
        
        This lead to a crash before, see the new test for a repro. — ibiryukov / ViewSVN
365606. [clangd] Consume error to avoid assertion failures
        
        When we fail to calculate #include insertion for a completion item.
        Note that this change does not add a test, although that would be good. — ibiryukov / ViewSVN

#18421 (Jul 10, 2019 3:57:59 AM)

365604. [ARM] Enable VPUSH/VPOP aliases when either MVE or VFP is present
        
        Summary:
        Use the same predicates as VSTMDB/VLDMIA since VPUSH/VPOP alias to
        these.
        
        Patch by Momchil Velikov.
        
        Reviewers: ostannard, simon_tatham, SjoerdMeijer, samparker, t.p.northover, dmgreen
        
        Reviewed By: dmgreen
        
        Subscribers: javed.absar, kristof.beyls, hiraditya, dmgreen, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64413 — miyuki / ViewSVN
365603. [docs][llvm-dwarfdump] Normalise some wording — jhenderson / ViewSVN
365602. [clangd] Added highlighting for class and enum types.
        
        Summary: Added highlighting for non-builtin types using VisitTypeLoc. Ignoring namespace qualifiers as for now.
        
        Reviewers: hokein, sammccall, ilya-biryukov
        
        Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64257 — jvikstrom / ViewSVN
365601. [test/Object/nm-trivial-object.test] - Remove 4 precompiled binaries.
        
        This converts 5 precompiled binaries to YAMLs,
        removes 4 from inputs and performs a cleanup.
        
        Differential revision: https://reviews.llvm.org/D64246 — grimar / ViewSVN
365600. [SimpleLoopUnswitch] Add a test case exposing a bug
        
        This test exposes a bug in SimpleLoopUnswitch that leads to a crash on
        assert(SuccessorsCount > 1 && "Cannot unswitch a condition without multiple distinct successors!");
        when SimpleLoopUnswitch considers unswitching of a loop by a switch with one successor.
        
        Fix will be submitted soon.
        
        Patch Author: Daniil Suchkov.
        
        Reviewers: reames, asbirlea, skatkov
        Reviewed By: skatkov
        Subscribers: zzheng, llvm-commits
        Differential Revision: https://reviews.llvm.org/D64403 — skatkov / ViewSVN
365599. [Syntax] Add assertion to catch invalid tokens early. NFC
        
        To help with identifiying root cause of a crash we are seeing. — ibiryukov / ViewSVN
365598. [NFC][AArch64] Fix vector vqtb[lx][1-4]_s8 operand
        
        Summary:
        Change the vqtb[lx][1-4]_s8 instrinsics to have the last argument as vector of unsigned valuse, not
        signed, accordingly to https://developer.arm.com/architectures/instruction-sets/simd-isas/neon/intrinsics
        
        Reviewers: LukeCheeseman, DavidSpickett
        
        Reviewed By: DavidSpickett
        
        Subscribers: DavidSpickett, javed.absar, kristof.beyls, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64243 — dnsampaio / ViewSVN
365597. Silence gcc warning by adding parentheses to condition [NFC]
        
        Without this gcc 7.4.0 complains with
        
          ../include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:457:54: error: suggest parentheses around '&&' within '||' [-Werror=parentheses]
                            isArtifactCast(TmpDef->getOpcode()) &&
                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
                                "Expecting copy or artifact cast here");
                                ~ — uabelho / ViewSVN

#18420 (Jul 9, 2019 11:45:16 PM)

365594. Fix modular build issues caused by BitCodes.h
        
        Consolidate llvm::BWH_* statics into an enum to fix
        module build issues. This fixes the LLVM_Bitcode module,
        getting rid of -Wmodules-ambiguous-internal-linkage.
        
        Differential Revision: https://reviews.llvm.org/D64469 — Kristina Brooks / ViewSVN
365591. [ubsan][test] Restore float-divide-by-zero test
        
        Removed by rCTE365307 to fix buildbots. It can be restored now because D64317/rC365587 brought back -fsanitize=float-divide-by-zero — maskray / ViewSVN
365590. [analyzer] CastValueChecker: Remove a dump()
        
        Summary: Fix a nit. — charusso / ViewSVN

#18419 (Jul 9, 2019 6:52:20 PM)

365589. [X86] Limit getTargetConstantFromNode to only work on NormalLoads not extending loads.
        
        This seems to fix a failure reported by Jordan Rupprecht, but we
        don't have a reduced test case yet. — ctopper / ViewSVN
365588. [Support] Move llvm::MemoryBuffer to sys::fs::file_t
        
        Summary:
        On Windows, Posix integer file descriptors are a compatibility layer
        over native file handles provided by the C runtime. There is a hard
        limit on the maximum number of file descriptors that a process can open,
        and the limit is 8192. LLD typically doesn't run into this limit because
        it opens input files, maps them into memory, and then immediately closes
        the file descriptor. This prevents it from running out of FDs.
        
        For various reasons, I'd like to open handles to every input file and
        keep them open during linking. That requires migrating MemoryBuffer over
        to taking open native file handles instead of integer FDs.
        
        Reviewers: aganea, Bigcheese
        
        Reviewed By: aganea
        
        Subscribers: smeenai, silvas, mehdi_amini, hiraditya, steven_wu, dexonsmith, dang, llvm-commits, zturner
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63453 — rnk / ViewSVN
365587. [Driver] Add float-divide-by-zero back to supported sanitizers after D63793/rC365272
        
        D63793 removed float-divide-by-zero from the "undefined" set but it
        failed to add it to getSupportedSanitizers(), thus the sanitizer is
        rejected by the driver:
        
            clang-9: error: unsupported option '-fsanitize=float-divide-by-zero' for target 'x86_64-unknown-linux-gnu'
        
        Also, add SanitizerMask::FloatDivideByZero to a few other masks to make -fsanitize-trap, -fsanitize-recover, -fsanitize-minimal-runtime and -fsanitize-coverage work.
        
        Reviewed By: rsmith, vitalybuka
        
        Differential Revision: https://reviews.llvm.org/D64317 — maskray / ViewSVN
365586. AMDGPU/GlobalISel: Add support for wide loads >= 256-bits
        
        Summary:
        This adds support for the most commonly used wide load types:
        <8xi32>, <16xi32>, <4xi64>, and <8xi64>
        
        Reviewers: arsenm
        
        Reviewed By: arsenm
        
        Subscribers: hiraditya, kzhuravl, jvesely, wdng, nhaehnle, yaxunl, rovka, kristof.beyls, dstuttard, tpr, t-tye, volkan, Petar.Avramovic, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D57399 — tstellar / ViewSVN
365585. [analyzer] CastValueChecker: Model casts
        
        Summary:
        It models the LLVM casts:
        - `cast<>`
        - `dyn_cast<>`
        - `cast_or_null<>`
        - `dyn_cast_or_null<>`
        
        It has a very basic support without checking the `classof()` function.
        
        (It reapplies the reverted 'llvm-svn: 365582' patch with proper test file.)
        
        Reviewed By: NoQ
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64374 — charusso / ViewSVN
365584. Revert "[analyzer] CastValueChecker: Model casts"
        
        This reverts commit 27cf6664437efd640bb6db5594bafcce68fa2854. — charusso / ViewSVN
365583. GlobalISel: Implement lower for G_FCOPYSIGN
        
        In SelectionDAG AMDGPU treated these as legal, but this was mostly
        because the bitcasts required for FP types were painful. Theoretically
        the bitpattern should eventually match to bfi, so don't bother trying
        to get the patterns to import. — arsenm / ViewSVN
365582. [analyzer] CastValueChecker: Model casts
        
        Summary:
        It models the LLVM casts:
        - `cast<>`
        - `dyn_cast<>`
        - `cast_or_null<>`
        - `dyn_cast_or_null<>`
        
        It has a very basic support without checking the `classof()` function.
        
        Reviewed By: NoQ
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64374 — charusso / ViewSVN
365581. Revert [clang] DirectoryWatcher
        
        This reverts r365574 (git commit 31babea94a3ed38a140540f2252cf043dacec1f7) — rnk / ViewSVN
365580. [Bitcode] Explicitly include Bitstream/BitCodes.h and BitstreamWriter.h
        
        This fixes a modules issue. — thegameg / ViewSVN
365579. [MS] Treat ignored explicit calling conventions as an explicit __cdecl
        
        The CCCR_Ignore action is only used for Microsoft calling conventions,
        mainly because MSVC does not warn when a calling convention would be
        ignored by the current target. This behavior is actually somewhat
        important, since windows.h uses WINAPI (which expands to __stdcall)
        widely. This distinction didn't matter much before the introduction of
        __vectorcall to x64 and the ability to make that the default calling
        convention with /Gv. Now, we can't just ignore __stdcall for x64, we
        have to treat it as an explicit __cdecl annotation.
        
        Fixes PR42531 — rnk / ViewSVN
365578. [docs][Remarks] Add documentation for remarks in LLVM
        
        This adds documentation that describes remarks in LLVM.
        
        It aims at explaining what remarks are, how to enable them, and what
        users can do with the different modes.
        
        It lists all the available flags in LLVM (excluding clang), and
        describes the expected YAML structure as well as the tools that support
        the YAML format today.
        
        Differential Revision: https://reviews.llvm.org/D64355 — thegameg / ViewSVN
365577. [X86] Don't form extloads in combineExtInVec unless the load extension is legal.
        
        This should prevent doing this on pre-sse4.1 targets or for 256
        bit vectors without avx2.
        
        I don't know of a failure from this. Op legalization will probably
        take care of, but seemed better to be safe. — ctopper / ViewSVN
365576. [clangd] fix assert in test after r365531.
        
        Unverified because CMake/ninja seems to be broken... — sammccall / ViewSVN
365575. AMDGPU/GlobalISel: Fix legality for G_BUILD_VECTOR — arsenm / ViewSVN
365574. [clang] DirectoryWatcher
        
        Asynchronously monitors specified directory for changes and passes notifications to provided callback.
        
        Dependency for index-while-building.
        
        Differential Revision: https://reviews.llvm.org/D58418 — Jan Korous / ViewSVN
365573. [AMDGPU] gfx908 v_pk_fmac_f16 support
        
        Differential Revision: https://reviews.llvm.org/D64433 — rampitec / ViewSVN
365572. gn build: Merge r365536. — pcc / ViewSVN
365571. gn build: Merge r365532. — pcc / ViewSVN
365570. gn build: Merge r365541. — pcc / ViewSVN
365569. gn build: Merge r365531. — pcc / ViewSVN
365568. Add lldb type unit support to the release notes
        
        Reviewers: JDevlieghere, teemperor
        
        Subscribers: llvm-commits, lldb-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64366 — labath / ViewSVN
365566. GlobalISel: Combine unmerge of merge with intermediate cast
        
        This eliminates some illegal intermediate vectors when operations are
        scalarized. — arsenm / ViewSVN
365565. [Profile] Support raw/indexed profiles larger than 4GB
        
        rdar://45955976 — Vedant Kumar / ViewSVN
365564. [llvm-objdump] Keep warning for --disassemble-functions in correct order.
        
        relative to normal output when dumping archive files.
        
        prepare for PR35351.
        
        Reviewers: jhenderson, grimar, MaskRay, rupprecht
        
        Reviewed by: MaskRay, jhenderson
        
        Differential Revision: https://reviews.llvm.org/D64165 — yuanfang / ViewSVN
365563. [AMDGPU] gfx908 mAI instructions, MC part
        
        Differential Revision: https://reviews.llvm.org/D64446 — rampitec / ViewSVN
365562. build: use multiple `install` rather than building up a list
        
        Rather than building up a list to iterate over later, just create multiple
        install commands based on the configuration. This makes it easier to see what
        is getting installed and allows for the install handling to be centralised. NFC — Saleem Abdulrasool / ViewSVN
365560. Reland "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8"
        
        Fix compilation errors related to `SANITIZER_GO` `#ifdef`s.
        
        Refine longjmp key management.  For Linux, re-implement key retrieval in
        C (instead of assembly).  Removal of `InitializeGuardPtr` and a final
        round of cleanups will be done in the next commit.
        
        Reviewed By: dvyukov
        
        Differential Revision: https://reviews.llvm.org/D64092
        
        llvm-svn: 365513 — yln / ViewSVN
365558. XFAIL clang/test/Headers/max_align.c on i686 — andusy / ViewSVN
365557. Use the Itanium C++ ABI for the pipe_builtin.cl test
        
        Certain OpenCL constructs cannot yet be mangled in the MS C++ ABI.
        Add a FIXME for it if anyone cares to implement it. — rnk / ViewSVN
365556. De-templatize non-dependent VS macro logic, NFC
        
        These macro definitions don't depend on the template parameter, so they
        don't need to be part of the template. Move them to a .cpp file. — rnk / ViewSVN
365555. [CXX] Exercise all paths through these tests.
        
        Differential Revision: https://reviews.llvm.org/D63894 — probinson / ViewSVN
365554. [TSan] Refine longjmp key management on Darwin
        
        NFC. — yln / ViewSVN

#18418 (Jul 9, 2019 3:04:13 PM)

365552. [SLP] Optimize getSpillCost(); NFCI
        
        For a given set of live values, the spill cost will always be the
        same for each call. Compute the cost once and multiply it by the
        number of calls.
        
        (I'm not sure this spill cost modeling makes sense if there are
        multiple calls, as the spill cost will likely be shared across
        calls in that case. But that's how it currently works.) — nikic / ViewSVN
365551. hwasan: Improve precision of checks using short granule tags.
        
        A short granule is a granule of size between 1 and `TG-1` bytes. The size
        of a short granule is stored at the location in shadow memory where the
        granule's tag is normally stored, while the granule's actual tag is stored
        in the last byte of the granule. This means that in order to verify that a
        pointer tag matches a memory tag, HWASAN must check for two possibilities:
        
        * the pointer tag is equal to the memory tag in shadow memory, or
        * the shadow memory tag is actually a short granule size, the value being loaded
          is in bounds of the granule and the pointer tag is equal to the last byte of
          the granule.
        
        Pointer tags between 1 to `TG-1` are possible and are as likely as any other
        tag. This means that these tags in memory have two interpretations: the full
        tag interpretation (where the pointer tag is between 1 and `TG-1` and the
        last byte of the granule is ordinary data) and the short tag interpretation
        (where the pointer tag is stored in the granule).
        
        When HWASAN detects an error near a memory tag between 1 and `TG-1`, it
        will show both the memory tag and the last byte of the granule. Currently,
        it is up to the user to disambiguate the two possibilities.
        
        Because this functionality obsoletes the right aligned heap feature of
        the HWASAN memory allocator (and because we can no longer easily test
        it), the feature is removed.
        
        Also update the documentation to cover both short granule tags and
        outlined checks.
        
        Differential Revision: https://reviews.llvm.org/D63908 — pcc / ViewSVN
365550. [PoisonChecking] Flesh out complete todo list for full coverage
        
        Note: I don't actually plan to implement all of the cases at the moment, I'm just documenting them for completeness.  There's a couple of cases left which are practically useful for me in debugging loop transforms, and I'll probably stop there for the moment. — reames / ViewSVN
365549. [X86][AMDGPU][DAGCombiner] Move call to allowsMemoryAccess into isLoadBitCastBeneficial/isStoreBitCastBeneficial to allow X86 to bypass it
        
        Basically the problem is that X86 doesn't set the Fast flag from
        allowsMemoryAccess on certain CPUs due to slow unaligned memory
        subtarget features. This prevents bitcasts from being folded into
        loads and stores. But all vector loads and stores of the same width
        are the same cost on X86.
        
        This patch merges the allowsMemoryAccess call into isLoadBitCastBeneficial to allow X86 to skip it.
        
        Differential Revision: https://reviews.llvm.org/D64295 — ctopper / ViewSVN
365548. Fix build error for VC STL, use llvm::make_unique — rnk / ViewSVN
365546. [AMDGPU] gfx908 register file changes
        
        Differential Revision: https://reviews.llvm.org/D64438 — rampitec / ViewSVN
365545. [OpenMP] Simplify getFloatTypeSemantics
        
        When the float point representations are the same on the host and on the target device,
        (`&Target->getLongDoubleFormat() == &AuxTarget->getLongDoubleFormat()`),
        we can just use `AuxTarget->getLongDoubleFormat()`.
        
        Reviewed By: ABataev
        
        Differential Revision: https://reviews.llvm.org/D64423 — maskray / ViewSVN
365544. [libFuzzer] Include FuzzedDataProvider.h in the test without "utils" subdir.
        
        Summary:
        This way the test would better match the intended usage of the header,
        plus it makes some additional testing (e.g. in CI) a bit easier to set up.
        
        Reviewers: morehouse
        
        Reviewed By: morehouse
        
        Subscribers: mgorny, delcypher, #sanitizers, llvm-commits
        
        Tags: #llvm, #sanitizers
        
        Differential Revision: https://reviews.llvm.org/D64440 — dor1s / ViewSVN
365543. [PoisonCheker] Support for out of bounds operands on shifts + insert/extractelement
        
        These are sources of poison which don't come from flags, but are clearly documented in the LangRef.  Left off support for scalable vectors for the moment, but should be easy to add if anyone is interested. — reames / ViewSVN
365541. Boilerplate for producing XCOFF object files from the PowerPC backend.
        
        Stubs out a number of the classes needed to produce a new object file format
        (XCOFF) for the powerpc-aix target. For testing input is an empty module which
        produces an object file with just a file header.
        
        Differential Revision: https://reviews.llvm.org/D61694 — sfertile / ViewSVN
365540. [X86] LowerToHorizontalOp - use count_if to count non-UNDEF ops. NFCI. — rksimon / ViewSVN
365538. [PoisonChecking] Add validation rules for "exact" on sdiv/udiv
        
        As directly stated in the LangRef, no ambiguity here... — reames / ViewSVN
365537. [ThinLTO] only emit used or referenced CFI records to index
        
        Summary: We emit CFI_FUNCTION_DEFS and CFI_FUNCTION_DECLS to
        distributed ThinLTO indices to implement indirect function call
        checking.  This change causes us to only emit entries for functions
        that are either defined or used by the module we're writing the index
        for (instead of all functions in the combined index), which can make
        the indices substantially smaller.
        
        Fixes PR42378.
        
        Reviewers: pcc, vitalybuka, eugenis
        
        Subscribers: mehdi_amini, hiraditya, dexonsmith, arphaman, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D63887 — inglorion / ViewSVN
365536. Add a transform pass to make the executable semantics of poison explicit in the IR
        
        Implements a transform pass which instruments IR such that poison semantics are made explicit. That is, it provides a (possibly partial) executable semantics for every instruction w.r.t. poison as specified in the LLVM LangRef. There are obvious parallels to the sanitizer tools, but this pass is focused purely on the semantics of LLVM IR, not any particular source language.
        
        The target audience for this tool is developers working on or targetting LLVM from a frontend. The idea is to be able to take arbitrary IR (with the assumption of known inputs), and evaluate it concretely after having made poison semantics explicit to detect cases where either a) the original code executes UB, or b) a transform pass introduces UB which didn't exist in the original program.
        
        At the moment, this is mostly the framework and still needs to be fleshed out. By reusing existing code we have decent coverage, but there's a lot of cases not yet handled. What's here is good enough to handle interesting cases though; for instance, one of the recent LFTR bugs involved UB being triggered by integer induction variables with nsw/nuw flags would be reported by the current code.
        
        (See comment in PoisonChecking.cpp for full explanation and context)
        
        Differential Revision: https://reviews.llvm.org/D64215 — reames / ViewSVN
365535. Try to appease the Windows build bots.
        
        Several of the conditonal operators commited in llvm-svn: 365524 fail to compile
        on the windows buildbots. Converting to an if and early return to try to fix. — sfertile / ViewSVN
365534. Revert "[TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8"
        
        This reverts commit 521f77e6351fd921f5a81027c7c72addca378989. — yln / ViewSVN
365532. [BPF] Fix a typo in the file name
        
        Fixed the file name from BPFAbstrctMemberAccess.cpp to
        BPFAbstractMemberAccess.cpp.
        
        Signed-off-by: Yonghong Song <yhs@fb.com> — yhs / ViewSVN
365531. [clangd] Rewrite of logic to rebuild the background index serving structures.
        
        Summary:
        Previously it was rebuilding every 5s by default, which was much too frequent
        in the long run - the goal was to provide an early build. There were also some
        bugs. There were also some bugs, and a dedicated thread was used in production
        but not tested.
        
        - rebuilds are triggered by #TUs built, rather than time. This should scale
           more sensibly to fast vs slow machines.
        - there are two separate indexed-TU thresholds to trigger index build: 5 TUs
           for the first build, 100 for subsequent rebuilds.
        - rebuild is always done on the regular indexing threads, and is affected by
           blockUntilIdle. This means unit/lit tests run the production configuration.
        - fixed a bug where we'd rebuild after attempting to load shards, even if there
           were no shards.
        - the BackgroundIndexTests don't really test the subtleties of the rebuild
           policy (for determinism, we call blockUntilIdle, so rebuild-on-idle is enough
           to pass the tests). Instead, we expose the rebuilder as a separate class and
           have fine-grained tests for it.
        
        Reviewers: kadircet
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, jfb, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64291 — sammccall / ViewSVN

#18417 (Jul 9, 2019 2:00:03 PM)

365530. gn build: Merge r365503. — pcc / ViewSVN
365529. [unittest] Add the missing bogus machine register info initialization. — hliao / ViewSVN
365528. [AMDGPU] gfx908 clang target
        
        Differential Revision: https://reviews.llvm.org/D64430 — rampitec / ViewSVN
365525. [AMDGPU] gfx908 target
        
        Differential Revision: https://reviews.llvm.org/D64429 — rampitec / ViewSVN
365524. [Object][XCOFF] Add support for 64-bit file header and section header dumping.
        
        Adds a readobj dumper for 32-bit and 64-bit section header tables, and extend
        support for the file-header dumping to include 64-bit object files. Also
        refactors the binary file parsing to be done in a helper function in an attempt
        to cleanup error handeling.
        
        Differential Revision: https://reviews.llvm.org/D63843 — sfertile / ViewSVN
365523. [InstCombine] add tests for trunc(load); NFC
        
        I'm not sure if transforming any of these is valid as
        a target-independent fold, but we might as well have
        a few tests here to confirm or deny our position. — spatel / ViewSVN
365522. [clangd] Show documentation in hover, and fetch docs from index if needed.
        
        Summary:
        I assume showing docs is going to be part of structured hover rendering, but
        it's unclear whether that's going to make clangd 9 so this is low-hanging fruit.
        
        (Also fixes a bug uncovered in FormattedString's plain text output: need blank
        lines when text follows codeblocks)
        
        Reviewers: kadircet
        
        Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64296 — sammccall / ViewSVN
365521. AMDGPU: Fix test failing since r365512 — arsenm / ViewSVN
365520. Revert "[HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()"
        
        This reverts commit d95557306585404893d610784edb3e32f1bfce18. — jsji / ViewSVN
365519. Add lit.local.cfg to llvm-objdump tests
        
        Add configuration file to llvm-objdump tests to treat files with .yaml
        extension as tests. — steven_wu / ViewSVN
365518. [ObjC] Add a warning for implicit conversions of a constant non-boolean value to BOOL
        
        rdar://51954400
        
        Differential revision: https://reviews.llvm.org/D63912 — epilk / ViewSVN
365517. Remove a comment that has been obsolete since r327679 — nico / ViewSVN
365516. [unittest] Add bogus register info.
        
        Reviewers: dstenb
        
        Subscribers: llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64421 — hliao / ViewSVN
365515. Rename llvm/test/tools/llvm-pdbdump to llvm/test/tools/llvm-pdbutil
        
        llvm-pdbdump was renamed to llvm-pdbutil long ago. This updates the test
        to be where you'd expect them to be. — nico / ViewSVN
365514. Make pdbdump-objfilename test work again
        
        - The test had extension .yaml, which lit doesn't execute in this
          directory. Rename to .test to make it run, and move the yaml bits
          into a dedicated file, like with all other tests in this dir.
        
        - llvm-pdbdump got renamed to llvm-pdbutil long ago, update test.
        
        - -dbi-module-info got renamed in r305032, update test for this too. — nico / ViewSVN
365513. [TSan] Improve handling of stack pointer mangling in {set,long}jmp, pt.8
        
        Refine longjmp key management.  For Linux, re-implement key retrieval in
        C (instead of assembly).  Removal of `InitializeGuardPtr` and a final
        round of cleanups will be done in the next commit.
        
        Reviewed By: dvyukov
        
        Differential Revision: https://reviews.llvm.org/D64092 — yln / ViewSVN
365512. [AMDGPU] Created a sub-register class for the return address operand in the return instruction.
        
        Function return instruction lowering, currently uses the fixed register pair s[30:31] for holding
        the return address. It can be any SGPR pair other than the CSRs. Created an SGPR pair sub-register class
        exclusive of the CSRs, and used this regclass while lowering the return instruction.
        
        Reviewed By: arsenm
        
        Differential Revision: https://reviews.llvm.org/D63924 — cdevadas / ViewSVN
365511. [RISCV] Fix ICE in isDesirableToCommuteWithShift
        
        Summary:
        There was an error being thrown from isDesirableToCommuteWithShift in
        some tests. This was tracked down to the method being called before
        legalisation, with an extended value type, not a machine value type.
        
        In the case I diagnosed, the error was only hit with an instruction sequence
        involving `i24`s in the add and shift. `i24` is not a Machine ValueType, it is
        instead an Extended ValueType which was causing the issue.
        
        I have added a test to cover this case, and fixed the error in the callback.
        
        Reviewers: asb, luismarques
        
        Reviewed By: asb
        
        Subscribers: hiraditya, rbar, johnrusso, simoncook, apazos, sabuasal, niosHD, kito-cheng, shiva0217, jrtc27, MaskRay, zzheng, edward-jones, rogfer01, MartinMosbeck, brucehoult, the_o, rkruppe, PkmX, jocewei, psnobl, benna, Jim, llvm-commits
        
        Tags: #llvm
        
        Differential Revision: https://reviews.llvm.org/D64425 — lenary / ViewSVN
365510. [AArch64][GlobalISel] Optimize conditional branches followed by unconditional branches
        
        If we have an icmp->brcond->br sequence where the brcond just branches to the
        next block jumping over the br, while the br takes the false edge, then we can
        modify the conditional branch to jump to the br's target while inverting the
        condition of the incoming icmp. This means we can eliminate the br as an
        unconditional branch to the fallthrough block.
        
        Differential Revision: https://reviews.llvm.org/D64354 — aemerson / ViewSVN
365509. Revert Revert Devirtualize destructor of final class.
        
        Revert r364359 and recommit r364100.
        
        r364100 was reverted as r364359 due to an internal test failure, but it was a
        false alarm. — yamauchi / ViewSVN
365508. [mips] Show error in case of using FP64 mode on pre MIPS32R2 CPU — atanasyan / ViewSVN
365507. [mips] Explicitly select `mips32r2` CPU for test cases require 64-bit FPU. NFC
        
        Support for 64-bit coprocessors on a 32-bit architecture
        was added in `MIPS32 R2`. — atanasyan / ViewSVN
365506. [NFC] Fixed tests — xbolva00 / ViewSVN
365504. [DAGCombine] LoadedSlice - keep getOffsetFromBase() uint64_t offset. NFCI.
        
        Keep the uint64_t type from getOffsetFromBase() to stop truncation/extension overflow warnings in MSVC in alignment math. — rksimon / ViewSVN
365503. [BPF] Support for compile once and run everywhere
        
        Introduction
        ============
        
        This patch added intial support for bpf program compile once
        and run everywhere (CO-RE).
        
        The main motivation is for bpf program which depends on
        kernel headers which may vary between different kernel versions.
        The initial discussion can be found at https://lwn.net/Articles/773198/.
        
        Currently, bpf program accesses kernel internal data structure
        through bpf_probe_read() helper. The idea is to capture the
        kernel data structure to be accessed through bpf_probe_read()
        and relocate them on different kernel versions.
        
        On each host, right before bpf program load, the bpfloader
        will look at the types of the native linux through vmlinux BTF,
        calculates proper access offset and patch the instruction.
        
        To accommodate this, three intrinsic functions
           preserve_{array,union,struct}_access_index
        are introduced which in clang will preserve the base pointer,
        struct/union/array access_index and struct/union debuginfo type
        information. Later, bpf IR pass can reconstruct the whole gep
        access chains without looking at gep itself.
        
        This patch did the following:
          . An IR pass is added to convert preserve_*_access_index to
            global variable who name encodes the getelementptr
            access pattern. The global variable has metadata
            attached to describe the corresponding struct/union
            debuginfo type.
          . An SimplifyPatchable MachineInstruction pass is added
            to remove unnecessary loads.
          . The BTF output pass is enhanced to generate relocation
            records located in .BTF.ext section.
        
        Typical CO-RE also needs support of global variables which can
        be assigned to different values to different hosts. For example,
        kernel version can be used to guard different versions of codes.
        This patch added the support for patchable externals as well.
        
        Example
        =======
        
        The following is an example.
        
          struct pt_regs {
            long arg1;
            long arg2;
          };
          struct sk_buff {
            int i;
            struct net_device *dev;
          };
        
          #define _(x) (__builtin_preserve_access_index(x))
          static int (*bpf_probe_read)(void *dst, int size, const void *unsafe_ptr) =
                  (void *) 4;
          extern __attribute__((section(".BPF.patchable_externs"))) unsigned __kernel_version;
          int bpf_prog(struct pt_regs *ctx) {
            struct net_device *dev = 0;
        
            // ctx->arg* does not need bpf_probe_read
            if (__kernel_version >= 41608)
              bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg1)->dev));
            else
              bpf_probe_read(&dev, sizeof(dev), _(&((struct sk_buff *)ctx->arg2)->dev));
            return dev != 0;
          }
        
        In the above, we want to translate the third argument of
        bpf_probe_read() as relocations.
        
          -bash-4.4$ clang -target bpf -O2 -g -S trace.c
        
        The compiler will generate two new subsections in .BTF.ext,
        OffsetReloc and ExternReloc.
        OffsetReloc is to record the structure member offset operations,
        and ExternalReloc is to record the external globals where
        only u8, u16, u32 and u64 are supported.
        
           BPFOffsetReloc Size
           struct SecLOffsetReloc for ELF section #1
           A number of struct BPFOffsetReloc for ELF section #1
           struct SecOffsetReloc for ELF section #2
           A number of struct BPFOffsetReloc for ELF section #2
           ...
           BPFExternReloc Size
           struct SecExternReloc for ELF section #1
           A number of struct BPFExternReloc for ELF section #1
           struct SecExternReloc for ELF section #2
           A number of struct BPFExternReloc for ELF section #2
        
          struct BPFOffsetReloc {
            uint32_t InsnOffset;    ///< Byte offset in this section
            uint32_t TypeID;        ///< TypeID for the relocation
            uint32_t OffsetNameOff; ///< The string to traverse types
          };
        
          struct BPFExternReloc {
            uint32_t InsnOffset;    ///< Byte offset in this section
            uint32_t ExternNameOff; ///< The string for external variable
          };
        
        Note that only externs with attribute section ".BPF.patchable_externs"
        are considered for Extern Reloc which will be patched by bpf loader
        right before the load.
        
        For the above test case, two offset records and one extern record
        will be generated:
          OffsetReloc records:
                .long   .Ltmp12                 # Insn Offset
                .long   7                       # TypeId
                .long   242                     # Type Decode String
                .long   .Ltmp18                 # Insn Offset
                .long   7                       # TypeId
                .long   242                     # Type Decode String
        
          ExternReloc record:
                .long   .Ltmp5                  # Insn Offset
                .long   165                     # External Variable
        
          In string table:
                .ascii  "0:1"                   # string offset=242
                .ascii  "__kernel_version"      # string offset=165
        
        The default member offset can be calculated as
            the 2nd member offset (0 representing the 1st member) of struct "sk_buff".
        
        The asm code:
            .Ltmp5:
            .Ltmp6:
                    r2 = 0
                    r3 = 41608
            .Ltmp7:
            .Ltmp8:
                    .loc    1 18 9 is_stmt 0        # t.c:18:9
            .Ltmp9:
                    if r3 > r2 goto LBB0_2
            .Ltmp10:
            .Ltmp11:
                    .loc    1 0 9                   # t.c:0:9
            .Ltmp12:
                    r2 = 8
            .Ltmp13:
                    .loc    1 19 66 is_stmt 1       # t.c:19:66
            .Ltmp14:
            .Ltmp15:
                    r3 = *(u64 *)(r1 + 0)
                    goto LBB0_3
            .Ltmp16:
            .Ltmp17:
            LBB0_2:
                    .loc    1 0 66 is_stmt 0        # t.c:0:66
            .Ltmp18:
                    r2 = 8
                    .loc    1 21 66 is_stmt 1       # t.c:21:66
            .Ltmp19:
                    r3 = *(u64 *)(r1 + 8)
            .Ltmp20:
            .Ltmp21:
            LBB0_3:
                    .loc    1 0 66 is_stmt 0        # t.c:0:66
                    r3 += r2
                    r1 = r10
            .Ltmp22:
            .Ltmp23:
            .Ltmp24:
                    r1 += -8
                    r2 = 8
                    call 4
        
        For instruction .Ltmp12 and .Ltmp18, "r2 = 8", the number
        8 is the structure offset based on the current BTF.
        Loader needs to adjust it if it changes on the host.
        
        For instruction .Ltmp5, "r2 = 0", the external variable
        got a default value 0, loader needs to supply an appropriate
        value for the particular host.
        
        Compiling to generate object code and disassemble:
           0000000000000000 bpf_prog:
                   0:       b7 02 00 00 00 00 00 00         r2 = 0
                   1:       7b 2a f8 ff 00 00 00 00         *(u64 *)(r10 - 8) = r2
                   2:       b7 02 00 00 00 00 00 00         r2 = 0
                   3:       b7 03 00 00 88 a2 00 00         r3 = 41608
                   4:       2d 23 03 00 00 00 00 00         if r3 > r2 goto +3 <LBB0_2>
                   5:       b7 02 00 00 08 00 00 00         r2 = 8
                   6:       79 13 00 00 00 00 00 00         r3 = *(u64 *)(r1 + 0)
                   7:       05 00 02 00 00 00 00 00         goto +2 <LBB0_3>
        
            0000000000000040 LBB0_2:
                   8:       b7 02 00 00 08 00 00 00         r2 = 8
                   9:       79 13 08 00 00 00 00 00         r3 = *(u64 *)(r1 + 8)
        
            0000000000000050 LBB0_3:
                  10:       0f 23 00 00 00 00 00 00         r3 += r2
                  11:       bf a1 00 00 00 00 00 00         r1 = r10
                  12:       07 01 00 00 f8 ff ff ff         r1 += -8
                  13:       b7 02 00 00 08 00 00 00         r2 = 8
                  14:       85 00 00 00 04 00 00 00         call 4
        
        Instructions #2, #5 and #8 need relocation resoutions from the loader.
        
        Signed-off-by: Yonghong Song <yhs@fb.com>
        
        Differential Revision: https://reviews.llvm.org/D61524 — yhs / ViewSVN
365502. [ADT] Remove MSVC-only "no two-phase name lookup" typename path.
        
        Now that we've dropped VS2015 support (D64326) we can use the regular codepath as VS2017+ correctly handles it — rksimon / ViewSVN
365501. [NFC] Added tests for D64285 — xbolva00 / ViewSVN
365500. [OpenCL][Sema] Improve address space support for blocks
        
        Summary:
        This patch ensures that the following code is compiled identically with
        -cl-std=CL2.0 and -fblocks -cl-std=c++.
        
            kernel void test(void) {
              void (^const block_A)(void) = ^{
                return;
              };
            }
        
        A new test is not added because cl20-device-side-enqueue.cl will cover
        this once blocks are further improved for C++ for OpenCL.
        
        The changes to Sema::PerformImplicitConversion are based on
        the parts of Sema::CheckAssignmentConstraints on block pointer
        conversions.
        
        Reviewers: rjmccall, Anastasia
        
        Subscribers: yaxunl, cfe-commits
        
        Tags: #clang
        
        Differential Revision: https://reviews.llvm.org/D64083 — mantognini / ViewSVN
365499. [OpenCL][Sema] Fix builtin rewriting
        
        This patch ensures built-in functions are rewritten using the proper
        parent declaration.
        
        Existing tests are modified to run in C++ mode to ensure the
        functionality works also with C++ for OpenCL while not increasing the
        testing runtime. — mantognini / ViewSVN
365498. Ignore trailing NullStmts in StmtExprs for GCC compatibility.
        
        Ignore trailing NullStmts in compound expressions when determining the result type and value. This is to match the GCC behavior which ignores semicolons at the end of compound expressions.
        
        Patch by Dominic Ferreira. — aaronballman / ViewSVN
365497. [HardwareLoops] NFC - move hardware loop checking code to isHardwareLoopProfitable()
        
        Differential Revision: https://reviews.llvm.org/D64197 — shchenz / ViewSVN