SuccessChanges

Summary

  1. [mlir] NFC: fix typo in FileCheck prefix (details)
  2. [FIX] Avoid creating BFI when emitting remarks for dead functions (details)
  3. [lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues (details)
  4. [lldb] Initialize reproducers in LocateSymbolFileTest (details)
  5. [flang] Parse global compiler directives (details)
  6. [flang] Improve error handling for bad characters in source (details)
Commit 40cbb2484d72faefc9f6cd09548cd24d3fd9e9d5 by ishizaki
[mlir] NFC: fix typo in FileCheck prefix

CHECL -> CHECK

Reviewed By: ftynse

Differential Revision: https://reviews.llvm.org/D86550
The file was modifiedmlir/test/Conversion/StandardToLLVM/calling-convention.mlir (diff)
The file was modifiedmlir/test/mlir-tblgen/op-decl.td (diff)
Commit ae90df8e5a68c7df4ea3e552dd7f87270fbcb0c7 by hoy
[FIX] Avoid creating BFI when emitting remarks for dead functions

Dead function has its body stripped away, and can cause various
analyses to panic. Also it does not make sense to apply analyses on
such function.

Reviewed By: xazax.hun, MaskRay, wenlei, hoy

Differential Revision: https://reviews.llvm.org/D84715
The file was modifiedllvm/lib/LTO/LTO.cpp (diff)
The file was modifiedllvm/test/LTO/Resolution/X86/dead-strip-fulllto.ll (diff)
Commit 7de7fe5d0e3f7f4d28e1dde42df4a7defa564f11 by Raphael Isemann
[lldb] Don't ask for QOS_CLASS_UNSPECIFIED queue in TestQueues

TestQueues is curiously failing for me as my queue for QOS_CLASS_UNSPECIFIED
is named "Utility" and not "User Initiated" or "Default". While debugging, this
I noticed that this test isn't actually using this API right from what I understand. The API documentation
for `dispatch_get_global_queue` specifies for the parameter: "You may specify the value
QOS_CLASS_USER_INTERACTIVE, QOS_CLASS_USER_INITIATED, QOS_CLASS_UTILITY, or QOS_CLASS_BACKGROUND."

QOS_CLASS_UNSPECIFIED isn't listed as one of the supported values. swift-corelibs-libdispatch
even checks for this value and returns a DISPATCH_BAD_INPUT. The
libdispatch shipped on macOS seems to also check for QOS_CLASS_UNSPECIFIED and seems to
instead cause a "client crash", but somehow this doesn't trigger in this test and instead we just
get whatever queue

This patch just removes that part of the test as it appears the code is just incorrect.

Reviewed By: jasonmolenda

Differential Revision: https://reviews.llvm.org/D86211
The file was modifiedlldb/test/API/macosx/queues/TestQueues.py (diff)
The file was modifiedlldb/test/API/macosx/queues/main.c (diff)
Commit ef76686916d40f20c782ed3967130bd2e0105b31 by Raphael Isemann
[lldb] Initialize reproducers in LocateSymbolFileTest

Since a842950b62b6d029a392c3c312c6495d6368c2a4 this test started using
the reproducer subsystem but we never initialized it in the test. The
Subsystem takes an argument, so we can't use the usual SubsystemRAII at the
moment to do this for us.

This just adds the initialize/terminate calls to get the test passing again.
The file was modifiedlldb/unittests/Symbol/LocateSymbolFileTest.cpp (diff)
Commit 13cee14bb1612ccdc3a7e7e770373fa2d2a94254 by pklausler
[flang] Parse global compiler directives

Accept and represent "global" compiler directives that appear
before and between program units in a source file.

Differential Revision: https://reviews.llvm.org/D86555
The file was modifiedflang/lib/Semantics/program-tree.h (diff)
The file was modifiedflang/lib/Semantics/resolve-names.cpp (diff)
The file was modifiedflang/test/Parser/compiler-directives.f90 (diff)
The file was modifiedflang/include/flang/Parser/parse-tree.h (diff)
The file was modifiedflang/lib/Semantics/program-tree.cpp (diff)
The file was modifiedflang/lib/Parser/program-parsers.cpp (diff)
Commit a0a1a4e5c83db53c806c56011a8741b31ab598a4 by pklausler
[flang] Improve error handling for bad characters in source

When an illegal character appears in Fortran source (after
preprocessing), catch and report it in the prescanning phase
rather than leaving it for the parser to cope with.

Differential Revision: https://reviews.llvm.org/D86553
The file was modifiedflang/lib/Parser/token-sequence.h (diff)
The file was modifiedflang/lib/Parser/prescan.cpp (diff)
The file was modifiedflang/lib/Parser/token-sequence.cpp (diff)
The file was modifiedflang/test/Preprocessing/pp130.F90 (diff)
The file was modifiedflang/include/flang/Parser/characters.h (diff)