FailedChanges

Summary

  1. [InstSimplify] SimplifyPHINode(): check that instruction is in basic block first (details)
  2. [OpenMP] Ensure testing for versions 4.5 and default - Part 3 (details)
  3. [CodeGen] Use an AttrBuilder to bulk remove 'target-cpu', 'target-features', and 'tune-cpu' before re-adding in CodeGenModule::setNonAliasAttributes. (details)
  4. [Attributor] Do not add AA to dependency graph after the update stage (details)
Commit b85f91fdced8e94c43f3350152bcb2ccfa71ef14 by lebedev.ri
[InstSimplify] SimplifyPHINode(): check that instruction is in basic block first

As pointed out in post-commit review, this can legally be called
on instructions that are not inserted into basic blocks,
so don't blindly assume that there is basic block.
The file was modifiedllvm/lib/Analysis/InstructionSimplify.cpp (diff)
Commit ff260ad0e014516fbebb4b9f7bcd5e085ac37661 by Saiyedul.Islam
[OpenMP] Ensure testing for versions 4.5 and default - Part 3

This third patch in the series removes version 5.0 string from
test cases making them check for default version. It also add test
cases for version 4.5.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D85214
The file was modifiedclang/test/OpenMP/atomic_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/nesting_of_regions.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_variant_mixed_codegen.c (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/depobj_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_scan_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_variant_device_isa_codegen_1.c (diff)
The file was modifiedclang/test/OpenMP/declare_variant_mixed_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_collapse_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/for_lastprivate_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_if_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_default_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_variant_implementation_vendor_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_if_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/flush_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_reduction_task_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_update_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/nvptx_asm_delayed_diags.c (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_if_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/flush_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_capture_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_target_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_schedule_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_reduction_task_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_variant_device_kind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/for_scan_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_reduction_task_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_write_codegen.c (diff)
The file was modifiedclang/test/OpenMP/deferred-diags.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_scan_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_messages.c (diff)
The file was modifiedclang/test/OpenMP/declare_target_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/declare_target_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/nvptx_declare_variant_implementation_vendor_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_scan_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/depobj_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_lastprivate_conditional.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/nvptx_declare_variant_name_mangling.cpp (diff)
The file was modifiedclang/test/OpenMP/for_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_reduction_task_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/atomic_read_codegen.c (diff)
The file was modifiedclang/test/OpenMP/parallel_for_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/for_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_lastprivate_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/for_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/master_taskloop_simd_reduction_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/nvptx_declare_variant_device_kind_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/for_simd_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/parallel_for_simd_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/parallel_master_taskloop_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_codegen.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_simd_misc_messages.c (diff)
The file was modifiedclang/test/OpenMP/for_simd_loop_messages.cpp (diff)
The file was modifiedclang/test/OpenMP/depobj_ast_print.cpp (diff)
The file was modifiedclang/test/OpenMP/distribute_parallel_for_simd_reduction_messages.cpp (diff)
Commit 17ceda99d32035dc654b45ef7af62c571d8a8273 by craig.topper
[CodeGen] Use an AttrBuilder to bulk remove 'target-cpu', 'target-features', and 'tune-cpu' before re-adding in CodeGenModule::setNonAliasAttributes.

I think the removeAttributes interface should be faster than
calling removeAttribute 3 times.
The file was modifiedclang/lib/CodeGen/CodeGenModule.cpp (diff)
Commit 58d257b2904bc637dcf8f90381298eb2661d9d95 by okuraofvegetable
[Attributor] Do not add AA to dependency graph after the update stage

If an AA is registered to the dependency graph in the manifest stage, Attributor aborts in `::manifestAttributes()`.
This patch prevents such termination.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D86734
The file was modifiedllvm/include/llvm/Transforms/IPO/Attributor.h (diff)