SuccessChanges

Summary

  1. [lldb] Make the lit configuration values optional for the API tests (details)
  2. [lldb] Hoist --framework argument out of LLDB_TEST_COMMON_ARGS (NFC) (details)
Commit 3f2fb0132f7b09e1309e8f7e0b5ba8ea471b17e7 by Jonas Devlieghere
[lldb] Make the lit configuration values optional for the API tests

LIT uses a model where the test suite is configurable trough a
lit.site.cfg file. Most of the time we use the lit.site.cfg with values
that match the current build configuration, generated by CMake.

Nothing prevents you from running the test suite with a different
configuration, either by overriding some of these values from the
command line, or by passing a different lit.site.cfg.

The latter is currently tedious. Many configuration values are optional
but they still need to be set because lit.cfg.py is accessing them
directly. This patch changes the code to use getattr to return the
attribute if it exists. This makes it possible to specify a minimal
lit.site.cfg with only the mandatory/desired configuration values.

Differential revision: https://reviews.llvm.org/D86821
The file was modifiedlldb/test/API/lldbtest.py (diff)
The file was modifiedlldb/test/API/lit.cfg.py (diff)
Commit 2965e9bd5edb079746a668794865be37f6f4d3d8 by Jonas Devlieghere
[lldb] Hoist --framework argument out of LLDB_TEST_COMMON_ARGS (NFC)

Give the framework argument its own variable (LLDB_FRAMEWORK_DIR) so
that we can configure it in lit.site.cfg.py if we so desire.
The file was modifiedlldb/test/API/lit.site.cfg.py.in (diff)
The file was modifiedlldb/test/API/lit.cfg.py (diff)
The file was modifiedlldb/utils/lldb-dotest/lldb-dotest.in (diff)
The file was modifiedlldb/test/API/CMakeLists.txt (diff)