SuccessChanges

Summary

  1. [Instruction] Speculatively undo isIdenticalToWhenDefined() PHI handling changes (details)
  2. [Sema] ICK_Function_Conversion is a third kind conversion (details)
  3. [Sema] Simplify ShouldDiagnoseUnusedDecl, NFC (details)
Commit 5ec2b757cc7d37ff0d03b36ee863b0962fe78108 by lebedev.ri
[Instruction] Speculatively undo isIdenticalToWhenDefined() PHI handling changes

The stage2-stage3 differences persist even without instcombine-based
PHI CSE, so this is the only possible reason.
The file was modifiedllvm/lib/Transforms/Utils/Local.cpp (diff)
The file was modifiedllvm/lib/IR/Instruction.cpp (diff)
Commit b4a2d36c3f74ea5574cd03a9c1a704bcffb1869e by aaronpuchert
[Sema] ICK_Function_Conversion is a third kind conversion

Not sure if this has any effect, but it was inconsistent before.

Reviewed By: rsmith

Differential Revision: https://reviews.llvm.org/D67113
The file was modifiedclang/lib/Sema/SemaOverload.cpp (diff)
Commit 85fce449dc43447bf9d75163bda81e157f5b73e7 by aaronpuchert
[Sema] Simplify ShouldDiagnoseUnusedDecl, NFC

Instead of writing to a flag and then returning based on that flag we
can also return directly. The flag name also doesn't provide additional
information, it just reflects the name of the function (isReferenced).
The file was modifiedclang/lib/Sema/SemaDecl.cpp (diff)