SuccessChanges

Summary

  1. [mlir][Linalg] Wrong tile size for convolutions fixed (details)
  2. Decouple OpPassManager from the the MLIRContext (NFC) (details)
  3. Adding GDB PrettyPrinter for mlir::Identifier. (details)
Commit 8d35080ebbea477316159a5af7d925bb51d805d0 by limo
[mlir][Linalg] Wrong tile size for convolutions fixed

Sizes of tiles (subviews) are bigger by 1 than they should. Let's consider
1D convolution without batches or channels. Furthermore let m iterate over
the output and n over the kernel then input is accessed with m + n. In tiling
subview sizes for convolutions are computed by applying requested tile size
together with kernel size to the above mentioned expression thus let's say
for tile size of 2 the subview size is 2 + size(n), which is bigger by one
than it should since we move kernel only once. The problem behind it is that
range is not turned into closed interval before the composition. This commit
fixes the problem by turning ranges first into closed intervals by substracting
1 and after the composition back to half open by adding 1.

Differential Revision: https://reviews.llvm.org/D86638
The file was modifiedmlir/lib/Dialect/Linalg/Transforms/Tiling.cpp (diff)
The file was modifiedmlir/test/Dialect/Linalg/tile_simple_conv.mlir (diff)
The file was modifiedmlir/test/Dialect/Linalg/tile_conv.mlir (diff)
Commit c0b6bc070e78cbd20bc4351704f52d85192e8804 by joker.eph
Decouple OpPassManager from the the MLIRContext (NFC)

This is allowing to build an OpPassManager from a StringRef instead of an
Identifier, which enables building pipelines without an MLIRContext.
An identifier is still cached on-demand on the OpPassManager for efficiency
during the IR traversal.
The file was modifiedmlir/include/mlir/Pass/PassManager.h (diff)
The file was modifiedmlir/lib/Pass/PassStatistics.cpp (diff)
The file was modifiedmlir/lib/Pass/Pass.cpp (diff)
Commit 9e9e6e698d8ef5dc5b7576058f2022aab2534a52 by csigg
Adding GDB PrettyPrinter for mlir::Identifier.

This is the first bit from D73546. Primarily setting up the corresponding test. Will add more pretty printers in a separate revision.

Reviewed By: dblaikie

Differential Revision: https://reviews.llvm.org/D86937
The file was modifieddebuginfo-tests/lit.cfg.py (diff)
The file was modifieddebuginfo-tests/lit.site.cfg.py.in (diff)
The file was addedmlir/utils/gdb-scripts/prettyprinters.py
The file was addeddebuginfo-tests/llvm-prettyprinters/gdb/mlir-support.cpp
The file was modifieddebuginfo-tests/CMakeLists.txt (diff)
The file was addeddebuginfo-tests/llvm-prettyprinters/gdb/mlir-support.gdb