SuccessChanges

Summary

  1. [NFC] Fix whitespace in lldb-vscode --help (details)
  2. [PGO] Skip if an IndirectBrInst critical edge cannot be split (details)
  3. [compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk (details)
  4. [compiler-rt] [netbsd] Regenerate syscall hooks (details)
Commit 6040d525507ba8a2593f0906259d012725b6aed2 by rupprecht
[NFC] Fix whitespace in lldb-vscode --help
The file was modifiedlldb/tools/lldb-vscode/lldb-vscode.cpp (diff)
Commit a0ffe2b21a5159f3f8eed8e98e488e723aa7cab3 by i
[PGO] Skip if an IndirectBrInst critical edge cannot be split

PGOInstrumentation runs `SplitIndirectBrCriticalEdges` but some IndirectBrInst
critical edge cannot be split. `getInstrBB` will crash when calling `SplitCriticalEdge`, e.g.

  int foo(char *p) {
    void *targets[2];
    targets[0] = &&indirect;
    targets[1] = &&end;
    for (;; p++)
      if (*p == 7) {
  indirect:
        goto *targets[p[1]]; // the self loop is critical in -O
      }
  end:
    return 0;
  }

Skip such critical edges to prevent a crash.

Reviewed By: davidxl, lebedev.ri

Differential Revision: https://reviews.llvm.org/D87435
The file was modifiedllvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp (diff)
The file was modifiedllvm/test/Transforms/PGOProfile/split-indirectbr-critical-edges.ll (diff)
Commit bba736e5036f3983ca22f08dec277fdf37926115 by n54
[compiler-rt] [netbsd] Update generate_netbsd_syscalls.awk

Sync with NetBSD 9.99.72.
The file was modifiedcompiler-rt/utils/generate_netbsd_syscalls.awk (diff)
Commit 00460ae520e284ae8c0cd400c1c75c0c7a0e8fa7 by n54
[compiler-rt] [netbsd] Regenerate syscall hooks

Sync with NetBSD 9.99.72.
The file was modifiedcompiler-rt/include/sanitizer/netbsd_syscall_hooks.h (diff)
The file was modifiedcompiler-rt/lib/sanitizer_common/sanitizer_syscalls_netbsd.inc (diff)

Summary

  1. [lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell (details)
Commit f63e49a069fad6631c55559cc9bdbb8e66dba34c by Jonas Devlieghere
[lldb] Have the Xcode build run check-lldb instead of just check-lldb-shell

For the Xcode generated build we were only running the shell tests to
reduce the test time (and flakiness) of the bot. However, this has
allowed multiple configuration issues to slip in, so I've switched back
to check-lldb.
The file was modifiedzorg/jenkins/monorepo_build.py (diff)