SuccessChanges

Summary

  1. GCOVProfiling: Avoid use-after-move (details)
  2. Correct end-of-namespace comment to be clang-tidy/LLVM style appropriate (details)
  3. PPCInstrInfo: Fix readability-inconsistent-declaration-parameter-name clang-tidy warning (details)
Commit 6e06f1cd0816b03d9336083667a0c71760d6b99f by dblaikie
GCOVProfiling: Avoid use-after-move

Turns out this was use-after-move of function_ref, which is trivially
copyable and movable, so the move did nothing and use after move was
safe.

But since this function_ref is being copied into a std::function, change
the function_ref to be std::function to avoid extra layers of type
erasure indirection - and then it's a real use after move, and fix that
by referring to the moved-to member variable rather than the moved-from
parameter.
The file was modifiedllvm/lib/Transforms/Instrumentation/GCOVProfiling.cpp (diff)
Commit 7940af02baa27e23ebbd9cd09b24ef1b24ea8cec by dblaikie
Correct end-of-namespace comment to be clang-tidy/LLVM style appropriate
The file was modifiedllvm/include/llvm/Transforms/Instrumentation/GCOVProfiler.h (diff)
Commit ce89eeee16dd1e7ca6eead3b9d7f256ca583f6e1 by dblaikie
PPCInstrInfo: Fix readability-inconsistent-declaration-parameter-name clang-tidy warning

Reduces the chance of confusion when calling the function with
autocomplete (will show the more accurate/informative variable name),
etc.
The file was modifiedllvm/lib/Target/PowerPC/PPCInstrInfo.h (diff)