SuccessChanges

Summary

  1. Revert "[lldb] Don't send invalid region addresses to lldb server" (details)
  2. [NFC][ARM] Tail fold test changes (details)
  3. SymbolizableObjectFile.h - remove unnecessary includes. NFCI. (details)
  4. MetadataLoader.cpp - remove unnecessary StringRef include. NFCI. (details)
  5. [clang-format][regression][PR47461] ifdef causes catch to be seen as a function (details)
  6. [ConstraintSystem] Remove local variable that is set but not read [NFC] (details)
  7. Remove unnecessary forward declarations. NFCI. (details)
Commit c65627a1fe3be7521fc232d633bb6df577f55269 by david.spickett
Revert "[lldb] Don't send invalid region addresses to lldb server"

This reverts commit c687af0c30b4dbdc9f614d5e061c888238e0f9c5
due to a test failure on Windows.
The file was modifiedlldb/test/API/functionalities/memory-region/TestMemoryRegion.py (diff)
The file was modifiedlldb/source/Commands/CommandObjectMemory.cpp (diff)
Commit 97a476eb56726ef09bdd9c7f8c46d7e1c456d46b by sam.parker
[NFC][ARM] Tail fold test changes

Run update script on one test and add another.
The file was addedllvm/test/Transforms/LoopVectorize/ARM/tail-fold-multiple-icmps.ll
The file was modifiedllvm/test/Transforms/LoopVectorize/ARM/tail-folding-not-allowed.ll (diff)
Commit ed53ff4cde331e0ffeb492dca6281aaeea2cd8cf by llvm-dev
SymbolizableObjectFile.h - remove unnecessary includes. NFCI.

Use forward declarations where possible, move includes down to SymbolizableObjectFile.cpp and avoid duplicate includes.
The file was modifiedllvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.cpp (diff)
The file was modifiedllvm/lib/DebugInfo/Symbolize/SymbolizableObjectFile.h (diff)
Commit abe0d8551da52ea1d0d8ad5f9ad71d22a7cd9928 by llvm-dev
MetadataLoader.cpp - remove unnecessary StringRef include. NFCI.

Already included in MetadataLoader.h
The file was modifiedllvm/lib/Bitcode/Reader/MetadataLoader.cpp (diff)
Commit 40e771c1c0d33c687230111271060c2ba761269f by mydeveloperday
[clang-format][regression][PR47461] ifdef causes catch to be seen as a function

https://bugs.llvm.org/show_bug.cgi?id=47461

The following change {D80940} caused a regression in code which ifdef's around the try and catch block cause incorrect brace placement around the catch

```
  try
  {
  }
  catch (...) {
    // This is not a small function
    bar = 1;
  }
}
```

The brace after the catch will be placed on a newline

Reviewed By: curdeius

Differential Revision: https://reviews.llvm.org/D87291
The file was modifiedclang/unittests/Format/FormatTest.cpp (diff)
The file was modifiedclang/lib/Format/FormatTokenLexer.cpp (diff)
Commit bb037c2a7625d9d13a86b18d9b8b0c75eb8c91cb by mikael.holmen
[ConstraintSystem] Remove local variable that is set but not read [NFC]

gcc 7.4 warns about it.
The file was modifiedllvm/lib/Analysis/ConstraintSystem.cpp (diff)
Commit aa896a0b3a9d93df818fbe9b68644ad90bcda831 by llvm-dev
Remove unnecessary forward declarations. NFCI.

All of these forward declarations are fully defined in headers that are directly included.
The file was modifiedllvm/include/llvm/ProfileData/SampleProf.h (diff)
The file was modifiedllvm/include/llvm/Transforms/Utils/LoopVersioning.h (diff)
The file was modifiedllvm/include/llvm/MC/MCParser/MCTargetAsmParser.h (diff)
The file was modifiedllvm/include/llvm/DebugInfo/PDB/PDBSymbol.h (diff)
The file was modifiedllvm/include/llvm/IR/LegacyPassManagers.h (diff)
The file was modifiedllvm/include/llvm/Transforms/Utils/LoopUtils.h (diff)
The file was modifiedllvm/include/llvm/MC/MCELFObjectWriter.h (diff)
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/CompileUtils.h (diff)
The file was modifiedllvm/include/llvm/ExecutionEngine/Orc/GlobalMappingLayer.h (diff)